Mercurial > blahgd > experimental

changeset 981:272b84ebb926

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
post: simplify post_lock to only lock the post Leave it up to the caller to explicitly call post_refresh if needed. Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
author Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
date Wed, 14 Nov 2018 00:54:16 +0000
parents c9c892dc7fc8
children 9fefaaa6dcba
files post.h post_nv.c
diffstat 2 files changed, 5 insertions(+), 6 deletions(-) [+]
line wrap: on
line diff
--- a/post.h	Tue Nov 13 16:56:26 2018 -0500
+++ b/post.h	Wed Nov 14 00:54:16 2018 +0000
@@ -108,12 +108,9 @@
 
 REFCNT_INLINE_FXNS(struct post, post, refcnt, post_destroy, NULL)
 
-static inline void post_lock(struct post *post, bool refresh)
+static inline void post_lock(struct post *post)
 {
 	MXLOCK(&post->lock);
-
-	if (refresh)
-		post_refresh(post);
 }
 
 static inline void post_unlock(struct post *post)
--- a/post_nv.c	Tue Nov 13 16:56:26 2018 -0500
+++ b/post_nv.c	Wed Nov 14 00:54:16 2018 +0000
@@ -169,7 +169,8 @@
 	if (!post)
 		return NULL;
 
-	post_lock(post, true);
+	post_lock(post);
+	post_refresh(post);
 
 	out = __store_vars(req, post, titlevar);
 
@@ -201,7 +202,8 @@
 	for (i = 0; i < nposts; i++) {
 		struct post *post = posts[i];
 
-		post_lock(post, true);
+		post_lock(post);
+		post_refresh(post);
 
 		nvposts[nnvposts] = nvl_cast_to_val(__store_vars(req, post, NULL));
 		if (IS_ERR(nvposts[nnvposts])) {