Mercurial > dovecot > core-2.2
diff src/lib-storage/index/dbox-common/dbox-file.c @ 14682:d0d7b810646b
Make sure we check all the functions' return values. Minor API changes to simplify this.
Checked using a patched clang that adds attribute(warn_unused_result) to all
functions. This commit fixes several error handling mistakes.
| author | Timo Sirainen <tss@iki.fi> |
|---|---|
| date | Mon, 25 Jun 2012 01:14:03 +0300 |
| parents | ca37d1577291 |
| children | 1b46c1bf9d1e |
line wrap: on
line diff
--- a/src/lib-storage/index/dbox-common/dbox-file.c Mon Jun 25 00:01:59 2012 +0300 +++ b/src/lib-storage/index/dbox-common/dbox-file.c Mon Jun 25 01:14:03 2012 +0300 @@ -601,7 +601,10 @@ "dbox file size too small"); return 0; } - o_stream_seek(ctx->output, st.st_size); + if (o_stream_seek(ctx->output, st.st_size) < 0) { + dbox_file_set_syscall_error(file, "lseek()"); + return -1; + } } *output_r = ctx->output; return 1;