Mercurial > dovecot > core-2.2
diff src/pop3/main.c @ 14682:d0d7b810646b
Make sure we check all the functions' return values. Minor API changes to simplify this.
Checked using a patched clang that adds attribute(warn_unused_result) to all
functions. This commit fixes several error handling mistakes.
| author | Timo Sirainen <tss@iki.fi> |
|---|---|
| date | Mon, 25 Jun 2012 01:14:03 +0300 |
| parents | fbb1ecb9b888 |
| children | 7c058aa05b0a |
line wrap: on
line diff
--- a/src/pop3/main.c Mon Jun 25 00:01:59 2012 +0300 +++ b/src/pop3/main.c Mon Jun 25 01:14:03 2012 +0300 @@ -138,9 +138,9 @@ if (input.username == NULL) i_fatal("USER environment missing"); if ((value = getenv("IP")) != NULL) - net_addr2ip(value, &input.remote_ip); + (void)net_addr2ip(value, &input.remote_ip); if ((value = getenv("LOCAL_IP")) != NULL) - net_addr2ip(value, &input.local_ip); + (void)net_addr2ip(value, &input.local_ip); input_base64 = getenv("CLIENT_INPUT"); input_buf = input_base64 == NULL ? NULL :