Mercurial > dovecot > core-2.2
view src/imap/cmd-rename.c @ 21322:5ab8dc1a4a6f
global: Change string position/length from unsigned int to size_t
Mainly to avoid truncating >4GB strings, which might potentially cause
some security holes. Normally there are other limits, which prevent such
excessive strings from being created in the first place.
I'm sure this didn't find everything. Maybe everything could be found with
compiler warnings. -Wconversion kind of does it, but it gives way too many
unnecessary warnings.
These were mainly found with:
grep " = strlen"
egrep "unsigned int.*(size|len)"
author | Timo Sirainen <timo.sirainen@dovecot.fi> |
---|---|
date | Mon, 12 Dec 2016 07:19:55 +0200 |
parents | 0f22db71df7a |
children | 2e2563132d5f |
line wrap: on
line source
/* Copyright (c) 2002-2016 Dovecot authors, see the included COPYING file */ #include "imap-common.h" #include "mail-namespace.h" #include "imap-commands.h" bool cmd_rename(struct client_command_context *cmd) { struct mail_namespace *old_ns, *new_ns; struct mailbox *old_box, *new_box; const char *oldname, *newname; size_t oldlen; /* <old name> <new name> */ if (!client_read_string_args(cmd, 2, &oldname, &newname)) return FALSE; old_ns = client_find_namespace(cmd, &oldname); if (old_ns == NULL) return TRUE; new_ns = client_find_namespace(cmd, &newname); if (new_ns == NULL) return TRUE; if (old_ns == new_ns) { /* disallow box -> box/child, because it may break clients and there's really no point in doing it anyway. */ old_ns = mailbox_list_get_namespace(old_ns->list); oldlen = strlen(oldname); if (strncmp(oldname, newname, oldlen) == 0 && newname[oldlen] == mail_namespace_get_sep(old_ns)) { client_send_tagline(cmd, "NO Can't rename mailbox under its own child."); return TRUE; } } old_box = mailbox_alloc(old_ns->list, oldname, 0); new_box = mailbox_alloc(new_ns->list, newname, 0); if (mailbox_rename(old_box, new_box) < 0) client_send_box_error(cmd, old_box); else client_send_tagline(cmd, "OK Rename completed."); mailbox_free(&old_box); mailbox_free(&new_box); return TRUE; }