Mercurial > dovecot > core-2.2
view src/auth/userdb-blocking.c @ 14682:d0d7b810646b
Make sure we check all the functions' return values. Minor API changes to simplify this.
Checked using a patched clang that adds attribute(warn_unused_result) to all
functions. This commit fixes several error handling mistakes.
author | Timo Sirainen <tss@iki.fi> |
---|---|
date | Mon, 25 Jun 2012 01:14:03 +0300 |
parents | ba770cba5598 |
children | 128c598d2870 |
line wrap: on
line source
/* Copyright (c) 2005-2012 Dovecot authors, see the included COPYING file */ #include "auth-common.h" #include "str.h" #include "auth-worker-server.h" #include "userdb.h" #include "userdb-blocking.h" #include <stdlib.h> struct blocking_userdb_iterate_context { struct userdb_iterate_context ctx; struct auth_worker_connection *conn; bool next; bool destroyed; }; static bool user_callback(const char *reply, void *context) { struct auth_request *request = context; enum userdb_result result; const char *args; if (strncmp(reply, "FAIL\t", 5) == 0) { result = USERDB_RESULT_INTERNAL_FAILURE; args = reply + 5; } else if (strncmp(reply, "NOTFOUND\t", 9) == 0) { result = USERDB_RESULT_USER_UNKNOWN; args = reply + 9; } else if (strncmp(reply, "OK\t", 3) == 0) { result = USERDB_RESULT_OK; args = reply + 3; } else { result = USERDB_RESULT_INTERNAL_FAILURE; i_error("BUG: auth-worker sent invalid user reply"); args = ""; } if (*args != '\0') { request->userdb_reply = auth_stream_reply_init(request->pool); auth_stream_reply_import(request->userdb_reply, args); if (auth_stream_reply_exists(request->userdb_reply, "tempfail")) request->userdb_lookup_failed = TRUE; } auth_request_userdb_callback(result, request); auth_request_unref(&request); return TRUE; } void userdb_blocking_lookup(struct auth_request *request) { struct auth_stream_reply *reply; reply = auth_stream_reply_init(pool_datastack_create()); auth_stream_reply_add(reply, "USER", NULL); auth_stream_reply_add(reply, NULL, dec2str(request->userdb->userdb->id)); auth_request_export(request, reply); auth_request_ref(request); (void)auth_worker_call(request->pool, reply, user_callback, request); } static bool iter_callback(const char *reply, void *context) { struct blocking_userdb_iterate_context *ctx = context; if (strncmp(reply, "*\t", 2) == 0) { ctx->next = FALSE; ctx->ctx.callback(reply + 2, ctx->ctx.context); return ctx->next; } if (strcmp(reply, "OK") != 0) ctx->ctx.failed = TRUE; if (!ctx->destroyed) ctx->ctx.callback(NULL, ctx->ctx.context); auth_request_unref(&ctx->ctx.auth_request); return TRUE; } struct userdb_iterate_context * userdb_blocking_iter_init(struct auth_request *request, userdb_iter_callback_t *callback, void *context) { struct blocking_userdb_iterate_context *ctx; struct auth_stream_reply *reply; reply = auth_stream_reply_init(pool_datastack_create()); auth_stream_reply_add(reply, "LIST", NULL); auth_stream_reply_add(reply, NULL, dec2str(request->userdb->userdb->id)); auth_request_export(request, reply); ctx = p_new(request->pool, struct blocking_userdb_iterate_context, 1); ctx->ctx.auth_request = request; ctx->ctx.callback = callback; ctx->ctx.context = context; auth_request_ref(request); ctx->conn = auth_worker_call(request->pool, reply, iter_callback, ctx); return &ctx->ctx; } void userdb_blocking_iter_next(struct userdb_iterate_context *_ctx) { struct blocking_userdb_iterate_context *ctx = (struct blocking_userdb_iterate_context *)_ctx; ctx->next = TRUE; auth_worker_server_resume_input(ctx->conn); } int userdb_blocking_iter_deinit(struct userdb_iterate_context **_ctx) { struct blocking_userdb_iterate_context *ctx = (struct blocking_userdb_iterate_context *)*_ctx; int ret = ctx->ctx.failed ? -1 : 0; *_ctx = NULL; /* iter_callback() may still be called */ ctx->destroyed = TRUE; return ret; }