Mercurial > dovecot > core-2.2
view src/lib-auth/auth-client.c @ 14682:d0d7b810646b
Make sure we check all the functions' return values. Minor API changes to simplify this.
Checked using a patched clang that adds attribute(warn_unused_result) to all
functions. This commit fixes several error handling mistakes.
author | Timo Sirainen <tss@iki.fi> |
---|---|
date | Mon, 25 Jun 2012 01:14:03 +0300 |
parents | ba770cba5598 |
children | 90710c6c3beb |
line wrap: on
line source
/* Copyright (c) 2005-2012 Dovecot authors, see the included COPYING file */ #include "lib.h" #include "array.h" #include "auth-client-private.h" #include "auth-server-connection.h" struct auth_client * auth_client_init(const char *auth_socket_path, unsigned int client_pid, bool debug) { struct auth_client *client; client = i_new(struct auth_client, 1); client->client_pid = client_pid; client->auth_socket_path = i_strdup(auth_socket_path); client->debug = debug; client->conn = auth_server_connection_init(client); (void)auth_server_connection_connect(client->conn); return client; } void auth_client_deinit(struct auth_client **_client) { struct auth_client *client = *_client; *_client = NULL; auth_server_connection_deinit(&client->conn); i_free(client->auth_socket_path); i_free(client); } void auth_client_connect(struct auth_client *client) { if (client->conn->fd == -1) (void)auth_server_connection_connect(client->conn); } void auth_client_disconnect(struct auth_client *client, const char *reason) { auth_server_connection_disconnect(client->conn, reason); } bool auth_client_is_connected(struct auth_client *client) { return client->conn->handshake_received; } bool auth_client_is_disconnected(struct auth_client *client) { return client->conn->fd == -1; } void auth_client_set_connect_notify(struct auth_client *client, auth_connect_notify_callback_t *callback, void *context) { client->connect_notify_callback = callback; client->connect_notify_context = context; } const struct auth_mech_desc * auth_client_get_available_mechs(struct auth_client *client, unsigned int *mech_count) { i_assert(auth_client_is_connected(client)); return array_get(&client->conn->available_auth_mechs, mech_count); } const struct auth_mech_desc * auth_client_find_mech(struct auth_client *client, const char *name) { const struct auth_mech_desc *mech; array_foreach(&client->conn->available_auth_mechs, mech) { if (strcasecmp(mech->name, name) == 0) return mech; } return NULL; } void auth_client_get_connect_id(struct auth_client *client, unsigned int *server_pid_r, unsigned int *connect_uid_r) { i_assert(auth_client_is_connected(client)); *server_pid_r = client->conn->server_pid; *connect_uid_r = client->conn->connect_uid; }