# HG changeset patch # User Timo Sirainen # Date 1502805016 -10800 # Node ID 486ddf6a61eb2e00269275b79ef148c2c53aa514 # Parent 6be650aee0b570b58698ed1029c3ed3db751e63a dict-sql: Cleanup - Remove unnecessary code The values are explicitly added to params. sql_dict_update_query() doesn't add them again. Since the "diff" parameter is already a long long type, this avoids unnecessary conversion to string and back. diff -r 6be650aee0b5 -r 486ddf6a61eb src/lib-dict/dict-sql.c --- a/src/lib-dict/dict-sql.c Tue Aug 15 16:38:33 2017 +0300 +++ b/src/lib-dict/dict-sql.c Tue Aug 15 16:50:16 2017 +0300 @@ -1248,7 +1248,7 @@ i_assert(map != NULL); field.map = map; - field.value = t_strdup_printf("%lld", diff); + field.value = NULL; /* unused */ i_zero(&build); build.dict = dict; @@ -1434,10 +1434,9 @@ field = array_append_space(&build.fields); field->map = ctx->prev_inc_map; - field->value = t_strdup_printf("%lld", ctx->prev_inc_diff); field = array_append_space(&build.fields); field->map = map; - field->value = t_strdup_printf("%lld", diff); + /* field->value is unused */ t_array_init(¶ms, 4); param = array_append_space(¶ms);