# HG changeset patch # User Martti Rannanjärvi # Date 1518793175 -7200 # Node ID 899f54a6371fcca8d211068d31a606867ee3fbec # Parent 5a0ecc358d230971906d534b2e4525da4d5d5802 charset-alias: Fix keyvalues iteration charset-alias-plugin.c:113:27: error: comparison between pointer and zero character constant [-Werror=pointer-compare] for (i = 0; keyvalues[i] != '\0'; i++) { ^~ charset-alias-plugin.c:113:14: note: did you mean to dereference the pointer? for (i = 0; keyvalues[i] != '\0'; i++) { diff -r 5a0ecc358d23 -r 899f54a6371f src/plugins/charset-alias/charset-alias-plugin.c --- a/src/plugins/charset-alias/charset-alias-plugin.c Fri Feb 16 16:53:04 2018 +0200 +++ b/src/plugins/charset-alias/charset-alias-plugin.c Fri Feb 16 16:59:35 2018 +0200 @@ -110,7 +110,7 @@ p_array_init(&charset_aliases, pool, 1); keyvalues = t_strsplit_spaces(str, " "); - for (i = 0; keyvalues[i] != '\0'; i++) { + for (i = 0; keyvalues[i] != NULL; i++) { value = strchr(keyvalues[i], '='); if (value == NULL) { i_error("charset_alias: Missing '=' in charset_aliases setting");