# HG changeset patch # User Pali Rohár # Date 1465134495 -7200 # Node ID 91278ef69de74a5cdcb1fa27d6a981d54f7295f9 # Parent 528bd5a67923a2ca72c7e99ca07e6eb88259d19f lib-mail: message_address_write: Fix generating group list with empty name Empty name for group list must be quoted. Test case: { { name = NULL, mailbox = "", domain = NULL }, { name = NULL, mailbox = NULL, domain = NULL } } converts to: "":; diff -r 528bd5a67923 -r 91278ef69de7 src/lib-mail/message-address.c --- a/src/lib-mail/message-address.c Sun Jun 05 15:48:14 2016 +0200 +++ b/src/lib-mail/message-address.c Sun Jun 05 15:48:15 2016 +0200 @@ -358,8 +358,12 @@ if (!in_group) { /* beginning of group. mailbox is the group name, others are NULL. */ - if (addr->mailbox != NULL) + if (addr->mailbox != NULL && *addr->mailbox != '\0') { str_append(str, addr->mailbox); + } else { + /* empty group name needs to be quoted */ + str_append(str, "\"\""); + } str_append(str, ": "); first = TRUE; } else {