# HG changeset patch # User Aki Tuomi # Date 1489252830 -7200 # Node ID ddf64cb2329515cd23fc38d67da2729b59ec5fd4 # Parent 1d329b71c6d8f4a8e75c1a22bc4d440ec70eb63d doveadm: Do not crash doveadm-server if input file missing save commands expects valid input file for it to work, if we are not running for cli, and input file is not provided, provide EINVAL error to caller via i_stream_error. diff -r 1d329b71c6d8 -r ddf64cb23295 src/doveadm/doveadm-mail.c --- a/src/doveadm/doveadm-mail.c Thu Mar 16 09:36:23 2017 +0200 +++ b/src/doveadm/doveadm-mail.c Sat Mar 11 19:20:30 2017 +0200 @@ -227,6 +227,11 @@ if (ctx->cmd_input != NULL) return; + if (!ctx->cli && ctx->conn == NULL) { + ctx->cmd_input = i_stream_create_error_str(EINVAL, "Input stream missing (provide with file parameter)"); + return; + } + if (ctx->conn != NULL) inputs[0] = i_stream_create_dot(ctx->conn->input, FALSE); else {