# HG changeset patch # User Timo Sirainen # Date 1443378505 -10800 # Node ID e5164f14723f081c80447999c00d1cd0836640f3 # Parent 038efefc7e70bd0a6006c79d4ce335ae56cfc5ad dict-client: Avoid crash if server disconnects during transaction commit. Found by Coverity. diff -r 038efefc7e70 -r e5164f14723f src/lib-dict/dict-client.c --- a/src/lib-dict/dict-client.c Sun Sep 27 21:25:59 2015 +0300 +++ b/src/lib-dict/dict-client.c Sun Sep 27 21:28:25 2015 +0300 @@ -797,10 +797,12 @@ default: i_error("dict-client: Invalid commit reply: %s", line); client_dict_disconnect(dict); + line = NULL; ret = -1; break; } - if (str_to_uint(line+1, &id) < 0 || ctx->id != id) { + if (line != NULL && + (str_to_uint(line+1, &id) < 0 || ctx->id != id)) { i_error("dict-client: Invalid commit reply, " "expected id=%u: %s", ctx->id, line); client_dict_disconnect(dict);