changeset 20520:2a50bc7f37c1

auth: Fail request if last passdb is noauthenticate
author Aki Tuomi <aki.tuomi@dovecot.fi>
date Mon, 11 Jul 2016 14:56:41 +0300
parents 9caf75a53fdb
children 1a31a7ef45b5
files src/auth/auth-request.c
diffstat 1 files changed, 5 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/auth/auth-request.c	Mon Jul 11 14:56:25 2016 +0300
+++ b/src/auth/auth-request.c	Mon Jul 11 14:56:41 2016 +0300
@@ -746,6 +746,11 @@
 			request->passdbs_seen_internal_failure = TRUE;
 		}
 		return FALSE;
+	} else if (*result == PASSDB_RESULT_NEXT) {
+		/* admin forgot to put proper passdb last */
+		auth_request_log_error(request, AUTH_SUBSYS_DB,
+			"Last passdb had noauthenticate field, cannot authenticate user");
+		*result = PASSDB_RESULT_INTERNAL_FAILURE;
 	} else if (request->passdb_success) {
 		/* either this or a previous passdb lookup succeeded. */
 		*result = PASSDB_RESULT_OK;