Mercurial > dovecot > core-2.2
changeset 18619:49f5131a502e
Make Coverity happier.
author | Timo Sirainen <tss@iki.fi> |
---|---|
date | Sat, 09 May 2015 19:58:59 +0300 |
parents | 8b452eb97422 |
children | 7799886e017a |
files | src/lib-http/http-server-connection.c src/lib-index/mail-transaction-log-file.c src/lib-mail/ostream-dot.c src/lib-storage/index/index-mail.c src/lib-storage/index/maildir/maildir-uidlist.c |
diffstat | 5 files changed, 7 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/lib-http/http-server-connection.c Sat May 09 19:57:28 2015 +0300 +++ b/src/lib-http/http-server-connection.c Sat May 09 19:58:59 2015 +0300 @@ -541,11 +541,13 @@ switch (error_code) { case HTTP_REQUEST_PARSE_ERROR_BROKEN_REQUEST: conn->input_broken = TRUE; + /* fall through */ case HTTP_REQUEST_PARSE_ERROR_BAD_REQUEST: http_server_request_fail(req, 400, "Bad Request"); break; case HTTP_REQUEST_PARSE_ERROR_METHOD_TOO_LONG: conn->input_broken = TRUE; + /* fall through */ case HTTP_REQUEST_PARSE_ERROR_NOT_IMPLEMENTED: http_server_request_fail(req, 501, "Not Implemented"); break;
--- a/src/lib-index/mail-transaction-log-file.c Sat May 09 19:57:28 2015 +0300 +++ b/src/lib-index/mail-transaction-log-file.c Sat May 09 19:58:59 2015 +0300 @@ -1620,6 +1620,7 @@ if (file->mmap_base == NULL) return; + i_assert(file->buffer != NULL); if (munmap(file->mmap_base, file->mmap_size) < 0) log_file_set_syscall_error(file, "munmap()"); file->mmap_base = NULL;
--- a/src/lib-mail/ostream-dot.c Sat May 09 19:57:28 2015 +0300 +++ b/src/lib-mail/ostream-dot.c Sat May 09 19:58:59 2015 +0300 @@ -139,6 +139,7 @@ case '.': /* add dot */ add = '.'; + /* fall through */ default: dstream->state = STREAM_STATE_NONE; break;
--- a/src/lib-storage/index/index-mail.c Sat May 09 19:57:28 2015 +0300 +++ b/src/lib-storage/index/index-mail.c Sat May 09 19:58:59 2015 +0300 @@ -920,6 +920,8 @@ old_offset = mail->data.stream == NULL ? 0 : mail->data.stream->v_offset; if (mail_get_stream(&mail->mail.mail, NULL, NULL, &input) < 0) return -1; + i_assert(mail->data.stream != NULL); + i_stream_seek(input, part->physical_pos); input = i_stream_create_limit(input, part->header_size.physical_size + part->body_size.physical_size);
--- a/src/lib-storage/index/maildir/maildir-uidlist.c Sat May 09 19:57:28 2015 +0300 +++ b/src/lib-storage/index/maildir/maildir-uidlist.c Sat May 09 19:58:59 2015 +0300 @@ -1976,6 +1976,7 @@ array_free(&uidlist->records); uidlist->records = ctx->records; ctx->records.arr.buffer = NULL; + i_assert(array_is_created(&uidlist->records)); hash_table_destroy(&uidlist->files); uidlist->files = ctx->files;