Mercurial > dovecot > core-2.2

changeset 19396:626758356cce

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
stats: Improved logging on invalid CONNECT input.
author Timo Sirainen <tss@iki.fi>
date Wed, 18 Nov 2015 20:50:55 +0200
parents dc08ba342085
children e976d6f988ec
files src/stats/mail-session.c
diffstat 1 files changed, 5 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/src/stats/mail-session.c	Wed Nov 18 19:15:36 2015 +0200
+++ b/src/stats/mail-session.c	Wed Nov 18 20:50:55 2015 +0200
@@ -84,13 +84,16 @@
 	}
 	session_id = args[0];
 	if (str_to_pid(args[3], &pid) < 0) {
-		*error_r = "CONNECT: Invalid pid";
+		*error_r = t_strdup_printf("CONNECT: Invalid pid %s for session ID %s",
+					   args[3], session_id);
 		return -1;
 	}
 
 	session = hash_table_lookup(mail_sessions_hash, session_id);
 	if (session != NULL) {
-		*error_r = "CONNECT: Duplicate session ID";
+		*error_r = t_strdup_printf(
+			"CONNECT: Duplicate session ID %s for user %s service %s",
+			session_id, args[1], args[2]);
 		return -1;
 	}
 	session = i_malloc(sizeof(struct mail_session) + stats_alloc_size());