Mercurial > dovecot > core-2.2
changeset 20473:a5a777e84bea
lib-http: client: Fixed potential segfault problem in http_client_connection_server_close().
Used wrong variable: it is set to NULL by http_client_request_unref() before it is used.
Problem found by Coverity.
| author | Stephan Bosch <stephan@rename-it.nl> |
|---|---|
| date | Thu, 30 Jun 2016 22:35:59 +0200 |
| parents | 1b849f5f2beb |
| children | 3f63a4e80fe1 |
| files | src/lib-http/http-client-connection.c |
| diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/lib-http/http-client-connection.c Thu Jun 30 18:13:52 2016 +0300 +++ b/src/lib-http/http-client-connection.c Thu Jun 30 22:35:59 2016 +0200 @@ -113,7 +113,7 @@ if (!http_client_request_unref(req_idx)) continue; /* resubmit the request, which may drop it */ - if ((*req_idx)->state < HTTP_REQUEST_STATE_FINISHED) + if (req->state < HTTP_REQUEST_STATE_FINISHED) http_client_request_resubmit(req); } array_clear(&conn->request_wait_list);