Mercurial > dovecot > core-2.2

changeset 19236:c30c30c1e642

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
lib-http: Added asserts to all refcount increments. These could catch situations where an already freed object's refcount is attempted to be increased.
author Timo Sirainen <tss@iki.fi>
date Mon, 28 Sep 2015 13:54:28 +0300
parents 77486e114423
children cfee3a8b35ec
files src/lib-http/http-client-connection.c src/lib-http/http-client-request.c src/lib-http/http-server-connection.c src/lib-http/http-server-request.c
diffstat 4 files changed, 4 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/lib-http/http-client-connection.c	Mon Sep 28 13:53:22 2015 +0300
+++ b/src/lib-http/http-client-connection.c	Mon Sep 28 13:54:28 2015 +0300
@@ -1294,6 +1294,7 @@
 
 void http_client_connection_ref(struct http_client_connection *conn)
 {
+	i_assert(conn->refcount > 0);
 	conn->refcount++;
 }
 
--- a/src/lib-http/http-client-request.c	Mon Sep 28 13:53:22 2015 +0300
+++ b/src/lib-http/http-client-request.c	Mon Sep 28 13:54:28 2015 +0300
@@ -150,6 +150,7 @@
 
 void http_client_request_ref(struct http_client_request *req)
 {
+	i_assert(req->refcount > 0);
 	req->refcount++;
 }
 
--- a/src/lib-http/http-server-connection.c	Mon Sep 28 13:53:22 2015 +0300
+++ b/src/lib-http/http-server-connection.c	Mon Sep 28 13:54:28 2015 +0300
@@ -831,6 +831,7 @@
 
 void http_server_connection_ref(struct http_server_connection *conn)
 {
+	i_assert(conn->refcount > 0);
 	conn->refcount++;
 }
 
--- a/src/lib-http/http-server-request.c	Mon Sep 28 13:53:22 2015 +0300
+++ b/src/lib-http/http-server-request.c	Mon Sep 28 13:54:28 2015 +0300
@@ -23,6 +23,7 @@
 
 void http_server_request_ref(struct http_server_request *req)
 {
+	i_assert(req->refcount > 0);
 	req->refcount++;
 }