# HG changeset patch # User Timo Sirainen # Date 1138909079 -7200 # Node ID 23e76fc59a35f9f8e876780e0a9a78b35ab179c3 # Parent 884da753caba5f91ba43b5083b2c8f45304b9269 Don't bother checking if mailbox_search_init() returns NULL. It never does. diff -r 884da753caba -r 23e76fc59a35 src/imap/cmd-search.c --- a/src/imap/cmd-search.c Thu Feb 02 20:13:59 2006 +0200 +++ b/src/imap/cmd-search.c Thu Feb 02 21:37:59 2006 +0200 @@ -24,10 +24,6 @@ trans = mailbox_transaction_begin(client->mailbox, 0); ctx = mailbox_search_init(trans, charset, sargs, NULL); - if (ctx == NULL) { - mailbox_transaction_rollback(&trans); - return FALSE; - } str_append(str, "* SEARCH"); mail = mail_alloc(trans, 0, NULL); diff -r 884da753caba -r 23e76fc59a35 src/imap/imap-expunge.c --- a/src/imap/imap-expunge.c Thu Feb 02 20:13:59 2006 +0200 +++ b/src/imap/imap-expunge.c Thu Feb 02 21:37:59 2006 +0200 @@ -20,18 +20,15 @@ t = mailbox_transaction_begin(box, 0); ctx = mailbox_search_init(t, NULL, &search_arg, NULL); - if (ctx == NULL) - failed = TRUE; - else { - mail = mail_alloc(t, 0, NULL); - while (mailbox_search_next(ctx, mail) > 0) { - if (mail_expunge(mail) < 0) { - failed = TRUE; - break; - } + + mail = mail_alloc(t, 0, NULL); + while (mailbox_search_next(ctx, mail) > 0) { + if (mail_expunge(mail) < 0) { + failed = TRUE; + break; } - mail_free(&mail); } + mail_free(&mail); if (mailbox_search_deinit(&ctx) < 0) return FALSE; diff -r 884da753caba -r 23e76fc59a35 src/pop3/client.c --- a/src/pop3/client.c Thu Feb 02 20:13:59 2006 +0200 +++ b/src/pop3/client.c Thu Feb 02 21:37:59 2006 +0200 @@ -75,11 +75,6 @@ t = mailbox_transaction_begin(client->mailbox, 0); ctx = mailbox_search_init(t, NULL, &search_arg, NULL); - if (ctx == NULL) { - client_send_storage_error(client); - mailbox_transaction_rollback(&t); - break; - } client->last_seen = 0; client->total_size = 0;