# HG changeset patch # User Timo Sirainen # Date 1215508549 -19800 # Node ID 47483377feb4373f8000b5df8fdc1669e1ad3906 # Parent 6d9f2185b9e03177c0a53423f99c933113254059 pgsql: Don't crash in sync queries if db can't be connected to. diff -r 6d9f2185b9e0 -r 47483377feb4 src/lib-sql/driver-pgsql.c --- a/src/lib-sql/driver-pgsql.c Tue Jul 08 13:49:35 2008 +0530 +++ b/src/lib-sql/driver-pgsql.c Tue Jul 08 14:45:49 2008 +0530 @@ -560,6 +560,7 @@ driver_pgsql_query_s(struct sql_db *_db, const char *query) { struct pgsql_db *db = (struct pgsql_db *)_db; + struct sql_result *result; struct io old_io; if (db->queue_to != NULL) { @@ -585,7 +586,7 @@ driver_pgsql_query(_db, query, pgsql_query_s_callback, db); if (!db->query_finished) { - if (db->connected || db->connecting) + if ((db->connected || db->connecting) && db->io != NULL) io_loop_run(db->ioloop); else queue_abort_next(db); @@ -602,9 +603,15 @@ } io_loop_destroy(&db->ioloop); - i_assert(db->io == NULL); + result = db->sync_result; + if (result == &sql_not_connected_result) { + /* we don't end up in pgsql's free function, so sync_result + won't be set to NULL if we don't do it here. */ + db->sync_result = NULL; + } - return db->sync_result; + i_assert(db->io == NULL); + return result; } static int driver_pgsql_result_next_row(struct sql_result *_result)