view usr/src/test/zfs-tests/tests/functional/acl/nontrivial/zfs_acl_chmod_inherit_002_neg.ksh @ 13899:0bcf78798346

3311 Want a test framework for arbitrary OS unit tests 3312 Add a testrunner package for OS unit tests 3313 Add a testrunner package to convert ZFS tests from STF Reviewed by: Matt Ahrens <matthew.ahrens@delphix.com> Reviewed by: Will Guyette <will.guyette@delphix.com> Reviewed by: Dan Kimmel <dan.kimmel@delphix.com> Reviewed by: Adam Leventhal <ahl@delphix.com> Reviewed by: Henrik Mattson <henrik.mattson@delphix.com> Reviewed by: Sonu Pillai <sonu.pillai@delphix.com> Reviewed by: Christopher Siden <chris.siden@delphix.com> Reviewed by: George Wilson <george.wilson@delphix.com> Reviewed by: Richard Lowe <richlowe@richlowe.net> Approved by: Richard Lowe <richlowe@richlowe.net>
author John Wren Kennedy <john.kennedy@delphix.com>
date Wed, 05 Dec 2012 22:04:50 -0500
parents
children
line wrap: on
line source

#!/bin/ksh -p
#
# CDDL HEADER START
#
# The contents of this file are subject to the terms of the
# Common Development and Distribution License (the "License").
# You may not use this file except in compliance with the License.
#
# You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
# or http://www.opensolaris.org/os/licensing.
# See the License for the specific language governing permissions
# and limitations under the License.
#
# When distributing Covered Code, include this CDDL HEADER in each
# file and include the License file at usr/src/OPENSOLARIS.LICENSE.
# If applicable, add the following below this CDDL HEADER, with the
# fields enclosed by brackets "[]" replaced with your own identifying
# information: Portions Copyright [yyyy] [name of copyright owner]
#
# CDDL HEADER END
#

#
# Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
# Use is subject to license terms.
#

#
# Copyright (c) 2012 by Delphix. All rights reserved.
#

. $STF_SUITE/tests/functional/acl/acl_common.kshlib

#
# DESCRIPTION:
#	Verify chmod have correct behaviour to directory and file not inherited
#	when filesystem has the different aclinherit setting
#
# STRATEGY:
#	1. Loop super user and non-super user to run the test case.
#	2. Create basedir and a set of subdirectores and files within it.
#	3. Separately chmod basedir with different inherite options,
#	combine with the variable setting of aclinherit:
#		"discard", "noallow", "restricted" or "passthrough".
#	4. Then create nested directories and files like the following.
#
#                     ofile
#                     odir
#          chmod -->  basedir -|
#                              |_ nfile1
#                              |_ ndir1 _
#                                        |_ nfile2
#                                        |_ ndir2 _
#                                                  |_ nfile3
#                                                  |_ ndir3
#
#	5. Verify non-inherited directories and files have the correct access
#	   control capability.
#

verify_runnable "both"

function cleanup
{
	typeset dir

	# Cleanup basedir, compared file and dir.

	if [[ -f $ofile ]]; then
		log_must $RM -f $ofile
	fi

	for dir in $odir $basedir ; do
		if [[ -d $dir ]]; then
			log_must $RM -rf $dir
		fi
	done
	log_must $ZFS set aclmode=discard $TESTPOOL/$TESTFS
}

log_assert "Verify chmod have correct behaviour to directory and file when " \
    "filesystem has the different aclinherit setting."
log_onexit cleanup

# Define inherit flag
typeset aclinherit_flag=(discard noallow restricted passthrough)
typeset object_flag=(file_inherit dir_inherit file_inherit/dir_inherit)
typeset strategy_flag=("" inherit_only no_propagate inherit_only/no_propagate)

typeset ace_prefix1="user:$ZFS_ACL_OTHER1"
typeset ace_prefix2="user:$ZFS_ACL_OTHER2"
typeset ace_discard ace_noallow ace_secure ace_passthrough
typeset ace_secure_new

# Defile the based directory and file
basedir=$TESTDIR/basedir;  ofile=$TESTDIR/ofile; odir=$TESTDIR/odir

# Define the files and directories will be created after chmod
ndir1=$basedir/ndir1; ndir2=$ndir1/ndir2; ndir3=$ndir2/ndir3
nfile1=$basedir/nfile1; nfile2=$ndir1/nfile2; nfile3=$ndir2/nfile3

# Verify all the node have expected correct access control
allnodes="$ndir1 $ndir2 $ndir3 $nfile1 $nfile2 $nfile3"

#
# According to inherited flag, verify subdirectories and files within it has
# correct inherited access control.
#
function verify_inherit #<aclinherit> <object> [strategy]
{
	# Define the nodes which will be affected by inherit.
	typeset non_inherit_nodes=""
	typeset inherit=$1
	typeset obj=$2
	typeset str=$3
	typeset inherit_type
	typeset str1="/inherit_only/inherited:"
	typeset str2="/inherited:"

	# count: the ACE item to fetch
	# maxnumber: predefine as 4
	# passcnt: counter, if it achieves to maxnumber,
	#	then no additional ACE should apply.
	# isinherit: indicate if the current target is in the inherit list.

	typeset -i count=0 pass=0 passcnt=0 isinherit=0 maxnumber=4 no_propagate=0

	log_must usr_exec $MKDIR -p $ndir3
	log_must usr_exec $TOUCH $nfile1 $nfile2 $nfile3

	# Get the inherit type/object_flag and non-inherited nodes.
	if [[ $obj == *"file_inherit"* && $obj == *"dir_inherit"* ]]; then
		inherit_type="both"
		if [[ $str == *"no_propagate"* ]]; then
			non_inherit_nodes= $ndir2 $ndir3 $nfile2 $nfile3
			no_propagate=1
		fi
	elif [[ $obj == *"dir_inherit"* ]]; then
		inherit_type="directory"
		non_inherit_nodes="$nfile1 $nfile2 $nfile3"
		if [[ $str == *"no_propagate"* ]]; then
			non_inherit_nodes="$non_inherit_nodes $ndir2 $ndir3"
			no_propagate=1
		fi
	else
		inherit_type="file"
		non_inherit_nodes="$ndir1 $ndir2 $ndir3"
		if [[ $str == *"no_propagate"* ]]; then
			non_inherit_nodes="$non_inherit_nodes $nfile2 $nfile3"
			no_propagate=1
		fi
	fi
	# Verify ACE's for all the dirs/files under $basedir
	for node in $allnodes; do
		if [[ " $non_inherit_nodes " == *" $node "* ]]; then
			no_inherit=1
		else
			no_inherit=0
		fi
		i=0
		count=0
		passcnt=0
		while ((i < maxnumber)); do
			pass=0
			eval expect1=\$acl$i
			case $inherit in
				noallow)
					[[ $expect1 == *":allow" ]] && pass=1
					;;
				discard)
					passcnt=maxnumber
					break
					;;
			esac
			if ((pass == 0 && no_inherit == 1)); then
				aclaction=${expect1##*:}
				acltemp=${expect1%:*}
				# Verify ACE's for sub-directory
				if [[ -d $node ]]; then
					eval expect1=\$acl$i
					acltemp=${expect1%:*}
					if [[ $inherit_type == "directory" || \
					    $inherit_type == "both" ]]; then
						expect1=${acltemp}/inherited:
						expect1=${expect1}${aclaction}
					elif [[ $inherit_type == "file" ]]; then
						if [[ $expect1 != \
						    *"inherit_only"* ]]; then
							#
							# directory should append
							# "inherit_only" if not have
							#
							expect1=${acltemp}${str1}
							expect1=${expect1}${aclaction}
						else
							expect1=${acltemp}${str2}
							expect1=${expect1}${aclaction}
						fi
					fi
					aclcur=$(get_ACE $node $count)
					aclcur=${aclcur#$count:}
					if [[ $no_propagate == 0 ]]; then
						if [[ $expect1 != $aclcur ]]; then
							$LS -vd $basedir
							$LS -vd $node
							log_fail "$inherit $i #"\
							    "$count ACE: $aclcur"\
							    "expect to be $expect1"
						fi
					else
						# compare if directory has basic
						# ACL's
						compare_acls $node $odir
						if [[ $? -ne 0 ]]; then
							$LS -vd $basedir
							$LS -vd $node
							log_fail "Unexpect acl:"\
							    " $node, $inherit"
							    "($str)"
						fi
					fi
				# Verify ACE's for nested file
				elif [[ -f $node ]]; then
					compare_acls $node $ofile
					if [[ $? -ne 0 ]]; then
						$LS -vd $basedir
						$LS -vd $node
						log_fail "Unexpect acl: $node," \
						    "$inherit ($str)"
					fi

				fi
				((count = count + 1))
			fi
			((i = i + 1))
		done

		#
		# If there's no any ACE be checked, it should be identify as
		# an normal file/dir, verify it.
		#

		if ((passcnt == maxnumber)); then
			if [[ -d $node ]]; then
				compare_acls $node $odir
			elif [[	-f $node ]]; then
				compare_acls $node $ofile
			fi

			if [[ $? -ne 0 ]]; then
				$LS -vd $basedir
				$LS -vd $node
				log_fail "Unexpect acl: $node, $inherit ($str)"
			fi
		fi
	done
}

typeset -i i=0
typeset acl0 acl1 acl2 acl3
typeset acls0 acls1 acls2 acls3

#
# Set aclmode=passthrough to make sure
# the acl will not change during chmod.
# A general testing should verify the combination of
# aclmode/aclinherit works well,
# here we just simple test them separately.
#

log_must $ZFS set aclmode=passthrough $TESTPOOL/$TESTFS

for inherit in "${aclinherit_flag[@]}"; do

	#
	# Set different value of aclinherit
	#

	log_must $ZFS set aclinherit=$inherit $TESTPOOL/$TESTFS

	for user in root $ZFS_ACL_STAFF1; do
		log_must set_cur_usr $user

		for obj in "${object_flag[@]}"; do
			for str in "${strategy_flag[@]}"; do
				typeset inh_opt=$obj
				((${#str} != 0)) && inh_opt=$inh_opt/$str

				#
				# Prepare 4 ACES, which should include :
				# deny -> to verify "noallow"
				# write_acl/write_owner -> to verify "secure"
				#

				acl0=${ace_prefix1}":read_xattr/write_acl/"
				acl0=${acl0}"write_owner:"${inh_opt}":deny"
				acl1="$ace_prefix2:read_xattr/write_acl/"
				acl1=${acl1}"write_owner:$inh_opt:allow"
				acl2="$ace_prefix1:read_xattr:$inh_opt:deny"
				acl3="$ace_prefix2:read_xattr:$inh_opt:allow"

				#
				# The ACE filtered by write_acl/write_owner
				#

				acls0="$ace_prefix1:read_xattr:$inh_opt:deny"
				acls1="$ace_prefix2:read_xattr:$inh_opt:allow"
				acls2=$acl2
				acls3=$acl3
				#
				# Create basedir and tmp dir/file
				# for comparison.
				#
				log_note "$user: $CHMOD $acl $basedir"
				log_must usr_exec $MKDIR $basedir
				log_must usr_exec $MKDIR $odir
				log_must usr_exec $TOUCH $ofile

				i=3
				while ((i >= 0)); do
					eval acl=\$acl$i

				#
				# Place on a directory should succeed.
				#
					log_must usr_exec $CHMOD A+$acl $basedir

					((i = i - 1))
				done
				log_note "verify_inherit $inherit $obj $str"
				log_must verify_inherit $inherit $obj $str

				log_must usr_exec $RM -rf $ofile $odir $basedir
			done
		done
	done
done

log_pass "Verify chmod inherit behaviour co-op with aclinherit setting passed."