changeset 11160:334d14d98fd2

6899293 Use of uninitialized variable in krb5_sname_to_principal on error path
author Mark Phalan <Mark.Phalan@Sun.COM>
date Mon, 09 Nov 2009 12:07:46 +0100
parents 7f286ef996b2
children a6839d90563b
files usr/src/lib/gss_mechs/mech_krb5/krb5/os/sn2princ.c
diffstat 1 files changed, 3 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/usr/src/lib/gss_mechs/mech_krb5/krb5/os/sn2princ.c	Mon Nov 09 12:06:03 2009 +0100
+++ b/usr/src/lib/gss_mechs/mech_krb5/krb5/os/sn2princ.c	Mon Nov 09 12:07:46 2009 +0100
@@ -1,5 +1,5 @@
 /*
- * Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
+ * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
 
@@ -249,7 +249,8 @@
 				      realm, sname, remote_host,
 				      (char *)0);
 
-	krb5_princ_type(context, *ret_princ) = type;
+	if (retval == 0)
+		krb5_princ_type(context, *ret_princ) = type;
 
 #ifdef DEBUG_REFERRALS
 	printf("krb5_sname_to_principal returning\n");