Mercurial > illumos > illumos-gate

changeset 11093:92e0bcf89283

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6894487 ibdma is not lint clean 6894500 srpt is not lint clean 6897087 idm/iser - not lint clean 6893707 iscsitgtd is not lint clean
author srivijitha dugganapalli <Srivijitha.Dugganapalli@Sun.COM>
date Wed, 18 Nov 2009 10:38:52 -0700
parents 17a676e9520e
children 8c8383a5ac33
files usr/src/cmd/iscsi/iscsitgtd/isns_client.c usr/src/cmd/iscsi/iscsitgtd/main.c usr/src/cmd/iscsi/iscsitgtd/mgmt_create.c usr/src/cmd/iscsi/iscsitgtd/t10_spc_pr.c usr/src/uts/common/io/comstar/port/srpt/srpt_ch.c usr/src/uts/common/io/comstar/port/srpt/srpt_ioc.c usr/src/uts/common/io/comstar/port/srpt/srpt_mod.c usr/src/uts/common/io/comstar/port/srpt/srpt_stp.c usr/src/uts/common/io/ib/clients/iser/iser_ib.c usr/src/uts/common/io/ib/clients/iser/iser_idm.c usr/src/uts/common/io/ib/clients/iser/iser_resource.c usr/src/uts/common/io/ib/mgt/ibdma/ibdma.c usr/src/uts/common/io/idm/idm_so.c
diffstat 13 files changed, 49 insertions(+), 47 deletions(-) [+]
line wrap: on
line diff
--- a/usr/src/cmd/iscsi/iscsitgtd/isns_client.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/cmd/iscsi/iscsitgtd/isns_client.c	Wed Nov 18 10:38:52 2009 -0700
@@ -20,7 +20,7 @@
  */
 
 /*
- * Copyright 2008 Sun Microsystems, Inc.  All rights reserved.
+ * Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
  * Use is subject to license terms.
  */
 
@@ -406,7 +406,7 @@
 	while (isns_shutdown == False &&
 	    connection_thr_bail_out == False) {
 		/* current server */
-		strcpy(server, isns_args.server);
+		(void) strcpy(server, isns_args.server);
 
 		if (is_isns_server_up(server) == 0) {
 			if (registered_targets == False) {
@@ -661,7 +661,8 @@
 	int retcode = 0;
 
 	/* get isns server info */
-	tgt_find_value_str(main_config, XML_ELEMENT_ISNS_SERV, &isns_srv);
+	(void) tgt_find_value_str(main_config, XML_ELEMENT_ISNS_SERV,
+	    &isns_srv);
 	if (isns_srv == NULL) {
 		syslog(LOG_INFO,
 		    "The server has not been setup, "
@@ -688,7 +689,7 @@
 			    "Detected a new isns server, deregistering"
 			    " %s", isns_args.server);
 			(void) isns_dereg_all();
-			strcpy(isns_args.server, isns_srv);
+			(void) strcpy(isns_args.server, isns_srv);
 			/* Register with the new server */
 			if (isns_reg_all() == 0) {
 				/* scn register all targets */
@@ -736,7 +737,7 @@
 	    esi_scn_thr, (void *)&isns_args) !=
 	    0) {
 		syslog(LOG_ALERT, "isns_init failed to pthread_create");
-		pthread_kill(isns_tid, SIGKILL);
+		(void) pthread_kill(isns_tid, SIGKILL);
 		return (-1);
 	}
 
@@ -783,8 +784,8 @@
 		if (is_isns_enabled == False) {
 			isns_shutdown = True;
 			/* pthread_join for the isns thread */
-			pthread_join(isns_tid, NULL);
-			pthread_join(scn_tid, NULL);
+			(void) pthread_join(isns_tid, NULL);
+			(void) pthread_join(scn_tid, NULL);
 			isns_server_connection_thr_running = False;
 		} else {
 			/*
--- a/usr/src/cmd/iscsi/iscsitgtd/main.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/cmd/iscsi/iscsitgtd/main.c	Wed Nov 18 10:38:52 2009 -0700
@@ -476,7 +476,7 @@
 
 	if (validate_xml(argp) != True) {
 		xml_rtn_msg(&err_rply, ERR_INVALID_XML_REQUEST);
-		strlcpy(argp, err_rply, arg_size);
+		(void) strlcpy(argp, err_rply, arg_size);
 		free(err_rply);
 		(void) door_return(argp, strlen(argp) + 1, NULL, 0);
 		return;
--- a/usr/src/cmd/iscsi/iscsitgtd/mgmt_create.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/cmd/iscsi/iscsitgtd/mgmt_create.c	Wed Nov 18 10:38:52 2009 -0700
@@ -286,9 +286,9 @@
 		(void) snprintf(path, sizeof (path), "%s/%s",
 		    target_basedir, name);
 		(void) unlink(path);
-		tgt_node_remove(targets_config, n, MatchBoth);
+		(void) tgt_node_remove(targets_config, n, MatchBoth);
 	} else
-		tgt_node_remove(c, l, MatchBoth);
+		(void) tgt_node_remove(c, l, MatchBoth);
 
 	xml_rtn_msg(&msg, code);
 
@@ -568,7 +568,7 @@
 	 * information are not stored as part of the iscsioptions properity, but
 	 * are retained in the in-core targets_config
 	 */
-	tgt_update_value_str(n, XML_ELEMENT_TARG, dataset);
+	(void) tgt_update_value_str(n, XML_ELEMENT_TARG, dataset);
 	c = tgt_node_alloc(XML_ELEMENT_ALIAS, String, dataset);
 	tgt_node_add(n, c);
 
--- a/usr/src/cmd/iscsi/iscsitgtd/t10_spc_pr.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/cmd/iscsi/iscsitgtd/t10_spc_pr.c	Wed Nov 18 10:38:52 2009 -0700
@@ -343,7 +343,7 @@
 		return;
 	}
 
-	pthread_rwlock_wrlock(&res->res_rwlock);
+	(void) pthread_rwlock_wrlock(&res->res_rwlock);
 	/*
 	 * The ways to get in here are,
 	 * 1) to be the owner of the reservation (SPC-2 section 7.21.2)
@@ -359,7 +359,7 @@
 		res->res_owner = cmd->c_lu;
 	}
 	res->res_type = RT_NPR;
-	pthread_rwlock_unlock(&res->res_rwlock);
+	(void) pthread_rwlock_unlock(&res->res_rwlock);
 
 	trans_send_complete(cmd, STATUS_GOOD);
 }
@@ -385,7 +385,7 @@
 		return;
 	}
 
-	pthread_rwlock_wrlock(&res->res_rwlock);
+	(void) pthread_rwlock_wrlock(&res->res_rwlock);
 	/*
 	 * The ways to get in here are,
 	 * 1) to be the owner of the reservation
@@ -400,7 +400,7 @@
 		res->res_owner = NULL;
 		res->res_type = RT_NONE;
 	}
-	pthread_rwlock_unlock(&res->res_rwlock);
+	(void) pthread_rwlock_unlock(&res->res_rwlock);
 
 	trans_send_complete(cmd, STATUS_GOOD);
 }
--- a/usr/src/uts/common/io/comstar/port/srpt/srpt_ch.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/comstar/port/srpt/srpt_ch.c	Wed Nov 18 10:38:52 2009 -0700
@@ -118,8 +118,8 @@
 
 	ibt_set_cq_handler(ch->ch_scq_hdl, srpt_ch_scq_hdlr, ch);
 	ibt_set_cq_handler(ch->ch_rcq_hdl, srpt_ch_rcq_hdlr, ch);
-	ibt_enable_cq_notify(ch->ch_scq_hdl, IBT_NEXT_COMPLETION);
-	ibt_enable_cq_notify(ch->ch_rcq_hdl, IBT_NEXT_COMPLETION);
+	(void) ibt_enable_cq_notify(ch->ch_scq_hdl, IBT_NEXT_COMPLETION);
+	(void) ibt_enable_cq_notify(ch->ch_rcq_hdl, IBT_NEXT_COMPLETION);
 
 	ch_args.rc_flags   = IBT_WR_SIGNALED;
 
@@ -171,7 +171,7 @@
 	    KM_SLEEP);
 	if (ch->ch_swqe == NULL) {
 		SRPT_DPRINTF_L2("ch_alloc, SWQE alloc error");
-		ibt_free_channel(ch->ch_chan_hdl);
+		(void) ibt_free_channel(ch->ch_chan_hdl);
 		goto qp_alloc_err;
 	}
 	mutex_init(&ch->ch_swqe_lock, NULL, MUTEX_DRIVER, NULL);
@@ -185,10 +185,10 @@
 	return (ch);
 
 qp_alloc_err:
-	ibt_free_cq(ch->ch_rcq_hdl);
+	(void) ibt_free_cq(ch->ch_rcq_hdl);
 
 rcq_alloc_err:
-	ibt_free_cq(ch->ch_scq_hdl);
+	(void) ibt_free_cq(ch->ch_scq_hdl);
 
 scq_alloc_err:
 	cv_destroy(&ch->ch_cv_complete);
@@ -257,15 +257,15 @@
 	SRPT_DPRINTF_L3("ch_release_ref - release resources");
 	if (ch->ch_chan_hdl) {
 		SRPT_DPRINTF_L3("ch_release_ref - free channel");
-		ibt_free_channel(ch->ch_chan_hdl);
+		(void) ibt_free_channel(ch->ch_chan_hdl);
 	}
 
 	if (ch->ch_scq_hdl) {
-		ibt_free_cq(ch->ch_scq_hdl);
+		(void) ibt_free_cq(ch->ch_scq_hdl);
 	}
 
 	if (ch->ch_rcq_hdl) {
-		ibt_free_cq(ch->ch_rcq_hdl);
+		(void) ibt_free_cq(ch->ch_rcq_hdl);
 	}
 
 	/*
@@ -657,7 +657,7 @@
 			 * we are done.
 			 */
 			if (cq_rearmed == 0) {
-				ibt_enable_cq_notify(ch->ch_scq_hdl,
+				(void) ibt_enable_cq_notify(ch->ch_scq_hdl,
 				    IBT_NEXT_COMPLETION);
 				cq_rearmed = 1;
 				continue;
@@ -763,7 +763,7 @@
 			 * we are done.
 			 */
 			if (cq_rearmed == 0) {
-				ibt_enable_cq_notify(ch->ch_rcq_hdl,
+				(void) ibt_enable_cq_notify(ch->ch_rcq_hdl,
 				    IBT_NEXT_COMPLETION);
 				cq_rearmed = 1;
 				continue;
--- a/usr/src/uts/common/io/comstar/port/srpt/srpt_ioc.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/comstar/port/srpt/srpt_ioc.c	Wed Nov 18 10:38:52 2009 -0700
@@ -162,7 +162,7 @@
 	hca_cnt = ibt_get_hca_list(&guid);
 	if (hca_cnt < 1) {
 		SRPT_DPRINTF_L2("ioc_attach, no HCA found");
-		ibt_detach(srpt_ctxt->sc_ibt_hdl);
+		(void) ibt_detach(srpt_ctxt->sc_ibt_hdl);
 		srpt_ctxt->sc_ibt_hdl = NULL;
 		return (DDI_FAILURE);
 	}
@@ -216,7 +216,7 @@
 
 	list_destroy(&srpt_ctxt->sc_ioc_list);
 
-	ibt_detach(srpt_ctxt->sc_ibt_hdl);
+	(void) ibt_detach(srpt_ctxt->sc_ibt_hdl);
 	srpt_ctxt->sc_ibt_hdl = NULL;
 }
 
@@ -776,7 +776,7 @@
 		    new_gid.gid_prefix != port->hwp_gid.gid_prefix) {
 			SRPT_DPRINTF_L2("ioc_svc_bind, unregister current"
 			    " bind");
-			ibt_unbind_service(tgt->tp_ibt_svc_hdl,
+			(void) ibt_unbind_service(tgt->tp_ibt_svc_hdl,
 			    port->hwp_bind_hdl);
 			port->hwp_bind_hdl = NULL;
 		}
@@ -838,7 +838,8 @@
 
 	if (tgt->tp_ibt_svc_hdl != NULL && port->hwp_bind_hdl != NULL) {
 		SRPT_DPRINTF_L2("ioc_svc_unbind, unregister current bind");
-		ibt_unbind_service(tgt->tp_ibt_svc_hdl, port->hwp_bind_hdl);
+		(void) ibt_unbind_service(tgt->tp_ibt_svc_hdl,
+		    port->hwp_bind_hdl);
 	}
 	port->hwp_bind_hdl = NULL;
 	port->hwp_gid.gid_prefix = 0;
--- a/usr/src/uts/common/io/comstar/port/srpt/srpt_mod.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/comstar/port/srpt/srpt_mod.c	Wed Nov 18 10:38:52 2009 -0700
@@ -341,7 +341,7 @@
 	srpt_ioc_detach();
 
 err_exit_2:
-	stmf_deregister_port_provider(srpt_ctxt->sc_pp);
+	(void) stmf_deregister_port_provider(srpt_ctxt->sc_pp);
 
 err_exit_1:
 	stmf_free(srpt_ctxt->sc_pp);
@@ -479,7 +479,7 @@
 	srpt_ioc_detach();
 
 	/* De-register ourselves as an STMF port provider */
-	stmf_deregister_port_provider(srpt_ctxt->sc_pp);
+	(void) stmf_deregister_port_provider(srpt_ctxt->sc_pp);
 	stmf_free(srpt_ctxt->sc_pp);
 	srpt_ctxt->sc_pp = NULL;
 
--- a/usr/src/uts/common/io/comstar/port/srpt/srpt_stp.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/comstar/port/srpt/srpt_stp.c	Wed Nov 18 10:38:52 2009 -0700
@@ -173,7 +173,7 @@
 	tgt->tp_srp_enabled = 0;
 	srpt_ioc_svc_unbind_all(tgt);
 	if (tgt->tp_ibt_svc_hdl != NULL) {
-		ibt_deregister_service(srpt_ctxt->sc_ibt_hdl,
+		(void) ibt_deregister_service(srpt_ctxt->sc_ibt_hdl,
 		    tgt->tp_ibt_svc_hdl);
 		tgt->tp_ibt_svc_hdl = NULL;
 	}
--- a/usr/src/uts/common/io/ib/clients/iser/iser_ib.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/ib/clients/iser/iser_ib.c	Wed Nov 18 10:38:52 2009 -0700
@@ -288,7 +288,7 @@
 		    is_sbind != NULL;
 		    is_sbind = next_sb) {
 			next_sb = list_next(&iser_svc->is_sbindlist, is_sbind);
-			ibt_unbind_service(iser_svc->is_srvhdl,
+			(void) ibt_unbind_service(iser_svc->is_srvhdl,
 			    is_sbind->is_sbindhdl);
 			list_remove(&iser_svc->is_sbindlist, is_sbind);
 			kmem_free(is_sbind, sizeof (iser_sbind_t));
@@ -305,9 +305,9 @@
 	if (idm_svc != NULL && idm_svc->is_iser_svc != NULL) {
 
 		iser_svc = (iser_svc_t *)idm_svc->is_iser_svc;
-		ibt_deregister_service(iser_state->is_ibhdl,
+		(void) ibt_deregister_service(iser_state->is_ibhdl,
 		    iser_svc->is_srvhdl);
-		ibt_release_ip_sid(iser_svc->is_svcid);
+		(void) ibt_release_ip_sid(iser_svc->is_svcid);
 	}
 }
 
@@ -521,7 +521,7 @@
 		return (NULL);
 	}
 	ibt_set_cq_handler(chan->ic_sendcq, iser_ib_sendcq_handler, chan);
-	ibt_enable_cq_notify(chan->ic_sendcq, IBT_NEXT_COMPLETION);
+	(void) ibt_enable_cq_notify(chan->ic_sendcq, IBT_NEXT_COMPLETION);
 
 	/* Set up the Receive Completion Queue */
 	status = iser_ib_setup_cq(hca->hca_hdl, chan->ic_recvcq_sz,
@@ -535,7 +535,7 @@
 		return (NULL);
 	}
 	ibt_set_cq_handler(chan->ic_recvcq, iser_ib_recvcq_handler, chan);
-	ibt_enable_cq_notify(chan->ic_recvcq, IBT_NEXT_COMPLETION);
+	(void) ibt_enable_cq_notify(chan->ic_recvcq, IBT_NEXT_COMPLETION);
 
 	/* Setup the channel arguments */
 	iser_ib_setup_chanargs(hca_port, chan->ic_sendcq, chan->ic_recvcq,
@@ -702,8 +702,8 @@
 	chan->ic_chanhdl = NULL;
 
 	/* Free the CQs */
-	ibt_free_cq(chan->ic_sendcq);
-	ibt_free_cq(chan->ic_recvcq);
+	(void) ibt_free_cq(chan->ic_sendcq);
+	(void) ibt_free_cq(chan->ic_recvcq);
 
 	/* Free the chan handle */
 	mutex_destroy(&chan->ic_chan_lock);
@@ -1726,7 +1726,7 @@
 		is_sbind = iser_ib_get_bind(iser_svc, hca_guid, gid);
 		if (is_sbind != NULL) {
 			/* This service is still bound, tear it down */
-			ibt_unbind_service(iser_svc->is_srvhdl,
+			(void) ibt_unbind_service(iser_svc->is_srvhdl,
 			    is_sbind->is_sbindhdl);
 			list_remove(&iser_svc->is_sbindlist, is_sbind);
 			kmem_free(is_sbind, sizeof (iser_sbind_t));
--- a/usr/src/uts/common/io/ib/clients/iser/iser_idm.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/ib/clients/iser/iser_idm.c	Wed Nov 18 10:38:52 2009 -0700
@@ -342,7 +342,7 @@
 	if (rc != DDI_SUCCESS) {
 		ISER_LOG(CE_NOTE, "iser_tgt_svc_create: iser_register_service "
 		    "failed on port (%d): rc (0x%x)", sr->sr_port, rc);
-		ibt_release_ip_sid(iser_svc->is_svcid);
+		(void) ibt_release_ip_sid(iser_svc->is_svcid);
 		list_destroy(&iser_svc->is_sbindlist);
 		idm_refcnt_destroy(&iser_svc->is_refcnt);
 		kmem_free(iser_svc, sizeof (iser_svc_t));
--- a/usr/src/uts/common/io/ib/clients/iser/iser_resource.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/ib/clients/iser/iser_resource.c	Wed Nov 18 10:38:52 2009 -0700
@@ -585,7 +585,7 @@
 void
 iser_dereg_mem(iser_hca_t *hca, iser_mr_t *mr)
 {
-	ibt_deregister_mr(hca->hca_hdl, mr->is_mrhdl);
+	(void) ibt_deregister_mr(hca->hca_hdl, mr->is_mrhdl);
 	kmem_free(mr, sizeof (iser_mr_t));
 }
 
--- a/usr/src/uts/common/io/ib/mgt/ibdma/ibdma.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/ib/mgt/ibdma/ibdma.c	Wed Nov 18 10:38:52 2009 -0700
@@ -303,7 +303,7 @@
 #ifdef	DEBUG_IBDMA
 		cmn_err(CE_NOTE, "ibt_init, no HCA(s) found");
 #endif
-		ibt_detach(ibdma->ms_ibt_hdl);
+		(void) ibt_detach(ibdma->ms_ibt_hdl);
 		return (DDI_FAILURE);
 	}
 
--- a/usr/src/uts/common/io/idm/idm_so.c	Wed Nov 18 09:20:55 2009 -0800
+++ b/usr/src/uts/common/io/idm/idm_so.c	Wed Nov 18 10:38:52 2009 -0700
@@ -1049,10 +1049,10 @@
 	t_addrlen = sizeof (struct sockaddr_in6);
 
 	/* Set the local and remote addresses in the idm conn handle */
-	ksocket_getsockname(so_conn->ic_so, (struct sockaddr *)&t_addr,
+	(void) ksocket_getsockname(so_conn->ic_so, (struct sockaddr *)&t_addr,
 	    &t_addrlen, CRED());
 	bcopy(&t_addr, &ic->ic_laddr, t_addrlen);
-	ksocket_getpeername(so_conn->ic_so, (struct sockaddr *)&t_addr,
+	(void) ksocket_getpeername(so_conn->ic_so, (struct sockaddr *)&t_addr,
 	    &t_addrlen, CRED());
 	bcopy(&t_addr, &ic->ic_raddr, t_addrlen);
 
@@ -3036,10 +3036,10 @@
 
 	/* resume blocking mode */
 	nonblocking = 0;
-	(void)  ksocket_ioctl(ks, FIONBIO, (intptr_t)&nonblocking, &rval,
+	(void) ksocket_ioctl(ks, FIONBIO, (intptr_t)&nonblocking, &rval,
 	    CRED());
 cleanup:
-	ksocket_setcallbacks(ks, NULL, NULL, CRED());
+	(void) ksocket_setcallbacks(ks, NULL, NULL, CRED());
 	cv_destroy(&it.it_cv);
 	if (rc != 0) {
 		idm_soshutdown(ks);