Mercurial > illumos > illumos-gate

changeset 3226:955c53c12aab

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
6406663 rcp's recvacl() leaks memory when acl_fromtext() or facl_set() fail
author mp204432
date Tue, 12 Dec 2006 23:13:49 -0800
parents 388e07ab79ce
children 9602d8b74112
files usr/src/cmd/cmd-inet/usr.bin/rcp.c
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/usr/src/cmd/cmd-inet/usr.bin/rcp.c	Tue Dec 12 22:11:01 2006 -0800
+++ b/usr/src/cmd/cmd-inet/usr.bin/rcp.c	Tue Dec 12 23:13:49 2006 -0800
@@ -1957,12 +1957,15 @@
 			if (aclerror != 0) {
 				error("rcp: failed to parse acl : %s\n",
 				    acl_strerror(aclerror));
+				free(acltext);
 				return (ACL_FAIL);
 			}
 
 			if (f != -1) {
 				if (facl_set(f, aclp) < 0) {
 					error("rcp: failed to set acl\n");
+					acl_free(aclp);
+					free(acltext);
 					return (ACL_FAIL);
 				}
 			}