changeset 9896:e800509e1335

6403003 empty string is accepted as a valid chapname in iscsiadm
author Jack Meng <Jack.Meng@Sun.COM>
date Thu, 18 Jun 2009 13:37:31 +0800
parents adcf72c91c4f
children 4e5853ebe346
files usr/src/cmd/iscsiadm/iscsiadm_main.c
diffstat 1 files changed, 8 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/usr/src/cmd/iscsiadm/iscsiadm_main.c	Thu Jun 18 10:55:44 2009 +0800
+++ b/usr/src/cmd/iscsiadm/iscsiadm_main.c	Thu Jun 18 13:37:31 2009 +0800
@@ -3048,6 +3048,10 @@
 			(void) fprintf(stderr, "CHAP name cannot be NULL.\n");
 			return (1);
 		}
+		if (strlen(chapName) == 0) {
+			(void) fprintf(stderr, "CHAP name cannot be empty.\n");
+			return (1);
+		}
 		(void) memset(&authParams.chapParms.name, 0,
 		    sizeof (authParams.chapParms.name));
 		(void) memcpy(&authParams.chapParms.name,
@@ -3113,6 +3117,10 @@
 			(void) fprintf(stderr, "CHAP name cannot be NULL.\n");
 			return (1);
 		}
+		if (strlen(chapName) == 0) {
+			(void) fprintf(stderr, "CHAP name cannot be empty.\n");
+			return (1);
+		}
 		(void) memset(&authParams.chapParms.name, 0,
 		    sizeof (authParams.chapParms.name));
 		(void) memcpy(&authParams.chapParms.name,