# HG changeset patch
# User Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
# Date 1671326371 18000
# Node ID 7f43822eef34550b8e5e95a03bc2e28dcb2374fd
# Parent  75e654e85cabf7653e6825971c2e29a52b84f0c7
objstore: add a FIXME about decrementing the unlink target's nlinks

Not doing this is currently fine because:

 1. nothing will have a link count >1 as we don't support hardlinks yet
 2. everything we unlink will cease to exist, so not writing a 0 nlinks is ok

Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>

diff -r 75e654e85cab -r 7f43822eef34 src/objstore/obj_dir_unlink.c
--- a/src/objstore/obj_dir_unlink.c	Sat Dec 17 20:15:05 2022 -0500
+++ b/src/objstore/obj_dir_unlink.c	Sat Dec 17 20:19:31 2022 -0500
@@ -72,6 +72,9 @@
 	if (!rmdir && (block->entries[i].tgts[j].type == NDIRENT_TYPE_DIR))
 		return -EISDIR;
 
+	if (!rmdir)
+		FIXME("need to decrement the target's link count");
+
 	/* update the target */
 	block->entries[i].tgts[j].deleted = true;