Mercurial > dovecot > core-2.2
annotate src/lib/eacces-error.c @ 12929:ab12bc9fcc21
eperm_error_get_chgrp(): Changed wiki link.
author | Timo Sirainen <tss@iki.fi> |
---|---|
date | Fri, 08 Apr 2011 16:06:20 +0300 |
parents | 1319931cfda0 |
children | 12e3e8570d77 |
rev | line source |
---|---|
12822
44d0474a451e
Updated copyright notices to include year 2011.
Timo Sirainen <tss@iki.fi>
parents:
12050
diff
changeset
|
1 /* Copyright (c) 2007-2011 Dovecot authors, see the included COPYING file */ |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
2 |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
3 #include "lib.h" |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
4 #include "str.h" |
10502
13be6ac759ee
Added t_get_current_dir() and use it instead of getcwd().
Timo Sirainen <tss@iki.fi>
parents:
10210
diff
changeset
|
5 #include "abspath.h" |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
6 #include "ipwd.h" |
9501
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
7 #include "restrict-access.h" |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
8 #include "eacces-error.h" |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
9 |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
10 #include <sys/stat.h> |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
11 #include <unistd.h> |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
12 |
9501
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
13 static bool is_in_group(gid_t gid) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
14 { |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
15 const gid_t *gids; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
16 unsigned int i, count; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
17 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
18 if (getegid() == gid) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
19 return TRUE; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
20 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
21 gids = restrict_get_groups_list(&count); |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
22 for (i = 0; i < count; i++) { |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
23 if (gids[i] == gid) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
24 return TRUE; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
25 } |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
26 return FALSE; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
27 } |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
28 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
29 static int test_access(const char *path, int mode, string_t *errmsg) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
30 { |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
31 struct stat st; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
32 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
33 if (getuid() == geteuid()) { |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
34 if (access(path, mode) == 0) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
35 return 0; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
36 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
37 if (errno != EACCES) { |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
38 str_printfa(errmsg, " access(%s, %d) failed: %m", |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
39 path, mode); |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
40 } |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
41 return -1; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
42 } |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
43 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
44 /* access() uses real uid, not effective uid. |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
45 we'll have to do these checks manually. */ |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
46 switch (mode) { |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
47 case X_OK: |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
48 if (stat(t_strconcat(path, "/test", NULL), &st) == 0) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
49 return 0; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
50 if (errno == ENOENT || errno == ENOTDIR) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
51 return 0; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
52 if (errno != EACCES) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
53 str_printfa(errmsg, " stat(%s/test) failed: %m", path); |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
54 return -1; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
55 case R_OK: |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
56 mode = 04; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
57 break; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
58 case W_OK: |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
59 mode = 02; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
60 break; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
61 default: |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
62 i_unreached(); |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
63 } |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
64 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
65 if (stat(path, &st) < 0) { |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
66 str_printfa(errmsg, " stat(%s) failed: %m", path); |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
67 return -1; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
68 } |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
69 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
70 if (st.st_uid == geteuid()) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
71 st.st_mode = (st.st_mode & 0700) >> 6; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
72 else if (is_in_group(st.st_gid)) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
73 st.st_mode = (st.st_mode & 0070) >> 3; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
74 else |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
75 st.st_mode = (st.st_mode & 0007); |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
76 |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
77 if ((st.st_mode & mode) != 0) |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
78 return 0; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
79 errno = EACCES; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
80 return -1; |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
81 } |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
82 |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
83 static const char * |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
84 eacces_error_get_full(const char *func, const char *path, bool creating) |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
85 { |
9589
f564209e9396
eacces_error_get*(): Show current directory if path is relative.
Timo Sirainen <tss@iki.fi>
parents:
9537
diff
changeset
|
86 const char *prev_path = path, *dir, *p; |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
87 const char *pw_name = NULL, *gr_name = NULL; |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
88 struct passwd pw; |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
89 struct group group; |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
90 string_t *errmsg; |
9501
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
91 struct stat st, dir_st; |
9537
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
92 int orig_errno, ret = -1; |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
93 |
9537
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
94 orig_errno = errno; |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
95 errmsg = t_str_new(256); |
9589
f564209e9396
eacces_error_get*(): Show current directory if path is relative.
Timo Sirainen <tss@iki.fi>
parents:
9537
diff
changeset
|
96 str_printfa(errmsg, "%s(%s)", func, path); |
12050
8db227a70bec
access_get_error(): Fixed to give better error messages with relative paths.
Timo Sirainen <tss@iki.fi>
parents:
12004
diff
changeset
|
97 dir = "/"; |
9589
f564209e9396
eacces_error_get*(): Show current directory if path is relative.
Timo Sirainen <tss@iki.fi>
parents:
9537
diff
changeset
|
98 if (*path != '/') { |
10502
13be6ac759ee
Added t_get_current_dir() and use it instead of getcwd().
Timo Sirainen <tss@iki.fi>
parents:
10210
diff
changeset
|
99 if (t_get_current_dir(&dir) == 0) |
9589
f564209e9396
eacces_error_get*(): Show current directory if path is relative.
Timo Sirainen <tss@iki.fi>
parents:
9537
diff
changeset
|
100 str_printfa(errmsg, " in directory %s", dir); |
12050
8db227a70bec
access_get_error(): Fixed to give better error messages with relative paths.
Timo Sirainen <tss@iki.fi>
parents:
12004
diff
changeset
|
101 if (strchr(path, '/') == NULL) { |
8db227a70bec
access_get_error(): Fixed to give better error messages with relative paths.
Timo Sirainen <tss@iki.fi>
parents:
12004
diff
changeset
|
102 /* we have no path. do the file access checks anyway. */ |
8db227a70bec
access_get_error(): Fixed to give better error messages with relative paths.
Timo Sirainen <tss@iki.fi>
parents:
12004
diff
changeset
|
103 ret = 0; |
8db227a70bec
access_get_error(): Fixed to give better error messages with relative paths.
Timo Sirainen <tss@iki.fi>
parents:
12004
diff
changeset
|
104 } |
9589
f564209e9396
eacces_error_get*(): Show current directory if path is relative.
Timo Sirainen <tss@iki.fi>
parents:
9537
diff
changeset
|
105 } |
f564209e9396
eacces_error_get*(): Show current directory if path is relative.
Timo Sirainen <tss@iki.fi>
parents:
9537
diff
changeset
|
106 str_printfa(errmsg, " failed: Permission denied (euid=%s", |
f564209e9396
eacces_error_get*(): Show current directory if path is relative.
Timo Sirainen <tss@iki.fi>
parents:
9537
diff
changeset
|
107 dec2str(geteuid())); |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
108 |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
109 switch (i_getpwuid(geteuid(), &pw)) { |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
110 case -1: |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
111 str_append(errmsg, "(<getpwuid() error>)"); |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
112 break; |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
113 case 0: |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
114 str_append(errmsg, "(<unknown>)"); |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
115 break; |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
116 default: |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
117 pw_name = t_strdup(pw.pw_name); |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
118 str_printfa(errmsg, "(%s)", pw_name); |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
119 break; |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
120 } |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
121 |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
122 str_printfa(errmsg, " egid=%s", dec2str(getegid())); |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
123 switch (i_getgrgid(getegid(), &group)) { |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
124 case -1: |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
125 str_append(errmsg, "(<getgrgid() error>)"); |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
126 break; |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
127 case 0: |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
128 str_append(errmsg, "(<unknown>)"); |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
129 break; |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
130 default: |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
131 gr_name = t_strdup(group.gr_name); |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
132 str_printfa(errmsg, "(%s)", gr_name); |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
133 break; |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
134 } |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
135 |
12050
8db227a70bec
access_get_error(): Fixed to give better error messages with relative paths.
Timo Sirainen <tss@iki.fi>
parents:
12004
diff
changeset
|
136 memset(&dir_st, 0, sizeof(dir_st)); |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
137 while ((p = strrchr(prev_path, '/')) != NULL) { |
12854
46d46fa3929f
eacces_error_get*(): Handle errors to / directory better.
Timo Sirainen <tss@iki.fi>
parents:
12822
diff
changeset
|
138 dir = p == prev_path ? "/" : t_strdup_until(prev_path, p); |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
139 ret = stat(dir, &st); |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
140 if (ret == 0) |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
141 break; |
12854
46d46fa3929f
eacces_error_get*(): Handle errors to / directory better.
Timo Sirainen <tss@iki.fi>
parents:
12822
diff
changeset
|
142 if (errno == EACCES && strcmp(dir, "/") != 0) { |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
143 /* see if we have access to parent directory */ |
12854
46d46fa3929f
eacces_error_get*(): Handle errors to / directory better.
Timo Sirainen <tss@iki.fi>
parents:
12822
diff
changeset
|
144 } else if (errno == ENOENT && creating && |
46d46fa3929f
eacces_error_get*(): Handle errors to / directory better.
Timo Sirainen <tss@iki.fi>
parents:
12822
diff
changeset
|
145 strcmp(dir, "/") != 0) { |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
146 /* probably mkdir_parents() failed here, find the first |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
147 parent directory we couldn't create */ |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
148 } else { |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
149 /* some other error, can't handle it */ |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
150 str_printfa(errmsg, " stat(%s) failed: %m", dir); |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
151 break; |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
152 } |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
153 prev_path = dir; |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
154 dir = "/"; |
9501
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
155 dir_st = st; |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
156 } |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
157 |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
158 if (ret == 0) { |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
159 /* dir is the first parent directory we can stat() */ |
9501
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
160 if (test_access(dir, X_OK, errmsg) < 0) { |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
161 if (errno == EACCES) |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
162 str_printfa(errmsg, " missing +x perm: %s", dir); |
9501
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
163 } else if (creating && test_access(dir, W_OK, errmsg) < 0) { |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
164 if (errno == EACCES) |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
165 str_printfa(errmsg, " missing +w perm: %s", dir); |
9501
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
166 } else if (prev_path == path && |
e22e36a61fdd
eacces_error_get*() works now properly when process's real uid != effective uid.
Timo Sirainen <tss@iki.fi>
parents:
8759
diff
changeset
|
167 test_access(path, R_OK, errmsg) < 0) { |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
168 if (errno == EACCES) |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
169 str_printfa(errmsg, " missing +r perm: %s", path); |
9534
8760bc0b1c3a
eacces_error_get(): Check also if user had write permissions to the given file.
Timo Sirainen <tss@iki.fi>
parents:
9501
diff
changeset
|
170 } else if (!creating && test_access(path, W_OK, errmsg) < 0) { |
8760bc0b1c3a
eacces_error_get(): Check also if user had write permissions to the given file.
Timo Sirainen <tss@iki.fi>
parents:
9501
diff
changeset
|
171 /* this produces a wrong error if the operation didn't |
8760bc0b1c3a
eacces_error_get(): Check also if user had write permissions to the given file.
Timo Sirainen <tss@iki.fi>
parents:
9501
diff
changeset
|
172 actually need write permissions, but we don't know |
8760bc0b1c3a
eacces_error_get(): Check also if user had write permissions to the given file.
Timo Sirainen <tss@iki.fi>
parents:
9501
diff
changeset
|
173 it here.. */ |
8760bc0b1c3a
eacces_error_get(): Check also if user had write permissions to the given file.
Timo Sirainen <tss@iki.fi>
parents:
9501
diff
changeset
|
174 if (errno == EACCES) |
8760bc0b1c3a
eacces_error_get(): Check also if user had write permissions to the given file.
Timo Sirainen <tss@iki.fi>
parents:
9501
diff
changeset
|
175 str_printfa(errmsg, " missing +w perm: %s", path); |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
176 } else |
10210
66eaf7b1e36b
eaccess_error*(): Error message updated.
Timo Sirainen <tss@iki.fi>
parents:
9589
diff
changeset
|
177 str_printfa(errmsg, " UNIX perms appear ok, " |
66eaf7b1e36b
eaccess_error*(): Error message updated.
Timo Sirainen <tss@iki.fi>
parents:
9589
diff
changeset
|
178 "some security policy wrong?"); |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
179 } |
10819
6a8ee83cbc8c
eacces_error_get*(): Mention if euid is parent directory's owner.
Timo Sirainen <tss@iki.fi>
parents:
10582
diff
changeset
|
180 if (dir_st.st_uid != geteuid()) { |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
181 if (pw_name != NULL && i_getpwuid(dir_st.st_uid, &pw) > 0 && |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
182 strcmp(pw.pw_name, pw_name) == 0) { |
10819
6a8ee83cbc8c
eacces_error_get*(): Mention if euid is parent directory's owner.
Timo Sirainen <tss@iki.fi>
parents:
10582
diff
changeset
|
183 str_printfa(errmsg, ", conflicting dir uid=%s(%s)", |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
184 dec2str(dir_st.st_uid), pw_name); |
10819
6a8ee83cbc8c
eacces_error_get*(): Mention if euid is parent directory's owner.
Timo Sirainen <tss@iki.fi>
parents:
10582
diff
changeset
|
185 } else { |
6a8ee83cbc8c
eacces_error_get*(): Mention if euid is parent directory's owner.
Timo Sirainen <tss@iki.fi>
parents:
10582
diff
changeset
|
186 str_append(errmsg, ", euid is not dir owner"); |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
187 } |
10819
6a8ee83cbc8c
eacces_error_get*(): Mention if euid is parent directory's owner.
Timo Sirainen <tss@iki.fi>
parents:
10582
diff
changeset
|
188 } else { |
6a8ee83cbc8c
eacces_error_get*(): Mention if euid is parent directory's owner.
Timo Sirainen <tss@iki.fi>
parents:
10582
diff
changeset
|
189 str_append(errmsg, ", euid is dir owner"); |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
190 } |
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
191 if (gr_name != NULL && dir_st.st_gid != getegid()) { |
12859
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
192 if (i_getgrgid(dir_st.st_gid, &group) > 0 && |
02829f7f79c7
Replaced all getpw/gr*() to use i_getpw/gr*() with improved error handling.
Timo Sirainen <tss@iki.fi>
parents:
12854
diff
changeset
|
193 strcmp(group.gr_name, gr_name) == 0) { |
10819
6a8ee83cbc8c
eacces_error_get*(): Mention if euid is parent directory's owner.
Timo Sirainen <tss@iki.fi>
parents:
10582
diff
changeset
|
194 str_printfa(errmsg, ", conflicting dir gid=%s(%s)", |
10553
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
195 dec2str(dir_st.st_gid), gr_name); |
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
196 } |
b8966b8133f2
eacces_error_get*(): Check and warn if multiple uids/gids have same name.
Timo Sirainen <tss@iki.fi>
parents:
10502
diff
changeset
|
197 } |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
198 str_append_c(errmsg, ')'); |
9537
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
199 errno = orig_errno; |
8759
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
200 return str_c(errmsg); |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
201 } |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
202 |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
203 const char *eacces_error_get(const char *func, const char *path) |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
204 { |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
205 return eacces_error_get_full(func, path, FALSE); |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
206 } |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
207 |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
208 const char *eacces_error_get_creating(const char *func, const char *path) |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
209 { |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
210 return eacces_error_get_full(func, path, TRUE); |
6ec819adfde3
Moved user-friendly EACCES error message generation to lib/.
Timo Sirainen <tss@iki.fi>
parents:
diff
changeset
|
211 } |
9537
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
212 |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
213 const char *eperm_error_get_chgrp(const char *func, const char *path, |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
214 gid_t gid, const char *gid_origin) |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
215 { |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
216 string_t *errmsg; |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
217 const struct group *group; |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
218 int orig_errno = errno; |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
219 |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
220 errmsg = t_str_new(256); |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
221 |
12928
1319931cfda0
eperm_error_get_chgrp(): Improved error message and added a link to wiki.
Timo Sirainen <tss@iki.fi>
parents:
12859
diff
changeset
|
222 str_printfa(errmsg, "%s(%s, group=%s", func, path, dec2str(gid)); |
9537
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
223 group = getgrgid(gid); |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
224 if (group != NULL) |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
225 str_printfa(errmsg, "(%s)", group->gr_name); |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
226 |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
227 str_printfa(errmsg, ") failed: Operation not permitted (egid=%s", |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
228 dec2str(getegid())); |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
229 group = getgrgid(getegid()); |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
230 if (group != NULL) |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
231 str_printfa(errmsg, "(%s)", group->gr_name); |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
232 if (gid_origin != NULL) |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
233 str_printfa(errmsg, ", group based on %s", gid_origin); |
12929
ab12bc9fcc21
eperm_error_get_chgrp(): Changed wiki link.
Timo Sirainen <tss@iki.fi>
parents:
12928
diff
changeset
|
234 str_append(errmsg, " - see http://wiki2.dovecot.org/Errors/ChgrpNoPerm)"); |
9537
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
235 errno = orig_errno; |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
236 return str_c(errmsg); |
b373de4973cd
Whenever file's group changing fails, show the group origin in the error message.
Timo Sirainen <tss@iki.fi>
parents:
9534
diff
changeset
|
237 } |