changeset 20268:60327526fd00

lib-imap-storage: Don't sort uninitialized array on invalid header list.
author Timo Sirainen <timo.sirainen@dovecot.fi>
date Wed, 18 May 2016 21:41:49 +0300
parents e0c9a4da066a
children 53ba0bd3d5a7
files src/lib-imap-storage/imap-msgpart.c
diffstat 1 files changed, 2 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/lib-imap-storage/imap-msgpart.c	Wed May 18 14:24:55 2016 +0300
+++ b/src/lib-imap-storage/imap-msgpart.c	Wed May 18 21:41:49 2016 +0300
@@ -166,13 +166,12 @@
 			value = p_strdup(pool, t_str_ucase(value));
 			array_append(fields, &value, 1);
 		}
+		/* istream-header-filter requires headers to be sorted */
+		array_sort(fields, i_strcasecmp_p);
 	} else {
 		result = -1;
 	}
 
-	/* istream-header-filter requires headers to be sorted */
-	array_sort(fields, i_strcasecmp_p);
-
 	imap_parser_unref(&parser);
 	i_stream_unref(&input);
 	return result;