Mercurial > dovecot > core-2.2
changeset 22829:89547df99d4a
doveadm-server: http: Fixed lingering connections after the request is sent.
Turns out conn->http_client is already NULL while doveadm_http_server_connection_destroy() is called.
This is because http_server_connection_unref() sets it to NULL;
Fixed by removing useless HTTP connection reference.
| author | Stephan Bosch <stephan.bosch@dovecot.fi> |
|---|---|
| date | Tue, 17 Oct 2017 03:19:19 +0200 |
| parents | b562bf4b2513 |
| children | cf5fd56a24d3 |
| files | src/doveadm/client-connection-http.c |
| diffstat | 1 files changed, 0 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/src/doveadm/client-connection-http.c Sun Jun 18 19:55:23 2017 +0200 +++ b/src/doveadm/client-connection-http.c Tue Oct 17 03:19:19 2017 +0200 @@ -185,7 +185,6 @@ http_server_request_unref(&(conn->http_server_request)); http_server_switch_ioloop(doveadm_http_server); - http_server_connection_unref(&(conn->http_client)); } static void doveadm_http_server_json_error(void *context, const char *error) @@ -723,7 +722,6 @@ conn->http_request = http_server_request_get(req); struct doveadm_http_server_mount *ep = NULL; - http_server_connection_ref(conn->http_client); http_server_request_set_destroy_callback(req, doveadm_http_server_request_destroy, conn); http_server_request_ref(conn->http_server_request);