Mercurial > dovecot > core-2.2
changeset 12448:9a9f65bcbe19
auth: Fixed assert-crash at deinit if there were clients left with pending auth requests.
author | Timo Sirainen <tss@iki.fi> |
---|---|
date | Thu, 18 Nov 2010 20:35:20 +0000 |
parents | 8adacd9c03b2 |
children | 3e4a65a74c40 |
files | src/auth/auth-client-connection.c |
diffstat | 1 files changed, 3 insertions(+), 11 deletions(-) [+] |
line wrap: on
line diff
--- a/src/auth/auth-client-connection.c Thu Nov 18 19:32:50 2010 +0000 +++ b/src/auth/auth-client-connection.c Thu Nov 18 20:35:20 2010 +0000 @@ -319,9 +319,7 @@ return conn; } -static void -auth_client_connection_destroy_full(struct auth_client_connection **_conn, - bool abort_requests) +void auth_client_connection_destroy(struct auth_client_connection **_conn) { struct auth_client_connection *conn = *_conn; struct auth_client_connection *const *clients; @@ -350,8 +348,7 @@ conn->fd = -1; if (conn->request_handler != NULL) { - if (abort_requests) - auth_request_handler_abort_requests(conn->request_handler); + auth_request_handler_abort_requests(conn->request_handler); auth_request_handler_destroy(&conn->request_handler); } @@ -359,11 +356,6 @@ auth_client_connection_unref(&conn); } -void auth_client_connection_destroy(struct auth_client_connection **_conn) -{ - auth_client_connection_destroy_full(_conn, TRUE); -} - static void auth_client_connection_unref(struct auth_client_connection **_conn) { struct auth_client_connection *conn = *_conn; @@ -404,6 +396,6 @@ clients = array_get_modifiable(&auth_client_connections, &count); for (i = count; i > 0; i--) - auth_client_connection_destroy_full(&clients[i-1], FALSE); + auth_client_connection_destroy(&clients[i-1]); array_free(&auth_client_connections); }