Mercurial > dovecot > core-2.2

changeset 22273:a8b639453bee

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
lib-storage: Fix error logging for failing to create .vsize.lock
author Timo Sirainen <timo.sirainen@dovecot.fi>
date Thu, 22 Jun 2017 01:56:18 +0300
parents 651fa80715a3
children 59406ffe10b1
files src/lib-storage/index/index-mailbox-size.c
diffstat 1 files changed, 5 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/src/lib-storage/index/index-mailbox-size.c	Wed Jun 28 17:48:01 2017 +0300
+++ b/src/lib-storage/index/index-mailbox-size.c	Thu Jun 22 01:56:18 2017 +0300
@@ -150,9 +150,12 @@
 	update->lock_fd = file_create_locked(update->lock_path, &set,
 					     &update->lock, &created, &error);
 	if (update->lock_fd == -1) {
+		/* don't log lock timeouts, because we're somewhat expecting
+		   them. Especially when lock_secs is 0. */
 		if (errno != EAGAIN) {
-			i_error("file_create_locked(%s) failed: %m",
-				update->lock_path);
+			mail_storage_set_critical(box->storage,
+				"file_create_locked(%s) failed: %s",
+				update->lock_path, error);
 		}
 		return FALSE;
 	}