Mercurial > dovecot > core-2.2

changeset 20735:ad61b4f88130

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Added asserts to make static analyzer happier.
author Timo Sirainen <timo.sirainen@dovecot.fi>
date Fri, 09 Sep 2016 18:10:29 +0300
parents 1e3fc9741860
children 9734b271baba
files src/lib-fs/fs-posix.c src/lib-index/mailbox-log.c src/lib-stats/stats-connection.c src/lib-storage/index/imapc/imapc-mail.c src/lib/istream-file.c src/login-common/login-proxy-state.c src/plugins/fts/fts-api.c src/plugins/virtual/virtual-mail.c
diffstat 8 files changed, 8 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/lib-fs/fs-posix.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/lib-fs/fs-posix.c	Fri Sep 09 18:10:29 2016 +0300
@@ -499,6 +499,7 @@
 	if (file->fd == -1) {
 		if (fs_posix_open(file) < 0)
 			return -1;
+		i_assert(file->fd != -1);
 	}
 
 	if (file->open_mode != FS_OPEN_MODE_APPEND) {
--- a/src/lib-index/mailbox-log.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/lib-index/mailbox-log.c	Fri Sep 09 18:10:29 2016 +0300
@@ -176,6 +176,7 @@
 	if (log->fd == -1) {
 		if (mailbox_log_open(log) < 0)
 			return -1;
+		i_assert(log->fd != -1);
 	}
 
 	/* We don't bother with locking, atomic appends will protect us.
--- a/src/lib-stats/stats-connection.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/lib-stats/stats-connection.c	Fri Sep 09 18:10:29 2016 +0300
@@ -83,6 +83,7 @@
 	if (conn->fd == -1) {
 		if (!stats_connection_open(conn))
 			return -1;
+		i_assert(conn->fd != -1);
 	}
 
 	if (str_len(str) > PIPE_BUF && !pipe_warned) {
--- a/src/lib-storage/index/imapc/imapc-mail.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/lib-storage/index/imapc/imapc-mail.c	Fri Sep 09 18:10:29 2016 +0300
@@ -187,6 +187,7 @@
 	old_offset = data->stream == NULL ? 0 : data->stream->v_offset;
 	if (mail_get_stream(_mail, NULL, NULL, &input) < 0)
 		return -1;
+	i_assert(data->stream != NULL);
 	i_stream_seek(data->stream, old_offset);
 
 	ret = i_stream_get_size(data->stream, TRUE,
--- a/src/lib/istream-file.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/lib/istream-file.c	Fri Sep 09 18:10:29 2016 +0300
@@ -54,6 +54,7 @@
 	if (stream->fd == -1) {
 		if (i_stream_file_open(stream) < 0)
 			return -1;
+		i_assert(stream->fd != -1);
 	}
 
 	offset = stream->istream.v_offset + (stream->pos - stream->skip);
--- a/src/login-common/login-proxy-state.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/login-common/login-proxy-state.c	Fri Sep 09 18:10:29 2016 +0300
@@ -138,6 +138,7 @@
 	if (state->notify_fd == -1) {
 		if (login_proxy_state_notify_open(state) < 0)
 			return TRUE;
+		i_assert(state->notify_fd != -1);
 	}
 
 	T_BEGIN {
--- a/src/plugins/fts/fts-api.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/plugins/fts/fts-api.c	Fri Sep 09 18:10:29 2016 +0300
@@ -125,6 +125,7 @@
 {
 	fts_backend_update_unset_build_key(ctx);
 	if (ctx->backend_box != ctx->cur_box) {
+		i_assert(ctx->cur_box != NULL);
 		ctx->backend->v.update_set_mailbox(ctx, ctx->cur_box);
 		ctx->backend_box = ctx->cur_box;
 	}
--- a/src/plugins/virtual/virtual-mail.c	Fri Sep 09 18:07:15 2016 +0300
+++ b/src/plugins/virtual/virtual-mail.c	Fri Sep 09 18:10:29 2016 +0300
@@ -131,6 +131,7 @@
 			return -1;
 		}
 		(void)virtual_mail_set_backend_mail(mail, bbox);
+		i_assert(vmail->cur_backend_mail != NULL);
 	}
 	virtual_backend_box_accessed(mbox, bbox);
 	vmail->cur_lost = !mail_set_uid(vmail->cur_backend_mail,