Mercurial > dovecot > core-2.2

changeset 21796:e9db2f82f290

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
global: Log mailbox_list internal errors
author Martti Rannanjärvi <martti.rannanjarvi@dovecot.fi>
date Fri, 17 Mar 2017 12:58:08 +0200
parents c17be6188c79
children 3daf1ea24cf1
files src/doveadm/doveadm-mail-index.c src/doveadm/doveadm-mail-mailbox.c src/doveadm/doveadm-mail.c src/doveadm/doveadm-mailbox-list-iter.c src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c src/doveadm/dsync/dsync-mailbox-tree-fill.c src/imap/main.c src/lib-imap-urlauth/imap-urlauth-backend.c src/lib-storage/list/mailbox-list-index-backend.c src/lib-storage/mail-autoexpunge.c src/plugins/quota/quota-count.c src/plugins/virtual/virtual-config.c src/pop3/pop3-client.c
diffstat 13 files changed, 15 insertions(+), 15 deletions(-) [+]
line wrap: on
line diff
--- a/src/doveadm/doveadm-mail-index.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/doveadm/doveadm-mail-index.c	Fri Mar 17 12:58:08 2017 +0200
@@ -206,7 +206,7 @@
 	}
 	if (mailbox_list_iter_deinit(&iter) < 0) {
 		i_error("Listing mailboxes failed: %s",
-			mailbox_list_get_last_error(user->namespaces->list, NULL));
+			mailbox_list_get_last_internal_error(user->namespaces->list, NULL));
 		doveadm_mail_failed_error(_ctx, MAIL_ERROR_TEMP);
 		ret = -1;
 	}
--- a/src/doveadm/doveadm-mail-mailbox.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/doveadm/doveadm-mail-mailbox.c	Fri Mar 17 12:58:08 2017 +0200
@@ -741,7 +741,7 @@
 	if (ret < 0) {
 		i_error("Failed to lookup mailbox %s path: %s",
 			ctx->mailbox,
-			mailbox_list_get_last_error(ns->list, &mail_error));
+			mailbox_list_get_last_internal_error(ns->list, &mail_error));
 		doveadm_mail_failed_error(_ctx, mail_error);
 	} else if (ret > 0) {
 		doveadm_print(path);
--- a/src/doveadm/doveadm-mail.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/doveadm/doveadm-mail.c	Fri Mar 17 12:58:08 2017 +0200
@@ -323,7 +323,7 @@
 	}
 	if (mailbox_list_iter_deinit(&iter) < 0) {
 		i_error("Listing mailboxes failed: %s",
-			mailbox_list_get_last_error(user->namespaces->list, NULL));
+			mailbox_list_get_last_internal_error(user->namespaces->list, NULL));
 		doveadm_mail_failed_list(ctx, user->namespaces->list);
 		ret = -1;
 	}
--- a/src/doveadm/doveadm-mailbox-list-iter.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/doveadm/doveadm-mailbox-list-iter.c	Fri Mar 17 12:58:08 2017 +0200
@@ -152,7 +152,7 @@
 		ret = 0;
 	else if ((ret = mailbox_list_iter_deinit(&iter->iter)) < 0) {
 		i_error("Listing mailboxes failed: %s",
-			mailbox_list_get_last_error(iter->user->namespaces->list, &error));
+			mailbox_list_get_last_internal_error(iter->user->namespaces->list, &error));
 		doveadm_mail_failed_error(iter->ctx, error);
 	}
 	array_free(&iter->patterns);
--- a/src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c	Fri Mar 17 12:58:08 2017 +0200
@@ -148,7 +148,7 @@
 		if (mailbox_list_delete_dir(change->ns->list, storage_name) == 0)
 			return 0;
 
-		errstr = mailbox_list_get_last_error(change->ns->list, &error);
+		errstr = mailbox_list_get_last_internal_error(change->ns->list, &error);
 		if (error == MAIL_ERROR_NOTFOUND ||
 		    error == MAIL_ERROR_EXISTS) {
 			dsync_brain_set_changes_during_sync(brain, t_strdup_printf(
--- a/src/doveadm/dsync/dsync-mailbox-tree-fill.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/doveadm/dsync/dsync-mailbox-tree-fill.c	Fri Mar 17 12:58:08 2017 +0200
@@ -361,7 +361,7 @@
 	} T_END;
 	if (mailbox_list_iter_deinit(&iter) < 0) {
 		i_error("Mailbox listing for namespace '%s' failed: %s",
-			ns->prefix, mailbox_list_get_last_error(ns->list, error_r));
+			ns->prefix, mailbox_list_get_last_internal_error(ns->list, error_r));
 		ret = -1;
 	}
 
@@ -377,7 +377,7 @@
 	}
 	if (mailbox_list_iter_deinit(&iter) < 0) {
 		i_error("Mailbox listing for namespace '%s' failed: %s",
-			ns->prefix, mailbox_list_get_last_error(ns->list, error_r));
+			ns->prefix, mailbox_list_get_last_internal_error(ns->list, error_r));
 		ret = -1;
 	}
 	if (ret < 0)
--- a/src/imap/main.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/imap/main.c	Fri Mar 17 12:58:08 2017 +0200
@@ -240,7 +240,7 @@
 	   imapc. */
 	ns = mail_namespace_find_inbox(mail_user->namespaces);
 	(void)mailbox_list_get_hierarchy_sep(ns->list);
-	errstr = mailbox_list_get_last_error(ns->list, &mail_error);
+	errstr = mailbox_list_get_last_internal_error(ns->list, &mail_error);
 	if (mail_error != MAIL_ERROR_NONE) {
 		*error_r = t_strdup(errstr);
 		mail_user_unref(&mail_user);
--- a/src/lib-imap-urlauth/imap-urlauth-backend.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/lib-imap-urlauth/imap-urlauth-backend.c	Fri Mar 17 12:58:08 2017 +0200
@@ -138,7 +138,7 @@
 	}
 	if (mailbox_list_iter_deinit(&iter) < 0) {
 		i_error("urlauth key reset: Couldn't iterate mailboxes: %s",
-			mailbox_list_get_last_error(user->namespaces->list, NULL));
+			mailbox_list_get_last_internal_error(user->namespaces->list, NULL));
 		ret = -1;
 	}
 	return ret;
--- a/src/lib-storage/list/mailbox-list-index-backend.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/lib-storage/list/mailbox-list-index-backend.c	Fri Mar 17 12:58:08 2017 +0200
@@ -54,7 +54,7 @@
 	if (mailbox_list_get_root_path(_list, MAILBOX_LIST_PATH_TYPE_INDEX, &dir) &&
 	    mailbox_list_mkdir_root(_list, dir, MAILBOX_LIST_PATH_TYPE_INDEX) < 0) {
 		*error_r = t_strdup_printf("Failed to create the index root directory: %s",
-					   mailbox_list_get_last_error(_list, NULL));
+					   mailbox_list_get_last_internal_error(_list, NULL));
 		return -1;
 	}
 	return 0;
--- a/src/lib-storage/mail-autoexpunge.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/lib-storage/mail-autoexpunge.c	Fri Mar 17 12:58:08 2017 +0200
@@ -177,7 +177,7 @@
 	} T_END;
 	if (mailbox_list_iter_deinit(&iter) < 0) {
 		i_error("Failed to iterate autoexpunge mailboxes '%s': %s",
-			iter_name, mailbox_list_get_last_error(ns->list, NULL));
+			iter_name, mailbox_list_get_last_internal_error(ns->list, NULL));
 	}
 }
 
--- a/src/plugins/quota/quota-count.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/plugins/quota/quota-count.c	Fri Mar 17 12:58:08 2017 +0200
@@ -94,7 +94,7 @@
 		if (mailbox_list_iter_deinit(&iter->iter) < 0) {
 			i_error("quota: Listing namespace '%s' failed: %s",
 				iter->ns->prefix,
-				mailbox_list_get_last_error(iter->ns->list, NULL));
+				mailbox_list_get_last_internal_error(iter->ns->list, NULL));
 			ret = -1;
 		}
 	}
@@ -130,7 +130,7 @@
 	if (mailbox_list_iter_deinit(&iter->iter) < 0) {
 		i_error("quota: Listing namespace '%s' failed: %s",
 			iter->ns->prefix,
-			mailbox_list_get_last_error(iter->ns->list, NULL));
+			mailbox_list_get_last_internal_error(iter->ns->list, NULL));
 		iter->failed = TRUE;
 	}
 	if (iter->ns->prefix_len > 0 &&
--- a/src/plugins/virtual/virtual-config.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/plugins/virtual/virtual-config.c	Fri Mar 17 12:58:08 2017 +0200
@@ -440,7 +440,7 @@
 	for (i = 0; i < count; i++)
 		mail_search_args_unref(&wboxes[i]->search_args);
 	if (mailbox_list_iter_deinit(&iter) < 0) {
-		*error_r = mailbox_list_get_last_error(user->namespaces->list, NULL);
+		*error_r = mailbox_list_get_last_internal_error(user->namespaces->list, NULL);
 		return -1;
 	}
 	return ret < 0 ? -1 : 0;
--- a/src/pop3/pop3-client.c	Fri Mar 17 12:38:21 2017 +0200
+++ b/src/pop3/pop3-client.c	Fri Mar 17 12:58:08 2017 +0200
@@ -353,7 +353,7 @@
 	}
 	if (mailbox_list_mkdir_root(client->inbox_ns->list, dir, type) < 0) {
 		i_error("pop3_lock_session: Couldn't create root directory %s: %s",
-			dir, mailbox_list_get_last_error(client->inbox_ns->list, NULL));
+			dir, mailbox_list_get_last_internal_error(client->inbox_ns->list, NULL));
 		return -1;
 	}
 	path = t_strdup_printf("%s/"POP3_LOCK_FNAME, dir);