dovecot/original-hg/dovecot-1.2: src/lib-storage/index/index-sort-string.c annotate

annotate src/lib-storage/index/index-sort-string.c @ 8193:b3fb8215a339 HEAD

Sort indexes: Don't assert-crash with broken sort IDs.

author	Timo Sirainen <tss@iki.fi>
date	Sat, 13 Sep 2008 11:56:16 +0300
parents	7e3590da43a9
children	f0c9677bf489

rev	line source
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	1 /* Copyright (c) 2006-2008 Dovecot authors, see the included COPYING file */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	2
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	3 /* The idea is that we use 32bit integers for string sort IDs which specifiy
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	4 the sort order for primary sort condition. The whole 32bit integer space is
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	5 used and whenever adding a string, the available space is halved and the new
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	6 ID is added in the middle. For example if we add one mail the first time, it
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	7 gets ID 2^31. If we then add two mails which are sorted before the first
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	8 one, they get IDs 2^31/3 and 2^31/3*2. Once we run out of the available
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	9 space between IDs, more space is made by renumbering some IDs.
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	10 */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	11 #include "lib.h"
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	12 #include "array.h"
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	13 #include "str.h"
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	14 #include "index-storage.h"
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	15 #include "index-sort-private.h"
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	16
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	17 #include <stdlib.h>
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	18
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	19 struct mail_sort_node {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	20 uint32_t seq:29;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	21 uint32_t wanted:1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	22 uint32_t no_update:1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	23 uint32_t sort_id_changed:1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	24 uint32_t sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	25 };
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	26 ARRAY_DEFINE_TYPE(mail_sort_node, struct mail_sort_node);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	27
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	28 struct sort_string_context {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	29 struct mail_search_sort_program *program;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	30
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	31 ARRAY_TYPE(mail_sort_node) zero_nodes, nonzero_nodes, sorted_nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	32 const char **sort_strings;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	33 pool_t sort_string_pool;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	34 unsigned int first_missing_sort_id_idx;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	35
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	36 uint32_t ext_id, last_seq, highest_reset_id;
7569 ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	37 uint32_t lowest_nonexpunged_zero;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	38
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	39 unsigned int regetting:1;
7567 9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	40 unsigned int have_all_wanted:1;
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	41 unsigned int no_writing:1;
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	42 unsigned int reverse:1;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	43 };
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	44
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	45 static char expunged_msg;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	46 static struct sort_string_context *static_zero_cmp_context;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	47
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	48 static void index_sort_node_add(struct sort_string_context *ctx,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	49 struct mail_sort_node *node);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	50
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	51 void index_sort_list_init_string(struct mail_search_sort_program *program)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	52 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	53 struct index_mailbox ibox = (struct index_mailbox )program->t->box;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	54 struct sort_string_context *ctx;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	55 const char *name;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	56
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	57 switch (program->sort_program[0] & MAIL_SORT_MASK) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	58 case MAIL_SORT_CC:
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	59 name = "sort-c";
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	60 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	61 case MAIL_SORT_FROM:
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	62 name = "sort-f";
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	63 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	64 case MAIL_SORT_SUBJECT:
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	65 name = "sort-s";
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	66 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	67 case MAIL_SORT_TO:
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	68 name = "sort-t";
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	69 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	70 default:
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	71 i_unreached();
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	72 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	73
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	74 program->context = ctx = i_new(struct sort_string_context, 1);
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	75 ctx->reverse = (program->sort_program[0] & MAIL_SORT_FLAG_REVERSE) != 0;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	76 ctx->program = program;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	77 ctx->ext_id = mail_index_ext_register(ibox->index, name, 0,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	78 sizeof(uint32_t),
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	79 sizeof(uint32_t));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	80 i_array_init(&ctx->zero_nodes, 128);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	81 i_array_init(&ctx->nonzero_nodes, 128);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	82 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	83
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	84 static void index_sort_generate_seqs(struct sort_string_context *ctx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	85 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	86 struct mail_sort_node nodes, nodes2;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	87 unsigned int i, j, count, count2;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	88 uint32_t seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	89
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	90 nodes = array_get_modifiable(&ctx->nonzero_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	91 nodes2 = array_get_modifiable(&ctx->zero_nodes, &count2);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	92
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	93 if (!array_is_created(&ctx->program->seqs))
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	94 i_array_init(&ctx->program->seqs, count + count2);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	95 else
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	96 array_clear(&ctx->program->seqs);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	97
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	98 for (i = j = 0;;) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	99 if (i < count && j < count2) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	100 if (nodes[i].seq < nodes2[j].seq)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	101 seq = nodes[i++].seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	102 else
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	103 seq = nodes2[j++].seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	104 } else if (i < count) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	105 seq = nodes[i++].seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	106 } else if (j < count2) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	107 seq = nodes2[j++].seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	108 } else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	109 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	110 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	111 array_append(&ctx->program->seqs, &seq, 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	112 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	113 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	114
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	115 static void index_sort_reget_sort_ids(struct sort_string_context *ctx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	116 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	117 struct mail_sort_node node;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	118 const uint32_t *seqs;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	119 unsigned int i, count;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	120
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	121 i_assert(!ctx->regetting);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	122 ctx->regetting = TRUE;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	123
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	124 index_sort_generate_seqs(ctx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	125 array_clear(&ctx->zero_nodes);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	126 array_clear(&ctx->nonzero_nodes);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	127
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	128 memset(&node, 0, sizeof(node));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	129 node.wanted = TRUE;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	130 seqs = array_get(&ctx->program->seqs, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	131 for (i = 0; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	132 node.seq = seqs[i];
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	133 index_sort_node_add(ctx, &node);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	134 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	135 ctx->regetting = FALSE;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	136 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	137
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	138 static void index_sort_node_add(struct sort_string_context *ctx,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	139 struct mail_sort_node *node)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	140 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	141 struct index_transaction_context *t =
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	142 (struct index_transaction_context *)ctx->program->t;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	143 struct mail_index_map *map;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	144 const void *data;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	145 uint32_t reset_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	146 bool expunged;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	147
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	148 mail_index_lookup_ext_full(t->trans_view, node->seq,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	149 ctx->ext_id, &map, &data, &expunged);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	150 if (expunged) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	151 /* we don't want to update expunged messages' sort IDs */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	152 node->no_update = TRUE;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	153 /* we can't trust expunged messages' sort IDs. they might be
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	154 valid, but it's also possible that sort IDs were updated
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	155 and the expunged messages' sort IDs became invalid. we could
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	156 use sort ID if we could know the extension's reset_id at the
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	157 time of the expunge so we could compare it to
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	158 highest_reset_id, but this isn't currently possible. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	159 node->sort_id = 0;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	160 } else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	161 node->sort_id = data == NULL ? 0 : (const uint32_t )data;
7569 ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	162 if (node->sort_id == 0) {
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	163 if (ctx->lowest_nonexpunged_zero > node->seq \|\|
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	164 ctx->lowest_nonexpunged_zero == 0)
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	165 ctx->lowest_nonexpunged_zero = node->seq;
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	166 } else {
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	167 i_assert(ctx->lowest_nonexpunged_zero == 0 \|\|
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	168 ctx->lowest_nonexpunged_zero > node->seq);
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	169 }
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	170 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	171
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	172 if (node->sort_id != 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	173 /* if reset ID increases, lookup all existing messages' sort
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	174 IDs again. if it decreases, ignore the sort ID. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	175 if (!mail_index_ext_get_reset_id(t->trans_view, map,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	176 ctx->ext_id, &reset_id))
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	177 reset_id = 0;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	178 if (reset_id != ctx->highest_reset_id) {
7567 9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	179 if (reset_id < ctx->highest_reset_id) {
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	180 i_assert(expunged);
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	181 node->sort_id = 0;
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	182 } else if (ctx->have_all_wanted) {
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	183 /* a bit late to start changing the reset_id.
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	184 the node lists aren't ordered by sequence
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	185 anymore. */
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	186 node->sort_id = 0;
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	187 ctx->no_writing = TRUE;
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	188 } else {
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	189 ctx->highest_reset_id = reset_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	190 index_sort_reget_sort_ids(ctx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	191 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	192 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	193 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	194
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	195 if (node->sort_id == 0)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	196 array_append(&ctx->zero_nodes, node, 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	197 else
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	198 array_append(&ctx->nonzero_nodes, node, 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	199 if (ctx->last_seq < node->seq)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	200 ctx->last_seq = node->seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	201 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	202
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	203 void index_sort_list_add_string(struct mail_search_sort_program *program,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	204 struct mail *mail)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	205 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	206 struct mail_sort_node node;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	207
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	208 memset(&node, 0, sizeof(node));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	209 node.seq = mail->seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	210 node.wanted = TRUE;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	211
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	212 index_sort_node_add(program->context, &node);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	213 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	214
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	215 static int sort_node_zero_string_cmp(const void p1, const void p2)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	216 {
7613 63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	217 struct sort_string_context *ctx = static_zero_cmp_context;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	218 const struct mail_sort_node n1 = p1, n2 = p2;
7613 63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	219 int ret;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	220
7613 63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	221 ret = strcmp(ctx->sort_strings[n1->seq], ctx->sort_strings[n2->seq]);
63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	222 if (ret != 0)
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	223 return !ctx->reverse ? ret : -ret;
7613 63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	224
63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	225 return index_sort_node_cmp_type(ctx->program->temp_mail,
63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	226 ctx->program->sort_program + 1,
63602977ca9b sort index: Messages without sort_id weren't sorted correctly on secondary Timo Sirainen <tss@iki.fi> parents: 7612 diff changeset	227 n1->seq, n2->seq);
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	228 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	229
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	230 static void index_sort_zeroes(struct sort_string_context *ctx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	231 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	232 struct mail *mail = ctx->program->temp_mail;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	233 enum mail_sort_type sort_type = ctx->program->sort_program[0];
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	234 string_t *str;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	235 pool_t pool;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	236 struct mail_sort_node *nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	237 unsigned int i, count;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	238
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	239 /* first get all the messages' sort strings. although this takes more
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	240 memory, it makes error handling easier and probably also helps
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	241 CPU caching. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	242 ctx->sort_strings = i_new(const char *, ctx->last_seq + 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	243 ctx->sort_string_pool = pool =
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	244 pool_alloconly_create("sort strings", 1024*64);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	245 str = t_str_new(512);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	246 nodes = array_get_modifiable(&ctx->zero_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	247 for (i = 0; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	248 i_assert(nodes[i].seq <= ctx->last_seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	249
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	250 index_sort_header_get(mail, nodes[i].seq, sort_type, str);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	251 ctx->sort_strings[nodes[i].seq] = str_len(str) == 0 ? "" :
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	252 p_strdup(pool, str_c(str));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	253 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	254
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	255 /* we have all strings, sort nodes based on them */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	256 static_zero_cmp_context = ctx;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	257 qsort(nodes, count, sizeof(struct mail_sort_node),
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	258 sort_node_zero_string_cmp);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	259 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	260
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	261 static const char *
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	262 index_sort_get_expunged_string(struct sort_string_context *ctx, uint32_t idx,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	263 string_t *str)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	264 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	265 struct mail *mail = ctx->program->temp_mail;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	266 enum mail_sort_type sort_type = ctx->program->sort_program[0];
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	267 const struct mail_sort_node *nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	268 const char *result = NULL;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	269 unsigned int i, count;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	270 uint32_t sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	271
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	272 /* Look forwards and backwards to see if there are
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	273 identical sort_ids. If we do find them, try to get
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	274 their sort string and use it to update the rest. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	275 nodes = array_get(&ctx->nonzero_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	276 sort_id = nodes[idx].sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	277 /* If previous sort ID is identical and its sort string is set, we can
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	278 trust it. If it's expunged, we already verified that there are no
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	279 non-expunged messages. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	280 if (idx > 0 && nodes[idx-1].sort_id == sort_id &&
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	281 ctx->sort_strings[nodes[idx].seq] != NULL)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	282 return ctx->sort_strings[nodes[idx].seq];
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	283
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	284 /* Go forwards as long as there are identical sort IDs. If we find one
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	285 that's not expunged, update string table for all messages with
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	286 identical sort IDs. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	287 for (i = idx + 1; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	288 if (nodes[i].sort_id != sort_id)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	289 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	290
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	291 if (ctx->sort_strings[nodes[i].seq] != NULL) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	292 /* usually we fill all identical sort_ids and this
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	293 shouldn't happen, but we can get here if we skipped
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	294 over messages when binary searching */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	295 result = ctx->sort_strings[nodes[i].seq];
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	296 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	297 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	298 if (index_sort_header_get(mail, nodes[i].seq,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	299 sort_type, str) >= 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	300 result = str_len(str) == 0 ? "" :
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	301 p_strdup(ctx->sort_string_pool, str_c(str));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	302 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	303 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	304 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	305 if (result == NULL) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	306 /* unknown */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	307 return &expunged_msg;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	308 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	309
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	310 /* fill all identical sort_ids with the same value */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	311 for (i = idx; i > 0 && nodes[i-1].sort_id == sort_id; i--) ;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	312 for (i = idx; i < count && nodes[i].sort_id == sort_id; i++)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	313 ctx->sort_strings[nodes[i].seq] = result;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	314 return result;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	315 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	316
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	317 static const char *
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	318 index_sort_get_string(struct sort_string_context *ctx,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	319 uint32_t idx, uint32_t seq)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	320 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	321 struct mail *mail = ctx->program->temp_mail;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	322 int ret;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	323
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	324 if (ctx->sort_strings[seq] == NULL) T_BEGIN {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	325 string_t *str;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	326
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	327 str = t_str_new(256);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	328 ret = index_sort_header_get(mail, seq,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	329 ctx->program->sort_program[0], str);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	330 if (str_len(str) > 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	331 ctx->sort_strings[seq] =
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	332 p_strdup(ctx->sort_string_pool, str_c(str));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	333 } else if (ret >= 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	334 ctx->sort_strings[seq] = "";
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	335 } else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	336 ctx->sort_strings[seq] =
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	337 index_sort_get_expunged_string(ctx, idx, str);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	338 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	339 } T_END;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	340
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	341 return ctx->sort_strings[seq];
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	342 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	343
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	344 static void
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	345 index_sort_bsearch(struct sort_string_context ctx, const char key,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	346 unsigned int start_idx, unsigned int *idx_r,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	347 const char **prev_str_r)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	348 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	349 const struct mail_sort_node *nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	350 const char str, str2;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	351 unsigned int idx, left_idx, right_idx, prev;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	352 int ret;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	353
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	354 nodes = array_get_modifiable(&ctx->nonzero_nodes, &right_idx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	355 idx = left_idx = start_idx;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	356 while (left_idx < right_idx) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	357 idx = (left_idx + right_idx) / 2;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	358 str = index_sort_get_string(ctx, idx, nodes[idx].seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	359 if (str != &expunged_msg)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	360 ret = strcmp(key, str);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	361 else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	362 /* put expunged messages first */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	363 ret = 1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	364 for (prev = idx; prev > 0; ) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	365 prev--;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	366 str2 = index_sort_get_string(ctx, prev,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	367 nodes[prev].seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	368 if (str2 != &expunged_msg) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	369 ret = strcmp(key, str2);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	370 if (ret <= 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	371 idx = prev;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	372 str = str2;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	373 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	374 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	375 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	376 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	377 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	378 if (ret > 0)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	379 left_idx = idx+1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	380 else if (ret < 0)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	381 right_idx = idx;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	382 else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	383 *idx_r = idx + 1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	384 *prev_str_r = str;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	385 return;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	386 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	387 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	388
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	389 if (left_idx > idx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	390 idx++;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	391
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	392 *idx_r = idx;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	393 if (idx > start_idx) {
7566 8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	394 prev = idx;
8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	395 do {
8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	396 prev--;
8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	397 str2 = index_sort_get_string(ctx, prev,
8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	398 nodes[prev].seq);
8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	399 } while (str2 == &expunged_msg && prev > 0 &&
8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	400 nodes[prev-1].sort_id == nodes[prev].sort_id);
8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	401 *prev_str_r = str2;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	402 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	403 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	404
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	405 static void index_sort_merge(struct sort_string_context *ctx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	406 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	407 struct mail_sort_node znodes, nznodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	408 const char zstr, nzstr, *prev_str;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	409 unsigned int zpos, nzpos, nz_next_pos, zcount, nzcount;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	410 int ret;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	411
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	412 /* both zero_nodes and nonzero_nodes are sorted. we'll now just have
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	413 to merge them together. use sorted_nodes as the result array. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	414 i_array_init(&ctx->sorted_nodes, array_count(&ctx->nonzero_nodes) +
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	415 array_count(&ctx->zero_nodes));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	416
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	417 znodes = array_get_modifiable(&ctx->zero_nodes, &zcount);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	418 nznodes = array_get_modifiable(&ctx->nonzero_nodes, &nzcount);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	419
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	420 prev_str = NULL;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	421 for (zpos = nzpos = 0; zpos < zcount && nzpos < nzcount; ) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	422 zstr = ctx->sort_strings[znodes[zpos].seq];
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	423 nzstr = index_sort_get_string(ctx, nzpos, nznodes[nzpos].seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	424
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	425 if (nzstr != &expunged_msg)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	426 ret = strcmp(zstr, nzstr);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	427 else if (prev_str != NULL && strcmp(zstr, prev_str) == 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	428 /* identical to previous message, must keep them
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	429 together */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	430 ret = -1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	431 } else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	432 /* we can't be yet sure about the order, but future
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	433 nznodes may reveal that the znode must be added
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	434 later. if future nznodes don't reveal that, we have
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	435 no idea about these nodes' order. so just always
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	436 put the expunged message first. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	437 ret = 1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	438 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	439
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	440 if (ret <= 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	441 array_append(&ctx->sorted_nodes, &znodes[zpos], 1);
7566 8ae86f73f80d Fixes to sort indexing. Timo Sirainen <tss@iki.fi> parents: 7564 diff changeset	442 prev_str = zstr;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	443 zpos++;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	444 } else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	445 array_append(&ctx->sorted_nodes, &nznodes[nzpos], 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	446 prev_str = nzstr;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	447 nzpos++;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	448
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	449 /* avoid looking up all existing messages' strings by
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	450 binary searching the next zero-node position. don't
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	451 bother if it looks like more work than linear
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	452 scanning. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	453 if (zcount - zpos < (nzcount - nzpos)/2) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	454 index_sort_bsearch(ctx, zstr, nzpos,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	455 &nz_next_pos, &prev_str);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	456 array_append(&ctx->sorted_nodes,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	457 &nznodes[nzpos],
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	458 nz_next_pos - nzpos);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	459 nzpos = nz_next_pos;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	460 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	461 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	462 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	463 /* only one of zero_nodes and nonzero_nodes can be non-empty now */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	464 for (; zpos < zcount; zpos++)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	465 array_append(&ctx->sorted_nodes, &znodes[zpos], 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	466 for (; nzpos < nzcount; nzpos++)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	467 array_append(&ctx->sorted_nodes, &nznodes[nzpos], 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	468
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	469 /* future index_sort_get_string() calls use ctx->nonzero_nodes, but we
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	470 use only ctx->sorted_nodes. make them identical. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	471 array_free(&ctx->nonzero_nodes);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	472 ctx->nonzero_nodes = ctx->sorted_nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	473 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	474
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	475 static int
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	476 index_sort_add_ids_range(struct sort_string_context *ctx,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	477 unsigned int left_idx, unsigned int right_idx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	478 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	479
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	480 struct mail_sort_node *nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	481 unsigned int i, count, rightmost_idx, skip;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	482 const char left_str = NULL, right_str = NULL, *str;
7609 c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	483 uint32_t left_sort_id, right_sort_id, diff;
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	484 bool no_left_str = FALSE, no_right_str = FALSE;
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	485 int ret;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	486
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	487 nodes = array_get_modifiable(&ctx->sorted_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	488 rightmost_idx = count - 1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	489
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	490 /* get the sort IDs from left and right */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	491 left_sort_id = nodes[left_idx].sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	492 right_sort_id = nodes[right_idx].sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	493 /* check if all of them should have the same sort IDs. we don't want
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	494 to hit the renumbering code in that situation. */
7612 5824e6f1d279 sort index: Removed some optimization checks that wouldn't always be true, Timo Sirainen <tss@iki.fi> parents: 7609 diff changeset	495 if (left_sort_id == right_sort_id && left_sort_id != 0) {
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	496 /* they should all have the same sort ID */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	497 for (i = left_idx + 1; i < right_idx; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	498 nodes[i].sort_id = left_sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	499 nodes[i].sort_id_changed = TRUE;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	500 }
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	501 return 0;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	502 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	503
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	504 if (left_sort_id == 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	505 i_assert(left_idx == 0);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	506 left_sort_id = 1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	507 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	508 if (right_sort_id == 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	509 i_assert(right_idx == rightmost_idx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	510 right_sort_id = (uint32_t)-1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	511 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	512 i_assert(left_sort_id <= right_sort_id);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	513
7609 c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	514 diff = right_sort_id - left_sort_id;
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	515 while (diff / (right_idx-left_idx + 2) == 0) {
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	516 /* we most likely don't have enough space. we have to
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	517 renumber some of the existing sort IDs. do this by
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	518 widening the area we're giving sort IDs. */
8070 7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	519 while (left_idx > 0) {
7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	520 if (nodes[--left_idx].sort_id != left_sort_id) {
7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	521 left_sort_id = nodes[left_idx].sort_id;
7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	522 if (left_sort_id == 0) {
7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	523 i_assert(left_idx == 0);
7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	524 left_sort_id = 1;
7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	525 }
7e3590da43a9 sort indexes: One more assert-crashfix when renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 8018 diff changeset	526 break;
7568 66e6b61680a5 Sort index: Fix to renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 7567 diff changeset	527 }
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	528 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	529
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	530 while (right_idx < rightmost_idx) {
7609 c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	531 right_idx++;
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	532 if (nodes[right_idx].sort_id > right_sort_id)
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	533 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	534 }
7568 66e6b61680a5 Sort index: Fix to renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 7567 diff changeset	535 right_sort_id = nodes[right_idx].sort_id;
66e6b61680a5 Sort index: Fix to renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 7567 diff changeset	536 if (right_sort_id == 0) {
66e6b61680a5 Sort index: Fix to renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 7567 diff changeset	537 i_assert(right_idx == rightmost_idx);
66e6b61680a5 Sort index: Fix to renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 7567 diff changeset	538 right_sort_id = (uint32_t)-1;
66e6b61680a5 Sort index: Fix to renumbering sort IDs. Timo Sirainen <tss@iki.fi> parents: 7567 diff changeset	539 }
8018 2621f6f10c2e SORT: Fixed assert-crash. Timo Sirainen <tss@iki.fi> parents: 7956 diff changeset	540 i_assert(left_sort_id <= right_sort_id);
7609 c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	541
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	542 if (diff == right_sort_id - left_sort_id) {
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	543 /* we did nothing, but there's still not enough space.
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	544 have to renumber the leftmost/rightmost node(s) */
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	545 i_assert(left_idx == 0 && right_idx == rightmost_idx);
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	546 if (left_sort_id > 1) {
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	547 left_sort_id = 1;
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	548 no_left_str = TRUE;
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	549 } else {
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	550 i_assert(right_sort_id != (uint32_t)-1);
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	551 right_sort_id = (uint32_t)-1;
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	552 no_right_str = TRUE;
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	553 }
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	554 }
c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	555 diff = right_sort_id - left_sort_id;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	556 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	557
7609 c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	558 if (nodes[left_idx].sort_id != 0 && !no_left_str) {
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	559 left_str = index_sort_get_string(ctx, left_idx,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	560 nodes[left_idx].seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	561 if (left_str == &expunged_msg) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	562 /* not equivalent with any message */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	563 left_str = NULL;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	564 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	565 left_idx++;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	566 }
7609 c008dde3c973 sort index: Fixed infinite looping. Timo Sirainen <tss@iki.fi> parents: 7569 diff changeset	567 if (nodes[right_idx].sort_id != 0 && !no_right_str) {
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	568 right_str = index_sort_get_string(ctx, right_idx,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	569 nodes[right_idx].seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	570 if (right_str == &expunged_msg) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	571 /* not equivalent with any message */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	572 right_str = NULL;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	573 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	574 right_idx--;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	575 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	576 i_assert(left_idx <= right_idx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	577
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	578 /* give (new) sort IDs to all nodes in left_idx..right_idx range.
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	579 divide the available space so that each message gets an equal sized
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	580 share. some messages' sort strings may be equivalent, so give them
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	581 the same sort IDs. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	582 for (i = left_idx; i <= right_idx; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	583 str = index_sort_get_string(ctx, i, nodes[i].seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	584 if (str == &expunged_msg) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	585 /* it doesn't really matter what we give to this
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	586 message, since it's only temporary and we don't
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	587 know its correct position anyway. so let's assume
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	588 it's equivalent to previous message. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	589 nodes[i].sort_id = left_sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	590 continue;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	591 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	592
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	593 ret = left_str == NULL ? 1 : strcmp(str, left_str);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	594 if (ret <= 0) {
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	595 if (ret < 0) {
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	596 /* broken sort_ids */
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	597 return -1;
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	598 }
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	599 nodes[i].sort_id = left_sort_id;
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	600 } else if (right_str != NULL && strcmp(str, right_str) == 0) {
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	601 /* the rest of the sort IDs should be the same */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	602 nodes[i].sort_id = right_sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	603 left_sort_id = right_sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	604 } else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	605 /* divide the available space equally. leave the same
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	606 sized space also between the first and the last
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	607 messages */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	608 skip = (right_sort_id - left_sort_id) /
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	609 (right_idx - i + 2);
8193 b3fb8215a339 Sort indexes: Don't assert-crash with broken sort IDs. Timo Sirainen <tss@iki.fi> parents: 8070 diff changeset	610 if (skip == 0) {
b3fb8215a339 Sort indexes: Don't assert-crash with broken sort IDs. Timo Sirainen <tss@iki.fi> parents: 8070 diff changeset	611 /* broken sort IDs (we previously assigned
b3fb8215a339 Sort indexes: Don't assert-crash with broken sort IDs. Timo Sirainen <tss@iki.fi> parents: 8070 diff changeset	612 left_sort_id=right_sort_id) */
b3fb8215a339 Sort indexes: Don't assert-crash with broken sort IDs. Timo Sirainen <tss@iki.fi> parents: 8070 diff changeset	613 return -1;
b3fb8215a339 Sort indexes: Don't assert-crash with broken sort IDs. Timo Sirainen <tss@iki.fi> parents: 8070 diff changeset	614 }
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	615 left_sort_id += skip;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	616 i_assert(left_sort_id < right_sort_id);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	617
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	618 nodes[i].sort_id = left_sort_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	619 left_str = str;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	620 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	621 nodes[i].sort_id_changed = TRUE;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	622 }
7954 d75fdd0fb8b2 Sort index sometimes failed wrongly with "Sort IDs broken" errors. Timo Sirainen <tss@iki.fi> parents: 7859 diff changeset	623 return right_str == NULL \|\| strcmp(str, right_str) < 0 \|\|
d75fdd0fb8b2 Sort index sometimes failed wrongly with "Sort IDs broken" errors. Timo Sirainen <tss@iki.fi> parents: 7859 diff changeset	624 (strcmp(str, right_str) == 0 &&
d75fdd0fb8b2 Sort index sometimes failed wrongly with "Sort IDs broken" errors. Timo Sirainen <tss@iki.fi> parents: 7859 diff changeset	625 nodes[i-1].sort_id == right_sort_id) ? 0 : -1;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	626 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	627
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	628 static int
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	629 index_sort_add_sort_ids(struct sort_string_context *ctx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	630 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	631 const struct mail_sort_node *nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	632 unsigned int i, left_idx, right_idx, count;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	633
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	634 nodes = array_get(&ctx->sorted_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	635 for (i = 0; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	636 if (nodes[i].sort_id != 0)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	637 continue;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	638
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	639 /* get the range for all sort_id=0 nodes. include the nodes
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	640 left and right of the range as well */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	641 for (right_idx = i + 1; right_idx < count; right_idx++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	642 if (nodes[right_idx].sort_id != 0)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	643 break;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	644 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	645 if (right_idx == count)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	646 right_idx--;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	647 left_idx = i == 0 ? 0 : i - 1;
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	648 if (index_sort_add_ids_range(ctx, left_idx, right_idx) < 0)
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	649 return -1;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	650 }
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	651 return 0;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	652 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	653
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	654 static void index_sort_write_changed_sort_ids(struct sort_string_context *ctx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	655 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	656 struct index_transaction_context *t =
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	657 (struct index_transaction_context *)ctx->program->t;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	658 uint32_t ext_id = ctx->ext_id;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	659 const struct mail_sort_node *nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	660 unsigned int i, count;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	661
7567 9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	662 if (ctx->no_writing) {
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	663 /* our reset_id is already stale - don't even bother
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	664 trying to write */
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	665 return;
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	666 }
9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	667
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	668 mail_index_ext_reset_inc(t->trans, ext_id, ctx->highest_reset_id, FALSE);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	669
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	670 /* add the missing sort IDs to index */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	671 nodes = array_get_modifiable(&ctx->sorted_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	672 for (i = 0; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	673 i_assert(nodes[i].sort_id != 0);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	674 if (!nodes[i].sort_id_changed \|\| nodes[i].no_update)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	675 continue;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	676
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	677 mail_index_update_ext(t->trans, nodes[i].seq, ext_id,
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	678 &nodes[i].sort_id, NULL);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	679 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	680 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	681
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	682 static int sort_node_cmp(const void p1, const void p2)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	683 {
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	684 struct sort_string_context *ctx = static_zero_cmp_context;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	685 const struct mail_sort_node n1 = p1, n2 = p2;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	686
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	687 if (n1->sort_id < n2->sort_id)
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	688 return !ctx->reverse ? -1 : 1;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	689 if (n1->sort_id > n2->sort_id)
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	690 return !ctx->reverse ? 1 : -1;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	691
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	692 return index_sort_node_cmp_type(ctx->program->temp_mail,
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	693 ctx->program->sort_program + 1,
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	694 n1->seq, n2->seq);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	695 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	696
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	697 static void index_sort_add_missing(struct sort_string_context *ctx)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	698 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	699 struct mail_sort_node node;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	700 const uint32_t *seqs;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	701 unsigned int i, count;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	702 uint32_t seq, next_seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	703
7567 9c0d2413735d Sort index: Handle reset_id growing while adding non-wanted messages to sort Timo Sirainen <tss@iki.fi> parents: 7566 diff changeset	704 ctx->have_all_wanted = TRUE;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	705
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	706 seqs = array_get(&ctx->program->seqs, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	707 for (i = 0, next_seq = 1; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	708 if (seqs[i] == next_seq)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	709 next_seq++;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	710 else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	711 i_assert(next_seq < seqs[i]);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	712 for (seq = next_seq; seq < seqs[i]; seq++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	713 memset(&node, 0, sizeof(node));
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	714 node.seq = seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	715 index_sort_node_add(ctx, &node);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	716 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	717 next_seq = seqs[i] + 1;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	718 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	719 }
7569 ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	720
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	721 if (ctx->lowest_nonexpunged_zero == 0) {
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	722 /* we're handling only expunged zeros. if it causes us to
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	723 renumber some existing sort IDs, don't save them. */
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	724 ctx->no_writing = TRUE;
ea913434d522 Sort index optimization: Don't write changes to sort IDs if we're doing it Timo Sirainen <tss@iki.fi> parents: 7568 diff changeset	725 }
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	726 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	727
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	728 static void index_sort_list_reset_broken(struct sort_string_context *ctx)
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	729 {
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	730 struct mailbox *box = ctx->program->t->box;
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	731 struct mail_sort_node *nodes;
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	732 unsigned int i, count;
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	733
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	734 mail_storage_set_critical(box->storage,
7955 83019368c9dc s/reseting/resetting/ Timo Sirainen <tss@iki.fi> parents: 7954 diff changeset	735 "Sort IDs %u broken in mailbox %s, resetting",
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	736 ctx->ext_id, box->name);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	737
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	738 array_clear(&ctx->zero_nodes);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	739 array_append_array(&ctx->zero_nodes,
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	740 &ctx->nonzero_nodes);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	741 array_clear(&ctx->nonzero_nodes);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	742
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	743 nodes = array_get_modifiable(&ctx->zero_nodes, &count);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	744 for (i = 0; i < count; i++)
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	745 nodes[i].sort_id = 0;
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	746 }
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	747
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	748 void index_sort_list_finish_string(struct mail_search_sort_program *program)
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	749 {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	750 struct sort_string_context *ctx = program->context;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	751 struct mail_sort_node *nodes;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	752 unsigned int i, count;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	753 uint32_t seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	754
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	755 nodes = array_get_modifiable(&ctx->nonzero_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	756
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	757 static_zero_cmp_context = ctx;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	758 if (array_count(&ctx->zero_nodes) == 0) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	759 /* fast path: we have all sort IDs */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	760 qsort(nodes, count, sizeof(struct mail_sort_node),
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	761 sort_node_cmp);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	762
7956 439636cce455 Memory leak fixes. Timo Sirainen <tss@iki.fi> parents: 7955 diff changeset	763 if (!array_is_created(&program->seqs))
439636cce455 Memory leak fixes. Timo Sirainen <tss@iki.fi> parents: 7955 diff changeset	764 i_array_init(&program->seqs, count);
439636cce455 Memory leak fixes. Timo Sirainen <tss@iki.fi> parents: 7955 diff changeset	765 else
439636cce455 Memory leak fixes. Timo Sirainen <tss@iki.fi> parents: 7955 diff changeset	766 array_clear(&program->seqs);
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	767 for (i = 0; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	768 seq = nodes[i].seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	769 array_append(&program->seqs, &seq, 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	770 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	771 array_free(&ctx->nonzero_nodes);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	772 } else {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	773 /* we have to add some sort IDs. we'll do this for all
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	774 messages, so first remember what messages we wanted
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	775 to know about. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	776 index_sort_generate_seqs(ctx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	777 /* add messages not in seqs list */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	778 index_sort_add_missing(ctx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	779 /* sort all messages with sort IDs */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	780 nodes = array_get_modifiable(&ctx->nonzero_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	781 qsort(nodes, count, sizeof(struct mail_sort_node),
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	782 sort_node_cmp);
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	783 for (;;) {
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	784 /* sort all messages without sort IDs */
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	785 index_sort_zeroes(ctx);
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	786
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	787 if (ctx->reverse) {
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	788 /* sort lists are descending currently, but
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	789 merging and sort ID assigning works only
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	790 with ascending lists. reverse the lists
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	791 temporarily. we can't do this while earlier
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	792 because secondary sort conditions must not
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	793 be reversed in results (but while assigning
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	794 sort IDs it doesn't matter). */
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	795 array_reverse(&ctx->nonzero_nodes);
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	796 array_reverse(&ctx->zero_nodes);
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	797 }
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	798
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	799 /* merge zero and non-zero arrays into sorted_nodes */
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	800 index_sort_merge(ctx);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	801 /* give sort IDs to messages missing them */
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	802 if (index_sort_add_sort_ids(ctx) == 0)
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	803 break;
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	804
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	805 /* broken, try again with sort IDs reset */
7614 dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	806 index_sort_list_reset_broken(ctx);
dd899a1841d9 sort index: Try to catch broken sort_ids and recreate them correctly instead Timo Sirainen <tss@iki.fi> parents: 7613 diff changeset	807 }
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	808 index_sort_write_changed_sort_ids(ctx);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	809
7859 f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	810 if (ctx->reverse) {
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	811 /* restore the correct sort order */
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	812 array_reverse(&ctx->sorted_nodes);
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	813 }
f431c67621ed Reversing the primary sort criterion reversed also reversed secondary Timo Sirainen <tss@iki.fi> parents: 7614 diff changeset	814
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	815 nodes = array_get_modifiable(&ctx->sorted_nodes, &count);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	816 array_clear(&program->seqs);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	817 for (i = 0; i < count; i++) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	818 if (nodes[i].wanted) {
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	819 seq = nodes[i].seq;
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	820 array_append(&program->seqs, &seq, 1);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	821 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	822 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	823 pool_unref(&ctx->sort_string_pool);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	824 i_free(ctx->sort_strings);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	825 array_free(&ctx->sorted_nodes);
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	826 /* NOTE: we already freed nonzero_nodes and made it point to
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	827 sorted_nodes. */
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	828 }
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	829
4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	830 array_free(&ctx->zero_nodes);
7956 439636cce455 Memory leak fixes. Timo Sirainen <tss@iki.fi> parents: 7955 diff changeset	831 i_free(ctx);
439636cce455 Memory leak fixes. Timo Sirainen <tss@iki.fi> parents: 7955 diff changeset	832 program->context = NULL;
7564 4a9ce9df52c5 Message sort index handling rewrite to fix several race conditions when Timo Sirainen <tss@iki.fi> parents: diff changeset	833 }

Mercurial > dovecot > original-hg > dovecot-1.2

annotate src/lib-storage/index/index-sort-string.c @ 8193:b3fb8215a339 HEAD