changeset 5071:836a7d11f8df HEAD

If exec() fails, don't close 0..3 fds before logging the error. There's really no point, and it closes the logging fd so the exec() error can't be logged.
author Timo Sirainen <tss@iki.fi>
date Wed, 24 Jan 2007 19:39:11 +0200
parents 3cc5ec8549c0
children 030a7f7b708c
files src/master/mail-process.c
diffstat 1 files changed, 1 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/src/master/mail-process.c	Wed Jan 24 19:14:16 2007 +0200
+++ b/src/master/mail-process.c	Wed Jan 24 19:39:11 2007 +0200
@@ -408,7 +408,7 @@
 	gid_t gid;
 	ARRAY_DEFINE(extra_args, const char *);
 	unsigned int i, count;
-	int err, ret, log_fd, nice;
+	int ret, log_fd, nice;
 	bool home_given, nfs_check;
 
 	// FIXME: per-group
@@ -655,12 +655,6 @@
 		restrict_access_by_env(TRUE);
 
 	client_process_exec(set->mail_executable, title);
-	err = errno;
-
-	for (i = 0; i < 3; i++)
-		(void)close(i);
-
-	errno = err;
 	i_fatal_status(FATAL_EXEC, "execv(%s) failed: %m",
 		       set->mail_executable);