Mercurial > dovecot > original-hg > dovecot-1.2

changeset 699:cc795d74d08f HEAD

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
Use more warnings with GCC by default. Fixed several warnings.
author Timo Sirainen <tss@iki.fi>
date Tue, 26 Nov 2002 22:04:08 +0200
parents bbc5f74c464f
children 1d20a088aead
files configure.in src/auth/main.c src/auth/master.c src/imap/cmd-examine.c src/imap/cmd-list.c src/imap/cmd-lsub.c src/imap/cmd-select.c src/imap/cmd-subscribe.c src/imap/cmd-unsubscribe.c src/imap/commands.h src/lib/mempool-alloconly.c src/lib/mempool.c src/lib/mempool.h src/master/auth-process.c src/master/login-process.c
diffstat 15 files changed, 26 insertions(+), 28 deletions(-) [+]
line wrap: on
line diff
--- a/configure.in	Tue Nov 26 21:49:16 2002 +0200
+++ b/configure.in	Tue Nov 26 22:04:08 2002 +0200
@@ -129,8 +129,8 @@
 
 dnl * gcc specific options
 if test "x$ac_cv_prog_gcc" = "xyes"; then
-	# -Wchar-subscripts -Wpointer-arith -Wcast-qual -Wcast-align -Wconversion -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations
-	CFLAGS="$CFLAGS -Wall -W"
+	# -Wcast-qual -Wconversion -Wstrict-prototypes
+	CFLAGS="$CFLAGS -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wcast-align -Wpointer-arith -Wchar-subscripts"
 fi
 
 dnl **
--- a/src/auth/main.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/auth/main.c	Tue Nov 26 22:04:08 2002 +0200
@@ -10,13 +10,11 @@
 #include "cookie.h"
 #include "login-connection.h"
 #include "userinfo.h"
+#include "master.h"
 
 #include <stdlib.h>
 #include <syslog.h>
 
-void master_init(void);
-void master_deinit(void);
-
 IOLoop ioloop;
 static IO io_listen;
 
--- a/src/auth/master.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/auth/master.c	Tue Nov 26 22:04:08 2002 +0200
@@ -5,6 +5,7 @@
 #include "obuffer.h"
 #include "network.h"
 #include "cookie.h"
+#include "master.h"
 
 #define MAX_OUTBUF_SIZE (10 * sizeof(AuthCookieReplyData))
 
--- a/src/imap/cmd-examine.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/imap/cmd-examine.c	Tue Nov 26 22:04:08 2002 +0200
@@ -3,9 +3,7 @@
 #include "common.h"
 #include "commands.h"
 
-int cmd_select_full(Client *client, int readonly);
-
 int cmd_examine(Client *client)
 {
-	return cmd_select_full(client, TRUE);
+	return _cmd_select_full(client, TRUE);
 }
--- a/src/imap/cmd-list.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/imap/cmd-list.c	Tue Nov 26 22:04:08 2002 +0200
@@ -121,7 +121,7 @@
 	}
 }
 
-int cmd_list_full(Client *client, int subscribed)
+int _cmd_list_full(Client *client, int subscribed)
 {
 	ListContext ctx;
 	const char *ref, *pattern;
@@ -183,5 +183,5 @@
 
 int cmd_list(Client *client)
 {
-	return cmd_list_full(client, FALSE);
+	return _cmd_list_full(client, FALSE);
 }
--- a/src/imap/cmd-lsub.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/imap/cmd-lsub.c	Tue Nov 26 22:04:08 2002 +0200
@@ -3,9 +3,7 @@
 #include "common.h"
 #include "commands.h"
 
-int cmd_list_full(Client *client, int subscribed);
-
 int cmd_lsub(Client *client)
 {
-	return cmd_list_full(client, TRUE);
+	return _cmd_list_full(client, TRUE);
 }
--- a/src/imap/cmd-select.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/imap/cmd-select.c	Tue Nov 26 22:04:08 2002 +0200
@@ -4,7 +4,7 @@
 #include "temp-string.h"
 #include "commands.h"
 
-int cmd_select_full(Client *client, int readonly)
+int _cmd_select_full(Client *client, int readonly)
 {
 	Mailbox *box;
 	MailboxStatus status;
@@ -70,5 +70,5 @@
 
 int cmd_select(Client *client)
 {
-	return cmd_select_full(client, FALSE);
+	return _cmd_select_full(client, FALSE);
 }
--- a/src/imap/cmd-subscribe.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/imap/cmd-subscribe.c	Tue Nov 26 22:04:08 2002 +0200
@@ -3,7 +3,7 @@
 #include "common.h"
 #include "commands.h"
 
-int cmd_subscribe_full(Client *client, int subscribe)
+int _cmd_subscribe_full(Client *client, int subscribe)
 {
 	const char *mailbox;
 
@@ -28,5 +28,5 @@
 
 int cmd_subscribe(Client *client)
 {
-	return cmd_subscribe_full(client, TRUE);
+	return _cmd_subscribe_full(client, TRUE);
 }
--- a/src/imap/cmd-unsubscribe.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/imap/cmd-unsubscribe.c	Tue Nov 26 22:04:08 2002 +0200
@@ -3,9 +3,7 @@
 #include "common.h"
 #include "commands.h"
 
-int cmd_subscribe_full(Client *client, int subscribe);
-
 int cmd_unsubscribe(Client *client)
 {
-	return cmd_subscribe_full(client, FALSE);
+	return _cmd_subscribe_full(client, FALSE);
 }
--- a/src/imap/commands.h	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/imap/commands.h	Tue Nov 26 22:04:08 2002 +0200
@@ -41,4 +41,9 @@
 int cmd_copy(Client *client);
 int cmd_uid(Client *client);
 
+/* private: */
+int _cmd_list_full(Client *client, int subscribed);
+int _cmd_select_full(Client *client, int readonly);
+int _cmd_subscribe_full(Client *client, int subscribe);
+
 #endif
--- a/src/lib/mempool-alloconly.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/lib/mempool-alloconly.c	Tue Nov 26 22:04:08 2002 +0200
@@ -89,7 +89,7 @@
 	pool_alloconly_clear
 };
 
-Pool pool_alloconly_create(const char *name, size_t size)
+Pool _pool_alloconly_create(const char *name, size_t size)
 {
 	AlloconlyPool *apool;
 	int len;
--- a/src/lib/mempool.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/lib/mempool.c	Tue Nov 26 22:04:08 2002 +0200
@@ -26,12 +26,10 @@
 #include "lib.h"
 #include "mempool.h"
 
-Pool pool_alloconly_create(const char *name, size_t size);
-
 Pool pool_create(const char *name, size_t size, int allocfree)
 {
 	if (allocfree)
 		return system_pool;
 
-	return pool_alloconly_create(name, size);
+	return _pool_alloconly_create(name, size);
 }
--- a/src/lib/mempool.h	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/lib/mempool.h	Tue Nov 26 22:04:08 2002 +0200
@@ -66,4 +66,6 @@
 #  define p_free_clean(pool, mem)
 #endif
 
+Pool _pool_alloconly_create(const char *name, size_t size);
+
 #endif
--- a/src/master/auth-process.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/master/auth-process.c	Tue Nov 26 22:04:08 2002 +0200
@@ -166,7 +166,7 @@
 
 static pid_t create_auth_process(AuthConfig *config)
 {
-	static const char *argv[] = { NULL, NULL };
+	static char *argv[] = { NULL, NULL };
 	const char *path;
 	struct passwd *pwd;
 	pid_t pid;
--- a/src/master/login-process.c	Tue Nov 26 21:49:16 2002 +0200
+++ b/src/master/login-process.c	Tue Nov 26 22:04:08 2002 +0200
@@ -87,7 +87,7 @@
 	i_free(request);
 }
 
-void login_process_mark_nonlistening(LoginProcess *p)
+static void login_process_mark_nonlistening(LoginProcess *p)
 {
 	if (!p->listening) {
 		i_error("login: received another \"not listening\" "
@@ -189,7 +189,7 @@
 	return p;
 }
 
-void login_process_remove_from_lists(LoginProcess *p)
+static void login_process_remove_from_lists(LoginProcess *p)
 {
 	if (p == oldest_nonlisten_process)
 		oldest_nonlisten_process = p->next_nonlisten;
@@ -236,7 +236,7 @@
 
 static pid_t create_login_process(void)
 {
-	static const char *argv[] = { NULL, NULL };
+	static char *argv[] = { NULL, NULL };
 	pid_t pid;
 	int fd[2];