illumos/illumos-gate: usr/src/uts/common/fs/zfs/dsl

annotate usr/src/uts/common/fs/zfs/dsl_dataset.c @ 13055:8c712bbb18ea

PSARC 2010/105 zfs diff 6425091 want 'zfs diff' to list files that have changed between snapshots

author	Tim Haley <Tim.Haley@Sun.COM>
date	Sat, 07 Aug 2010 19:27:15 -0600
parents	5d7f2db1e620
children	7dd5626b8b49

rev	line source
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2 * CDDL HEADER START
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	3 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	4 * The contents of this file are subject to the terms of the
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	5 * Common Development and Distribution License (the "License").
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	6 * You may not use this file except in compliance with the License.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	7 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	8 * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	9 * or http://www.opensolaris.org/os/licensing.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	10 * See the License for the specific language governing permissions
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	11 * and limitations under the License.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	12 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	13 * When distributing Covered Code, include this CDDL HEADER in each
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	14 * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	15 * If applicable, add the following below this CDDL HEADER, with the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	16 * fields enclosed by brackets "[]" replaced with your own identifying
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	17 * information: Portions Copyright [yyyy] [name of copyright owner]
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	18 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	19 * CDDL HEADER END
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	20 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	21 /*
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	22 * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	23 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	24
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	25 #include <sys/dmu_objset.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	26 #include <sys/dsl_dataset.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	27 #include <sys/dsl_dir.h>
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	28 #include <sys/dsl_prop.h>
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	29 #include <sys/dsl_synctask.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	30 #include <sys/dmu_traverse.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	31 #include <sys/dmu_tx.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	32 #include <sys/arc.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	33 #include <sys/zio.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	34 #include <sys/zap.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	35 #include <sys/unique.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	36 #include <sys/zfs_context.h>
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	37 #include <sys/zfs_ioctl.h>
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	38 #include <sys/spa.h>
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	39 #include <sys/zfs_znode.h>
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	40 #include <sys/zfs_onexit.h>
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	41 #include <sys/zvol.h>
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	42 #include <sys/dsl_scan.h>
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	43 #include <sys/dsl_deadlist.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	44
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	45 static char *dsl_reaper = "the grim reaper";
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	46
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	47 static dsl_checkfunc_t dsl_dataset_destroy_begin_check;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	48 static dsl_syncfunc_t dsl_dataset_destroy_begin_sync;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	49 static dsl_syncfunc_t dsl_dataset_set_reservation_sync;
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	50
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	51 #define SWITCH64(x, y) \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	52 { \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	53 uint64_t __tmp = (x); \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	54 (x) = (y); \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	55 (y) = __tmp; \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	56 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	57
3444 dc160a70a50d 6410433 'zpool status -v' would be more useful with filenames ek110237 parents: 3025 diff changeset	58 #define DS_REF_MAX (1ULL << 62)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	59
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	60 #define DSL_DEADLIST_BLOCKSIZE SPA_MAXBLOCKSIZE
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	61
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	62 #define DSL_DATASET_IS_DESTROYED(ds) ((ds)->ds_owner == dsl_reaper)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	63
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	64
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	65 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	66 * Figure out how much of this delta should be propogated to the dsl_dir
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	67 * layer. If there's a refreservation, that space has already been
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	68 * partially accounted for in our ancestors.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	69 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	70 static int64_t
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	71 parent_delta(dsl_dataset_t *ds, int64_t delta)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	72 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	73 uint64_t old_bytes, new_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	74
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	75 if (ds->ds_reserved == 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	76 return (delta);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	77
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	78 old_bytes = MAX(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	79 new_bytes = MAX(ds->ds_phys->ds_unique_bytes + delta, ds->ds_reserved);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	80
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	81 ASSERT3U(ABS((int64_t)(new_bytes - old_bytes)), <=, ABS(delta));
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	82 return (new_bytes - old_bytes);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	83 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	84
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	85 void
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	86 dsl_dataset_block_born(dsl_dataset_t ds, const blkptr_t bp, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	87 {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	88 int used = bp_get_dsize_sync(tx->tx_pool->dp_spa, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	89 int compressed = BP_GET_PSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	90 int uncompressed = BP_GET_UCSIZE(bp);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	91 int64_t delta;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	92
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	93 dprintf_bp(bp, "ds=%p", ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	94
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	95 ASSERT(dmu_tx_is_syncing(tx));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	96 /* It could have been compressed away to nothing */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	97 if (BP_IS_HOLE(bp))
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	98 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	99 ASSERT(BP_GET_TYPE(bp) != DMU_OT_NONE);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	100 ASSERT3U(BP_GET_TYPE(bp), <, DMU_OT_NUMTYPES);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	101 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	102 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	103 * Account for the meta-objset space in its placeholder
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	104 * dsl_dir.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	105 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	106 ASSERT3U(compressed, ==, uncompressed); /* it's all metadata */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	107 dsl_dir_diduse_space(tx->tx_pool->dp_mos_dir, DD_USED_HEAD,
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	108 used, compressed, uncompressed, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	109 dsl_dir_dirty(tx->tx_pool->dp_mos_dir, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	110 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	111 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	112 dmu_buf_will_dirty(ds->ds_dbuf, tx);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	113
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	114 mutex_enter(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	115 mutex_enter(&ds->ds_lock);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	116 delta = parent_delta(ds, used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	117 ds->ds_phys->ds_used_bytes += used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	118 ds->ds_phys->ds_compressed_bytes += compressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	119 ds->ds_phys->ds_uncompressed_bytes += uncompressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	120 ds->ds_phys->ds_unique_bytes += used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	121 mutex_exit(&ds->ds_lock);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	122 dsl_dir_diduse_space(ds->ds_dir, DD_USED_HEAD, delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	123 compressed, uncompressed, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	124 dsl_dir_transfer_space(ds->ds_dir, used - delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	125 DD_USED_REFRSRV, DD_USED_HEAD, tx);
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	126 mutex_exit(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	127 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	128
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	129 int
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	130 dsl_dataset_block_kill(dsl_dataset_t ds, const blkptr_t bp, dmu_tx_t *tx,
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	131 boolean_t async)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	132 {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	133 if (BP_IS_HOLE(bp))
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	134 return (0);
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	135
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	136 ASSERT(dmu_tx_is_syncing(tx));
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	137 ASSERT(bp->blk_birth <= tx->tx_txg);
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	138
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	139 int used = bp_get_dsize_sync(tx->tx_pool->dp_spa, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	140 int compressed = BP_GET_PSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	141 int uncompressed = BP_GET_UCSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	142
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	143 ASSERT(used > 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	144 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	145 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	146 * Account for the meta-objset space in its placeholder
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	147 * dataset.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	148 */
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	149 dsl_free(tx->tx_pool, tx->tx_txg, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	150
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	151 dsl_dir_diduse_space(tx->tx_pool->dp_mos_dir, DD_USED_HEAD,
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	152 -used, -compressed, -uncompressed, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	153 dsl_dir_dirty(tx->tx_pool->dp_mos_dir, tx);
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	154 return (used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	155 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	156 ASSERT3P(tx->tx_pool, ==, ds->ds_dir->dd_pool);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	157
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	158 ASSERT(!dsl_dataset_is_snapshot(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	159 dmu_buf_will_dirty(ds->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	160
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	161 if (bp->blk_birth > ds->ds_phys->ds_prev_snap_txg) {
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	162 int64_t delta;
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	163
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	164 dprintf_bp(bp, "freeing ds=%llu", ds->ds_object);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	165 dsl_free(tx->tx_pool, tx->tx_txg, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	166
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	167 mutex_enter(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	168 mutex_enter(&ds->ds_lock);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	169 ASSERT(ds->ds_phys->ds_unique_bytes >= used \|\|
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	170 !DS_UNIQUE_IS_ACCURATE(ds));
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	171 delta = parent_delta(ds, -used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	172 ds->ds_phys->ds_unique_bytes -= used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	173 mutex_exit(&ds->ds_lock);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	174 dsl_dir_diduse_space(ds->ds_dir, DD_USED_HEAD,
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	175 delta, -compressed, -uncompressed, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	176 dsl_dir_transfer_space(ds->ds_dir, -used - delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	177 DD_USED_REFRSRV, DD_USED_HEAD, tx);
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	178 mutex_exit(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	179 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	180 dprintf_bp(bp, "putting on dead list: %s", "");
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	181 if (async) {
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	182 /*
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	183 * We are here as part of zio's write done callback,
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	184 * which means we're a zio interrupt thread. We can't
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	185 * call dsl_deadlist_insert() now because it may block
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	186 * waiting for I/O. Instead, put bp on the deferred
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	187 * queue and let dsl_pool_sync() finish the job.
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	188 */
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	189 bplist_append(&ds->ds_pending_deadlist, bp);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	190 } else {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	191 dsl_deadlist_insert(&ds->ds_deadlist, bp, tx);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	192 }
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	193 ASSERT3U(ds->ds_prev->ds_object, ==,
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	194 ds->ds_phys->ds_prev_snap_obj);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	195 ASSERT(ds->ds_prev->ds_phys->ds_num_children > 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	196 /* if (bp->blk_birth > prev prev snap txg) prev unique += bs */
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	197 if (ds->ds_prev->ds_phys->ds_next_snap_obj ==
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	198 ds->ds_object && bp->blk_birth >
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	199 ds->ds_prev->ds_phys->ds_prev_snap_txg) {
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	200 dmu_buf_will_dirty(ds->ds_prev->ds_dbuf, tx);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	201 mutex_enter(&ds->ds_prev->ds_lock);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	202 ds->ds_prev->ds_phys->ds_unique_bytes += used;
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	203 mutex_exit(&ds->ds_prev->ds_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	204 }
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	205 if (bp->blk_birth > ds->ds_dir->dd_origin_txg) {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	206 dsl_dir_transfer_space(ds->ds_dir, used,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	207 DD_USED_HEAD, DD_USED_SNAP, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	208 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	209 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	210 mutex_enter(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	211 ASSERT3U(ds->ds_phys->ds_used_bytes, >=, used);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	212 ds->ds_phys->ds_used_bytes -= used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	213 ASSERT3U(ds->ds_phys->ds_compressed_bytes, >=, compressed);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	214 ds->ds_phys->ds_compressed_bytes -= compressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	215 ASSERT3U(ds->ds_phys->ds_uncompressed_bytes, >=, uncompressed);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	216 ds->ds_phys->ds_uncompressed_bytes -= uncompressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	217 mutex_exit(&ds->ds_lock);
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	218
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	219 return (used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	220 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	221
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	222 uint64_t
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	223 dsl_dataset_prev_snap_txg(dsl_dataset_t *ds)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	224 {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	225 uint64_t trysnap = 0;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	226
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	227 if (ds == NULL)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	228 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	229 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	230 * The snapshot creation could fail, but that would cause an
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	231 * incorrect FALSE return, which would only result in an
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	232 * overestimation of the amount of space that an operation would
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	233 * consume, which is OK.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	234 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	235 * There's also a small window where we could miss a pending
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	236 * snapshot, because we could set the sync task in the quiescing
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	237 * phase. So this should only be used as a guess.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	238 */
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	239 if (ds->ds_trysnap_txg >
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	240 spa_last_synced_txg(ds->ds_dir->dd_pool->dp_spa))
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	241 trysnap = ds->ds_trysnap_txg;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	242 return (MAX(ds->ds_phys->ds_prev_snap_txg, trysnap));
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	243 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	244
9653 a70048a304d1 6664765 Unable to remove files when using fat-zap and quota exceeded on ZFS filesystem Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 9396 diff changeset	245 boolean_t
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	246 dsl_dataset_block_freeable(dsl_dataset_t ds, const blkptr_t bp,
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	247 uint64_t blk_birth)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	248 {
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	249 if (blk_birth <= dsl_dataset_prev_snap_txg(ds))
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	250 return (B_FALSE);
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	251
12587 16aef3d16470 6957090 ddt_zap_prefetch() induces deadlock, panic George Wilson <George.Wilson@Sun.COM> parents: 12527 diff changeset	252 ddt_prefetch(dsl_dataset_get_spa(ds), bp);
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	253
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	254 return (B_TRUE);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	255 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	256
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	257 /* ARGSUSED */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	258 static void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	259 dsl_dataset_evict(dmu_buf_t db, void dsv)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	260 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	261 dsl_dataset_t *ds = dsv;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	262
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	263 ASSERT(ds->ds_owner == NULL \|\| DSL_DATASET_IS_DESTROYED(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	264
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	265 unique_remove(ds->ds_fsid_guid);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	266
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	267 if (ds->ds_objset != NULL)
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	268 dmu_objset_evict(ds->ds_objset);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	269
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	270 if (ds->ds_prev) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	271 dsl_dataset_drop_ref(ds->ds_prev, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	272 ds->ds_prev = NULL;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	273 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	274
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	275 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	276 if (db != NULL) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	277 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	278 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	279 ASSERT(ds->ds_deadlist.dl_dbuf == NULL);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	280 ASSERT(!ds->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	281 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	282 if (ds->ds_dir)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	283 dsl_dir_close(ds->ds_dir, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	284
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	285 ASSERT(!list_link_active(&ds->ds_synced_link));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	286
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	287 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	288 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	289 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	290 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	291 cv_destroy(&ds->ds_exclusive_cv);
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	292
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	293 kmem_free(ds, sizeof (dsl_dataset_t));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	294 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	295
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	296 static int
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	297 dsl_dataset_get_snapname(dsl_dataset_t *ds)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	298 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	299 dsl_dataset_phys_t *headphys;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	300 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	301 dmu_buf_t *headdbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	302 dsl_pool_t *dp = ds->ds_dir->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	303 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	304
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	305 if (ds->ds_snapname[0])
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	306 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	307 if (ds->ds_phys->ds_next_snap_obj == 0)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	308 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	309
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	310 err = dmu_bonus_hold(mos, ds->ds_dir->dd_phys->dd_head_dataset_obj,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	311 FTAG, &headdbuf);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	312 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	313 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	314 headphys = headdbuf->db_data;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	315 err = zap_value_search(dp->dp_meta_objset,
4577 ed36b0e652bc PSARC/2007/328 zfs upgrade ahrens parents: 4569 diff changeset	316 headphys->ds_snapnames_zapobj, ds->ds_object, 0, ds->ds_snapname);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	317 dmu_buf_rele(headdbuf, FTAG);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	318 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	319 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	320
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	321 static int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	322 dsl_dataset_snap_lookup(dsl_dataset_t ds, const char name, uint64_t *value)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	323 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	324 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	325 uint64_t snapobj = ds->ds_phys->ds_snapnames_zapobj;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	326 matchtype_t mt;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	327 int err;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	328
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	329 if (ds->ds_phys->ds_flags & DS_FLAG_CI_DATASET)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	330 mt = MT_FIRST;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	331 else
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	332 mt = MT_EXACT;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	333
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	334 err = zap_lookup_norm(mos, snapobj, name, 8, 1,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	335 value, mt, NULL, 0, NULL);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	336 if (err == ENOTSUP && mt == MT_FIRST)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	337 err = zap_lookup(mos, snapobj, name, 8, 1, value);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	338 return (err);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	339 }
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	340
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	341 static int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	342 dsl_dataset_snap_remove(dsl_dataset_t ds, char name, dmu_tx_t *tx)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	343 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	344 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	345 uint64_t snapobj = ds->ds_phys->ds_snapnames_zapobj;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	346 matchtype_t mt;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	347 int err;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	348
10373 bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	349 dsl_dir_snap_cmtime_update(ds->ds_dir);
bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	350
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	351 if (ds->ds_phys->ds_flags & DS_FLAG_CI_DATASET)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	352 mt = MT_FIRST;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	353 else
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	354 mt = MT_EXACT;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	355
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	356 err = zap_remove_norm(mos, snapobj, name, mt, tx);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	357 if (err == ENOTSUP && mt == MT_FIRST)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	358 err = zap_remove(mos, snapobj, name, tx);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	359 return (err);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	360 }
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	361
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	362 static int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	363 dsl_dataset_get_ref(dsl_pool_t dp, uint64_t dsobj, void tag,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	364 dsl_dataset_t **dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	365 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	366 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	367 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	368 dsl_dataset_t *ds;
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	369 int err;
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	370 dmu_object_info_t doi;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	371
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	372 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock) \|\|
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	373 dsl_pool_sync_context(dp));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	374
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	375 err = dmu_bonus_hold(mos, dsobj, tag, &dbuf);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	376 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	377 return (err);
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	378
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	379 /* Make sure dsobj has the correct object type. */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	380 dmu_object_info_from_db(dbuf, &doi);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	381 if (doi.doi_type != DMU_OT_DSL_DATASET)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	382 return (EINVAL);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	383
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	384 ds = dmu_buf_get_user(dbuf);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	385 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	386 dsl_dataset_t *winner;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	387
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	388 ds = kmem_zalloc(sizeof (dsl_dataset_t), KM_SLEEP);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	389 ds->ds_dbuf = dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	390 ds->ds_object = dsobj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	391 ds->ds_phys = dbuf->db_data;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	392
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	393 mutex_init(&ds->ds_lock, NULL, MUTEX_DEFAULT, NULL);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	394 mutex_init(&ds->ds_recvlock, NULL, MUTEX_DEFAULT, NULL);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	395 mutex_init(&ds->ds_opening_lock, NULL, MUTEX_DEFAULT, NULL);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	396 rw_init(&ds->ds_rwlock, 0, 0, 0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	397 cv_init(&ds->ds_exclusive_cv, NULL, CV_DEFAULT, NULL);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	398
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	399 bplist_create(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	400 dsl_deadlist_open(&ds->ds_deadlist,
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	401 mos, ds->ds_phys->ds_deadlist_obj);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	402
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	403 if (err == 0) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	404 err = dsl_dir_open_obj(dp,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	405 ds->ds_phys->ds_dir_obj, NULL, ds, &ds->ds_dir);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	406 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	407 if (err) {
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	408 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	409 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	410 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	411 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	412 cv_destroy(&ds->ds_exclusive_cv);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	413 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	414 dsl_deadlist_close(&ds->ds_deadlist);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	415 kmem_free(ds, sizeof (dsl_dataset_t));
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	416 dmu_buf_rele(dbuf, tag);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	417 return (err);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	418 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	419
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	420 if (!dsl_dataset_is_snapshot(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	421 ds->ds_snapname[0] = '\0';
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	422 if (ds->ds_phys->ds_prev_snap_obj) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	423 err = dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	424 ds->ds_phys->ds_prev_snap_obj,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	425 ds, &ds->ds_prev);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	426 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	427 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	428 if (zfs_flags & ZFS_DEBUG_SNAPNAMES)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	429 err = dsl_dataset_get_snapname(ds);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	430 if (err == 0 && ds->ds_phys->ds_userrefs_obj != 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	431 err = zap_count(
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	432 ds->ds_dir->dd_pool->dp_meta_objset,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	433 ds->ds_phys->ds_userrefs_obj,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	434 &ds->ds_userrefs);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	435 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	436 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	437
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	438 if (err == 0 && !dsl_dataset_is_snapshot(ds)) {
5569 d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	439 /*
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	440 * In sync context, we're called with either no lock
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	441 * or with the write lock. If we're not syncing,
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	442 * we're always called with the read lock held.
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	443 */
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	444 boolean_t need_lock =
5569 d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	445 !RW_WRITE_HELD(&dp->dp_config_rwlock) &&
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	446 dsl_pool_sync_context(dp);
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	447
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	448 if (need_lock)
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	449 rw_enter(&dp->dp_config_rwlock, RW_READER);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	450
7265 cc18862247da PSARC/2008/483 ZFS clone -o ahrens parents: 7237 diff changeset	451 err = dsl_prop_get_ds(ds,
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	452 "refreservation", sizeof (uint64_t), 1,
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	453 &ds->ds_reserved, NULL);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	454 if (err == 0) {
7265 cc18862247da PSARC/2008/483 ZFS clone -o ahrens parents: 7237 diff changeset	455 err = dsl_prop_get_ds(ds,
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	456 "refquota", sizeof (uint64_t), 1,
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	457 &ds->ds_quota, NULL);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	458 }
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	459
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	460 if (need_lock)
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	461 rw_exit(&dp->dp_config_rwlock);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	462 } else {
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	463 ds->ds_reserved = ds->ds_quota = 0;
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	464 }
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	465
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	466 if (err == 0) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	467 winner = dmu_buf_set_user_ie(dbuf, ds, &ds->ds_phys,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	468 dsl_dataset_evict);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	469 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	470 if (err \|\| winner) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	471 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	472 dsl_deadlist_close(&ds->ds_deadlist);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	473 if (ds->ds_prev)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	474 dsl_dataset_drop_ref(ds->ds_prev, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	475 dsl_dir_close(ds->ds_dir, ds);
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	476 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	477 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	478 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	479 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	480 cv_destroy(&ds->ds_exclusive_cv);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	481 kmem_free(ds, sizeof (dsl_dataset_t));
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	482 if (err) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	483 dmu_buf_rele(dbuf, tag);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	484 return (err);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	485 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	486 ds = winner;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	487 } else {
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	488 ds->ds_fsid_guid =
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	489 unique_insert(ds->ds_phys->ds_fsid_guid);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	490 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	491 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	492 ASSERT3P(ds->ds_dbuf, ==, dbuf);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	493 ASSERT3P(ds->ds_phys, ==, dbuf->db_data);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	494 ASSERT(ds->ds_phys->ds_prev_snap_obj != 0 \|\|
7061 524fec1acf1c 6723703 zpool upgrade -> assertion failed: ds->ds_phys->ds_prev_snap_obj != 0 \|\| ... ahrens parents: 7046 diff changeset	495 spa_version(dp->dp_spa) < SPA_VERSION_ORIGIN \|\|
7077 a63bdc0b8352 6724675 assertion failed in dsl_dataset_get_ref(): ds->ds_phys->ds_prev_snap_obj != 0 ... ahrens parents: 7061 diff changeset	496 dp->dp_origin_snap == NULL \|\| ds == dp->dp_origin_snap);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	497 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	498 if (!dsl_pool_sync_context(dp) && DSL_DATASET_IS_DESTROYED(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	499 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	500 dmu_buf_rele(ds->ds_dbuf, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	501 return (ENOENT);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	502 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	503 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	504 *dsp = ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	505 return (0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	506 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	507
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	508 static int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	509 dsl_dataset_hold_ref(dsl_dataset_t ds, void tag)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	510 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	511 dsl_pool_t *dp = ds->ds_dir->dd_pool;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	512
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	513 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	514 * In syncing context we don't want the rwlock lock: there
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	515 * may be an existing writer waiting for sync phase to
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	516 * finish. We don't need to worry about such writers, since
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	517 * sync phase is single-threaded, so the writer can't be
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	518 * doing anything while we are active.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	519 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	520 if (dsl_pool_sync_context(dp)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	521 ASSERT(!DSL_DATASET_IS_DESTROYED(ds));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	522 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	523 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	524
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	525 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	526 * Normal users will hold the ds_rwlock as a READER until they
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	527 * are finished (i.e., call dsl_dataset_rele()). "Owners" will
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	528 * drop their READER lock after they set the ds_owner field.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	529 *
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	530 * If the dataset is being destroyed, the destroy thread will
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	531 * obtain a WRITER lock for exclusive access after it's done its
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	532 * open-context work and then change the ds_owner to
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	533 * dsl_reaper once destruction is assured. So threads
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	534 * may block here temporarily, until the "destructability" of
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	535 * the dataset is determined.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	536 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	537 ASSERT(!RW_WRITE_HELD(&dp->dp_config_rwlock));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	538 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	539 while (!rw_tryenter(&ds->ds_rwlock, RW_READER)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	540 rw_exit(&dp->dp_config_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	541 cv_wait(&ds->ds_exclusive_cv, &ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	542 if (DSL_DATASET_IS_DESTROYED(ds)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	543 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	544 dsl_dataset_drop_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	545 rw_enter(&dp->dp_config_rwlock, RW_READER);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	546 return (ENOENT);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	547 }
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	548 /*
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	549 * The dp_config_rwlock lives above the ds_lock. And
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	550 * we need to check DSL_DATASET_IS_DESTROYED() while
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	551 * holding the ds_lock, so we have to drop and reacquire
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	552 * the ds_lock here.
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	553 */
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	554 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	555 rw_enter(&dp->dp_config_rwlock, RW_READER);
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	556 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	557 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	558 mutex_exit(&ds->ds_lock);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	559 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	560 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	561
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	562 int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	563 dsl_dataset_hold_obj(dsl_pool_t dp, uint64_t dsobj, void tag,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	564 dsl_dataset_t **dsp)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	565 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	566 int err = dsl_dataset_get_ref(dp, dsobj, tag, dsp);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	567
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	568 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	569 return (err);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	570 return (dsl_dataset_hold_ref(*dsp, tag));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	571 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	572
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	573 int
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	574 dsl_dataset_own_obj(dsl_pool_t *dp, uint64_t dsobj, boolean_t inconsistentok,
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	575 void tag, dsl_dataset_t *dsp)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	576 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	577 int err = dsl_dataset_hold_obj(dp, dsobj, tag, dsp);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	578 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	579 return (err);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	580 if (!dsl_dataset_tryown(*dsp, inconsistentok, tag)) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	581 dsl_dataset_rele(*dsp, tag);
8779 f164e0e90508 6784924 panic while ludelete (zfs destroy) Mark J Musante <Mark.Musante@Sun.COM> parents: 8746 diff changeset	582 *dsp = NULL;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	583 return (EBUSY);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	584 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	585 return (0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	586 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	587
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	588 int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	589 dsl_dataset_hold(const char name, void tag, dsl_dataset_t **dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	590 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	591 dsl_dir_t *dd;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	592 dsl_pool_t *dp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	593 const char *snapname;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	594 uint64_t obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	595 int err = 0;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	596
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	597 err = dsl_dir_open_spa(NULL, name, FTAG, &dd, &snapname);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	598 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	599 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	600
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	601 dp = dd->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	602 obj = dd->dd_phys->dd_head_dataset_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	603 rw_enter(&dp->dp_config_rwlock, RW_READER);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	604 if (obj)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	605 err = dsl_dataset_get_ref(dp, obj, tag, dsp);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	606 else
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	607 err = ENOENT;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	608 if (err)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	609 goto out;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	610
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	611 err = dsl_dataset_hold_ref(*dsp, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	612
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	613 /* we may be looking for a snapshot */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	614 if (err == 0 && snapname != NULL) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	615 dsl_dataset_t *ds = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	616
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	617 if (*snapname++ != '@') {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	618 dsl_dataset_rele(*dsp, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	619 err = ENOENT;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	620 goto out;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	621 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	622
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	623 dprintf("looking for snapshot '%s'\n", snapname);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	624 err = dsl_dataset_snap_lookup(*dsp, snapname, &obj);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	625 if (err == 0)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	626 err = dsl_dataset_get_ref(dp, obj, tag, &ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	627 dsl_dataset_rele(*dsp, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	628
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	629 ASSERT3U((err == 0), ==, (ds != NULL));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	630
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	631 if (ds) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	632 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	633 if (ds->ds_snapname[0] == 0)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	634 (void) strlcpy(ds->ds_snapname, snapname,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	635 sizeof (ds->ds_snapname));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	636 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	637 err = dsl_dataset_hold_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	638 *dsp = err ? NULL : ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	639 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	640 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	641 out:
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	642 rw_exit(&dp->dp_config_rwlock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	643 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	644 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	645 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	646
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	647 int
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	648 dsl_dataset_own(const char *name, boolean_t inconsistentok,
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	649 void tag, dsl_dataset_t *dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	650 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	651 int err = dsl_dataset_hold(name, tag, dsp);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	652 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	653 return (err);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	654 if (!dsl_dataset_tryown(*dsp, inconsistentok, tag)) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	655 dsl_dataset_rele(*dsp, tag);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	656 return (EBUSY);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	657 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	658 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	659 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	660
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	661 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	662 dsl_dataset_name(dsl_dataset_t ds, char name)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	663 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	664 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	665 (void) strcpy(name, "mos");
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	666 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	667 dsl_dir_name(ds->ds_dir, name);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	668 VERIFY(0 == dsl_dataset_get_snapname(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	669 if (ds->ds_snapname[0]) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	670 (void) strcat(name, "@");
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	671 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	672 * We use a "recursive" mutex so that we
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	673 * can call dprintf_ds() with ds_lock held.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	674 */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	675 if (!MUTEX_HELD(&ds->ds_lock)) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	676 mutex_enter(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	677 (void) strcat(name, ds->ds_snapname);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	678 mutex_exit(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	679 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	680 (void) strcat(name, ds->ds_snapname);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	681 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	682 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	683 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	684 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	685
3978 2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	686 static int
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	687 dsl_dataset_namelen(dsl_dataset_t *ds)
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	688 {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	689 int result;
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	690
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	691 if (ds == NULL) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	692 result = 3; /* "mos" */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	693 } else {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	694 result = dsl_dir_namelen(ds->ds_dir);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	695 VERIFY(0 == dsl_dataset_get_snapname(ds));
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	696 if (ds->ds_snapname[0]) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	697 ++result; /* adding one for the @-sign */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	698 if (!MUTEX_HELD(&ds->ds_lock)) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	699 mutex_enter(&ds->ds_lock);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	700 result += strlen(ds->ds_snapname);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	701 mutex_exit(&ds->ds_lock);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	702 } else {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	703 result += strlen(ds->ds_snapname);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	704 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	705 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	706 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	707
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	708 return (result);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	709 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	710
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	711 void
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	712 dsl_dataset_drop_ref(dsl_dataset_t ds, void tag)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	713 {
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	714 dmu_buf_rele(ds->ds_dbuf, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	715 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	716
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	717 void
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	718 dsl_dataset_rele(dsl_dataset_t ds, void tag)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	719 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	720 if (!dsl_pool_sync_context(ds->ds_dir->dd_pool)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	721 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	722 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	723 dsl_dataset_drop_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	724 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	725
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	726 void
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	727 dsl_dataset_disown(dsl_dataset_t ds, void tag)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	728 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	729 ASSERT((ds->ds_owner == tag && ds->ds_dbuf) \|\|
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	730 (DSL_DATASET_IS_DESTROYED(ds) && ds->ds_dbuf == NULL));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	731
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	732 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	733 ds->ds_owner = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	734 if (RW_WRITE_HELD(&ds->ds_rwlock)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	735 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	736 cv_broadcast(&ds->ds_exclusive_cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	737 }
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	738 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	739 if (ds->ds_dbuf)
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	740 dsl_dataset_drop_ref(ds, tag);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	741 else
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	742 dsl_dataset_evict(NULL, ds);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	743 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	744
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	745 boolean_t
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	746 dsl_dataset_tryown(dsl_dataset_t ds, boolean_t inconsistentok, void tag)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	747 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	748 boolean_t gotit = FALSE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	749
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	750 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	751 if (ds->ds_owner == NULL &&
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	752 (!DS_IS_INCONSISTENT(ds) \|\| inconsistentok)) {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	753 ds->ds_owner = tag;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	754 if (!dsl_pool_sync_context(ds->ds_dir->dd_pool))
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	755 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	756 gotit = TRUE;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	757 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	758 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	759 return (gotit);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	760 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	761
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	762 void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	763 dsl_dataset_make_exclusive(dsl_dataset_t ds, void owner)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	764 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	765 ASSERT3P(owner, ==, ds->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	766 if (!RW_WRITE_HELD(&ds->ds_rwlock))
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	767 rw_enter(&ds->ds_rwlock, RW_WRITER);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	768 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	769
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	770 uint64_t
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	771 dsl_dataset_create_sync_dd(dsl_dir_t dd, dsl_dataset_t origin,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	772 uint64_t flags, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	773 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	774 dsl_pool_t *dp = dd->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	775 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	776 dsl_dataset_phys_t *dsphys;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	777 uint64_t dsobj;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	778 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	779
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	780 if (origin == NULL)
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	781 origin = dp->dp_origin_snap;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	782
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	783 ASSERT(origin == NULL \|\| origin->ds_dir->dd_pool == dp);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	784 ASSERT(origin == NULL \|\| origin->ds_phys->ds_num_children > 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	785 ASSERT(dmu_tx_is_syncing(tx));
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	786 ASSERT(dd->dd_phys->dd_head_dataset_obj == 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	787
928 36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	788 dsobj = dmu_object_alloc(mos, DMU_OT_DSL_DATASET, 0,
36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	789 DMU_OT_DSL_DATASET, sizeof (dsl_dataset_phys_t), tx);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	790 VERIFY(0 == dmu_bonus_hold(mos, dsobj, FTAG, &dbuf));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	791 dmu_buf_will_dirty(dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	792 dsphys = dbuf->db_data;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	793 bzero(dsphys, sizeof (dsl_dataset_phys_t));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	794 dsphys->ds_dir_obj = dd->dd_object;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	795 dsphys->ds_flags = flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	796 dsphys->ds_fsid_guid = unique_create();
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	797 (void) random_get_pseudo_bytes((void*)&dsphys->ds_guid,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	798 sizeof (dsphys->ds_guid));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	799 dsphys->ds_snapnames_zapobj =
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	800 zap_create_norm(mos, U8_TEXTPREP_TOUPPER, DMU_OT_DSL_DS_SNAP_MAP,
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	801 DMU_OT_NONE, 0, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	802 dsphys->ds_creation_time = gethrestime_sec();
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	803 dsphys->ds_creation_txg = tx->tx_txg == TXG_INITIAL ? 1 : tx->tx_txg;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	804
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	805 if (origin == NULL) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	806 dsphys->ds_deadlist_obj = dsl_deadlist_alloc(mos, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	807 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	808 dsl_dataset_t *ohds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	809
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	810 dsphys->ds_prev_snap_obj = origin->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	811 dsphys->ds_prev_snap_txg =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	812 origin->ds_phys->ds_creation_txg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	813 dsphys->ds_used_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	814 origin->ds_phys->ds_used_bytes;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	815 dsphys->ds_compressed_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	816 origin->ds_phys->ds_compressed_bytes;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	817 dsphys->ds_uncompressed_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	818 origin->ds_phys->ds_uncompressed_bytes;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	819 dsphys->ds_bp = origin->ds_phys->ds_bp;
6502 66aef5f20377 6694731 drc->drc_real_ds->ds_phys->ds_flags & (1ULL<<0), file: ../../common/fs/zfs/dmu_send.c, line: 1069 timh parents: 6492 diff changeset	820 dsphys->ds_flags \|= origin->ds_phys->ds_flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	821
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	822 dmu_buf_will_dirty(origin->ds_dbuf, tx);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	823 origin->ds_phys->ds_num_children++;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	824
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	825 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	826 origin->ds_dir->dd_phys->dd_head_dataset_obj, FTAG, &ohds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	827 dsphys->ds_deadlist_obj = dsl_deadlist_clone(&ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	828 dsphys->ds_prev_snap_txg, dsphys->ds_prev_snap_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	829 dsl_dataset_rele(ohds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	830
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	831 if (spa_version(dp->dp_spa) >= SPA_VERSION_NEXT_CLONES) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	832 if (origin->ds_phys->ds_next_clones_obj == 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	833 origin->ds_phys->ds_next_clones_obj =
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	834 zap_create(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	835 DMU_OT_NEXT_CLONES, DMU_OT_NONE, 0, tx);
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	836 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	837 VERIFY(0 == zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	838 origin->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	839 dsobj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	840 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	841
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	842 dmu_buf_will_dirty(dd->dd_dbuf, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	843 dd->dd_phys->dd_origin_obj = origin->ds_object;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	844 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	845 if (origin->ds_dir->dd_phys->dd_clones == 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	846 dmu_buf_will_dirty(origin->ds_dir->dd_dbuf, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	847 origin->ds_dir->dd_phys->dd_clones =
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	848 zap_create(mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	849 DMU_OT_DSL_CLONES, DMU_OT_NONE, 0, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	850 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	851 VERIFY3U(0, ==, zap_add_int(mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	852 origin->ds_dir->dd_phys->dd_clones, dsobj, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	853 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	854 }
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	855
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	856 if (spa_version(dp->dp_spa) >= SPA_VERSION_UNIQUE_ACCURATE)
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	857 dsphys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	858
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	859 dmu_buf_rele(dbuf, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	860
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	861 dmu_buf_will_dirty(dd->dd_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	862 dd->dd_phys->dd_head_dataset_obj = dsobj;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	863
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	864 return (dsobj);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	865 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	866
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	867 uint64_t
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	868 dsl_dataset_create_sync(dsl_dir_t pdd, const char lastname,
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	869 dsl_dataset_t origin, uint64_t flags, cred_t cr, dmu_tx_t *tx)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	870 {
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	871 dsl_pool_t *dp = pdd->dd_pool;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	872 uint64_t dsobj, ddobj;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	873 dsl_dir_t *dd;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	874
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	875 ASSERT(lastname[0] != '@');
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	876
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	877 ddobj = dsl_dir_create_sync(dp, pdd, lastname, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	878 VERIFY(0 == dsl_dir_open_obj(dp, ddobj, lastname, FTAG, &dd));
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	879
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	880 dsobj = dsl_dataset_create_sync_dd(dd, origin, flags, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	881
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	882 dsl_deleg_set_create_perms(dd, tx, cr);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	883
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	884 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	885
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	886 /*
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	887 * If we are creating a clone, make sure we zero out any stale
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	888 * data from the origin snapshots zil header.
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	889 */
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	890 if (origin != NULL) {
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	891 dsl_dataset_t *ds;
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	892 objset_t *os;
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	893
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	894 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds));
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	895 VERIFY3U(0, ==, dmu_objset_from_ds(ds, &os));
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	896 bzero(&os->os_zil_header, sizeof (os->os_zil_header));
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	897 dsl_dataset_dirty(ds, tx);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	898 dsl_dataset_rele(ds, FTAG);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	899 }
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	900
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	901 return (dsobj);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	902 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	903
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	904 struct destroyarg {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	905 dsl_sync_task_group_t *dstg;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	906 char *snapname;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	907 char *failed;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	908 boolean_t defer;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	909 };
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	910
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	911 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	912 dsl_snapshot_destroy_one(const char name, void arg)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	913 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	914 struct destroyarg *da = arg;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	915 dsl_dataset_t *ds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	916 int err;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	917 char *dsname;
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	918
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	919 dsname = kmem_asprintf("%s@%s", name, da->snapname);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	920 err = dsl_dataset_own(dsname, B_TRUE, da->dstg, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	921 strfree(dsname);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	922 if (err == 0) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	923 struct dsl_ds_destroyarg *dsda;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	924
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	925 dsl_dataset_make_exclusive(ds, da->dstg);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	926 dsda = kmem_zalloc(sizeof (struct dsl_ds_destroyarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	927 dsda->ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	928 dsda->defer = da->defer;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	929 dsl_sync_task_create(da->dstg, dsl_dataset_destroy_check,
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	930 dsl_dataset_destroy_sync, dsda, da->dstg, 0);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	931 } else if (err == ENOENT) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	932 err = 0;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	933 } else {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	934 (void) strcpy(da->failed, name);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	935 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	936 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	937 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	938
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	939 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	940 * Destroy 'snapname' in all descendants of 'fsname'.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	941 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	942 #pragma weak dmu_snapshots_destroy = dsl_snapshots_destroy
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	943 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	944 dsl_snapshots_destroy(char fsname, char snapname, boolean_t defer)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	945 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	946 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	947 struct destroyarg da;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	948 dsl_sync_task_t *dst;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	949 spa_t *spa;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	950
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	951 err = spa_open(fsname, &spa, FTAG);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	952 if (err)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	953 return (err);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	954 da.dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	955 da.snapname = snapname;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	956 da.failed = fsname;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	957 da.defer = defer;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	958
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	959 err = dmu_objset_find(fsname,
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	960 dsl_snapshot_destroy_one, &da, DS_FIND_CHILDREN);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	961
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	962 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	963 err = dsl_sync_task_group_wait(da.dstg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	964
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	965 for (dst = list_head(&da.dstg->dstg_tasks); dst;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	966 dst = list_next(&da.dstg->dstg_tasks, dst)) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	967 struct dsl_ds_destroyarg *dsda = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	968 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	969
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	970 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	971 * Return the file system name that triggered the error
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	972 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	973 if (dst->dst_err) {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	974 dsl_dataset_name(ds, fsname);
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	975 *strchr(fsname, '@') = '\0';
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	976 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	977 ASSERT3P(dsda->rm_origin, ==, NULL);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	978 dsl_dataset_disown(ds, da.dstg);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	979 kmem_free(dsda, sizeof (struct dsl_ds_destroyarg));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	980 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	981
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	982 dsl_sync_task_group_destroy(da.dstg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	983 spa_close(spa, FTAG);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	984 return (err);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	985 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	986
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	987 static boolean_t
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	988 dsl_dataset_might_destroy_origin(dsl_dataset_t *ds)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	989 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	990 boolean_t might_destroy = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	991
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	992 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	993 if (ds->ds_phys->ds_num_children == 2 && ds->ds_userrefs == 0 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	994 DS_IS_DEFER_DESTROY(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	995 might_destroy = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	996 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	997
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	998 return (might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	999 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1000
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1001 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1002 * If we're removing a clone, and these three conditions are true:
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1003 * 1) the clone's origin has no other children
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1004 * 2) the clone's origin has no user references
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1005 * 3) the clone's origin has been marked for deferred destruction
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1006 * Then, prepare to remove the origin as part of this sync task group.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1007 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1008 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1009 dsl_dataset_origin_rm_prep(struct dsl_ds_destroyarg dsda, void tag)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1010 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1011 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1012 dsl_dataset_t *origin = ds->ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1013
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1014 if (dsl_dataset_might_destroy_origin(origin)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1015 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1016 int namelen;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1017 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1018
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1019 namelen = dsl_dataset_namelen(origin) + 1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1020 name = kmem_alloc(namelen, KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1021 dsl_dataset_name(origin, name);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1022 #ifdef _KERNEL
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1023 error = zfs_unmount_snap(name, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1024 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1025 kmem_free(name, namelen);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1026 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1027 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1028 #endif
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1029 error = dsl_dataset_own(name, B_TRUE, tag, &origin);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1030 kmem_free(name, namelen);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1031 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1032 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1033 dsda->rm_origin = origin;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1034 dsl_dataset_make_exclusive(origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1035 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1036
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1037 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1038 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1039
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1040 /*
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1041 * ds must be opened as OWNER. On return (whether successful or not),
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1042 * ds will be closed and caller can no longer dereference it.
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1043 */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1044 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1045 dsl_dataset_destroy(dsl_dataset_t ds, void tag, boolean_t defer)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1046 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1047 int err;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1048 dsl_sync_task_group_t *dstg;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1049 objset_t *os;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1050 dsl_dir_t *dd;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1051 uint64_t obj;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1052 struct dsl_ds_destroyarg dsda = { 0 };
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1053 dsl_dataset_t dummy_ds = { 0 };
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1054
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1055 dsda.ds = ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1056
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1057 if (dsl_dataset_is_snapshot(ds)) {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1058 /* Destroying a snapshot is simpler */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1059 dsl_dataset_make_exclusive(ds, tag);
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	1060
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1061 dsda.defer = defer;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1062 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1063 dsl_dataset_destroy_check, dsl_dataset_destroy_sync,
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1064 &dsda, tag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1065 ASSERT3P(dsda.rm_origin, ==, NULL);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1066 goto out;
10385 21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1067 } else if (defer) {
21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1068 err = EINVAL;
21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1069 goto out;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1070 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1071
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1072 dd = ds->ds_dir;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1073 dummy_ds.ds_dir = dd;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1074 dummy_ds.ds_object = ds->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1075
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1076 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1077 * Check for errors and mark this ds as inconsistent, in
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1078 * case we crash while freeing the objects.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1079 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1080 err = dsl_sync_task_do(dd->dd_pool, dsl_dataset_destroy_begin_check,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1081 dsl_dataset_destroy_begin_sync, ds, NULL, 0);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1082 if (err)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1083 goto out;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1084
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1085 err = dmu_objset_from_ds(ds, &os);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1086 if (err)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1087 goto out;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1088
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1089 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1090 * remove the objects in open context, so that we won't
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1091 * have too much to do in syncing context.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1092 */
3025 4e5ee8301d84 6424466 "panic: data after EOF" when unmounting abused pool ahrens parents: 2885 diff changeset	1093 for (obj = 0; err == 0; err = dmu_object_next(os, &obj, FALSE,
4e5ee8301d84 6424466 "panic: data after EOF" when unmounting abused pool ahrens parents: 2885 diff changeset	1094 ds->ds_phys->ds_prev_snap_txg)) {
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1095 /*
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1096 * Ignore errors, if there is not enough disk space
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1097 * we will deal with it in dsl_dataset_destroy_sync().
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1098 */
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1099 (void) dmu_free_object(os, obj);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1100 }
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1101 if (err != ESRCH)
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1102 goto out;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1103
9396 f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1104 /*
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1105 * Only the ZIL knows how to free log blocks.
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1106 */
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1107 zil_destroy(dmu_objset_zil(os), B_FALSE);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1108
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1109 /*
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1110 * Sync out all in-flight IO.
9396 f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1111 */
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1112 txg_wait_synced(dd->dd_pool, 0);
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1113
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1114 /*
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1115 * If we managed to free all the objects in open
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1116 * context, the user space accounting should be zero.
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1117 */
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1118 if (ds->ds_phys->ds_bp.blk_fill == 0 &&
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1119 dmu_objset_userused_enabled(os)) {
9396 f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1120 uint64_t count;
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1121
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1122 ASSERT(zap_count(os, DMU_USERUSED_OBJECT, &count) != 0 \|\|
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1123 count == 0);
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1124 ASSERT(zap_count(os, DMU_GROUPUSED_OBJECT, &count) != 0 \|\|
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1125 count == 0);
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1126 }
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1127
6975 c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1128 rw_enter(&dd->dd_pool->dp_config_rwlock, RW_READER);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1129 err = dsl_dir_open_obj(dd->dd_pool, dd->dd_object, NULL, FTAG, &dd);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1130 rw_exit(&dd->dd_pool->dp_config_rwlock);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1131
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1132 if (err)
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1133 goto out;
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1134
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1135 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1136 * Blow away the dsl_dir + head dataset.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1137 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1138 dsl_dataset_make_exclusive(ds, tag);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1139 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1140 * If we're removing a clone, we might also need to remove its
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1141 * origin.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1142 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1143 do {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1144 dsda.need_prep = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1145 if (dsl_dir_is_clone(dd)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1146 err = dsl_dataset_origin_rm_prep(&dsda, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1147 if (err) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1148 dsl_dir_close(dd, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1149 goto out;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1150 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1151 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1152
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1153 dstg = dsl_sync_task_group_create(ds->ds_dir->dd_pool);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1154 dsl_sync_task_create(dstg, dsl_dataset_destroy_check,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1155 dsl_dataset_destroy_sync, &dsda, tag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1156 dsl_sync_task_create(dstg, dsl_dir_destroy_check,
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1157 dsl_dir_destroy_sync, &dummy_ds, FTAG, 0);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1158 err = dsl_sync_task_group_wait(dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1159 dsl_sync_task_group_destroy(dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1160
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1161 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1162 * We could be racing against 'zfs release' or 'zfs destroy -d'
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1163 * on the origin snap, in which case we can get EBUSY if we
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1164 * needed to destroy the origin snap but were not ready to
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1165 * do so.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1166 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1167 if (dsda.need_prep) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1168 ASSERT(err == EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1169 ASSERT(dsl_dir_is_clone(dd));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1170 ASSERT(dsda.rm_origin == NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1171 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1172 } while (dsda.need_prep);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1173
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1174 if (dsda.rm_origin != NULL)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1175 dsl_dataset_disown(dsda.rm_origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1176
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1177 /* if it is successful, dsl_dir_destroy_sync will close the dd */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1178 if (err)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1179 dsl_dir_close(dd, FTAG);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1180 out:
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1181 dsl_dataset_disown(ds, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1182 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1183 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1184
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1185 blkptr_t *
e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1186 dsl_dataset_get_blkptr(dsl_dataset_t *ds)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1187 {
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1188 return (&ds->ds_phys->ds_bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1189 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1190
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1191 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1192 dsl_dataset_set_blkptr(dsl_dataset_t ds, blkptr_t bp, dmu_tx_t *tx)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1193 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1194 ASSERT(dmu_tx_is_syncing(tx));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1195 /* If it's the meta-objset, set dp_meta_rootbp */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1196 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1197 tx->tx_pool->dp_meta_rootbp = *bp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1198 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1199 dmu_buf_will_dirty(ds->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1200 ds->ds_phys->ds_bp = *bp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1201 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1202 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1203
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1204 spa_t *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1205 dsl_dataset_get_spa(dsl_dataset_t *ds)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1206 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1207 return (ds->ds_dir->dd_pool->dp_spa);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1208 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1209
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1210 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1211 dsl_dataset_dirty(dsl_dataset_t ds, dmu_tx_t tx)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1212 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1213 dsl_pool_t *dp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1214
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1215 if (ds == NULL) /* this is the meta-objset */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1216 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1217
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1218 ASSERT(ds->ds_objset != NULL);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1219
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1220 if (ds->ds_phys->ds_next_snap_obj != 0)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1221 panic("dirtying snapshot!");
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1222
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1223 dp = ds->ds_dir->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1224
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1225 if (txg_list_add(&dp->dp_dirty_datasets, ds, tx->tx_txg) == 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1226 /* up the hold count until we can be written out */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1227 dmu_buf_add_ref(ds->ds_dbuf, ds);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1228 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1229 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1230
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1231 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1232 * The unique space in the head dataset can be calculated by subtracting
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1233 * the space used in the most recent snapshot, that is still being used
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1234 * in this file system, from the space currently in use. To figure out
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1235 * the space in the most recent snapshot still in use, we need to take
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1236 * the total space used in the snapshot and subtract out the space that
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1237 * has been freed up since the snapshot was taken.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1238 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1239 static void
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1240 dsl_dataset_recalc_head_uniq(dsl_dataset_t *ds)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1241 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1242 uint64_t mrs_used;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1243 uint64_t dlused, dlcomp, dluncomp;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1244
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1245 ASSERT(!dsl_dataset_is_snapshot(ds));
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1246
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1247 if (ds->ds_phys->ds_prev_snap_obj != 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1248 mrs_used = ds->ds_prev->ds_phys->ds_used_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1249 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1250 mrs_used = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1251
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1252 dsl_deadlist_space(&ds->ds_deadlist, &dlused, &dlcomp, &dluncomp);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1253
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1254 ASSERT3U(dlused, <=, mrs_used);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1255 ds->ds_phys->ds_unique_bytes =
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1256 ds->ds_phys->ds_used_bytes - (mrs_used - dlused);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1257
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1258 if (spa_version(ds->ds_dir->dd_pool->dp_spa) >=
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1259 SPA_VERSION_UNIQUE_ACCURATE)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1260 ds->ds_phys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1261 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1262
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1263 struct killarg {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1264 dsl_dataset_t *ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1265 dmu_tx_t *tx;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1266 };
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1267
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1268 /* ARGSUSED */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1269 static int
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1270 kill_blkptr(spa_t spa, zilog_t zilog, const blkptr_t bp, arc_buf_t pbuf,
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1271 const zbookmark_t zb, const dnode_phys_t dnp, void *arg)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1272 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1273 struct killarg *ka = arg;
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1274 dmu_tx_t *tx = ka->tx;
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1275
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1276 if (bp == NULL)
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1277 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1278
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1279 if (zb->zb_level == ZB_ZIL_LEVEL) {
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1280 ASSERT(zilog != NULL);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1281 /*
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1282 * It's a block in the intent log. It has no
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1283 * accounting, so just free it.
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1284 */
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1285 dsl_free(ka->tx->tx_pool, ka->tx->tx_txg, bp);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1286 } else {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1287 ASSERT(zilog == NULL);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1288 ASSERT3U(bp->blk_birth, >, ka->ds->ds_phys->ds_prev_snap_txg);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1289 (void) dsl_dataset_block_kill(ka->ds, bp, tx, B_FALSE);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1290 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1291
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1292 return (0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1293 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1294
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1295 /* ARGSUSED */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1296 static int
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1297 dsl_dataset_destroy_begin_check(void arg1, void arg2, dmu_tx_t *tx)
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1298 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1299 dsl_dataset_t *ds = arg1;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1300 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1301 uint64_t count;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1302 int err;
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1303
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1304 /*
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1305 * Can't delete a head dataset if there are snapshots of it.
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1306 * (Except if the only snapshots are from the branch we cloned
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1307 * from.)
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1308 */
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1309 if (ds->ds_prev != NULL &&
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1310 ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object)
10816 731471f04028 6482588 zfs destroy -r aborts and dumps core when destroying a file system (while snapshotting is going on) vitezslav batrla - Sun Microsystems - Prague Czech Republic <Vitezslav.Batrla@Sun.COM> parents: 10801 diff changeset	1311 return (EBUSY);
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1312
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1313 /*
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1314 * This is really a dsl_dir thing, but check it here so that
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1315 * we'll be less likely to leave this dataset inconsistent &
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1316 * nearly destroyed.
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1317 */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1318 err = zap_count(mos, ds->ds_dir->dd_phys->dd_child_dir_zapobj, &count);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1319 if (err)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1320 return (err);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1321 if (count != 0)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1322 return (EEXIST);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1323
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1324 return (0);
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1325 }
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1326
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1327 /* ARGSUSED */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1328 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1329 dsl_dataset_destroy_begin_sync(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1330 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1331 dsl_dataset_t *ds = arg1;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1332 dsl_pool_t *dp = ds->ds_dir->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1333
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1334 /* Mark it as inconsistent on-disk, in case we crash */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1335 dmu_buf_will_dirty(ds->ds_dbuf, tx);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1336 ds->ds_phys->ds_flags \|= DS_FLAG_INCONSISTENT;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1337
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1338 spa_history_log_internal(LOG_DS_DESTROY_BEGIN, dp->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1339 "dataset = %llu", ds->ds_object);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1340 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1341
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1342 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1343 dsl_dataset_origin_check(struct dsl_ds_destroyarg dsda, void tag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1344 dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1345 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1346 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1347 dsl_dataset_t *ds_prev = ds->ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1348
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1349 if (dsl_dataset_might_destroy_origin(ds_prev)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1350 struct dsl_ds_destroyarg ndsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1351
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1352 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1353 * If we're not prepared to remove the origin, don't remove
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1354 * the clone either.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1355 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1356 if (dsda->rm_origin == NULL) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1357 dsda->need_prep = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1358 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1359 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1360
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1361 ndsda.ds = ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1362 ndsda.is_origin_rm = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1363 return (dsl_dataset_destroy_check(&ndsda, tag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1364 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1365
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1366 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1367 * If we're not going to remove the origin after all,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1368 * undo the open context setup.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1369 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1370 if (dsda->rm_origin != NULL) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1371 dsl_dataset_disown(dsda->rm_origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1372 dsda->rm_origin = NULL;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1373 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1374
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1375 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1376 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1377
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1378 /*
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1379 * If you add new checks here, you may need to add
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1380 * additional checks to the "temporary" case in
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1381 * snapshot_check() in dmu_objset.c.
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1382 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1383 /* ARGSUSED */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1384 int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1385 dsl_dataset_destroy_check(void arg1, void arg2, dmu_tx_t *tx)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1386 {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1387 struct dsl_ds_destroyarg *dsda = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1388 dsl_dataset_t *ds = dsda->ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1389
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1390 /* we have an owner hold, so noone else can destroy us */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1391 ASSERT(!DSL_DATASET_IS_DESTROYED(ds));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1392
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1393 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1394 * Only allow deferred destroy on pools that support it.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1395 * NOTE: deferred destroy is only supported on snapshots.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1396 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1397 if (dsda->defer) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1398 if (spa_version(ds->ds_dir->dd_pool->dp_spa) <
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1399 SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1400 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1401 ASSERT(dsl_dataset_is_snapshot(ds));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1402 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1403 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1404
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1405 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1406 * Can't delete a head dataset if there are snapshots of it.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1407 * (Except if the only snapshots are from the branch we cloned
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1408 * from.)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1409 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1410 if (ds->ds_prev != NULL &&
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1411 ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object)
10816 731471f04028 6482588 zfs destroy -r aborts and dumps core when destroying a file system (while snapshotting is going on) vitezslav batrla - Sun Microsystems - Prague Czech Republic <Vitezslav.Batrla@Sun.COM> parents: 10801 diff changeset	1412 return (EBUSY);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1413
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1414 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1415 * If we made changes this txg, traverse_dsl_dataset won't find
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1416 * them. Try again.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1417 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1418 if (ds->ds_phys->ds_bp.blk_birth >= tx->tx_txg)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1419 return (EAGAIN);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1420
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1421 if (dsl_dataset_is_snapshot(ds)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1422 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1423 * If this snapshot has an elevated user reference count,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1424 * we can't destroy it yet.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1425 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1426 if (ds->ds_userrefs > 0 && !dsda->releasing)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1427 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1428
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1429 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1430 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1431 * Can't delete a branch point. However, if we're destroying
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1432 * a clone and removing its origin due to it having a user
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1433 * hold count of 0 and having been marked for deferred destroy,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1434 * it's OK for the origin to have a single clone.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1435 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1436 if (ds->ds_phys->ds_num_children >
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1437 (dsda->is_origin_rm ? 2 : 1)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1438 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1439 return (EEXIST);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1440 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1441 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1442 } else if (dsl_dir_is_clone(ds->ds_dir)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1443 return (dsl_dataset_origin_check(dsda, arg2, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1444 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1445
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1446 /* XXX we should do some i/o error checking... */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1447 return (0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1448 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1449
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1450 struct refsarg {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1451 kmutex_t lock;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1452 boolean_t gone;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1453 kcondvar_t cv;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1454 };
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1455
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1456 /* ARGSUSED */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1457 static void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1458 dsl_dataset_refs_gone(dmu_buf_t db, void argv)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1459 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1460 struct refsarg *arg = argv;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1461
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1462 mutex_enter(&arg->lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1463 arg->gone = TRUE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1464 cv_signal(&arg->cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1465 mutex_exit(&arg->lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1466 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1467
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1468 static void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1469 dsl_dataset_drain_refs(dsl_dataset_t ds, void tag)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1470 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1471 struct refsarg arg;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1472
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1473 mutex_init(&arg.lock, NULL, MUTEX_DEFAULT, NULL);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1474 cv_init(&arg.cv, NULL, CV_DEFAULT, NULL);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1475 arg.gone = FALSE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1476 (void) dmu_buf_update_user(ds->ds_dbuf, ds, &arg, &ds->ds_phys,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1477 dsl_dataset_refs_gone);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1478 dmu_buf_rele(ds->ds_dbuf, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1479 mutex_enter(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1480 while (!arg.gone)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1481 cv_wait(&arg.cv, &arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1482 ASSERT(arg.gone);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1483 mutex_exit(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1484 ds->ds_dbuf = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1485 ds->ds_phys = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1486 mutex_destroy(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1487 cv_destroy(&arg.cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1488 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1489
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1490 static void
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1491 remove_from_next_clones(dsl_dataset_t ds, uint64_t obj, dmu_tx_t tx)
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1492 {
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1493 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1494 uint64_t count;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1495 int err;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1496
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1497 ASSERT(ds->ds_phys->ds_num_children >= 2);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1498 err = zap_remove_int(mos, ds->ds_phys->ds_next_clones_obj, obj, tx);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1499 /*
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1500 * The err should not be ENOENT, but a bug in a previous version
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1501 * of the code could cause upgrade_clones_cb() to not set
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1502 * ds_next_snap_obj when it should, leading to a missing entry.
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1503 * If we knew that the pool was created after
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1504 * SPA_VERSION_NEXT_CLONES, we could assert that it isn't
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1505 * ENOENT. However, at least we can check that we don't have
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1506 * too many entries in the next_clones_obj even after failing to
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1507 * remove this one.
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1508 */
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1509 if (err != ENOENT) {
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1510 VERIFY3U(err, ==, 0);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1511 }
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1512 ASSERT3U(0, ==, zap_count(mos, ds->ds_phys->ds_next_clones_obj,
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1513 &count));
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1514 ASSERT3U(count, <=, ds->ds_phys->ds_num_children - 2);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1515 }
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1516
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1517 static void
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1518 dsl_dataset_remove_clones_key(dsl_dataset_t ds, uint64_t mintxg, dmu_tx_t tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1519 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1520 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1521 zap_cursor_t zc;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1522 zap_attribute_t za;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1523
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1524 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1525 * If it is the old version, dd_clones doesn't exist so we can't
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1526 * find the clones, but deadlist_remove_key() is a no-op so it
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1527 * doesn't matter.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1528 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1529 if (ds->ds_dir->dd_phys->dd_clones == 0)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1530 return;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1531
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1532 for (zap_cursor_init(&zc, mos, ds->ds_dir->dd_phys->dd_clones);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1533 zap_cursor_retrieve(&zc, &za) == 0;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1534 zap_cursor_advance(&zc)) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1535 dsl_dataset_t *clone;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1536
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1537 VERIFY3U(0, ==, dsl_dataset_hold_obj(ds->ds_dir->dd_pool,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1538 za.za_first_integer, FTAG, &clone));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1539 if (clone->ds_dir->dd_origin_txg > mintxg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1540 dsl_deadlist_remove_key(&clone->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1541 mintxg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1542 dsl_dataset_remove_clones_key(clone, mintxg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1543 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1544 dsl_dataset_rele(clone, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1545 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1546 zap_cursor_fini(&zc);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1547 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1548
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1549 struct process_old_arg {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1550 dsl_dataset_t *ds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1551 dsl_dataset_t *ds_prev;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1552 boolean_t after_branch_point;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1553 zio_t *pio;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1554 uint64_t used, comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1555 };
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1556
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1557 static int
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1558 process_old_cb(void arg, const blkptr_t bp, dmu_tx_t *tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1559 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1560 struct process_old_arg *poa = arg;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1561 dsl_pool_t *dp = poa->ds->ds_dir->dd_pool;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1562
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1563 if (bp->blk_birth <= poa->ds->ds_phys->ds_prev_snap_txg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1564 dsl_deadlist_insert(&poa->ds->ds_deadlist, bp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1565 if (poa->ds_prev && !poa->after_branch_point &&
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1566 bp->blk_birth >
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1567 poa->ds_prev->ds_phys->ds_prev_snap_txg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1568 poa->ds_prev->ds_phys->ds_unique_bytes +=
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1569 bp_get_dsize_sync(dp->dp_spa, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1570 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1571 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1572 poa->used += bp_get_dsize_sync(dp->dp_spa, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1573 poa->comp += BP_GET_PSIZE(bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1574 poa->uncomp += BP_GET_UCSIZE(bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1575 dsl_free_sync(poa->pio, dp, tx->tx_txg, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1576 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1577 return (0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1578 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1579
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1580 static void
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1581 process_old_deadlist(dsl_dataset_t ds, dsl_dataset_t ds_prev,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1582 dsl_dataset_t ds_next, boolean_t after_branch_point, dmu_tx_t tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1583 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1584 struct process_old_arg poa = { 0 };
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1585 dsl_pool_t *dp = ds->ds_dir->dd_pool;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1586 objset_t *mos = dp->dp_meta_objset;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1587
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1588 ASSERT(ds->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1589 ASSERT(ds_next->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1590
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1591 poa.ds = ds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1592 poa.ds_prev = ds_prev;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1593 poa.after_branch_point = after_branch_point;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1594 poa.pio = zio_root(dp->dp_spa, NULL, NULL, ZIO_FLAG_MUSTSUCCEED);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1595 VERIFY3U(0, ==, bpobj_iterate(&ds_next->ds_deadlist.dl_bpobj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1596 process_old_cb, &poa, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1597 VERIFY3U(zio_wait(poa.pio), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1598 ASSERT3U(poa.used, ==, ds->ds_phys->ds_unique_bytes);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1599
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1600 /* change snapused */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1601 dsl_dir_diduse_space(ds->ds_dir, DD_USED_SNAP,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1602 -poa.used, -poa.comp, -poa.uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1603
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1604 /* swap next's deadlist to our deadlist */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1605 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1606 dsl_deadlist_close(&ds_next->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1607 SWITCH64(ds_next->ds_phys->ds_deadlist_obj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1608 ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1609 dsl_deadlist_open(&ds->ds_deadlist, mos, ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1610 dsl_deadlist_open(&ds_next->ds_deadlist, mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1611 ds_next->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1612 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1613
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1614 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1615 dsl_dataset_destroy_sync(void arg1, void tag, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1616 {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1617 struct dsl_ds_destroyarg *dsda = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1618 dsl_dataset_t *ds = dsda->ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1619 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1620 int after_branch_point = FALSE;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1621 dsl_pool_t *dp = ds->ds_dir->dd_pool;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1622 objset_t *mos = dp->dp_meta_objset;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1623 dsl_dataset_t *ds_prev = NULL;
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1624 boolean_t wont_destroy;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1625 uint64_t obj;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1626
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1627 wont_destroy = (dsda->defer &&
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1628 (ds->ds_userrefs > 0 \|\| ds->ds_phys->ds_num_children > 1));
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1629
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1630 ASSERT(ds->ds_owner \|\| wont_destroy);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1631 ASSERT(dsda->defer \|\| ds->ds_phys->ds_num_children <= 1);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1632 ASSERT(ds->ds_prev == NULL \|\|
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1633 ds->ds_prev->ds_phys->ds_next_snap_obj != ds->ds_object);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1634 ASSERT3U(ds->ds_phys->ds_bp.blk_birth, <=, tx->tx_txg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1635
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1636 if (wont_destroy) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1637 ASSERT(spa_version(dp->dp_spa) >= SPA_VERSION_USERREFS);
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1638 dmu_buf_will_dirty(ds->ds_dbuf, tx);
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1639 ds->ds_phys->ds_flags \|= DS_FLAG_DEFER_DESTROY;
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1640 return;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1641 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1642
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1643 /* signal any waiters that this dataset is going away */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1644 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1645 ds->ds_owner = dsl_reaper;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1646 cv_broadcast(&ds->ds_exclusive_cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1647 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1648
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1649 /* Remove our reservation */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1650 if (ds->ds_reserved != 0) {
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1651 dsl_prop_setarg_t psa;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1652 uint64_t value = 0;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1653
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1654 dsl_prop_setarg_init_uint64(&psa, "refreservation",
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1655 (ZPROP_SRC_NONE \| ZPROP_SRC_LOCAL \| ZPROP_SRC_RECEIVED),
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1656 &value);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1657 psa.psa_effective_value = 0; /* predict default value */
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1658
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1659 dsl_dataset_set_reservation_sync(ds, &psa, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1660 ASSERT3U(ds->ds_reserved, ==, 0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1661 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1662
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1663 ASSERT(RW_WRITE_HELD(&dp->dp_config_rwlock));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1664
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1665 dsl_scan_ds_destroyed(ds, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1666
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1667 obj = ds->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1668
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1669 if (ds->ds_phys->ds_prev_snap_obj != 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1670 if (ds->ds_prev) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1671 ds_prev = ds->ds_prev;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1672 } else {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1673 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1674 ds->ds_phys->ds_prev_snap_obj, FTAG, &ds_prev));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1675 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1676 after_branch_point =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1677 (ds_prev->ds_phys->ds_next_snap_obj != obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1678
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1679 dmu_buf_will_dirty(ds_prev->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1680 if (after_branch_point &&
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1681 ds_prev->ds_phys->ds_next_clones_obj != 0) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1682 remove_from_next_clones(ds_prev, obj, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1683 if (ds->ds_phys->ds_next_snap_obj != 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1684 VERIFY(0 == zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1685 ds_prev->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1686 ds->ds_phys->ds_next_snap_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1687 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1688 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1689 if (after_branch_point &&
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1690 ds->ds_phys->ds_next_snap_obj == 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1691 /* This clone is toast. */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1692 ASSERT(ds_prev->ds_phys->ds_num_children > 1);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1693 ds_prev->ds_phys->ds_num_children--;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1694
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1695 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1696 * If the clone's origin has no other clones, no
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1697 * user holds, and has been marked for deferred
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1698 * deletion, then we should have done the necessary
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1699 * destroy setup for it.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1700 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1701 if (ds_prev->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1702 ds_prev->ds_userrefs == 0 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1703 DS_IS_DEFER_DESTROY(ds_prev)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1704 ASSERT3P(dsda->rm_origin, !=, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1705 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1706 ASSERT3P(dsda->rm_origin, ==, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1707 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1708 } else if (!after_branch_point) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1709 ds_prev->ds_phys->ds_next_snap_obj =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1710 ds->ds_phys->ds_next_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1711 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1712 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1713
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1714 if (dsl_dataset_is_snapshot(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1715 dsl_dataset_t *ds_next;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1716 uint64_t old_unique;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1717 uint64_t used = 0, comp = 0, uncomp = 0;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1718
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1719 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1720 ds->ds_phys->ds_next_snap_obj, FTAG, &ds_next));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1721 ASSERT3U(ds_next->ds_phys->ds_prev_snap_obj, ==, obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1722
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1723 old_unique = ds_next->ds_phys->ds_unique_bytes;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1724
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1725 dmu_buf_will_dirty(ds_next->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1726 ds_next->ds_phys->ds_prev_snap_obj =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1727 ds->ds_phys->ds_prev_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1728 ds_next->ds_phys->ds_prev_snap_txg =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1729 ds->ds_phys->ds_prev_snap_txg;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1730 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, ==,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1731 ds_prev ? ds_prev->ds_phys->ds_creation_txg : 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1732
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1733
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1734 if (ds_next->ds_deadlist.dl_oldfmt) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1735 process_old_deadlist(ds, ds_prev, ds_next,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1736 after_branch_point, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1737 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1738 /* Adjust prev's unique space. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1739 if (ds_prev && !after_branch_point) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1740 dsl_deadlist_space_range(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1741 ds_prev->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1742 ds->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1743 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1744 ds_prev->ds_phys->ds_unique_bytes += used;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1745 }
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1746
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1747 /* Adjust snapused. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1748 dsl_deadlist_space_range(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1749 ds->ds_phys->ds_prev_snap_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1750 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1751 dsl_dir_diduse_space(ds->ds_dir, DD_USED_SNAP,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1752 -used, -comp, -uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1753
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1754 /* Move blocks to be freed to pool's free list. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1755 dsl_deadlist_move_bpobj(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1756 &dp->dp_free_bpobj, ds->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1757 tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1758 dsl_dir_diduse_space(tx->tx_pool->dp_free_dir,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1759 DD_USED_HEAD, used, comp, uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1760 dsl_dir_dirty(tx->tx_pool->dp_free_dir, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1761
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1762 /* Merge our deadlist into next's and free it. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1763 dsl_deadlist_merge(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1764 ds->ds_phys->ds_deadlist_obj, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1765 }
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1766 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1767 dsl_deadlist_free(mos, ds->ds_phys->ds_deadlist_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1768
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1769 /* Collapse range in clone heads */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1770 dsl_dataset_remove_clones_key(ds,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1771 ds->ds_phys->ds_creation_txg, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1772
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1773 if (dsl_dataset_is_snapshot(ds_next)) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1774 dsl_dataset_t *ds_nextnext;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1775
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1776 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1777 * Update next's unique to include blocks which
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1778 * were previously shared by only this snapshot
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1779 * and it. Those blocks will be born after the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1780 * prev snap and before this snap, and will have
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1781 * died after the next snap and before the one
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1782 * after that (ie. be on the snap after next's
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1783 * deadlist).
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1784 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1785 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1786 ds_next->ds_phys->ds_next_snap_obj,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1787 FTAG, &ds_nextnext));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1788 dsl_deadlist_space_range(&ds_nextnext->ds_deadlist,
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1789 ds->ds_phys->ds_prev_snap_txg,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1790 ds->ds_phys->ds_creation_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1791 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1792 ds_next->ds_phys->ds_unique_bytes += used;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1793 dsl_dataset_rele(ds_nextnext, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1794 ASSERT3P(ds_next->ds_prev, ==, NULL);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1795
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1796 /* Collapse range in this head. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1797 dsl_dataset_t *hds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1798 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1799 ds->ds_dir->dd_phys->dd_head_dataset_obj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1800 FTAG, &hds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1801 dsl_deadlist_remove_key(&hds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1802 ds->ds_phys->ds_creation_txg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1803 dsl_dataset_rele(hds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1804
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1805 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1806 ASSERT3P(ds_next->ds_prev, ==, ds);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1807 dsl_dataset_drop_ref(ds_next->ds_prev, ds_next);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1808 ds_next->ds_prev = NULL;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1809 if (ds_prev) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1810 VERIFY(0 == dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1811 ds->ds_phys->ds_prev_snap_obj,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1812 ds_next, &ds_next->ds_prev));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1813 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1814
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1815 dsl_dataset_recalc_head_uniq(ds_next);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1816
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1817 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1818 * Reduce the amount of our unconsmed refreservation
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1819 * being charged to our parent by the amount of
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1820 * new unique data we have gained.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1821 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1822 if (old_unique < ds_next->ds_reserved) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1823 int64_t mrsdelta;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1824 uint64_t new_unique =
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1825 ds_next->ds_phys->ds_unique_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1826
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1827 ASSERT(old_unique <= new_unique);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1828 mrsdelta = MIN(new_unique - old_unique,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1829 ds_next->ds_reserved - old_unique);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1830 dsl_dir_diduse_space(ds->ds_dir,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1831 DD_USED_REFRSRV, -mrsdelta, 0, 0, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1832 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1833 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1834 dsl_dataset_rele(ds_next, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1835 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1836 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1837 * There's no next snapshot, so this is a head dataset.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1838 * Destroy the deadlist. Unless it's a clone, the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1839 * deadlist should be empty. (If it's a clone, it's
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1840 * safe to ignore the deadlist contents.)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1841 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1842 struct killarg ka;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1843
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1844 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1845 dsl_deadlist_free(mos, ds->ds_phys->ds_deadlist_obj, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1846 ds->ds_phys->ds_deadlist_obj = 0;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1847
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1848 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1849 * Free everything that we point to (that's born after
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1850 * the previous snapshot, if we are a clone)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1851 *
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1852 * NB: this should be very quick, because we already
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1853 * freed all the objects in open context.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1854 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1855 ka.ds = ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1856 ka.tx = tx;
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1857 err = traverse_dataset(ds, ds->ds_phys->ds_prev_snap_txg,
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1858 TRAVERSE_POST, kill_blkptr, &ka);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1859 ASSERT3U(err, ==, 0);
9390 887948510f80 6826861 assertion failed in dsl_dataset_destroy_sync when "zfs destroy" old fs Chris Kirby <chris.kirby@sun.com> parents: 8779 diff changeset	1860 ASSERT(!DS_UNIQUE_IS_ACCURATE(ds) \|\|
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1861 ds->ds_phys->ds_unique_bytes == 0);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1862
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1863 if (ds->ds_prev != NULL) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1864 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1865 VERIFY3U(0, ==, zap_remove_int(mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1866 ds->ds_prev->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1867 ds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1868 }
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1869 dsl_dataset_rele(ds->ds_prev, ds);
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1870 ds->ds_prev = ds_prev = NULL;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1871 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1872 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1873
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1874 /*
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1875 * This must be done after the dsl_traverse(), because it will
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1876 * re-open the objset.
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1877 */
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1878 if (ds->ds_objset) {
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1879 dmu_objset_evict(ds->ds_objset);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1880 ds->ds_objset = NULL;
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1881 }
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1882
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1883 if (ds->ds_dir->dd_phys->dd_head_dataset_obj == ds->ds_object) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1884 /* Erase the link in the dir */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1885 dmu_buf_will_dirty(ds->ds_dir->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1886 ds->ds_dir->dd_phys->dd_head_dataset_obj = 0;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1887 ASSERT(ds->ds_phys->ds_snapnames_zapobj != 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1888 err = zap_destroy(mos, ds->ds_phys->ds_snapnames_zapobj, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1889 ASSERT(err == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1890 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1891 /* remove from snapshot namespace */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1892 dsl_dataset_t *ds_head;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1893 ASSERT(ds->ds_phys->ds_snapnames_zapobj == 0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1894 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1895 ds->ds_dir->dd_phys->dd_head_dataset_obj, FTAG, &ds_head));
2207 47efcb3433a7 6439370 assertion failures possible in dsl_dataset_destroy_sync() ahrens parents: 2199 diff changeset	1896 VERIFY(0 == dsl_dataset_get_snapname(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1897 #ifdef ZFS_DEBUG
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1898 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1899 uint64_t val;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	1900
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1901 err = dsl_dataset_snap_lookup(ds_head,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	1902 ds->ds_snapname, &val);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1903 ASSERT3U(err, ==, 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1904 ASSERT3U(val, ==, obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1905 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1906 #endif
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1907 err = dsl_dataset_snap_remove(ds_head, ds->ds_snapname, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1908 ASSERT(err == 0);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1909 dsl_dataset_rele(ds_head, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1910 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1911
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1912 if (ds_prev && ds->ds_prev != ds_prev)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1913 dsl_dataset_rele(ds_prev, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1914
5094 71a3e95fb9e2 PSARC 2007/342 Enhanced ZFS Pool Properties lling parents: 4967 diff changeset	1915 spa_prop_clear_bootfs(dp->dp_spa, ds->ds_object, tx);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1916 spa_history_log_internal(LOG_DS_DESTROY, dp->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1917 "dataset = %llu", ds->ds_object);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1918
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1919 if (ds->ds_phys->ds_next_clones_obj != 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1920 uint64_t count;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1921 ASSERT(0 == zap_count(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1922 ds->ds_phys->ds_next_clones_obj, &count) && count == 0);
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1923 VERIFY(0 == dmu_object_free(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1924 ds->ds_phys->ds_next_clones_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1925 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1926 if (ds->ds_phys->ds_props_obj != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1927 VERIFY(0 == zap_destroy(mos, ds->ds_phys->ds_props_obj, tx));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1928 if (ds->ds_phys->ds_userrefs_obj != 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1929 VERIFY(0 == zap_destroy(mos, ds->ds_phys->ds_userrefs_obj, tx));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1930 dsl_dir_close(ds->ds_dir, ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1931 ds->ds_dir = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1932 dsl_dataset_drain_refs(ds, tag);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1933 VERIFY(0 == dmu_object_free(mos, obj, tx));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1934
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1935 if (dsda->rm_origin) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1936 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1937 * Remove the origin of the clone we just destroyed.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1938 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1939 struct dsl_ds_destroyarg ndsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1940
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1941 ndsda.ds = dsda->rm_origin;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1942 dsl_dataset_destroy_sync(&ndsda, tag, tx);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1943 }
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1944 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1945
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1946 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1947 dsl_dataset_snapshot_reserve_space(dsl_dataset_t ds, dmu_tx_t tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1948 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1949 uint64_t asize;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1950
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1951 if (!dmu_tx_is_syncing(tx))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1952 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1953
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1954 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1955 * If there's an fs-only reservation, any blocks that might become
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1956 * owned by the snapshot dataset must be accommodated by space
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1957 * outside of the reservation.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1958 */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1959 ASSERT(ds->ds_reserved == 0 \|\| DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1960 asize = MIN(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1961 if (asize > dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE))
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1962 return (ENOSPC);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1963
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1964 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1965 * Propogate any reserved space for this snapshot to other
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1966 * snapshot checks in this sync group.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1967 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1968 if (asize > 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1969 dsl_dir_willuse_space(ds->ds_dir, asize, tx);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1970
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1971 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1972 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1973
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1974 int
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1975 dsl_dataset_snapshot_check(void arg1, void arg2, dmu_tx_t *tx)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1976 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1977 dsl_dataset_t *ds = arg1;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1978 const char *snapname = arg2;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1979 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1980 uint64_t value;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1981
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1982 /*
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1983 * We don't allow multiple snapshots of the same txg. If there
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1984 * is already one, try again.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1985 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1986 if (ds->ds_phys->ds_prev_snap_txg >= tx->tx_txg)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1987 return (EAGAIN);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1988
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1989 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1990 * Check for conflicting name snapshot name.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1991 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1992 err = dsl_dataset_snap_lookup(ds, snapname, &value);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1993 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1994 return (EEXIST);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1995 if (err != ENOENT)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1996 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1997
3978 2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	1998 /*
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	1999 * Check that the dataset's name is not too long. Name consists
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2000 * of the dataset's length + 1 for the @-sign + snapshot name's length
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2001 */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2002 if (dsl_dataset_namelen(ds) + 1 + strlen(snapname) >= MAXNAMELEN)
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2003 return (ENAMETOOLONG);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2004
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2005 err = dsl_dataset_snapshot_reserve_space(ds, tx);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2006 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2007 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2008
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2009 ds->ds_trysnap_txg = tx->tx_txg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2010 return (0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2011 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2012
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2013 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2014 dsl_dataset_snapshot_sync(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2015 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2016 dsl_dataset_t *ds = arg1;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2017 const char *snapname = arg2;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2018 dsl_pool_t *dp = ds->ds_dir->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2019 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2020 dsl_dataset_phys_t *dsphys;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2021 uint64_t dsobj, crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2022 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2023 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2024
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2025 ASSERT(RW_WRITE_HELD(&dp->dp_config_rwlock));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2026
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2027 /*
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2028 * The origin's ds_creation_txg has to be < TXG_INITIAL
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2029 */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2030 if (strcmp(snapname, ORIGIN_DIR_NAME) == 0)
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2031 crtxg = 1;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2032 else
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2033 crtxg = tx->tx_txg;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2034
928 36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	2035 dsobj = dmu_object_alloc(mos, DMU_OT_DSL_DATASET, 0,
36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	2036 DMU_OT_DSL_DATASET, sizeof (dsl_dataset_phys_t), tx);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2037 VERIFY(0 == dmu_bonus_hold(mos, dsobj, FTAG, &dbuf));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2038 dmu_buf_will_dirty(dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2039 dsphys = dbuf->db_data;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2040 bzero(dsphys, sizeof (dsl_dataset_phys_t));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2041 dsphys->ds_dir_obj = ds->ds_dir->dd_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2042 dsphys->ds_fsid_guid = unique_create();
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2043 (void) random_get_pseudo_bytes((void*)&dsphys->ds_guid,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2044 sizeof (dsphys->ds_guid));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2045 dsphys->ds_prev_snap_obj = ds->ds_phys->ds_prev_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2046 dsphys->ds_prev_snap_txg = ds->ds_phys->ds_prev_snap_txg;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2047 dsphys->ds_next_snap_obj = ds->ds_object;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2048 dsphys->ds_num_children = 1;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2049 dsphys->ds_creation_time = gethrestime_sec();
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2050 dsphys->ds_creation_txg = crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2051 dsphys->ds_deadlist_obj = ds->ds_phys->ds_deadlist_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2052 dsphys->ds_used_bytes = ds->ds_phys->ds_used_bytes;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2053 dsphys->ds_compressed_bytes = ds->ds_phys->ds_compressed_bytes;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2054 dsphys->ds_uncompressed_bytes = ds->ds_phys->ds_uncompressed_bytes;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2055 dsphys->ds_flags = ds->ds_phys->ds_flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2056 dsphys->ds_bp = ds->ds_phys->ds_bp;
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2057 dmu_buf_rele(dbuf, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2058
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2059 ASSERT3U(ds->ds_prev != 0, ==, ds->ds_phys->ds_prev_snap_obj != 0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2060 if (ds->ds_prev) {
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2061 uint64_t next_clones_obj =
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2062 ds->ds_prev->ds_phys->ds_next_clones_obj;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2063 ASSERT(ds->ds_prev->ds_phys->ds_next_snap_obj ==
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2064 ds->ds_object \|\|
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2065 ds->ds_prev->ds_phys->ds_num_children > 1);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2066 if (ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object) {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2067 dmu_buf_will_dirty(ds->ds_prev->ds_dbuf, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2068 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, ==,
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2069 ds->ds_prev->ds_phys->ds_creation_txg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2070 ds->ds_prev->ds_phys->ds_next_snap_obj = dsobj;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2071 } else if (next_clones_obj != 0) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2072 remove_from_next_clones(ds->ds_prev,
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2073 dsphys->ds_next_snap_obj, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2074 VERIFY3U(0, ==, zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2075 next_clones_obj, dsobj, tx));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2076 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2077 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2078
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2079 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2080 * If we have a reference-reservation on this dataset, we will
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2081 * need to increase the amount of refreservation being charged
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2082 * since our unique space is going to zero.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2083 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2084 if (ds->ds_reserved) {
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2085 int64_t delta;
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2086 ASSERT(DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2087 delta = MIN(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2088 dsl_dir_diduse_space(ds->ds_dir, DD_USED_REFRSRV,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2089 delta, 0, 0, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2090 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2091
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2092 dmu_buf_will_dirty(ds->ds_dbuf, tx);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2093 zfs_dbgmsg("taking snapshot %s@%s/%llu; newkey=%llu",
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2094 ds->ds_dir->dd_myname, snapname, dsobj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2095 ds->ds_phys->ds_prev_snap_txg);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2096 ds->ds_phys->ds_deadlist_obj = dsl_deadlist_clone(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2097 UINT64_MAX, ds->ds_phys->ds_prev_snap_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2098 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2099 dsl_deadlist_open(&ds->ds_deadlist, mos, ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2100 dsl_deadlist_add_key(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2101 ds->ds_phys->ds_prev_snap_txg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2102
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	2103 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, <, tx->tx_txg);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2104 ds->ds_phys->ds_prev_snap_obj = dsobj;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2105 ds->ds_phys->ds_prev_snap_txg = crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2106 ds->ds_phys->ds_unique_bytes = 0;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2107 if (spa_version(dp->dp_spa) >= SPA_VERSION_UNIQUE_ACCURATE)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2108 ds->ds_phys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2109
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2110 err = zap_add(mos, ds->ds_phys->ds_snapnames_zapobj,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2111 snapname, 8, 1, &dsobj, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2112 ASSERT(err == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2113
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2114 if (ds->ds_prev)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2115 dsl_dataset_drop_ref(ds->ds_prev, ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2116 VERIFY(0 == dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2117 ds->ds_phys->ds_prev_snap_obj, ds, &ds->ds_prev));
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2118
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2119 dsl_scan_ds_snapshotted(ds, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2120
10373 bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	2121 dsl_dir_snap_cmtime_update(ds->ds_dir);
bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	2122
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2123 spa_history_log_internal(LOG_DS_SNAPSHOT, dp->dp_spa, tx,
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	2124 "dataset = %llu", dsobj);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2125 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2126
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2127 void
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	2128 dsl_dataset_sync(dsl_dataset_t ds, zio_t zio, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2129 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2130 ASSERT(dmu_tx_is_syncing(tx));
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2131 ASSERT(ds->ds_objset != NULL);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2132 ASSERT(ds->ds_phys->ds_next_snap_obj == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2133
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2134 /*
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2135 * in case we had to change ds_fsid_guid when we opened it,
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2136 * sync it out now.
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2137 */
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2138 dmu_buf_will_dirty(ds->ds_dbuf, tx);
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2139 ds->ds_phys->ds_fsid_guid = ds->ds_fsid_guid;
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2140
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2141 dsl_dir_dirty(ds->ds_dir, tx);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2142 dmu_objset_sync(ds->ds_objset, zio, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2143 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2144
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2145 void
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2146 dsl_dataset_stats(dsl_dataset_t ds, nvlist_t nv)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2147 {
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2148 uint64_t refd, avail, uobjs, aobjs;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2149
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2150 dsl_dir_stats(ds->ds_dir, nv);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2151
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2152 dsl_dataset_space(ds, &refd, &avail, &uobjs, &aobjs);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2153 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_AVAILABLE, avail);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2154 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFERENCED, refd);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2155
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2156 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_CREATION,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2157 ds->ds_phys->ds_creation_time);
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2158 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_CREATETXG,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2159 ds->ds_phys->ds_creation_txg);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2160 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFQUOTA,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2161 ds->ds_quota);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2162 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFRESERVATION,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2163 ds->ds_reserved);
6643 3a34b0dbb107 6625086 changing cachefile doesn't remove old cache on last user eschrock parents: 6502 diff changeset	2164 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_GUID,
3a34b0dbb107 6625086 changing cachefile doesn't remove old cache on last user eschrock parents: 6502 diff changeset	2165 ds->ds_phys->ds_guid);
10575 2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2166 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_UNIQUE,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2167 ds->ds_phys->ds_unique_bytes);
10575 2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2168 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_OBJSETID,
2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2169 ds->ds_object);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	2170 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_USERREFS,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	2171 ds->ds_userrefs);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	2172 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_DEFER_DESTROY,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	2173 DS_IS_DEFER_DESTROY(ds) ? 1 : 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2174
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2175 if (ds->ds_phys->ds_next_snap_obj) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2176 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2177 * This is a snapshot; override the dd's space used with
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2178 * our unique space and compression ratio.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2179 */
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2180 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_USED,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2181 ds->ds_phys->ds_unique_bytes);
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2182 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_COMPRESSRATIO,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2183 ds->ds_phys->ds_compressed_bytes == 0 ? 100 :
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2184 (ds->ds_phys->ds_uncompressed_bytes * 100 /
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2185 ds->ds_phys->ds_compressed_bytes));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2186 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2187 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2188
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2189 void
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2190 dsl_dataset_fast_stat(dsl_dataset_t ds, dmu_objset_stats_t stat)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2191 {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2192 stat->dds_creation_txg = ds->ds_phys->ds_creation_txg;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2193 stat->dds_inconsistent = ds->ds_phys->ds_flags & DS_FLAG_INCONSISTENT;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2194 stat->dds_guid = ds->ds_phys->ds_guid;
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2195 if (ds->ds_phys->ds_next_snap_obj) {
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2196 stat->dds_is_snapshot = B_TRUE;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2197 stat->dds_num_clones = ds->ds_phys->ds_num_children - 1;
8228 51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2198 } else {
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2199 stat->dds_is_snapshot = B_FALSE;
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2200 stat->dds_num_clones = 0;
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2201 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2202
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2203 /* clone origin is really a dsl_dir thing... */
5446 51fbc14b301d 6421210 zfs rollback without unmounting ahrens parents: 5383 diff changeset	2204 rw_enter(&ds->ds_dir->dd_pool->dp_config_rwlock, RW_READER);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2205 if (dsl_dir_is_clone(ds->ds_dir)) {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2206 dsl_dataset_t *ods;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2207
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2208 VERIFY(0 == dsl_dataset_get_ref(ds->ds_dir->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2209 ds->ds_dir->dd_phys->dd_origin_obj, FTAG, &ods));
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2210 dsl_dataset_name(ods, stat->dds_origin);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2211 dsl_dataset_drop_ref(ods, FTAG);
8228 51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2212 } else {
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2213 stat->dds_origin[0] = '\0';
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2214 }
5446 51fbc14b301d 6421210 zfs rollback without unmounting ahrens parents: 5383 diff changeset	2215 rw_exit(&ds->ds_dir->dd_pool->dp_config_rwlock);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2216 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2217
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2218 uint64_t
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2219 dsl_dataset_fsid_guid(dsl_dataset_t *ds)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2220 {
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2221 return (ds->ds_fsid_guid);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2222 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2223
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2224 void
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2225 dsl_dataset_space(dsl_dataset_t *ds,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2226 uint64_t refdbytesp, uint64_t availbytesp,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2227 uint64_t usedobjsp, uint64_t availobjsp)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2228 {
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2229 *refdbytesp = ds->ds_phys->ds_used_bytes;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2230 *availbytesp = dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2231 if (ds->ds_reserved > ds->ds_phys->ds_unique_bytes)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2232 *availbytesp += ds->ds_reserved - ds->ds_phys->ds_unique_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2233 if (ds->ds_quota != 0) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2234 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2235 * Adjust available bytes according to refquota
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2236 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2237 if (*refdbytesp < ds->ds_quota)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2238 availbytesp = MIN(availbytesp,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2239 ds->ds_quota - *refdbytesp);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2240 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2241 *availbytesp = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2242 }
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2243 *usedobjsp = ds->ds_phys->ds_bp.blk_fill;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2244 availobjsp = DN_MAX_OBJECT - usedobjsp;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2245 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2246
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2247 boolean_t
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2248 dsl_dataset_modified_since_lastsnap(dsl_dataset_t *ds)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2249 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2250 dsl_pool_t *dp = ds->ds_dir->dd_pool;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2251
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2252 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock) \|\|
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2253 dsl_pool_sync_context(dp));
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2254 if (ds->ds_prev == NULL)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2255 return (B_FALSE);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2256 if (ds->ds_phys->ds_bp.blk_birth >
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2257 ds->ds_prev->ds_phys->ds_creation_txg) {
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2258 objset_t os, os_prev;
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2259 /*
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2260 * It may be that only the ZIL differs, because it was
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2261 * reset in the head. Don't count that as being
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2262 * modified.
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2263 */
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2264 if (dmu_objset_from_ds(ds, &os) != 0)
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2265 return (B_TRUE);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2266 if (dmu_objset_from_ds(ds->ds_prev, &os_prev) != 0)
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2267 return (B_TRUE);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2268 return (bcmp(&os->os_phys->os_meta_dnode,
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2269 &os_prev->os_phys->os_meta_dnode,
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2270 sizeof (os->os_phys->os_meta_dnode)) != 0);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2271 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2272 return (B_FALSE);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2273 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2274
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2275 /* ARGSUSED */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2276 static int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2277 dsl_dataset_snapshot_rename_check(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2278 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2279 dsl_dataset_t *ds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2280 char *newsnapname = arg2;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2281 dsl_dir_t *dd = ds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2282 dsl_dataset_t *hds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2283 uint64_t val;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2284 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2285
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2286 err = dsl_dataset_hold_obj(dd->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2287 dd->dd_phys->dd_head_dataset_obj, FTAG, &hds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2288 if (err)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2289 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2290
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2291 /* new name better not be in use */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2292 err = dsl_dataset_snap_lookup(hds, newsnapname, &val);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2293 dsl_dataset_rele(hds, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2294
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2295 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2296 err = EEXIST;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2297 else if (err == ENOENT)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2298 err = 0;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2299
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2300 /* dataset name + 1 for the "@" + the new snapshot name must fit */
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2301 if (dsl_dir_namelen(ds->ds_dir) + 1 + strlen(newsnapname) >= MAXNAMELEN)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2302 err = ENAMETOOLONG;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2303
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2304 return (err);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2305 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2306
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2307 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2308 dsl_dataset_snapshot_rename_sync(void arg1, void arg2, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2309 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2310 dsl_dataset_t *ds = arg1;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2311 const char *newsnapname = arg2;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2312 dsl_dir_t *dd = ds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2313 objset_t *mos = dd->dd_pool->dp_meta_objset;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2314 dsl_dataset_t *hds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2315 int err;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2316
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2317 ASSERT(ds->ds_phys->ds_next_snap_obj != 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2318
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2319 VERIFY(0 == dsl_dataset_hold_obj(dd->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2320 dd->dd_phys->dd_head_dataset_obj, FTAG, &hds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2321
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2322 VERIFY(0 == dsl_dataset_get_snapname(ds));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2323 err = dsl_dataset_snap_remove(hds, ds->ds_snapname, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2324 ASSERT3U(err, ==, 0);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2325 mutex_enter(&ds->ds_lock);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2326 (void) strcpy(ds->ds_snapname, newsnapname);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2327 mutex_exit(&ds->ds_lock);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2328 err = zap_add(mos, hds->ds_phys->ds_snapnames_zapobj,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2329 ds->ds_snapname, 8, 1, &ds->ds_object, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2330 ASSERT3U(err, ==, 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2331
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2332 spa_history_log_internal(LOG_DS_RENAME, dd->dd_pool->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2333 "dataset = %llu", ds->ds_object);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2334 dsl_dataset_rele(hds, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2335 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2336
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2337 struct renamesnaparg {
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2338 dsl_sync_task_group_t *dstg;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2339 char failed[MAXPATHLEN];
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2340 char *oldsnap;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2341 char *newsnap;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2342 };
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2343
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2344 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2345 dsl_snapshot_rename_one(const char name, void arg)
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2346 {
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2347 struct renamesnaparg *ra = arg;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2348 dsl_dataset_t *ds = NULL;
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2349 char *snapname;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2350 int err;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2351
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2352 snapname = kmem_asprintf("%s@%s", name, ra->oldsnap);
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2353 (void) strlcpy(ra->failed, snapname, sizeof (ra->failed));
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2354
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2355 /*
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2356 * For recursive snapshot renames the parent won't be changing
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2357 * so we just pass name for both the to/from argument.
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2358 */
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2359 err = zfs_secpolicy_rename_perms(snapname, snapname, CRED());
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2360 if (err != 0) {
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2361 strfree(snapname);
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2362 return (err == ENOENT ? 0 : err);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2363 }
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2364
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2365 #ifdef _KERNEL
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2366 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2367 * For all filesystems undergoing rename, we'll need to unmount it.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2368 */
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2369 (void) zfs_unmount_snap(snapname, NULL);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2370 #endif
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2371 err = dsl_dataset_hold(snapname, ra->dstg, &ds);
11609 3b5da7ebb54d 6920880 assertion failure in dbuf_write_ready() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11546 diff changeset	2372 strfree(snapname);
3b5da7ebb54d 6920880 assertion failure in dbuf_write_ready() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11546 diff changeset	2373 if (err != 0)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2374 return (err == ENOENT ? 0 : err);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2375
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2376 dsl_sync_task_create(ra->dstg, dsl_dataset_snapshot_rename_check,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2377 dsl_dataset_snapshot_rename_sync, ds, ra->newsnap, 0);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2378
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2379 return (0);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2380 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2381
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2382 static int
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2383 dsl_recursive_rename(char oldname, const char newname)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2384 {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2385 int err;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2386 struct renamesnaparg *ra;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2387 dsl_sync_task_t *dst;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2388 spa_t *spa;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2389 char cp, fsname = spa_strdup(oldname);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2390 int len = strlen(oldname) + 1;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2391
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2392 /* truncate the snapshot name to get the fsname */
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2393 cp = strchr(fsname, '@');
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2394 *cp = '\0';
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2395
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	2396 err = spa_open(fsname, &spa, FTAG);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2397 if (err) {
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2398 kmem_free(fsname, len);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2399 return (err);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2400 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2401 ra = kmem_alloc(sizeof (struct renamesnaparg), KM_SLEEP);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2402 ra->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2403
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2404 ra->oldsnap = strchr(oldname, '@') + 1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2405 ra->newsnap = strchr(newname, '@') + 1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2406 *ra->failed = '\0';
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2407
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2408 err = dmu_objset_find(fsname, dsl_snapshot_rename_one, ra,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2409 DS_FIND_CHILDREN);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2410 kmem_free(fsname, len);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2411
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2412 if (err == 0) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2413 err = dsl_sync_task_group_wait(ra->dstg);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2414 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2415
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2416 for (dst = list_head(&ra->dstg->dstg_tasks); dst;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2417 dst = list_next(&ra->dstg->dstg_tasks, dst)) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2418 dsl_dataset_t *ds = dst->dst_arg1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2419 if (dst->dst_err) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2420 dsl_dir_name(ds->ds_dir, ra->failed);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2421 (void) strlcat(ra->failed, "@", sizeof (ra->failed));
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2422 (void) strlcat(ra->failed, ra->newsnap,
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2423 sizeof (ra->failed));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2424 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2425 dsl_dataset_rele(ds, ra->dstg);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2426 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2427
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2428 if (err)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2429 (void) strlcpy(oldname, ra->failed, sizeof (ra->failed));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2430
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2431 dsl_sync_task_group_destroy(ra->dstg);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2432 kmem_free(ra, sizeof (struct renamesnaparg));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2433 spa_close(spa, FTAG);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2434 return (err);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2435 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2436
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2437 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2438 dsl_valid_rename(const char oldname, void arg)
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2439 {
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2440 int delta = (int )arg;
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2441
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2442 if (strlen(oldname) + delta >= MAXNAMELEN)
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2443 return (ENAMETOOLONG);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2444
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2445 return (0);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2446 }
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2447
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2448 #pragma weak dmu_objset_rename = dsl_dataset_rename
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2449 int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2450 dsl_dataset_rename(char oldname, const char newname, boolean_t recursive)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2451 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2452 dsl_dir_t *dd;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2453 dsl_dataset_t *ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2454 const char *tail;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2455 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2456
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2457 err = dsl_dir_open(oldname, FTAG, &dd, &tail);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2458 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2459 return (err);
11701 6f890435df16 6915532 snapshot related activity causes akd to hang Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 11609 diff changeset	2460
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2461 if (tail == NULL) {
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2462 int delta = strlen(newname) - strlen(oldname);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2463
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2464 /* if we're growing, validate child name lengths */
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2465 if (delta > 0)
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2466 err = dmu_objset_find(oldname, dsl_valid_rename,
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2467 &delta, DS_FIND_CHILDREN \| DS_FIND_SNAPSHOTS);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2468
11823 c756cd80d532 6930022 zfs rename of non-shapshot is slower than necessary Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11701 diff changeset	2469 if (err == 0)
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2470 err = dsl_dir_rename(dd, newname);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2471 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2472 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2473 }
11701 6f890435df16 6915532 snapshot related activity causes akd to hang Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 11609 diff changeset	2474
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2475 if (tail[0] != '@') {
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2476 /* the name ended in a nonexistent component */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2477 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2478 return (ENOENT);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2479 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2480
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2481 dsl_dir_close(dd, FTAG);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2482
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2483 /* new name must be snapshot in same filesystem */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2484 tail = strchr(newname, '@');
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2485 if (tail == NULL)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2486 return (EINVAL);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2487 tail++;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2488 if (strncmp(oldname, newname, tail - newname) != 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2489 return (EXDEV);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2490
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2491 if (recursive) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2492 err = dsl_recursive_rename(oldname, newname);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2493 } else {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2494 err = dsl_dataset_hold(oldname, FTAG, &ds);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2495 if (err)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2496 return (err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2497
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2498 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2499 dsl_dataset_snapshot_rename_check,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2500 dsl_dataset_snapshot_rename_sync, ds, (char *)tail, 1);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2501
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2502 dsl_dataset_rele(ds, FTAG);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2503 }
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2504
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2505 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2506 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2507
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2508 struct promotenode {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2509 list_node_t link;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2510 dsl_dataset_t *ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2511 };
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2512
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2513 struct promotearg {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2514 list_t shared_snaps, origin_snaps, clone_snaps;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2515 dsl_dataset_t *origin_origin;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2516 uint64_t used, comp, uncomp, unique, cloneusedsnap, originusedsnap;
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2517 char *err_ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2518 };
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2519
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2520 static int snaplist_space(list_t l, uint64_t mintxg, uint64_t spacep);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2521 static boolean_t snaplist_unstable(list_t *l);
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2522
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2523 static int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2524 dsl_dataset_promote_check(void arg1, void arg2, dmu_tx_t *tx)
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2525 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2526 dsl_dataset_t *hds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2527 struct promotearg *pa = arg2;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2528 struct promotenode *snap = list_head(&pa->shared_snaps);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2529 dsl_dataset_t *origin_ds = snap->ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2530 int err;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2531 uint64_t unused;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2532
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2533 /* Check that it is a real clone */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2534 if (!dsl_dir_is_clone(hds->ds_dir))
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2535 return (EINVAL);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2536
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2537 /* Since this is so expensive, don't do the preliminary check */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2538 if (!dmu_tx_is_syncing(tx))
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2539 return (0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2540
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2541 if (hds->ds_phys->ds_flags & DS_FLAG_NOPROMOTE)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2542 return (EXDEV);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2543
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2544 /* compute origin's new unique space */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2545 snap = list_tail(&pa->clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2546 ASSERT3U(snap->ds->ds_phys->ds_prev_snap_obj, ==, origin_ds->ds_object);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2547 dsl_deadlist_space_range(&snap->ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2548 origin_ds->ds_phys->ds_prev_snap_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2549 &pa->unique, &unused, &unused);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2550
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2551 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2552 * Walk the snapshots that we are moving
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2553 *
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2554 * Compute space to transfer. Consider the incremental changes
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2555 * to used for each snapshot:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2556 * (my used) = (prev's used) + (blocks born) - (blocks killed)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2557 * So each snapshot gave birth to:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2558 * (blocks born) = (my used) - (prev's used) + (blocks killed)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2559 * So a sequence would look like:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2560 * (uN - u(N-1) + kN) + ... + (u1 - u0 + k1) + (u0 - 0 + k0)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2561 * Which simplifies to:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2562 * uN + kN + kN-1 + ... + k1 + k0
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2563 * Note however, if we stop before we reach the ORIGIN we get:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2564 * uN + kN + kN-1 + ... + kM - uM-1
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2565 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2566 pa->used = origin_ds->ds_phys->ds_used_bytes;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2567 pa->comp = origin_ds->ds_phys->ds_compressed_bytes;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2568 pa->uncomp = origin_ds->ds_phys->ds_uncompressed_bytes;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2569 for (snap = list_head(&pa->shared_snaps); snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2570 snap = list_next(&pa->shared_snaps, snap)) {
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2571 uint64_t val, dlused, dlcomp, dluncomp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2572 dsl_dataset_t *ds = snap->ds;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2573
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2574 /* Check that the snapshot name does not conflict */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2575 VERIFY(0 == dsl_dataset_get_snapname(ds));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2576 err = dsl_dataset_snap_lookup(hds, ds->ds_snapname, &val);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2577 if (err == 0) {
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2578 err = EEXIST;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2579 goto out;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2580 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2581 if (err != ENOENT)
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2582 goto out;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2583
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2584 /* The very first snapshot does not have a deadlist */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2585 if (ds->ds_phys->ds_prev_snap_obj == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2586 continue;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2587
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2588 dsl_deadlist_space(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2589 &dlused, &dlcomp, &dluncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2590 pa->used += dlused;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2591 pa->comp += dlcomp;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2592 pa->uncomp += dluncomp;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2593 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2594
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2595 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2596 * If we are a clone of a clone then we never reached ORIGIN,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2597 * so we need to subtract out the clone origin's used space.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2598 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2599 if (pa->origin_origin) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2600 pa->used -= pa->origin_origin->ds_phys->ds_used_bytes;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2601 pa->comp -= pa->origin_origin->ds_phys->ds_compressed_bytes;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2602 pa->uncomp -= pa->origin_origin->ds_phys->ds_uncompressed_bytes;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2603 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2604
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2605 /* Check that there is enough space here */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2606 err = dsl_dir_transfer_possible(origin_ds->ds_dir, hds->ds_dir,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2607 pa->used);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2608 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2609 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2610
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2611 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2612 * Compute the amounts of space that will be used by snapshots
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2613 * after the promotion (for both origin and clone). For each,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2614 * it is the amount of space that will be on all of their
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2615 * deadlists (that was not born before their new origin).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2616 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2617 if (hds->ds_dir->dd_phys->dd_flags & DD_FLAG_USED_BREAKDOWN) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2618 uint64_t space;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2619
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2620 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2621 * Note, typically this will not be a clone of a clone,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2622 * so dd_origin_txg will be < TXG_INITIAL, so
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2623 * these snaplist_space() -> dsl_deadlist_space_range()
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2624 * calls will be fast because they do not have to
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2625 * iterate over all bps.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2626 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2627 snap = list_head(&pa->origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2628 err = snaplist_space(&pa->shared_snaps,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2629 snap->ds->ds_dir->dd_origin_txg, &pa->cloneusedsnap);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2630 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2631 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2632
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2633 err = snaplist_space(&pa->clone_snaps,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2634 snap->ds->ds_dir->dd_origin_txg, &space);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2635 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2636 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2637 pa->cloneusedsnap += space;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2638 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2639 if (origin_ds->ds_dir->dd_phys->dd_flags & DD_FLAG_USED_BREAKDOWN) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2640 err = snaplist_space(&pa->origin_snaps,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2641 origin_ds->ds_phys->ds_creation_txg, &pa->originusedsnap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2642 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2643 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2644 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2645
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2646 return (0);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2647 out:
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2648 pa->err_ds = snap->ds->ds_snapname;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2649 return (err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2650 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2651
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2652 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2653 dsl_dataset_promote_sync(void arg1, void arg2, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2654 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2655 dsl_dataset_t *hds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2656 struct promotearg *pa = arg2;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2657 struct promotenode *snap = list_head(&pa->shared_snaps);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2658 dsl_dataset_t *origin_ds = snap->ds;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2659 dsl_dataset_t *origin_head;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2660 dsl_dir_t *dd = hds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2661 dsl_pool_t *dp = hds->ds_dir->dd_pool;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2662 dsl_dir_t *odd = NULL;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2663 uint64_t oldnext_obj;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2664 int64_t delta;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2665
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2666 ASSERT(0 == (hds->ds_phys->ds_flags & DS_FLAG_NOPROMOTE));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2667
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2668 snap = list_head(&pa->origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2669 origin_head = snap->ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2670
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2671 /*
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2672 * We need to explicitly open odd, since origin_ds's dd will be
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2673 * changing.
694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2674 */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2675 VERIFY(0 == dsl_dir_open_obj(dp, origin_ds->ds_dir->dd_object,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2676 NULL, FTAG, &odd));
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2677
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2678 /* change origin's next snap */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2679 dmu_buf_will_dirty(origin_ds->ds_dbuf, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2680 oldnext_obj = origin_ds->ds_phys->ds_next_snap_obj;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2681 snap = list_tail(&pa->clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2682 ASSERT3U(snap->ds->ds_phys->ds_prev_snap_obj, ==, origin_ds->ds_object);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2683 origin_ds->ds_phys->ds_next_snap_obj = snap->ds->ds_object;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2684
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2685 /* change the origin's next clone */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2686 if (origin_ds->ds_phys->ds_next_clones_obj) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2687 remove_from_next_clones(origin_ds, snap->ds->ds_object, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2688 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2689 origin_ds->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2690 oldnext_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2691 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2692
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2693 /* change origin */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2694 dmu_buf_will_dirty(dd->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2695 ASSERT3U(dd->dd_phys->dd_origin_obj, ==, origin_ds->ds_object);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2696 dd->dd_phys->dd_origin_obj = odd->dd_phys->dd_origin_obj;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2697 dd->dd_origin_txg = origin_head->ds_dir->dd_origin_txg;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2698 dmu_buf_will_dirty(odd->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2699 odd->dd_phys->dd_origin_obj = origin_ds->ds_object;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2700 origin_head->ds_dir->dd_origin_txg =
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2701 origin_ds->ds_phys->ds_creation_txg;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2702
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2703 /* change dd_clone entries */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2704 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2705 VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2706 odd->dd_phys->dd_clones, hds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2707 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2708 pa->origin_origin->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2709 hds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2710
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2711 VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2712 pa->origin_origin->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2713 origin_head->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2714 if (dd->dd_phys->dd_clones == 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2715 dd->dd_phys->dd_clones = zap_create(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2716 DMU_OT_DSL_CLONES, DMU_OT_NONE, 0, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2717 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2718 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2719 dd->dd_phys->dd_clones, origin_head->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2720
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2721 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2722
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2723 /* move snapshots to this dir */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2724 for (snap = list_head(&pa->shared_snaps); snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2725 snap = list_next(&pa->shared_snaps, snap)) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2726 dsl_dataset_t *ds = snap->ds;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2727
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	2728 /* unregister props as dsl_dir is changing */
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2729 if (ds->ds_objset) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2730 dmu_objset_evict(ds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2731 ds->ds_objset = NULL;
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	2732 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2733 /* move snap name entry */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2734 VERIFY(0 == dsl_dataset_get_snapname(ds));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2735 VERIFY(0 == dsl_dataset_snap_remove(origin_head,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2736 ds->ds_snapname, tx));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2737 VERIFY(0 == zap_add(dp->dp_meta_objset,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2738 hds->ds_phys->ds_snapnames_zapobj, ds->ds_snapname,
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2739 8, 1, &ds->ds_object, tx));
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2740
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2741 /* change containing dsl_dir */
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2742 dmu_buf_will_dirty(ds->ds_dbuf, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2743 ASSERT3U(ds->ds_phys->ds_dir_obj, ==, odd->dd_object);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2744 ds->ds_phys->ds_dir_obj = dd->dd_object;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2745 ASSERT3P(ds->ds_dir, ==, odd);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2746 dsl_dir_close(ds->ds_dir, ds);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2747 VERIFY(0 == dsl_dir_open_obj(dp, dd->dd_object,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2748 NULL, ds, &ds->ds_dir));
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2749
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2750 /* move any clone references */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2751 if (ds->ds_phys->ds_next_clones_obj &&
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2752 spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2753 zap_cursor_t zc;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2754 zap_attribute_t za;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2755
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2756 for (zap_cursor_init(&zc, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2757 ds->ds_phys->ds_next_clones_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2758 zap_cursor_retrieve(&zc, &za) == 0;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2759 zap_cursor_advance(&zc)) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2760 dsl_dataset_t *cnds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2761 uint64_t o;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2762
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2763 if (za.za_first_integer == oldnext_obj) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2764 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2765 * We've already moved the
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2766 * origin's reference.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2767 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2768 continue;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2769 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2770
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2771 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2772 za.za_first_integer, FTAG, &cnds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2773 o = cnds->ds_dir->dd_phys->dd_head_dataset_obj;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2774
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2775 VERIFY3U(zap_remove_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2776 odd->dd_phys->dd_clones, o, tx), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2777 VERIFY3U(zap_add_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2778 dd->dd_phys->dd_clones, o, tx), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2779 dsl_dataset_rele(cnds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2780 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2781 zap_cursor_fini(&zc);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2782 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2783
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2784 ASSERT3U(dsl_prop_numcb(ds), ==, 0);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2785 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2786
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2787 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2788 * Change space accounting.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2789 * Note, pa->*usedsnap and dd_used_breakdown[SNAP] will either
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2790 * both be valid, or both be 0 (resulting in delta == 0). This
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2791 * is true for each of {clone,origin} independently.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2792 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2793
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2794 delta = pa->cloneusedsnap -
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2795 dd->dd_phys->dd_used_breakdown[DD_USED_SNAP];
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2796 ASSERT3S(delta, >=, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2797 ASSERT3U(pa->used, >=, delta);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2798 dsl_dir_diduse_space(dd, DD_USED_SNAP, delta, 0, 0, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2799 dsl_dir_diduse_space(dd, DD_USED_HEAD,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2800 pa->used - delta, pa->comp, pa->uncomp, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2801
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2802 delta = pa->originusedsnap -
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2803 odd->dd_phys->dd_used_breakdown[DD_USED_SNAP];
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2804 ASSERT3S(delta, <=, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2805 ASSERT3U(pa->used, >=, -delta);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2806 dsl_dir_diduse_space(odd, DD_USED_SNAP, delta, 0, 0, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2807 dsl_dir_diduse_space(odd, DD_USED_HEAD,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2808 -pa->used - delta, -pa->comp, -pa->uncomp, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2809
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2810 origin_ds->ds_phys->ds_unique_bytes = pa->unique;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2811
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2812 /* log history record */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2813 spa_history_log_internal(LOG_DS_PROMOTE, dd->dd_pool->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2814 "dataset = %llu", hds->ds_object);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2815
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2816 dsl_dir_close(odd, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2817 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2818
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2819 static char *snaplist_tag = "snaplist";
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2820 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2821 * Make a list of dsl_dataset_t's for the snapshots between first_obj
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2822 * (exclusive) and last_obj (inclusive). The list will be in reverse
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2823 * order (last_obj will be the list_head()). If first_obj == 0, do all
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2824 * snapshots back to this dataset's origin.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2825 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2826 static int
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2827 snaplist_make(dsl_pool_t *dp, boolean_t own,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2828 uint64_t first_obj, uint64_t last_obj, list_t *l)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2829 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2830 uint64_t obj = last_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2831
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2832 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2833
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2834 list_create(l, sizeof (struct promotenode),
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2835 offsetof(struct promotenode, link));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2836
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2837 while (obj != first_obj) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2838 dsl_dataset_t *ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2839 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2840 int err;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2841
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2842 if (own) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2843 err = dsl_dataset_own_obj(dp, obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2844 0, snaplist_tag, &ds);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2845 if (err == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2846 dsl_dataset_make_exclusive(ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2847 } else {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2848 err = dsl_dataset_hold_obj(dp, obj, snaplist_tag, &ds);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2849 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2850 if (err == ENOENT) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2851 /* lost race with snapshot destroy */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2852 struct promotenode *last = list_tail(l);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2853 ASSERT(obj != last->ds->ds_phys->ds_prev_snap_obj);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2854 obj = last->ds->ds_phys->ds_prev_snap_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2855 continue;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2856 } else if (err) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2857 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2858 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2859
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2860 if (first_obj == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2861 first_obj = ds->ds_dir->dd_phys->dd_origin_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2862
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2863 snap = kmem_alloc(sizeof (struct promotenode), KM_SLEEP);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2864 snap->ds = ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2865 list_insert_tail(l, snap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2866 obj = ds->ds_phys->ds_prev_snap_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2867 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2868
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2869 return (0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2870 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2871
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2872 static int
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2873 snaplist_space(list_t l, uint64_t mintxg, uint64_t spacep)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2874 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2875 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2876
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2877 *spacep = 0;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2878 for (snap = list_head(l); snap; snap = list_next(l, snap)) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2879 uint64_t used, comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2880 dsl_deadlist_space_range(&snap->ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2881 mintxg, UINT64_MAX, &used, &comp, &uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2882 *spacep += used;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2883 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2884 return (0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2885 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2886
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2887 static void
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2888 snaplist_destroy(list_t *l, boolean_t own)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2889 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2890 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2891
8779 f164e0e90508 6784924 panic while ludelete (zfs destroy) Mark J Musante <Mark.Musante@Sun.COM> parents: 8746 diff changeset	2892 if (!l \|\| !list_link_active(&l->list_head))
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2893 return;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2894
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2895 while ((snap = list_tail(l)) != NULL) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2896 list_remove(l, snap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2897 if (own)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2898 dsl_dataset_disown(snap->ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2899 else
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2900 dsl_dataset_rele(snap->ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2901 kmem_free(snap, sizeof (struct promotenode));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2902 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2903 list_destroy(l);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2904 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2905
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2906 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2907 * Promote a clone. Nomenclature note:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2908 * "clone" or "cds": the original clone which is being promoted
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2909 * "origin" or "ods": the snapshot which is originally clone's origin
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2910 * "origin head" or "ohds": the dataset which is the head
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2911 * (filesystem/volume) for the origin
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2912 * "origin origin": the origin of the origin's filesystem (typically
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2913 * NULL, indicating that the clone is not a clone of a clone).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2914 */
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2915 int
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2916 dsl_dataset_promote(const char name, char conflsnap)
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2917 {
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2918 dsl_dataset_t *ds;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2919 dsl_dir_t *dd;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2920 dsl_pool_t *dp;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2921 dmu_object_info_t doi;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2922 struct promotearg pa = { 0 };
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2923 struct promotenode *snap;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2924 int err;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2925
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2926 err = dsl_dataset_hold(name, FTAG, &ds);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2927 if (err)
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2928 return (err);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2929 dd = ds->ds_dir;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2930 dp = dd->dd_pool;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2931
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2932 err = dmu_object_info(dp->dp_meta_objset,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2933 ds->ds_phys->ds_snapnames_zapobj, &doi);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2934 if (err) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2935 dsl_dataset_rele(ds, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2936 return (err);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2937 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2938
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2939 if (dsl_dataset_is_snapshot(ds) \|\| dd->dd_phys->dd_origin_obj == 0) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2940 dsl_dataset_rele(ds, FTAG);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2941 return (EINVAL);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2942 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2943
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2944 /*
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2945 * We are going to inherit all the snapshots taken before our
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2946 * origin (i.e., our new origin will be our parent's origin).
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2947 * Take ownership of them so that we can rename them into our
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2948 * namespace.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2949 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2950 rw_enter(&dp->dp_config_rwlock, RW_READER);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2951
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2952 err = snaplist_make(dp, B_TRUE, 0, dd->dd_phys->dd_origin_obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2953 &pa.shared_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2954 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2955 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2956
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2957 err = snaplist_make(dp, B_FALSE, 0, ds->ds_object, &pa.clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2958 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2959 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2960
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2961 snap = list_head(&pa.shared_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2962 ASSERT3U(snap->ds->ds_object, ==, dd->dd_phys->dd_origin_obj);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2963 err = snaplist_make(dp, B_FALSE, dd->dd_phys->dd_origin_obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2964 snap->ds->ds_dir->dd_phys->dd_head_dataset_obj, &pa.origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2965 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2966 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2967
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2968 if (snap->ds->ds_dir->dd_phys->dd_origin_obj != 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2969 err = dsl_dataset_hold_obj(dp,
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2970 snap->ds->ds_dir->dd_phys->dd_origin_obj,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2971 FTAG, &pa.origin_origin);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2972 if (err != 0)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2973 goto out;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2974 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2975
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2976 out:
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2977 rw_exit(&dp->dp_config_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2978
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2979 /*
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2980 * Add in 128x the snapnames zapobj size, since we will be moving
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2981 * a bunch of snapnames to the promoted ds, and dirtying their
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2982 * bonus buffers.
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2983 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2984 if (err == 0) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2985 err = dsl_sync_task_do(dp, dsl_dataset_promote_check,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2986 dsl_dataset_promote_sync, ds, &pa,
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	2987 2 + 2 * doi.doi_physical_blocks_512);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2988 if (err && pa.err_ds && conflsnap)
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2989 (void) strncpy(conflsnap, pa.err_ds, MAXNAMELEN);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2990 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2991
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2992 snaplist_destroy(&pa.shared_snaps, B_TRUE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2993 snaplist_destroy(&pa.clone_snaps, B_FALSE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2994 snaplist_destroy(&pa.origin_snaps, B_FALSE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2995 if (pa.origin_origin)
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2996 dsl_dataset_rele(pa.origin_origin, FTAG);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2997 dsl_dataset_rele(ds, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2998 return (err);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2999 }
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3000
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3001 struct cloneswaparg {
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3002 dsl_dataset_t cds; / clone dataset */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3003 dsl_dataset_t ohds; / origin's head dataset */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3004 boolean_t force;
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3005 int64_t unused_refres_delta; /* change in unconsumed refreservation */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3006 };
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3007
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3008 /* ARGSUSED */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3009 static int
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3010 dsl_dataset_clone_swap_check(void arg1, void arg2, dmu_tx_t *tx)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3011 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3012 struct cloneswaparg *csa = arg1;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3013
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3014 /* they should both be heads */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3015 if (dsl_dataset_is_snapshot(csa->cds) \|\|
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3016 dsl_dataset_is_snapshot(csa->ohds))
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3017 return (EINVAL);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3018
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3019 /* the branch point should be just before them */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3020 if (csa->cds->ds_prev != csa->ohds->ds_prev)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3021 return (EINVAL);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3022
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3023 /* cds should be the clone (unless they are unrelated) */
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3024 if (csa->cds->ds_prev != NULL &&
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3025 csa->cds->ds_prev != csa->cds->ds_dir->dd_pool->dp_origin_snap &&
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3026 csa->ohds->ds_object !=
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3027 csa->cds->ds_prev->ds_phys->ds_next_snap_obj)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3028 return (EINVAL);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3029
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3030 /* the clone should be a child of the origin */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3031 if (csa->cds->ds_dir->dd_parent != csa->ohds->ds_dir)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3032 return (EINVAL);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3033
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3034 /* ohds shouldn't be modified unless 'force' */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3035 if (!csa->force && dsl_dataset_modified_since_lastsnap(csa->ohds))
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3036 return (ETXTBSY);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3037
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3038 /* adjust amount of any unconsumed refreservation */
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3039 csa->unused_refres_delta =
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3040 (int64_t)MIN(csa->ohds->ds_reserved,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3041 csa->ohds->ds_phys->ds_unique_bytes) -
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3042 (int64_t)MIN(csa->ohds->ds_reserved,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3043 csa->cds->ds_phys->ds_unique_bytes);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3044
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3045 if (csa->unused_refres_delta > 0 &&
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3046 csa->unused_refres_delta >
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3047 dsl_dir_space_available(csa->ohds->ds_dir, NULL, 0, TRUE))
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3048 return (ENOSPC);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3049
10799 395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3050 if (csa->ohds->ds_quota != 0 &&
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3051 csa->cds->ds_phys->ds_unique_bytes > csa->ohds->ds_quota)
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3052 return (EDQUOT);
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3053
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3054 return (0);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3055 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3056
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3057 /* ARGSUSED */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3058 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3059 dsl_dataset_clone_swap_sync(void arg1, void arg2, dmu_tx_t *tx)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3060 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3061 struct cloneswaparg *csa = arg1;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3062 dsl_pool_t *dp = csa->cds->ds_dir->dd_pool;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3063
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3064 ASSERT(csa->cds->ds_reserved == 0);
10799 395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3065 ASSERT(csa->ohds->ds_quota == 0 \|\|
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3066 csa->cds->ds_phys->ds_unique_bytes <= csa->ohds->ds_quota);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3067
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3068 dmu_buf_will_dirty(csa->cds->ds_dbuf, tx);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3069 dmu_buf_will_dirty(csa->ohds->ds_dbuf, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3070
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3071 if (csa->cds->ds_objset != NULL) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3072 dmu_objset_evict(csa->cds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3073 csa->cds->ds_objset = NULL;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3074 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3075
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3076 if (csa->ohds->ds_objset != NULL) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3077 dmu_objset_evict(csa->ohds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3078 csa->ohds->ds_objset = NULL;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3079 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3080
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3081 /*
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3082 * Reset origin's unique bytes, if it exists.
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3083 */
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3084 if (csa->cds->ds_prev) {
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3085 dsl_dataset_t *origin = csa->cds->ds_prev;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3086 uint64_t comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3087
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3088 dmu_buf_will_dirty(origin->ds_dbuf, tx);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3089 dsl_deadlist_space_range(&csa->cds->ds_deadlist,
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3090 origin->ds_phys->ds_prev_snap_txg, UINT64_MAX,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3091 &origin->ds_phys->ds_unique_bytes, &comp, &uncomp);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3092 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3093
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3094 /* swap blkptrs */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3095 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3096 blkptr_t tmp;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3097 tmp = csa->ohds->ds_phys->ds_bp;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3098 csa->ohds->ds_phys->ds_bp = csa->cds->ds_phys->ds_bp;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3099 csa->cds->ds_phys->ds_bp = tmp;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3100 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3101
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3102 /* set dd__bytes /
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3103 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3104 int64_t dused, dcomp, duncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3105 uint64_t cdl_used, cdl_comp, cdl_uncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3106 uint64_t odl_used, odl_comp, odl_uncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3107
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3108 ASSERT3U(csa->cds->ds_dir->dd_phys->
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3109 dd_used_breakdown[DD_USED_SNAP], ==, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3110
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3111 dsl_deadlist_space(&csa->cds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3112 &cdl_used, &cdl_comp, &cdl_uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3113 dsl_deadlist_space(&csa->ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3114 &odl_used, &odl_comp, &odl_uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3115
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3116 dused = csa->cds->ds_phys->ds_used_bytes + cdl_used -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3117 (csa->ohds->ds_phys->ds_used_bytes + odl_used);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3118 dcomp = csa->cds->ds_phys->ds_compressed_bytes + cdl_comp -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3119 (csa->ohds->ds_phys->ds_compressed_bytes + odl_comp);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3120 duncomp = csa->cds->ds_phys->ds_uncompressed_bytes +
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3121 cdl_uncomp -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3122 (csa->ohds->ds_phys->ds_uncompressed_bytes + odl_uncomp);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3123
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3124 dsl_dir_diduse_space(csa->ohds->ds_dir, DD_USED_HEAD,
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3125 dused, dcomp, duncomp, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3126 dsl_dir_diduse_space(csa->cds->ds_dir, DD_USED_HEAD,
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3127 -dused, -dcomp, -duncomp, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3128
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3129 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3130 * The difference in the space used by snapshots is the
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3131 * difference in snapshot space due to the head's
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3132 * deadlist (since that's the only thing that's
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3133 * changing that affects the snapused).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3134 */
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3135 dsl_deadlist_space_range(&csa->cds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3136 csa->ohds->ds_dir->dd_origin_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3137 &cdl_used, &cdl_comp, &cdl_uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3138 dsl_deadlist_space_range(&csa->ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3139 csa->ohds->ds_dir->dd_origin_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3140 &odl_used, &odl_comp, &odl_uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3141 dsl_dir_transfer_space(csa->ohds->ds_dir, cdl_used - odl_used,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3142 DD_USED_HEAD, DD_USED_SNAP, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3143 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3144
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3145 /* swap ds__bytes /
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3146 SWITCH64(csa->ohds->ds_phys->ds_used_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3147 csa->cds->ds_phys->ds_used_bytes);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3148 SWITCH64(csa->ohds->ds_phys->ds_compressed_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3149 csa->cds->ds_phys->ds_compressed_bytes);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3150 SWITCH64(csa->ohds->ds_phys->ds_uncompressed_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3151 csa->cds->ds_phys->ds_uncompressed_bytes);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3152 SWITCH64(csa->ohds->ds_phys->ds_unique_bytes,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3153 csa->cds->ds_phys->ds_unique_bytes);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3154
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3155 /* apply any parent delta for change in unconsumed refreservation */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3156 dsl_dir_diduse_space(csa->ohds->ds_dir, DD_USED_REFRSRV,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3157 csa->unused_refres_delta, 0, 0, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3158
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3159 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3160 * Swap deadlists.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3161 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3162 dsl_deadlist_close(&csa->cds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3163 dsl_deadlist_close(&csa->ohds->ds_deadlist);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3164 SWITCH64(csa->ohds->ds_phys->ds_deadlist_obj,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3165 csa->cds->ds_phys->ds_deadlist_obj);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3166 dsl_deadlist_open(&csa->cds->ds_deadlist, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3167 csa->cds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3168 dsl_deadlist_open(&csa->ohds->ds_deadlist, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3169 csa->ohds->ds_phys->ds_deadlist_obj);
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	3170
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3171 dsl_scan_ds_clone_swapped(csa->ohds, csa->cds, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3172 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3173
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3174 /*
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3175 * Swap 'clone' with its origin head datasets. Used at the end of "zfs
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3176 * recv" into an existing fs to swizzle the file system to the new
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3177 * version, and by "zfs rollback". Can also be used to swap two
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3178 * independent head datasets if neither has any snapshots.
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3179 */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3180 int
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3181 dsl_dataset_clone_swap(dsl_dataset_t clone, dsl_dataset_t origin_head,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3182 boolean_t force)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3183 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3184 struct cloneswaparg csa;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3185 int error;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3186
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3187 ASSERT(clone->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3188 ASSERT(origin_head->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3189 retry:
12711 7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3190 /*
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3191 * Need exclusive access for the swap. If we're swapping these
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3192 * datasets back after an error, we already hold the locks.
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3193 */
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3194 if (!RW_WRITE_HELD(&clone->ds_rwlock))
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3195 rw_enter(&clone->ds_rwlock, RW_WRITER);
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3196 if (!RW_WRITE_HELD(&origin_head->ds_rwlock) &&
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3197 !rw_tryenter(&origin_head->ds_rwlock, RW_WRITER)) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3198 rw_exit(&clone->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3199 rw_enter(&origin_head->ds_rwlock, RW_WRITER);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3200 if (!rw_tryenter(&clone->ds_rwlock, RW_WRITER)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3201 rw_exit(&origin_head->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3202 goto retry;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3203 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3204 }
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3205 csa.cds = clone;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3206 csa.ohds = origin_head;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3207 csa.force = force;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3208 error = dsl_sync_task_do(clone->ds_dir->dd_pool,
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3209 dsl_dataset_clone_swap_check,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3210 dsl_dataset_clone_swap_sync, &csa, NULL, 9);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3211 return (error);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3212 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3213
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3214 /*
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3215 * Given a pool name and a dataset object number in that pool,
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3216 * return the name of that dataset.
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3217 */
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3218 int
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3219 dsl_dsobj_to_dsname(char pname, uint64_t obj, char buf)
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3220 {
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3221 spa_t *spa;
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3222 dsl_pool_t *dp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3223 dsl_dataset_t *ds;
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3224 int error;
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3225
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3226 if ((error = spa_open(pname, &spa, FTAG)) != 0)
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3227 return (error);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3228 dp = spa_get_dsl(spa);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3229 rw_enter(&dp->dp_config_rwlock, RW_READER);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3230 if ((error = dsl_dataset_hold_obj(dp, obj, FTAG, &ds)) == 0) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3231 dsl_dataset_name(ds, buf);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3232 dsl_dataset_rele(ds, FTAG);
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3233 }
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3234 rw_exit(&dp->dp_config_rwlock);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3235 spa_close(spa, FTAG);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3236
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3237 return (error);
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3238 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3239
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3240 int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3241 dsl_dataset_check_quota(dsl_dataset_t *ds, boolean_t check_quota,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3242 uint64_t asize, uint64_t inflight, uint64_t used, uint64_t ref_rsrv)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3243 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3244 int error = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3245
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3246 ASSERT3S(asize, >, 0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3247
5831 48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3248 /*
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3249 * *ref_rsrv is the portion of asize that will come from any
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3250 * unconsumed refreservation space.
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3251 */
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3252 *ref_rsrv = 0;
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3253
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3254 mutex_enter(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3255 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3256 * Make a space adjustment for reserved bytes.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3257 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3258 if (ds->ds_reserved > ds->ds_phys->ds_unique_bytes) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3259 ASSERT3U(*used, >=,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3260 ds->ds_reserved - ds->ds_phys->ds_unique_bytes);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3261 *used -= (ds->ds_reserved - ds->ds_phys->ds_unique_bytes);
5831 48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3262 *ref_rsrv =
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3263 asize - MIN(asize, parent_delta(ds, asize + inflight));
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3264 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3265
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3266 if (!check_quota \|\| ds->ds_quota == 0) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3267 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3268 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3269 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3270 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3271 * If they are requesting more space, and our current estimate
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3272 * is over quota, they get to try again unless the actual
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3273 * on-disk is over quota and there are no pending changes (which
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3274 * may free up space for us).
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3275 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3276 if (ds->ds_phys->ds_used_bytes + inflight >= ds->ds_quota) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3277 if (inflight > 0 \|\| ds->ds_phys->ds_used_bytes < ds->ds_quota)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3278 error = ERESTART;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3279 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3280 error = EDQUOT;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3281 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3282 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3283
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3284 return (error);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3285 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3286
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3287 /* ARGSUSED */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3288 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3289 dsl_dataset_set_quota_check(void arg1, void arg2, dmu_tx_t *tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3290 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3291 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3292 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3293 int err;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3294
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3295 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_REFQUOTA)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3296 return (ENOTSUP);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3297
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3298 if ((err = dsl_prop_predict_sync(ds->ds_dir, psa)) != 0)
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3299 return (err);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3300
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3301 if (psa->psa_effective_value == 0)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3302 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3303
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3304 if (psa->psa_effective_value < ds->ds_phys->ds_used_bytes \|\|
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3305 psa->psa_effective_value < ds->ds_reserved)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3306 return (ENOSPC);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3307
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3308 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3309 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3310
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3311 extern void dsl_prop_set_sync(void , void , dmu_tx_t *);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3312
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3313 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3314 dsl_dataset_set_quota_sync(void arg1, void arg2, dmu_tx_t *tx)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3315 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3316 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3317 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3318 uint64_t effective_value = psa->psa_effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3319
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3320 dsl_prop_set_sync(ds, psa, tx);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3321 DSL_PROP_CHECK_PREDICTION(ds->ds_dir, psa);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3322
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3323 if (ds->ds_quota != effective_value) {
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3324 dmu_buf_will_dirty(ds->ds_dbuf, tx);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3325 ds->ds_quota = effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3326
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3327 spa_history_log_internal(LOG_DS_REFQUOTA,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3328 ds->ds_dir->dd_pool->dp_spa, tx, "%lld dataset = %llu ",
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3329 (longlong_t)ds->ds_quota, ds->ds_object);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3330 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3331 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3332
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3333 int
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3334 dsl_dataset_set_quota(const char *dsname, zprop_source_t source, uint64_t quota)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3335 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3336 dsl_dataset_t *ds;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3337 dsl_prop_setarg_t psa;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3338 int err;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3339
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3340 dsl_prop_setarg_init_uint64(&psa, "refquota", source, &quota);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3341
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3342 err = dsl_dataset_hold(dsname, FTAG, &ds);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3343 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3344 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3345
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3346 /*
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3347 * If someone removes a file, then tries to set the quota, we
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3348 * want to make sure the file freeing takes effect.
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3349 */
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3350 txg_wait_open(ds->ds_dir->dd_pool, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3351
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3352 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3353 dsl_dataset_set_quota_check, dsl_dataset_set_quota_sync,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3354 ds, &psa, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3355
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3356 dsl_dataset_rele(ds, FTAG);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3357 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3358 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3359
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3360 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3361 dsl_dataset_set_reservation_check(void arg1, void arg2, dmu_tx_t *tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3362 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3363 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3364 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3365 uint64_t effective_value;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3366 uint64_t unique;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3367 int err;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3368
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3369 if (spa_version(ds->ds_dir->dd_pool->dp_spa) <
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3370 SPA_VERSION_REFRESERVATION)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3371 return (ENOTSUP);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3372
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3373 if (dsl_dataset_is_snapshot(ds))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3374 return (EINVAL);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3375
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3376 if ((err = dsl_prop_predict_sync(ds->ds_dir, psa)) != 0)
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3377 return (err);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3378
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3379 effective_value = psa->psa_effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3380
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3381 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3382 * If we are doing the preliminary check in open context, the
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3383 * space estimates may be inaccurate.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3384 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3385 if (!dmu_tx_is_syncing(tx))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3386 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3387
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3388 mutex_enter(&ds->ds_lock);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3389 if (!DS_UNIQUE_IS_ACCURATE(ds))
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3390 dsl_dataset_recalc_head_uniq(ds);
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3391 unique = ds->ds_phys->ds_unique_bytes;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3392 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3393
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3394 if (MAX(unique, effective_value) > MAX(unique, ds->ds_reserved)) {
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3395 uint64_t delta = MAX(unique, effective_value) -
8525 e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3396 MAX(unique, ds->ds_reserved);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3397
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3398 if (delta > dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE))
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3399 return (ENOSPC);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3400 if (ds->ds_quota > 0 &&
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3401 effective_value > ds->ds_quota)
8525 e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3402 return (ENOSPC);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3403 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3404
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3405 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3406 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3407
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3408 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3409 dsl_dataset_set_reservation_sync(void arg1, void arg2, dmu_tx_t *tx)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3410 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3411 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3412 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3413 uint64_t effective_value = psa->psa_effective_value;
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3414 uint64_t unique;
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3415 int64_t delta;
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3416
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3417 dsl_prop_set_sync(ds, psa, tx);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3418 DSL_PROP_CHECK_PREDICTION(ds->ds_dir, psa);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3419
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3420 dmu_buf_will_dirty(ds->ds_dbuf, tx);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3421
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3422 mutex_enter(&ds->ds_dir->dd_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3423 mutex_enter(&ds->ds_lock);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3424 ASSERT(DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3425 unique = ds->ds_phys->ds_unique_bytes;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3426 delta = MAX(0, (int64_t)(effective_value - unique)) -
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3427 MAX(0, (int64_t)(ds->ds_reserved - unique));
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3428 ds->ds_reserved = effective_value;
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3429 mutex_exit(&ds->ds_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3430
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3431 dsl_dir_diduse_space(ds->ds_dir, DD_USED_REFRSRV, delta, 0, 0, tx);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3432 mutex_exit(&ds->ds_dir->dd_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3433
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3434 spa_history_log_internal(LOG_DS_REFRESERV,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3435 ds->ds_dir->dd_pool->dp_spa, tx, "%lld dataset = %llu",
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3436 (longlong_t)effective_value, ds->ds_object);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3437 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3438
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3439 int
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3440 dsl_dataset_set_reservation(const char *dsname, zprop_source_t source,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3441 uint64_t reservation)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3442 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3443 dsl_dataset_t *ds;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3444 dsl_prop_setarg_t psa;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3445 int err;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3446
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3447 dsl_prop_setarg_init_uint64(&psa, "refreservation", source,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3448 &reservation);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3449
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3450 err = dsl_dataset_hold(dsname, FTAG, &ds);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3451 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3452 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3453
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3454 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3455 dsl_dataset_set_reservation_check,
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3456 dsl_dataset_set_reservation_sync, ds, &psa, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3457
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3458 dsl_dataset_rele(ds, FTAG);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3459 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3460 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3461
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3462 typedef struct zfs_hold_cleanup_arg {
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3463 dsl_pool_t *dp;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3464 uint64_t dsobj;
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3465 char htag[MAXNAMELEN];
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3466 } zfs_hold_cleanup_arg_t;
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3467
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3468 static void
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3469 dsl_dataset_user_release_onexit(void *arg)
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3470 {
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3471 zfs_hold_cleanup_arg_t *ca = arg;
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3472
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3473 (void) dsl_dataset_user_release_tmp(ca->dp, ca->dsobj, ca->htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3474 B_TRUE);
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3475 kmem_free(ca, sizeof (zfs_hold_cleanup_arg_t));
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3476 }
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3477
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3478 void
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3479 dsl_register_onexit_hold_cleanup(dsl_dataset_t ds, const char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3480 minor_t minor)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3481 {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3482 zfs_hold_cleanup_arg_t *ca;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3483
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3484 ca = kmem_alloc(sizeof (zfs_hold_cleanup_arg_t), KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3485 ca->dp = ds->ds_dir->dd_pool;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3486 ca->dsobj = ds->ds_object;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3487 (void) strlcpy(ca->htag, htag, sizeof (ca->htag));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3488 VERIFY3U(0, ==, zfs_onexit_add_cb(minor,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3489 dsl_dataset_user_release_onexit, ca, NULL));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3490 }
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3491
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3492 /*
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3493 * If you add new checks here, you may need to add
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3494 * additional checks to the "temporary" case in
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3495 * snapshot_check() in dmu_objset.c.
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3496 */
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3497 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3498 dsl_dataset_user_hold_check(void arg1, void arg2, dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3499 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3500 dsl_dataset_t *ds = arg1;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3501 struct dsl_ds_holdarg *ha = arg2;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3502 char *htag = ha->htag;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3503 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3504 int error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3505
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3506 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3507 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3508
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3509 if (!dsl_dataset_is_snapshot(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3510 return (EINVAL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3511
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3512 /* tags must be unique */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3513 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3514 if (ds->ds_phys->ds_userrefs_obj) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3515 error = zap_lookup(mos, ds->ds_phys->ds_userrefs_obj, htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3516 8, 1, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3517 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3518 error = EEXIST;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3519 else if (error == ENOENT)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3520 error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3521 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3522 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3523
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3524 if (error == 0 && ha->temphold &&
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3525 strlen(htag) + MAX_TAG_PREFIX_LEN >= MAXNAMELEN)
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3526 error = E2BIG;
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3527
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3528 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3529 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3530
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3531 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3532 dsl_dataset_user_hold_sync(void arg1, void arg2, dmu_tx_t *tx)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3533 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3534 dsl_dataset_t *ds = arg1;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3535 struct dsl_ds_holdarg *ha = arg2;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3536 char *htag = ha->htag;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3537 dsl_pool_t *dp = ds->ds_dir->dd_pool;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3538 objset_t *mos = dp->dp_meta_objset;
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3539 uint64_t now = gethrestime_sec();
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3540 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3541
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3542 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3543 if (ds->ds_phys->ds_userrefs_obj == 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3544 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3545 * This is the first user hold for this dataset. Create
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3546 * the userrefs zap object.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3547 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3548 dmu_buf_will_dirty(ds->ds_dbuf, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3549 zapobj = ds->ds_phys->ds_userrefs_obj =
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3550 zap_create(mos, DMU_OT_USERREFS, DMU_OT_NONE, 0, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3551 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3552 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3553 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3554 ds->ds_userrefs++;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3555 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3556
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3557 VERIFY(0 == zap_add(mos, zapobj, htag, 8, 1, &now, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3558
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3559 if (ha->temphold) {
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3560 VERIFY(0 == dsl_pool_user_hold(dp, ds->ds_object,
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3561 htag, &now, tx));
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3562 }
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3563
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3564 spa_history_log_internal(LOG_DS_USER_HOLD,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3565 dp->dp_spa, tx, "<%s> temp = %d dataset = %llu", htag,
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3566 (int)ha->temphold, ds->ds_object);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3567 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3568
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3569 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3570 dsl_dataset_user_hold_one(const char dsname, void arg)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3571 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3572 struct dsl_ds_holdarg *ha = arg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3573 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3574 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3575 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3576
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3577 /* alloc a buffer to hold dsname@snapname plus terminating NULL */
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3578 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3579 error = dsl_dataset_hold(name, ha->dstg, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3580 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3581 if (error == 0) {
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3582 ha->gotone = B_TRUE;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3583 dsl_sync_task_create(ha->dstg, dsl_dataset_user_hold_check,
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3584 dsl_dataset_user_hold_sync, ds, ha, 0);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3585 } else if (error == ENOENT && ha->recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3586 error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3587 } else {
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3588 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3589 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3590 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3591 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3592
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3593 int
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3594 dsl_dataset_user_hold_for_send(dsl_dataset_t ds, char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3595 boolean_t temphold)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3596 {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3597 struct dsl_ds_holdarg *ha;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3598 int error;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3599
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3600 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3601 ha->htag = htag;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3602 ha->temphold = temphold;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3603 error = dsl_sync_task_do(ds->ds_dir->dd_pool,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3604 dsl_dataset_user_hold_check, dsl_dataset_user_hold_sync,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3605 ds, ha, 0);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3606 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3607
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3608 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3609 }
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3610
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3611 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3612 dsl_dataset_user_hold(char dsname, char snapname, char *htag,
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3613 boolean_t recursive, boolean_t temphold, int cleanup_fd)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3614 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3615 struct dsl_ds_holdarg *ha;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3616 dsl_sync_task_t *dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3617 spa_t *spa;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3618 int error;
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3619 minor_t minor = 0;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3620
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3621 if (cleanup_fd != -1) {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3622 /* Currently we only support cleanup-on-exit of tempholds. */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3623 if (!temphold)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3624 return (EINVAL);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3625 error = zfs_onexit_fd_hold(cleanup_fd, &minor);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3626 if (error)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3627 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3628 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3629
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3630 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3631
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3632 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3633
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3634 error = spa_open(dsname, &spa, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3635 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3636 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3637 if (cleanup_fd != -1)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3638 zfs_onexit_fd_rele(cleanup_fd);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3639 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3640 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3641
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3642 ha->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3643 ha->htag = htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3644 ha->snapname = snapname;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3645 ha->recursive = recursive;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3646 ha->temphold = temphold;
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3647
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3648 if (recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3649 error = dmu_objset_find(dsname, dsl_dataset_user_hold_one,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3650 ha, DS_FIND_CHILDREN);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3651 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3652 error = dsl_dataset_user_hold_one(dsname, ha);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3653 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3654 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3655 error = dsl_sync_task_group_wait(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3656
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3657 for (dst = list_head(&ha->dstg->dstg_tasks); dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3658 dst = list_next(&ha->dstg->dstg_tasks, dst)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3659 dsl_dataset_t *ds = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3660
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3661 if (dst->dst_err) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3662 dsl_dataset_name(ds, ha->failed);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3663 *strchr(ha->failed, '@') = '\0';
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3664 } else if (error == 0 && minor != 0 && temphold) {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3665 /*
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3666 * If this hold is to be released upon process exit,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3667 * register that action now.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3668 */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3669 dsl_register_onexit_hold_cleanup(ds, htag, minor);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3670 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3671 dsl_dataset_rele(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3672 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3673
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3674 if (error == 0 && recursive && !ha->gotone)
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3675 error = ENOENT;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3676
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3677 if (error)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3678 (void) strlcpy(dsname, ha->failed, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3679
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3680 dsl_sync_task_group_destroy(ha->dstg);
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3681
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3682 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3683 spa_close(spa, FTAG);
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3684 if (cleanup_fd != -1)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3685 zfs_onexit_fd_rele(cleanup_fd);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3686 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3687 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3688
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3689 struct dsl_ds_releasearg {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3690 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3691 const char *htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3692 boolean_t own; /* do we own or just hold ds? */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3693 };
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3694
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3695 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3696 dsl_dataset_release_might_destroy(dsl_dataset_t ds, const char htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3697 boolean_t *might_destroy)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3698 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3699 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3700 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3701 uint64_t tmp;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3702 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3703
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3704 *might_destroy = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3705
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3706 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3707 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3708 if (zapobj == 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3709 /* The tag can't possibly exist */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3710 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3711 return (ESRCH);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3712 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3713
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3714 /* Make sure the tag exists */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3715 error = zap_lookup(mos, zapobj, htag, 8, 1, &tmp);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3716 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3717 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3718 if (error == ENOENT)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3719 error = ESRCH;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3720 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3721 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3722
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3723 if (ds->ds_userrefs == 1 && ds->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3724 DS_IS_DEFER_DESTROY(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3725 *might_destroy = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3726
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3727 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3728 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3729 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3730
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3731 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3732 dsl_dataset_user_release_check(void arg1, void tag, dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3733 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3734 struct dsl_ds_releasearg *ra = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3735 dsl_dataset_t *ds = ra->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3736 boolean_t might_destroy;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3737 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3738
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3739 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3740 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3741
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3742 error = dsl_dataset_release_might_destroy(ds, ra->htag, &might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3743 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3744 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3745
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3746 if (might_destroy) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3747 struct dsl_ds_destroyarg dsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3748
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3749 if (dmu_tx_is_syncing(tx)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3750 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3751 * If we're not prepared to remove the snapshot,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3752 * we can't allow the release to happen right now.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3753 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3754 if (!ra->own)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3755 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3756 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3757 dsda.ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3758 dsda.releasing = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3759 return (dsl_dataset_destroy_check(&dsda, tag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3760 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3761
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3762 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3763 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3764
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3765 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3766 dsl_dataset_user_release_sync(void arg1, void tag, dmu_tx_t *tx)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3767 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3768 struct dsl_ds_releasearg *ra = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3769 dsl_dataset_t *ds = ra->ds;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3770 dsl_pool_t *dp = ds->ds_dir->dd_pool;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3771 objset_t *mos = dp->dp_meta_objset;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3772 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3773 uint64_t dsobj = ds->ds_object;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3774 uint64_t refs;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3775 int error;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3776
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3777 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3778 ds->ds_userrefs--;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3779 refs = ds->ds_userrefs;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3780 mutex_exit(&ds->ds_lock);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3781 error = dsl_pool_user_release(dp, ds->ds_object, ra->htag, tx);
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3782 VERIFY(error == 0 \|\| error == ENOENT);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3783 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3784 VERIFY(0 == zap_remove(mos, zapobj, ra->htag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3785 if (ds->ds_userrefs == 0 && ds->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3786 DS_IS_DEFER_DESTROY(ds)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3787 struct dsl_ds_destroyarg dsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3788
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3789 ASSERT(ra->own);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3790 dsda.ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3791 dsda.releasing = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3792 /* We already did the destroy_check */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3793 dsl_dataset_destroy_sync(&dsda, tag, tx);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3794 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3795
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3796 spa_history_log_internal(LOG_DS_USER_RELEASE,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3797 dp->dp_spa, tx, "<%s> %lld dataset = %llu",
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3798 ra->htag, (longlong_t)refs, dsobj);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3799 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3800
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3801 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3802 dsl_dataset_user_release_one(const char dsname, void arg)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3803 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3804 struct dsl_ds_holdarg *ha = arg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3805 struct dsl_ds_releasearg *ra;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3806 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3807 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3808 void *dtag = ha->dstg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3809 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3810 boolean_t own = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3811 boolean_t might_destroy;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3812
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3813 /* alloc a buffer to hold dsname@snapname, plus the terminating NULL */
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3814 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3815 error = dsl_dataset_hold(name, dtag, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3816 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3817 if (error == ENOENT && ha->recursive)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3818 return (0);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3819 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3820 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3821 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3822
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3823 ha->gotone = B_TRUE;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3824
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3825 ASSERT(dsl_dataset_is_snapshot(ds));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3826
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3827 error = dsl_dataset_release_might_destroy(ds, ha->htag, &might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3828 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3829 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3830 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3831 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3832
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3833 if (might_destroy) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3834 #ifdef _KERNEL
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	3835 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3836 error = zfs_unmount_snap(name, NULL);
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	3837 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3838 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3839 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3840 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3841 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3842 #endif
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3843 if (!dsl_dataset_tryown(ds, B_TRUE, dtag)) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3844 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3845 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3846 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3847 own = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3848 dsl_dataset_make_exclusive(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3849 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3850 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3851
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3852 ra = kmem_alloc(sizeof (struct dsl_ds_releasearg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3853 ra->ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3854 ra->htag = ha->htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3855 ra->own = own;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3856 dsl_sync_task_create(ha->dstg, dsl_dataset_user_release_check,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3857 dsl_dataset_user_release_sync, ra, dtag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3858
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3859 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3860 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3861
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3862 int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3863 dsl_dataset_user_release(char dsname, char snapname, char *htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3864 boolean_t recursive)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3865 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3866 struct dsl_ds_holdarg *ha;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3867 dsl_sync_task_t *dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3868 spa_t *spa;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3869 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3870
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3871 top:
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3872 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3873
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3874 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3875
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3876 error = spa_open(dsname, &spa, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3877 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3878 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3879 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3880 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3881
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3882 ha->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3883 ha->htag = htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3884 ha->snapname = snapname;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3885 ha->recursive = recursive;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3886 if (recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3887 error = dmu_objset_find(dsname, dsl_dataset_user_release_one,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3888 ha, DS_FIND_CHILDREN);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3889 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3890 error = dsl_dataset_user_release_one(dsname, ha);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3891 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3892 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3893 error = dsl_sync_task_group_wait(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3894
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3895 for (dst = list_head(&ha->dstg->dstg_tasks); dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3896 dst = list_next(&ha->dstg->dstg_tasks, dst)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3897 struct dsl_ds_releasearg *ra = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3898 dsl_dataset_t *ds = ra->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3899
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3900 if (dst->dst_err)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3901 dsl_dataset_name(ds, ha->failed);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3902
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3903 if (ra->own)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3904 dsl_dataset_disown(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3905 else
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3906 dsl_dataset_rele(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3907
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3908 kmem_free(ra, sizeof (struct dsl_ds_releasearg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3909 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3910
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3911 if (error == 0 && recursive && !ha->gotone)
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3912 error = ENOENT;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3913
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3914 if (error && error != EBUSY)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3915 (void) strlcpy(dsname, ha->failed, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3916
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3917 dsl_sync_task_group_destroy(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3918 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3919 spa_close(spa, FTAG);
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3920
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3921 /*
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3922 * We can get EBUSY if we were racing with deferred destroy and
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3923 * dsl_dataset_user_release_check() hadn't done the necessary
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3924 * open context setup. We can also get EBUSY if we're racing
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3925 * with destroy and that thread is the ds_owner. Either way
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3926 * the busy condition should be transient, and we should retry
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3927 * the release operation.
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3928 */
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3929 if (error == EBUSY)
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3930 goto top;
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3931
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3932 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3933 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3934
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3935 /*
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3936 * Called at spa_load time (with retry == B_FALSE) to release a stale
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3937 * temporary user hold. Also called by the onexit code (with retry == B_TRUE).
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3938 */
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3939 int
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3940 dsl_dataset_user_release_tmp(dsl_pool_t dp, uint64_t dsobj, char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3941 boolean_t retry)
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3942 {
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3943 dsl_dataset_t *ds;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3944 char *snap;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3945 char *name;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3946 int namelen;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3947 int error;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3948
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3949 do {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3950 rw_enter(&dp->dp_config_rwlock, RW_READER);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3951 error = dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3952 rw_exit(&dp->dp_config_rwlock);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3953 if (error)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3954 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3955 namelen = dsl_dataset_namelen(ds)+1;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3956 name = kmem_alloc(namelen, KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3957 dsl_dataset_name(ds, name);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3958 dsl_dataset_rele(ds, FTAG);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3959
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3960 snap = strchr(name, '@');
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3961 *snap = '\0';
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3962 ++snap;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3963 error = dsl_dataset_user_release(name, snap, htag, B_FALSE);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3964 kmem_free(name, namelen);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3965
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3966 /*
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3967 * The object can't have been destroyed because we have a hold,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3968 * but it might have been renamed, resulting in ENOENT. Retry
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3969 * if we've been requested to do so.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3970 *
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3971 * It would be nice if we could use the dsobj all the way
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3972 * through and avoid ENOENT entirely. But we might need to
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3973 * unmount the snapshot, and there's currently no way to lookup
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3974 * a vfsp using a ZFS object id.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3975 */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3976 } while ((error == ENOENT) && retry);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3977
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3978 return (error);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3979 }
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3980
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3981 int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3982 dsl_dataset_get_holds(const char dsname, nvlist_t *nvp)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3983 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3984 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3985 int err;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3986
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3987 err = dsl_dataset_hold(dsname, FTAG, &ds);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3988 if (err)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3989 return (err);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3990
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3991 VERIFY(0 == nvlist_alloc(nvp, NV_UNIQUE_NAME, KM_SLEEP));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3992 if (ds->ds_phys->ds_userrefs_obj != 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3993 zap_attribute_t *za;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3994 zap_cursor_t zc;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3995
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3996 za = kmem_alloc(sizeof (zap_attribute_t), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3997 for (zap_cursor_init(&zc, ds->ds_dir->dd_pool->dp_meta_objset,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3998 ds->ds_phys->ds_userrefs_obj);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3999 zap_cursor_retrieve(&zc, za) == 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4000 zap_cursor_advance(&zc)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4001 VERIFY(0 == nvlist_add_uint64(*nvp, za->za_name,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4002 za->za_first_integer));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4003 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4004 zap_cursor_fini(&zc);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4005 kmem_free(za, sizeof (zap_attribute_t));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4006 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4007 dsl_dataset_rele(ds, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4008 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4009 }
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4010
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4011 /*
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4012 * Note, this fuction is used as the callback for dmu_objset_find(). We
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4013 * always return 0 so that we will continue to find and process
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4014 * inconsistent datasets, even if we encounter an error trying to
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4015 * process one of them.
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4016 */
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4017 /* ARGSUSED */
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4018 int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	4019 dsl_destroy_inconsistent(const char dsname, void arg)
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4020 {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4021 dsl_dataset_t *ds;
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4022
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4023 if (dsl_dataset_own(dsname, B_TRUE, FTAG, &ds) == 0) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4024 if (DS_IS_INCONSISTENT(ds))
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4025 (void) dsl_dataset_destroy(ds, FTAG, B_FALSE);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4026 else
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4027 dsl_dataset_disown(ds, FTAG);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4028 }
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4029 return (0);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4030 }

Mercurial > illumos > illumos-gate

annotate usr/src/uts/common/fs/zfs/dsl_dataset.c @ 13055:8c712bbb18ea