changeset 4996:1fec74abebba onnv_73

6515554 sdpadm does incorrect check on args passed to it 6519010 SIOSYSENABLESDP is misnamed 6564594 "BAD TRAP: module "genunix" due to a NULL pointer dereference" on amd64 infinband systems in snv_66 6599427 sdp needs to validate work queue entry before processing the mblk 6599436 sdpib leaking memory during detach
author se146197
date Tue, 04 Sep 2007 20:13:34 -0700
parents 3e3d6de427e8
children 0fec8fae5614
files usr/src/cmd/sdpadm/sdpadm.c usr/src/uts/common/fs/sockfs/socksdpvnops.c usr/src/uts/common/io/ib/clients/sdp/sdpddi.c usr/src/uts/common/sys/sockio.h
diffstat 4 files changed, 7 insertions(+), 7 deletions(-) [+]
line wrap: on
line diff
--- a/usr/src/cmd/sdpadm/sdpadm.c	Tue Sep 04 18:46:23 2007 -0700
+++ b/usr/src/cmd/sdpadm/sdpadm.c	Tue Sep 04 20:13:34 2007 -0700
@@ -116,18 +116,18 @@
 
 	if (argc == 2) {
 		/* Parse the on|off from the user */
-		if (strncasecmp(argv[1], "enable", 7) == 0) {
+		if (strcasecmp(argv[1], "enable") == 0) {
 			enable = 1;
-		} else if (strncasecmp(argv[1], "disable", 8) == 0) {
+		} else if (strcasecmp(argv[1], "disable") == 0) {
 			enable = 0;
-		} else if (strncasecmp(argv[1], "status", 7) == 0)
+		} else if (strcasecmp(argv[1], "status") == 0)
 			enable = -1;
 		else {
 			usage();
 		}
 	}
 
-	stri.ic_cmd = SIOSYSENABLESDP;
+	stri.ic_cmd = SIOCSENABLESDP;
 	stri.ic_timout = 0;
 	stri.ic_len = sizeof (int);
 	stri.ic_dp = (char *)&enable;
--- a/usr/src/uts/common/fs/sockfs/socksdpvnops.c	Tue Sep 04 18:46:23 2007 -0700
+++ b/usr/src/uts/common/fs/sockfs/socksdpvnops.c	Tue Sep 04 20:13:34 2007 -0700
@@ -353,7 +353,7 @@
 		return (0);
 
 
-	case SIOSYSENABLESDP: {
+	case SIOCSENABLESDP: {
 		int32_t enable;
 
 		/*
--- a/usr/src/uts/common/io/ib/clients/sdp/sdpddi.c	Tue Sep 04 18:46:23 2007 -0700
+++ b/usr/src/uts/common/io/ib/clients/sdp/sdpddi.c	Tue Sep 04 20:13:34 2007 -0700
@@ -182,7 +182,7 @@
 	/* LINTED */
 	iocp = (struct iocblk *)mp->b_rptr;
 	switch (iocp->ioc_cmd) {
-		case SIOSYSENABLESDP:
+		case SIOCSENABLESDP:
 			bcopy(mp->b_cont->b_rptr, &enable, sizeof (int));
 
 			/*
--- a/usr/src/uts/common/sys/sockio.h	Tue Sep 04 18:46:23 2007 -0700
+++ b/usr/src/uts/common/sys/sockio.h	Tue Sep 04 20:13:34 2007 -0700
@@ -316,7 +316,7 @@
 #define	SIOCSIPMPFAILBACK	_IOW('i', 182, int)	/* enable/disable */
 							/* FAILBACK */
 
-#define	SIOSYSENABLESDP _IOWR('i', 183, int)    /*  Enable SDP */
+#define	SIOCSENABLESDP _IOWR('i', 183, int)    /*  Enable SDP */
 
 #ifdef	__cplusplus
 }