Mercurial > illumos > illumos-gate

changeset 13627:81f67a2ecd98

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
2163 sparc bits should be more careful casting pointers Reviewed by: Joshua M. Clulow <josh@sysmgr.org> Reviewed by: Gordon Ross <gwr@nexenta.com> Reviewed by: Jason King <jason.brian.king@gmail.com> Approved by: Garrett D'Amore <garrett@damore.org>
author Richard Lowe <richlowe@richlowe.net>
date Wed, 22 Jun 2011 12:54:00 -0700
parents f228617ce378
children 03b37ed99c1b
files usr/src/psm/stand/boot/sparc/common/bootops.c usr/src/stand/lib/fs/hsfs/hsfsops.c usr/src/stand/lib/fs/ufs/ufsops.c usr/src/uts/sun4u/serengeti/io/sbdp_cpu.c usr/src/uts/sun4u/starfire/io/drmach.c usr/src/uts/sun4u/starfire/io/idn.c usr/src/uts/sun4u/starfire/sys/idn.h usr/src/uts/sun4u/starfire/sys/idn_smr.h usr/src/uts/sun4u/vm/zulu_hat.c
diffstat 9 files changed, 91 insertions(+), 96 deletions(-) [+]
line wrap: on
line diff
--- a/usr/src/psm/stand/boot/sparc/common/bootops.c	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/psm/stand/boot/sparc/common/bootops.c	Wed Jun 22 12:54:00 2011 -0700
@@ -23,8 +23,6 @@
  * Use is subject to license terms.
  */
 
-#pragma ident	"%Z%%M%	%I%	%E% SMI"
-
 #include <sys/types.h>
 #include <sys/bootconf.h>
 #include <sys/param.h>
@@ -58,7 +56,7 @@
 {
 	bootops.bsys_version = BO_VERSION;
 	bootops.bsys_1275_call = (uint64_t)boot_fail;
-	bootops.bsys_printf = (uint32_t)boot_fail;
+	bootops.bsys_printf = (uint32_t)(uintptr_t)boot_fail;
 
 	if (!memlistpage) /* paranoia runs rampant */
 		prom_panic("\nMemlistpage not setup yet.");
--- a/usr/src/stand/lib/fs/hsfs/hsfsops.c	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/stand/lib/fs/hsfs/hsfsops.c	Wed Jun 22 12:54:00 2011 -0700
@@ -23,8 +23,6 @@
  * Use is subject to license terms.
  */
 
-#pragma ident	"%Z%%M%	%I%	%E% SMI"
-
 #include <sys/param.h>
 #include <sys/vnode.h>
 #include <sys/fs/ufs_fsdir.h>
@@ -1004,7 +1002,7 @@
 	struct hs_direct *hdp;
 	unsigned long oldoff, oldblok;
 
-#define	SLOP (sizeof (struct dirent) - (int)&((struct dirent *)0)->d_name[1])
+#define	SLOP (sizeof (struct dirent) - offsetof(struct dirent, d_name[1]))
 
 	if (!(dir.fi = find_fp(fd)) ||
 	    ((dir.fi->fi_inode->i_smode & IFMT) != IFDIR)) {
--- a/usr/src/stand/lib/fs/ufs/ufsops.c	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/stand/lib/fs/ufs/ufsops.c	Wed Jun 22 12:54:00 2011 -0700
@@ -23,8 +23,6 @@
  * Use is subject to license terms.
  */
 
-#pragma ident	"%Z%%M%	%I%	%E% SMI"
-
 #include <sys/param.h>
 #include <sys/vnode.h>
 #include <sys/fs/ufs_fsdir.h>
@@ -863,7 +861,7 @@
 	fileid_t *fp;
 	unsigned long oldoff, oldblok;
 
-#define	SLOP (sizeof (struct dirent) - (int)&((struct dirent *)0)->d_name[1])
+#define	SLOP (sizeof (struct dirent) - offsetof(struct dirent, d_name[1]))
 
 	if (fp = find_fp(fd)) {
 		/*
--- a/usr/src/uts/sun4u/serengeti/io/sbdp_cpu.c	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/uts/sun4u/serengeti/io/sbdp_cpu.c	Wed Jun 22 12:54:00 2011 -0700
@@ -640,7 +640,7 @@
 	int		cpuid = cp->cpu_id;
 	tte_t		tte;
 	volatile uint_t	*src, *dst;
-	uint_t		funclen;
+	size_t		funclen;
 	sbdp_shutdown_t	sht;
 	uint_t		bbsram_pfn;
 	uint64_t	bbsram_addr;
@@ -648,7 +648,8 @@
 	extern void	sbdp_shutdown_asm(sbdp_shutdown_t *);
 	extern void	sbdp_shutdown_asm_end(void);
 
-	funclen = (uint_t)sbdp_shutdown_asm_end - (uint_t)sbdp_shutdown_asm;
+	funclen = (uintptr_t)sbdp_shutdown_asm_end -
+	    (uintptr_t)sbdp_shutdown_asm;
 	ASSERT(funclen <= MMU_PAGESIZE);
 	ASSERT(bbsram_pa != 0);
 	ASSERT((bbsram_pa & MMU_PAGEOFFSET) == 0);
--- a/usr/src/uts/sun4u/starfire/io/drmach.c	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/uts/sun4u/starfire/io/drmach.c	Wed Jun 22 12:54:00 2011 -0700
@@ -2491,7 +2491,7 @@
 	int		cpuid = (int)CPU->cpu_id;
 	tte_t		tte;
 	volatile uint_t	*src, *dst;
-	uint_t		funclen;
+	size_t		funclen;
 	uint64_t	bbsram_pa, bbsram_offset;
 	uint_t		bbsram_pfn;
 	uint64_t	bbsram_addr;
@@ -2499,7 +2499,8 @@
 	extern void	drmach_shutdown_asm(uint64_t);
 	extern void	drmach_shutdown_asm_end(void);
 
-	funclen = (uint_t)drmach_shutdown_asm_end - (uint_t)drmach_shutdown_asm;
+	funclen = (uintptr_t)drmach_shutdown_asm_end -
+	    (uintptr_t)drmach_shutdown_asm;
 	ASSERT(funclen <= MMU_PAGESIZE);
 	/*
 	 * We'll start from the 0th's base.
@@ -2511,7 +2512,7 @@
 	bbsram_pfn = (uint_t)(bbsram_pa >> MMU_PAGESHIFT);
 
 	bbsram_addr = (uint64_t)drmach_shutdown_va;
-	drmach_shutdown_asm_mbox->estack = bbsram_addr + (uint64_t)funclen;
+	drmach_shutdown_asm_mbox->estack = bbsram_addr + funclen;
 
 	tte.tte_inthi = TTE_VALID_INT | TTE_SZ_INT(TTE8K) |
 	    TTE_PFN_INTHI(bbsram_pfn);
--- a/usr/src/uts/sun4u/starfire/io/idn.c	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/uts/sun4u/starfire/io/idn.c	Wed Jun 22 12:54:00 2011 -0700
@@ -4745,7 +4745,8 @@
 		mutex_enter(&snoop_mutex); \
 		if (snoop_data == NULL) { \
 			snoop_data = (struct snoop_buffer *) \
-				(((uint_t)snoop_buffer + 0xf) & ~0xf); \
+				(((uint_t)(uintptr_t)snoop_buffer + 0xf) & \
+				    ~0xf);				\
 		} \
 		snoop_data[snoop_index].io = ((in) == 0) ? 'o' : 'i'; \
 		snoop_data[snoop_index].board = \
--- a/usr/src/uts/sun4u/starfire/sys/idn.h	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/uts/sun4u/starfire/sys/idn.h	Wed Jun 22 12:54:00 2011 -0700
@@ -2199,8 +2199,8 @@
 
 typedef idn_mboxmsg_t	idn_mboxq_t[1];
 
-#define	IDN_CKSUM_MBOX_COUNT	\
-			(((int)&((idn_mboxhdr_t *)(0))->mh_svr_ready) / 2)
+#define	IDN_CKSUM_MBOX_COUNT	(offsetof(idn_mboxhdr_t, mh_svr_ready) / 2)
+
 #define	IDN_CKSUM_MBOX(h)	\
 			(IDN_CHECKSUM ? \
 			idn_cksum((ushort_t *)(h), IDN_CKSUM_MBOX_COUNT) : 0)
--- a/usr/src/uts/sun4u/starfire/sys/idn_smr.h	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/uts/sun4u/starfire/sys/idn_smr.h	Wed Jun 22 12:54:00 2011 -0700
@@ -29,8 +29,6 @@
 #ifndef	_SYS_IDN_SMR_H
 #define	_SYS_IDN_SMR_H
 
-#pragma ident	"%Z%%M%	%I%	%E% SMI"
-
 #include <sys/sysmacros.h>
 
 #ifdef	__cplusplus
@@ -64,7 +62,8 @@
 #define	IDN_BUF2DATA(b, o)	((caddr_t)((uintptr_t)(b) + (uintptr_t)(o)))
 #define	IDN_BUF2HDR(b)		((smr_pkthdr_t *)(b))
 
-#define	IDN_CKSUM_PKT_COUNT	(((int)&((smr_pkthdr_t *)(0))->b_cksum) / 2)
+#define	IDN_CKSUM_PKT_COUNT	(offsetof(smr_pkthdr_t, b_cksum) / 2)
+
 #define	IDN_CKSUM_PKT(h)	\
 		(IDN_CHECKSUM ? \
 		idn_cksum((ushort_t *)(h), IDN_CKSUM_PKT_COUNT) : 0)
--- a/usr/src/uts/sun4u/vm/zulu_hat.c	Mon Feb 13 15:07:14 2012 -0500
+++ b/usr/src/uts/sun4u/vm/zulu_hat.c	Wed Jun 22 12:54:00 2011 -0700
@@ -24,8 +24,6 @@
  * Use is subject to license terms.
  */
 
-#pragma ident	"%Z%%M%	%I%	%E% SMI"
-
 #include <sys/types.h>
 #include <sys/cmn_err.h>
 #include <sys/mman.h>
@@ -150,9 +148,9 @@
 		ASSERT(zhat != NULL);
 
 		TNF_PROBE_3(steal_ctx_loop, "zulu_hat", /* CSTYLED */,
-			tnf_int, ctx, ctx,
-			tnf_long, last_used, zhat->last_used,
-			tnf_long, oldest, delta);
+		    tnf_int, ctx, ctx,
+		    tnf_long, last_used, zhat->last_used,
+		    tnf_long, oldest, delta);
 
 		if (zhat->last_used <  delta) {
 			zhat_oldest = zhat;
@@ -166,7 +164,7 @@
 
 	/* Nobody should have the tsb lock bit set here */
 	ASSERT(((uint64_t)zulu_ctx_tab[zhat_oldest->zulu_ctx] & ZULU_CTX_LOCK)
-		== 0);
+	    == 0);
 
 	ctx = zhat_oldest->zulu_ctx;
 	zhat_oldest->zulu_ctx = -1;
@@ -362,17 +360,17 @@
 	 * avl_find.
 	 */
 	if ((zhat->sblk_last != NULL) &&
-		(proto.ivaddr == zhat->sblk_last->ivaddr)) {
+	    (proto.ivaddr == zhat->sblk_last->ivaddr)) {
 		sblk = zhat->sblk_last;
 	} else {
 		sblk = (struct zulu_shadow_blk *)avl_find(&zhat->shadow_tree,
-								&proto, where);
+		    &proto, where);
 		zhat->sblk_last = sblk;
 	}
 
 	TNF_PROBE_2(zulu_shadow_tree_lookup, "zulu_shadow_tree", /* CSTYLED */,
-		tnf_opaque, ivaddr, proto.ivaddr,
-		tnf_opaque, where, where ? *where : ~0);
+	    tnf_opaque, ivaddr, proto.ivaddr,
+	    tnf_opaque, where, where ? *where : ~0);
 
 	return (sblk);
 }
@@ -398,7 +396,7 @@
 		sblk->ref_count++;
 
 		end = zblk->zulu_hat_blk_vaddr +
-					ZULU_HAT_PGSZ(zblk->zulu_hat_blk_size);
+		    ZULU_HAT_PGSZ(zblk->zulu_hat_blk_size);
 		if (zblk->zulu_hat_blk_vaddr < sblk->min_addr) {
 			sblk->min_addr = zblk->zulu_hat_blk_vaddr;
 		}
@@ -421,8 +419,8 @@
 	}
 	zblk->zulu_shadow_blk = sblk;
 	TNF_PROBE_2(zulu_shadow_tree_insert, "zulu_shadow_tree", /* CSTYLED */,
-		tnf_opaque, vaddr, ivaddr,
-		tnf_opaque, ref_count, sblk->ref_count);
+	    tnf_opaque, vaddr, ivaddr,
+	    tnf_opaque, ref_count, sblk->ref_count);
 }
 
 /*
@@ -440,8 +438,8 @@
 	sblk = zblk->zulu_shadow_blk;
 
 	TNF_PROBE_2(zulu_shadow_tree_delete, "zulu_shadow_tree", /* CSTYLED */,
-		tnf_opaque, vaddr, sblk->ivaddr,
-		tnf_opaque, ref_count, sblk->ref_count-1);
+	    tnf_opaque, vaddr, sblk->ivaddr,
+	    tnf_opaque, ref_count, sblk->ref_count-1);
 
 	if (--sblk->ref_count == 0) {
 		if (zhat->sblk_last == sblk) {
@@ -461,7 +459,7 @@
 		 * the zblks are deleted in order.
 		 */
 		uint64_t end = zblk->zulu_hat_blk_vaddr +
-					ZULU_HAT_PGSZ(zblk->zulu_hat_blk_size);
+		    ZULU_HAT_PGSZ(zblk->zulu_hat_blk_size);
 
 		if (zblk->zulu_hat_blk_vaddr == sblk->min_addr) {
 			sblk->min_addr = end;
@@ -481,10 +479,10 @@
 	void	*cookie = NULL;
 
 	while ((sblk = (struct zulu_shadow_blk *)avl_destroy_nodes(
-					&zhat->shadow_tree, &cookie)) != NULL) {
+	    &zhat->shadow_tree, &cookie)) != NULL) {
 		TNF_PROBE_2(shadow_tree_destroy, "zulu_hat", /* CSTYLED */,
-			tnf_opaque, vaddr, sblk->ivaddr,
-			tnf_opaque, ref_count, sblk->ref_count);
+		    tnf_opaque, vaddr, sblk->ivaddr,
+		    tnf_opaque, ref_count, sblk->ref_count);
 		kmem_free(sblk, sizeof (*sblk));
 	}
 	avl_destroy(&zhat->shadow_tree);
@@ -506,12 +504,12 @@
 	int tsb_hash;
 
 	tsb_hash = ZULU_TSB_HASH(zblk->zulu_hat_blk_vaddr,
-			    zblk->zulu_hat_blk_size, zhat->zulu_tsb_size);
+	    zblk->zulu_hat_blk_size, zhat->zulu_tsb_size);
 
 	TNF_PROBE_3(zulu_hat_insert_map, "zulu_hat", /* CSTYLED */,
-		tnf_opaque, zblkp, zblk,
-		tnf_opaque, vaddr, zblk->zulu_hat_blk_vaddr,
-		tnf_opaque, hash, tsb_hash);
+	    tnf_opaque, zblkp, zblk,
+	    tnf_opaque, vaddr, zblk->zulu_hat_blk_vaddr,
+	    tnf_opaque, hash, tsb_hash);
 
 	ASSERT(tsb_hash < zhat->zulu_tsb_size);
 
@@ -524,12 +522,12 @@
 	 */
 	zblk->zulu_hash_prev = NULL;
 	zblk->zulu_hash_next = ZULU_MAP_HASH_HEAD(zhat,
-			zblk->zulu_hat_blk_vaddr, zblk->zulu_hat_blk_size);
+	    zblk->zulu_hat_blk_vaddr, zblk->zulu_hat_blk_size);
 	if (zblk->zulu_hash_next) {
 		zblk->zulu_hash_next->zulu_hash_prev = zblk;
 	}
 	ZULU_MAP_HASH_HEAD(zhat, zblk->zulu_hat_blk_vaddr,
-				zblk->zulu_hat_blk_size) = zblk;
+	    zblk->zulu_hat_blk_size) = zblk;
 
 	zulu_ctx_tsb_lock_enter(zhat);
 	zhat->zulu_tsb[tsb_hash] = zblk->zulu_hat_blk_tte;
@@ -543,11 +541,11 @@
 zulu_hat_remove_map(struct zulu_hat *zhat, struct zulu_hat_blk *zblk)
 {
 	int tsb_hash = ZULU_TSB_HASH(zblk->zulu_hat_blk_vaddr,
-			    zblk->zulu_hat_blk_size, zhat->zulu_tsb_size);
+	    zblk->zulu_hat_blk_size, zhat->zulu_tsb_size);
 
 	TNF_PROBE_2(zulu_hat_remove_map, "zulu_hat", /* CSTYLED */,
-		tnf_opaque, vaddr, zblk->zulu_hat_blk_vaddr,
-		tnf_opaque, hash, tsb_hash);
+	    tnf_opaque, vaddr, zblk->zulu_hat_blk_vaddr,
+	    tnf_opaque, hash, tsb_hash);
 
 	ASSERT(tsb_hash < zhat->zulu_tsb_size);
 	ASSERT(mutex_owned(&zhat->lock));
@@ -561,7 +559,7 @@
 		zblk->zulu_hash_prev->zulu_hash_next = zblk->zulu_hash_next;
 	} else {
 		ZULU_MAP_HASH_HEAD(zhat, zblk->zulu_hat_blk_vaddr,
-			zblk->zulu_hat_blk_size) = NULL;
+		    zblk->zulu_hat_blk_size) = NULL;
 	}
 	if (zblk->zulu_hash_next) {
 		zblk->zulu_hash_next->zulu_hash_prev = zblk->zulu_hash_prev;
@@ -593,7 +591,7 @@
 	ASSERT(mutex_owned(&zhat->lock));
 
 	for (zblkp = ZULU_MAP_HASH_HEAD(zhat, ivaddr, page_sz); zblkp != NULL;
-						zblkp = zblkp->zulu_hash_next) {
+	    zblkp = zblkp->zulu_hash_next) {
 		uint64_t	size;
 		uint64_t	iaddr;
 
@@ -606,8 +604,8 @@
 			int tsb_hash;
 
 			tsb_hash = ZULU_TSB_HASH(zblkp->zulu_hat_blk_vaddr,
-				    zblkp->zulu_hat_blk_size,
-				    zhat->zulu_tsb_size);
+			    zblkp->zulu_hat_blk_size,
+			    zhat->zulu_tsb_size);
 			ASSERT(tsb_hash < zhat->zulu_tsb_size);
 
 			zulu_ctx_tsb_lock_enter(zhat);
@@ -619,9 +617,9 @@
 	}
 
 	TNF_PROBE_3(zulu_hat_lookup_map_bysz, "zulu_hat", /* CSTYLED */,
-		tnf_opaque, zblkp, zblkp,
-		tnf_int, blks_checked, blks_checked,
-		tnf_int, page_sz, page_sz);
+	    tnf_opaque, zblkp, zblkp,
+	    tnf_int, blks_checked, blks_checked,
+	    tnf_int, page_sz, page_sz);
 
 	return (zblkp);
 }
@@ -684,8 +682,8 @@
 	struct zulu_tte		tte;
 
 	TNF_PROBE_2(zulu_hat_load, "zulu_hat", /* CSTYLED */,
-		tnf_int, zulu_ctx, zhat->zulu_ctx,
-		tnf_opaque, vaddr, vaddr);
+	    tnf_int, zulu_ctx, zhat->zulu_ctx,
+	    tnf_opaque, vaddr, vaddr);
 
 	mutex_enter(&zhat->lock);
 	ASSERT(zhat->zulu_ctx >= 0);
@@ -703,7 +701,7 @@
 		*p = flags_pfn;		/* load the flags */
 
 		zuluvm_load_tte(zhat, vaddr, flags_pfn, tte.zulu_tte_perm,
-			tte.zulu_tte_size);
+		    tte.zulu_tte_size);
 		if (ppg_size != NULL) {
 			*ppg_size = tte.zulu_tte_size;
 		}
@@ -720,7 +718,7 @@
 		tte = zblkp->zulu_hat_blk_tte;
 		tte.zulu_tte_pfn = ZULU_HAT_ADJ_PFN((&tte), vaddr);
 		zuluvm_load_tte(zhat, vaddr,  tte.zulu_tte_pfn,
-			tte.zulu_tte_perm, tte.zulu_tte_size);
+		    tte.zulu_tte_perm, tte.zulu_tte_size);
 		if (ppg_size != NULL) {
 			*ppg_size = tte.zulu_tte_size;
 		}
@@ -739,8 +737,8 @@
 	TNF_PROBE_0(calling_as_fault, "zulu_hat", /* CSTYLED */);
 
 	as_err = as_fault((struct hat *)zhat, zhat->zulu_xhat.xhat_as,
-			(caddr_t)(ZULU_VADDR((uint64_t)vaddr) & PAGEMASK),
-			PAGESIZE, F_INVAL, rw);
+	    (caddr_t)(ZULU_VADDR((uint64_t)vaddr) & PAGEMASK),
+	    PAGESIZE, F_INVAL, rw);
 
 	mutex_enter(&zhat->lock);
 	zhat->in_fault = 0;
@@ -787,7 +785,7 @@
 	zhat->zulu_tsb_size = ZULU_TSB_NUM;
 	zhat->hash_tbl = kmem_zalloc(ZULU_HASH_TBL_SZ, KM_SLEEP);
 	avl_create(&zhat->shadow_tree, zulu_shadow_tree_compare,
-		sizeof (zhat->shadow_tree), ZULU_SHADOW_BLK_LINK_OFFSET);
+	    sizeof (zhat->shadow_tree), ZULU_SHADOW_BLK_LINK_OFFSET);
 	/*
 	 * The zulu hat has a few opaque data structs embedded in it.
 	 * This tag makes finding the our data easier with a debugger.
@@ -839,9 +837,9 @@
 	pfn_t pfn;
 
 	TNF_PROBE_4(zulu_hat_memload, "zulu_hat", /* CSTYLED */,
-		tnf_int, zulu_ctx, zhat->zulu_ctx,
-		tnf_opaque, vaddr, vaddr, tnf_opaque, attr, attr,
-		tnf_opaque, flags, flags);
+	    tnf_int, zulu_ctx, zhat->zulu_ctx,
+	    tnf_opaque, vaddr, vaddr, tnf_opaque, attr, attr,
+	    tnf_opaque, flags, flags);
 
 	/*
 	 * keep track of the highest address that this zhat has had
@@ -893,10 +891,10 @@
 	zulu_hat_insert_map(zhat, zblk);
 	if (!zhat->freed) {
 		zuluvm_load_tte(zhat, vaddr, zblk->zulu_hat_blk_pfn,
-			zblk->zulu_hat_blk_perm, zblk->zulu_hat_blk_size);
+		    zblk->zulu_hat_blk_perm, zblk->zulu_hat_blk_size);
 	}
 	zhat->fault_ivaddr_last =
-		ZULU_VADDR((uint64_t)zblk->zulu_hat_blk_vaddr);
+	    ZULU_VADDR((uint64_t)zblk->zulu_hat_blk_vaddr);
 
 	mutex_exit(&zhat->lock);
 }
@@ -924,9 +922,9 @@
 	struct zulu_hat *zhat = (struct zulu_hat *)xhat;
 
 	TNF_PROBE_3(zulu_hat_memload_array, "zulu_hat", /* CSTYLED */,
-		tnf_int, zulu_ctx, zhat->zulu_ctx,
-		tnf_opaque, addr, addr,
-		tnf_opaque, len, len);
+	    tnf_int, zulu_ctx, zhat->zulu_ctx,
+	    tnf_opaque, addr, addr,
+	    tnf_opaque, len, len);
 
 	for (; len > 0; len -= ZULU_HAT_PGSZ((*gen_pps)->p_szc),
 	    gen_pps += ZULU_HAT_NUM_PGS((*gen_pps)->p_szc)) {
@@ -1020,7 +1018,7 @@
 				zhat->fault_ivaddr_last = 0;
 			}
 			zulu_hat_demap_page(zhat, (caddr_t)iaddr,
-					zblkp->zulu_hat_blk_size);
+			    zblkp->zulu_hat_blk_size);
 		}
 
 		add_to_free_list(pfree_list, zblkp);
@@ -1047,10 +1045,10 @@
 	(void) flags;
 
 	TNF_PROBE_4(zulu_hat_unload, "zulu_hat", /* CSTYLED */,
-		tnf_int, zulu_ctx, zhat->zulu_ctx,
-		tnf_opaque, vaddr, vaddr,
-		tnf_opaque, vaddr_max, zhat->vaddr_max,
-		tnf_opaque, size, size);
+	    tnf_int, zulu_ctx, zhat->zulu_ctx,
+	    tnf_opaque, vaddr, vaddr,
+	    tnf_opaque, vaddr_max, zhat->vaddr_max,
+	    tnf_opaque, size, size);
 
 	mutex_enter(&zhat->lock);
 
@@ -1086,7 +1084,7 @@
 			found++;
 
 			sblk_end = (ivaddr + ZULU_SHADOW_BLK_RANGE) &
-					ZULU_SHADOW_BLK_MASK;
+			    ZULU_SHADOW_BLK_MASK;
 
 			if (sblk_end < end) {
 				region_size = sblk_end - ivaddr;
@@ -1094,7 +1092,7 @@
 				region_size = end - ivaddr;
 			}
 			zulu_hat_unload_region(zhat, ivaddr, region_size, sblk,
-				&free_list);
+			    &free_list);
 
 		}
 		ivaddr += ZULU_SHADOW_BLK_RANGE;
@@ -1133,9 +1131,9 @@
 	(void) flags;
 
 	TNF_PROBE_3(zulu_hat_pageunload, "zulu_hat", /* CSTYLED */,
-		tnf_int, zulu_ctx, zhat->zulu_ctx,
-		tnf_opaque, vaddr, zblk->zulu_hat_blk_vaddr,
-		tnf_int, pg_size, zblk->zulu_hat_blk_size);
+	    tnf_int, zulu_ctx, zhat->zulu_ctx,
+	    tnf_opaque, vaddr, zblk->zulu_hat_blk_vaddr,
+	    tnf_int, pg_size, zblk->zulu_hat_blk_size);
 
 	mutex_enter(&zhat->lock);
 	if (zblk->zulu_shadow_blk != NULL) {
@@ -1153,8 +1151,9 @@
 		 */
 		if (!zhat->freed) {
 			zulu_hat_demap_page(zhat,
-			(caddr_t)(zblk->zulu_hat_blk_page << ZULU_HAT_BP_SHIFT),
-			zblk->zulu_hat_blk_size);
+			    (caddr_t)(uintptr_t)(zblk->zulu_hat_blk_page <<
+			    ZULU_HAT_BP_SHIFT),
+			    zblk->zulu_hat_blk_size);
 		}
 	} else {
 		/*
@@ -1165,7 +1164,7 @@
 		do_delete = 0;
 
 		TNF_PROBE_0(zulu_hat_pageunload_skip, "zulu_hat",
-			    /* CSTYLED */);
+		    /* CSTYLED */);
 	}
 	mutex_exit(&zhat->lock);
 
@@ -1250,9 +1249,9 @@
 	struct zulu_hat *zhat = (struct zulu_hat *)xhat;
 
 	TNF_PROBE_5(zulu_hat_changeprot, "zulu_hat", /* CSTYLED */,
-		tnf_int, ctx, zhat->zulu_ctx,
-		tnf_opaque, vaddr, vaddr, tnf_opaque, size, size,
-		tnf_uint, flags, flags, tnf_int, op, op);
+	    tnf_int, ctx, zhat->zulu_ctx,
+	    tnf_opaque, vaddr, vaddr, tnf_opaque, size, size,
+	    tnf_uint, flags, flags, tnf_int, op, op);
 
 	zulu_hat_unload(xhat, vaddr, size, 0);
 }
@@ -1263,7 +1262,7 @@
 	struct zulu_hat *zhat = (struct zulu_hat *)xhat;
 #ifdef DEBUG
 	printf("zulu_hat_chgprot: ctx: %d addr: %lx, size: %lx flags: %x\n",
-		zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
+	    zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
 #endif
 	zulu_hat_update_attr(xhat, vaddr, size, flags, ZULU_HAT_CHGATTR);
 }
@@ -1275,7 +1274,7 @@
 	struct zulu_hat *zhat = (struct zulu_hat *)xhat;
 #ifdef DEBUG
 	printf("zulu_hat_setattr: ctx: %d addr: %lx, size: %lx flags: %x\n",
-		zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
+	    zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
 #endif
 	zulu_hat_update_attr(xhat, vaddr, size, flags, ZULU_HAT_SETATTR);
 }
@@ -1286,7 +1285,7 @@
 	struct zulu_hat *zhat = (struct zulu_hat *)xhat;
 #ifdef DEBUG
 	printf("zulu_hat_clrattr: ctx: %d addr: %lx, size: %lx flags: %x\n",
-		zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
+	    zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
 #endif
 	zulu_hat_update_attr(xhat, vaddr, size, flags, ZULU_HAT_CLRATTR);
 }
@@ -1296,12 +1295,12 @@
 {
 	struct zulu_hat *zhat = (struct zulu_hat *)xhat;
 	TNF_PROBE_3(zulu_hat_chgattr, "zulu_hat", /* CSTYLED */,
-		tnf_int, ctx, zhat->zulu_ctx,
-		tnf_opaque, vaddr, vaddr,
-		tnf_opaque, flags, flags);
+	    tnf_int, ctx, zhat->zulu_ctx,
+	    tnf_opaque, vaddr, vaddr,
+	    tnf_opaque, flags, flags);
 #ifdef DEBUG
 	printf("zulu_hat_chgattr: ctx: %d addr: %lx, size: %lx flags: %x\n",
-		zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
+	    zhat->zulu_ctx, (uint64_t)vaddr, size, flags);
 #endif
 	zulu_hat_update_attr(xhat, vaddr, size, flags, ZULU_HAT_CHGATTR);
 }
@@ -1408,7 +1407,7 @@
 	int		xhat_rval;
 
 	xhat_rval = xhat_attach_xhat(&zulu_hat_provider, as,
-			(struct xhat **)&zhat, NULL);
+	    (struct xhat **)&zhat, NULL);
 	if ((xhat_rval == 0) && (zhat != NULL)) {
 		mutex_enter(&zhat->lock);
 		ZULU_HAT2AS(zhat) = as;
@@ -1417,8 +1416,8 @@
 	}
 
 	TNF_PROBE_3(zulu_hat_proc_attach, "zulu_hat", /* CSTYLED */,
-		tnf_int, xhat_rval, xhat_rval, tnf_opaque, as, as,
-		tnf_opaque, zhat, zhat);
+	    tnf_int, xhat_rval, xhat_rval, tnf_opaque, as, as,
+	    tnf_opaque, zhat, zhat);
 
 	return (zhat);
 }