Mercurial > dovecot > core-2.2

changeset 22522:486ddf6a61eb

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
dict-sql: Cleanup - Remove unnecessary code The values are explicitly added to params. sql_dict_update_query() doesn't add them again. Since the "diff" parameter is already a long long type, this avoids unnecessary conversion to string and back.
author Timo Sirainen <timo.sirainen@dovecot.fi>
date Tue, 15 Aug 2017 16:50:16 +0300
parents 6be650aee0b5
children e7d2548700b9
files src/lib-dict/dict-sql.c
diffstat 1 files changed, 2 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/lib-dict/dict-sql.c	Tue Aug 15 16:38:33 2017 +0300
+++ b/src/lib-dict/dict-sql.c	Tue Aug 15 16:50:16 2017 +0300
@@ -1248,7 +1248,7 @@
 	i_assert(map != NULL);
 
 	field.map = map;
-	field.value = t_strdup_printf("%lld", diff);
+	field.value = NULL; /* unused */
 
 	i_zero(&build);
 	build.dict = dict;
@@ -1434,10 +1434,9 @@
 
 		field = array_append_space(&build.fields);
 		field->map = ctx->prev_inc_map;
-		field->value = t_strdup_printf("%lld", ctx->prev_inc_diff);
 		field = array_append_space(&build.fields);
 		field->map = map;
-		field->value = t_strdup_printf("%lld", diff);
+		/* field->value is unused */
 
 		t_array_init(&params, 4);
 		param = array_append_space(&params);