illumos/illumos-gate: usr/src/uts/common/fs/zfs/dsl

annotate usr/src/uts/common/fs/zfs/dsl_dataset.c @ 13387:7dd5626b8b49

1092 zfs refratio property Reviewed by: George Wilson <George.Wilson@delphix.com> Reviewed by: Adam Leventhal <Adam.Leventhal@delphix.com> Reviewed by: Dan McDonald <danmcd@nexenta.com> Reviewed by: Richard Elling <richard.elling@richardelling.com> Reviewed by: Mark Musante <Mark.Musante@oracle.com> Reviewed by: Garrett D'Amore <garrett@nexenta.com> Approved by: Garrett D'Amore <garrett@nexenta.com>

author	Matt Ahrens <Matt.Ahrens@delphix.com>
date	Mon, 13 Jun 2011 18:04:20 -0700
parents	8c712bbb18ea
children	04570f5cbeca

rev	line source
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2 * CDDL HEADER START
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	3 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	4 * The contents of this file are subject to the terms of the
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	5 * Common Development and Distribution License (the "License").
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	6 * You may not use this file except in compliance with the License.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	7 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	8 * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	9 * or http://www.opensolaris.org/os/licensing.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	10 * See the License for the specific language governing permissions
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	11 * and limitations under the License.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	12 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	13 * When distributing Covered Code, include this CDDL HEADER in each
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	14 * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	15 * If applicable, add the following below this CDDL HEADER, with the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	16 * fields enclosed by brackets "[]" replaced with your own identifying
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	17 * information: Portions Copyright [yyyy] [name of copyright owner]
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	18 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	19 * CDDL HEADER END
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	20 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	21 /*
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	22 * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
13387 7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	23 * Copyright (c) 2011 by Delphix. All rights reserved.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	24 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	25
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	26 #include <sys/dmu_objset.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	27 #include <sys/dsl_dataset.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	28 #include <sys/dsl_dir.h>
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	29 #include <sys/dsl_prop.h>
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	30 #include <sys/dsl_synctask.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	31 #include <sys/dmu_traverse.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	32 #include <sys/dmu_tx.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	33 #include <sys/arc.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	34 #include <sys/zio.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	35 #include <sys/zap.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	36 #include <sys/unique.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	37 #include <sys/zfs_context.h>
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	38 #include <sys/zfs_ioctl.h>
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	39 #include <sys/spa.h>
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	40 #include <sys/zfs_znode.h>
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	41 #include <sys/zfs_onexit.h>
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	42 #include <sys/zvol.h>
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	43 #include <sys/dsl_scan.h>
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	44 #include <sys/dsl_deadlist.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	45
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	46 static char *dsl_reaper = "the grim reaper";
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	47
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	48 static dsl_checkfunc_t dsl_dataset_destroy_begin_check;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	49 static dsl_syncfunc_t dsl_dataset_destroy_begin_sync;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	50 static dsl_syncfunc_t dsl_dataset_set_reservation_sync;
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	51
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	52 #define SWITCH64(x, y) \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	53 { \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	54 uint64_t __tmp = (x); \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	55 (x) = (y); \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	56 (y) = __tmp; \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	57 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	58
3444 dc160a70a50d 6410433 'zpool status -v' would be more useful with filenames ek110237 parents: 3025 diff changeset	59 #define DS_REF_MAX (1ULL << 62)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	60
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	61 #define DSL_DEADLIST_BLOCKSIZE SPA_MAXBLOCKSIZE
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	62
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	63 #define DSL_DATASET_IS_DESTROYED(ds) ((ds)->ds_owner == dsl_reaper)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	64
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	65
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	66 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	67 * Figure out how much of this delta should be propogated to the dsl_dir
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	68 * layer. If there's a refreservation, that space has already been
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	69 * partially accounted for in our ancestors.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	70 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	71 static int64_t
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	72 parent_delta(dsl_dataset_t *ds, int64_t delta)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	73 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	74 uint64_t old_bytes, new_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	75
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	76 if (ds->ds_reserved == 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	77 return (delta);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	78
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	79 old_bytes = MAX(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	80 new_bytes = MAX(ds->ds_phys->ds_unique_bytes + delta, ds->ds_reserved);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	81
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	82 ASSERT3U(ABS((int64_t)(new_bytes - old_bytes)), <=, ABS(delta));
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	83 return (new_bytes - old_bytes);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	84 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	85
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	86 void
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	87 dsl_dataset_block_born(dsl_dataset_t ds, const blkptr_t bp, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	88 {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	89 int used = bp_get_dsize_sync(tx->tx_pool->dp_spa, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	90 int compressed = BP_GET_PSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	91 int uncompressed = BP_GET_UCSIZE(bp);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	92 int64_t delta;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	93
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	94 dprintf_bp(bp, "ds=%p", ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	95
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	96 ASSERT(dmu_tx_is_syncing(tx));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	97 /* It could have been compressed away to nothing */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	98 if (BP_IS_HOLE(bp))
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	99 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	100 ASSERT(BP_GET_TYPE(bp) != DMU_OT_NONE);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	101 ASSERT3U(BP_GET_TYPE(bp), <, DMU_OT_NUMTYPES);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	102 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	103 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	104 * Account for the meta-objset space in its placeholder
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	105 * dsl_dir.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	106 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	107 ASSERT3U(compressed, ==, uncompressed); /* it's all metadata */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	108 dsl_dir_diduse_space(tx->tx_pool->dp_mos_dir, DD_USED_HEAD,
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	109 used, compressed, uncompressed, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	110 dsl_dir_dirty(tx->tx_pool->dp_mos_dir, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	111 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	112 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	113 dmu_buf_will_dirty(ds->ds_dbuf, tx);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	114
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	115 mutex_enter(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	116 mutex_enter(&ds->ds_lock);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	117 delta = parent_delta(ds, used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	118 ds->ds_phys->ds_used_bytes += used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	119 ds->ds_phys->ds_compressed_bytes += compressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	120 ds->ds_phys->ds_uncompressed_bytes += uncompressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	121 ds->ds_phys->ds_unique_bytes += used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	122 mutex_exit(&ds->ds_lock);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	123 dsl_dir_diduse_space(ds->ds_dir, DD_USED_HEAD, delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	124 compressed, uncompressed, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	125 dsl_dir_transfer_space(ds->ds_dir, used - delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	126 DD_USED_REFRSRV, DD_USED_HEAD, tx);
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	127 mutex_exit(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	128 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	129
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	130 int
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	131 dsl_dataset_block_kill(dsl_dataset_t ds, const blkptr_t bp, dmu_tx_t *tx,
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	132 boolean_t async)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	133 {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	134 if (BP_IS_HOLE(bp))
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	135 return (0);
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	136
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	137 ASSERT(dmu_tx_is_syncing(tx));
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	138 ASSERT(bp->blk_birth <= tx->tx_txg);
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	139
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	140 int used = bp_get_dsize_sync(tx->tx_pool->dp_spa, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	141 int compressed = BP_GET_PSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	142 int uncompressed = BP_GET_UCSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	143
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	144 ASSERT(used > 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	145 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	146 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	147 * Account for the meta-objset space in its placeholder
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	148 * dataset.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	149 */
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	150 dsl_free(tx->tx_pool, tx->tx_txg, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	151
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	152 dsl_dir_diduse_space(tx->tx_pool->dp_mos_dir, DD_USED_HEAD,
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	153 -used, -compressed, -uncompressed, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	154 dsl_dir_dirty(tx->tx_pool->dp_mos_dir, tx);
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	155 return (used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	156 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	157 ASSERT3P(tx->tx_pool, ==, ds->ds_dir->dd_pool);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	158
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	159 ASSERT(!dsl_dataset_is_snapshot(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	160 dmu_buf_will_dirty(ds->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	161
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	162 if (bp->blk_birth > ds->ds_phys->ds_prev_snap_txg) {
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	163 int64_t delta;
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	164
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	165 dprintf_bp(bp, "freeing ds=%llu", ds->ds_object);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	166 dsl_free(tx->tx_pool, tx->tx_txg, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	167
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	168 mutex_enter(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	169 mutex_enter(&ds->ds_lock);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	170 ASSERT(ds->ds_phys->ds_unique_bytes >= used \|\|
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	171 !DS_UNIQUE_IS_ACCURATE(ds));
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	172 delta = parent_delta(ds, -used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	173 ds->ds_phys->ds_unique_bytes -= used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	174 mutex_exit(&ds->ds_lock);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	175 dsl_dir_diduse_space(ds->ds_dir, DD_USED_HEAD,
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	176 delta, -compressed, -uncompressed, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	177 dsl_dir_transfer_space(ds->ds_dir, -used - delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	178 DD_USED_REFRSRV, DD_USED_HEAD, tx);
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	179 mutex_exit(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	180 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	181 dprintf_bp(bp, "putting on dead list: %s", "");
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	182 if (async) {
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	183 /*
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	184 * We are here as part of zio's write done callback,
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	185 * which means we're a zio interrupt thread. We can't
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	186 * call dsl_deadlist_insert() now because it may block
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	187 * waiting for I/O. Instead, put bp on the deferred
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	188 * queue and let dsl_pool_sync() finish the job.
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	189 */
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	190 bplist_append(&ds->ds_pending_deadlist, bp);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	191 } else {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	192 dsl_deadlist_insert(&ds->ds_deadlist, bp, tx);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	193 }
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	194 ASSERT3U(ds->ds_prev->ds_object, ==,
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	195 ds->ds_phys->ds_prev_snap_obj);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	196 ASSERT(ds->ds_prev->ds_phys->ds_num_children > 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	197 /* if (bp->blk_birth > prev prev snap txg) prev unique += bs */
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	198 if (ds->ds_prev->ds_phys->ds_next_snap_obj ==
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	199 ds->ds_object && bp->blk_birth >
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	200 ds->ds_prev->ds_phys->ds_prev_snap_txg) {
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	201 dmu_buf_will_dirty(ds->ds_prev->ds_dbuf, tx);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	202 mutex_enter(&ds->ds_prev->ds_lock);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	203 ds->ds_prev->ds_phys->ds_unique_bytes += used;
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	204 mutex_exit(&ds->ds_prev->ds_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	205 }
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	206 if (bp->blk_birth > ds->ds_dir->dd_origin_txg) {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	207 dsl_dir_transfer_space(ds->ds_dir, used,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	208 DD_USED_HEAD, DD_USED_SNAP, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	209 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	210 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	211 mutex_enter(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	212 ASSERT3U(ds->ds_phys->ds_used_bytes, >=, used);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	213 ds->ds_phys->ds_used_bytes -= used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	214 ASSERT3U(ds->ds_phys->ds_compressed_bytes, >=, compressed);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	215 ds->ds_phys->ds_compressed_bytes -= compressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	216 ASSERT3U(ds->ds_phys->ds_uncompressed_bytes, >=, uncompressed);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	217 ds->ds_phys->ds_uncompressed_bytes -= uncompressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	218 mutex_exit(&ds->ds_lock);
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	219
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	220 return (used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	221 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	222
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	223 uint64_t
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	224 dsl_dataset_prev_snap_txg(dsl_dataset_t *ds)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	225 {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	226 uint64_t trysnap = 0;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	227
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	228 if (ds == NULL)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	229 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	230 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	231 * The snapshot creation could fail, but that would cause an
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	232 * incorrect FALSE return, which would only result in an
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	233 * overestimation of the amount of space that an operation would
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	234 * consume, which is OK.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	235 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	236 * There's also a small window where we could miss a pending
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	237 * snapshot, because we could set the sync task in the quiescing
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	238 * phase. So this should only be used as a guess.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	239 */
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	240 if (ds->ds_trysnap_txg >
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	241 spa_last_synced_txg(ds->ds_dir->dd_pool->dp_spa))
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	242 trysnap = ds->ds_trysnap_txg;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	243 return (MAX(ds->ds_phys->ds_prev_snap_txg, trysnap));
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	244 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	245
9653 a70048a304d1 6664765 Unable to remove files when using fat-zap and quota exceeded on ZFS filesystem Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 9396 diff changeset	246 boolean_t
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	247 dsl_dataset_block_freeable(dsl_dataset_t ds, const blkptr_t bp,
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	248 uint64_t blk_birth)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	249 {
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	250 if (blk_birth <= dsl_dataset_prev_snap_txg(ds))
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	251 return (B_FALSE);
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	252
12587 16aef3d16470 6957090 ddt_zap_prefetch() induces deadlock, panic George Wilson <George.Wilson@Sun.COM> parents: 12527 diff changeset	253 ddt_prefetch(dsl_dataset_get_spa(ds), bp);
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	254
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	255 return (B_TRUE);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	256 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	257
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	258 /* ARGSUSED */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	259 static void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	260 dsl_dataset_evict(dmu_buf_t db, void dsv)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	261 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	262 dsl_dataset_t *ds = dsv;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	263
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	264 ASSERT(ds->ds_owner == NULL \|\| DSL_DATASET_IS_DESTROYED(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	265
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	266 unique_remove(ds->ds_fsid_guid);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	267
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	268 if (ds->ds_objset != NULL)
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	269 dmu_objset_evict(ds->ds_objset);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	270
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	271 if (ds->ds_prev) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	272 dsl_dataset_drop_ref(ds->ds_prev, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	273 ds->ds_prev = NULL;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	274 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	275
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	276 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	277 if (db != NULL) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	278 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	279 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	280 ASSERT(ds->ds_deadlist.dl_dbuf == NULL);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	281 ASSERT(!ds->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	282 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	283 if (ds->ds_dir)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	284 dsl_dir_close(ds->ds_dir, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	285
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	286 ASSERT(!list_link_active(&ds->ds_synced_link));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	287
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	288 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	289 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	290 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	291 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	292 cv_destroy(&ds->ds_exclusive_cv);
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	293
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	294 kmem_free(ds, sizeof (dsl_dataset_t));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	295 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	296
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	297 static int
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	298 dsl_dataset_get_snapname(dsl_dataset_t *ds)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	299 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	300 dsl_dataset_phys_t *headphys;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	301 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	302 dmu_buf_t *headdbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	303 dsl_pool_t *dp = ds->ds_dir->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	304 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	305
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	306 if (ds->ds_snapname[0])
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	307 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	308 if (ds->ds_phys->ds_next_snap_obj == 0)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	309 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	310
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	311 err = dmu_bonus_hold(mos, ds->ds_dir->dd_phys->dd_head_dataset_obj,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	312 FTAG, &headdbuf);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	313 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	314 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	315 headphys = headdbuf->db_data;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	316 err = zap_value_search(dp->dp_meta_objset,
4577 ed36b0e652bc PSARC/2007/328 zfs upgrade ahrens parents: 4569 diff changeset	317 headphys->ds_snapnames_zapobj, ds->ds_object, 0, ds->ds_snapname);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	318 dmu_buf_rele(headdbuf, FTAG);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	319 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	320 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	321
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	322 static int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	323 dsl_dataset_snap_lookup(dsl_dataset_t ds, const char name, uint64_t *value)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	324 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	325 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	326 uint64_t snapobj = ds->ds_phys->ds_snapnames_zapobj;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	327 matchtype_t mt;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	328 int err;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	329
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	330 if (ds->ds_phys->ds_flags & DS_FLAG_CI_DATASET)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	331 mt = MT_FIRST;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	332 else
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	333 mt = MT_EXACT;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	334
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	335 err = zap_lookup_norm(mos, snapobj, name, 8, 1,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	336 value, mt, NULL, 0, NULL);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	337 if (err == ENOTSUP && mt == MT_FIRST)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	338 err = zap_lookup(mos, snapobj, name, 8, 1, value);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	339 return (err);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	340 }
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	341
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	342 static int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	343 dsl_dataset_snap_remove(dsl_dataset_t ds, char name, dmu_tx_t *tx)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	344 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	345 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	346 uint64_t snapobj = ds->ds_phys->ds_snapnames_zapobj;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	347 matchtype_t mt;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	348 int err;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	349
10373 bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	350 dsl_dir_snap_cmtime_update(ds->ds_dir);
bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	351
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	352 if (ds->ds_phys->ds_flags & DS_FLAG_CI_DATASET)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	353 mt = MT_FIRST;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	354 else
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	355 mt = MT_EXACT;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	356
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	357 err = zap_remove_norm(mos, snapobj, name, mt, tx);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	358 if (err == ENOTSUP && mt == MT_FIRST)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	359 err = zap_remove(mos, snapobj, name, tx);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	360 return (err);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	361 }
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	362
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	363 static int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	364 dsl_dataset_get_ref(dsl_pool_t dp, uint64_t dsobj, void tag,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	365 dsl_dataset_t **dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	366 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	367 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	368 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	369 dsl_dataset_t *ds;
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	370 int err;
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	371 dmu_object_info_t doi;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	372
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	373 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock) \|\|
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	374 dsl_pool_sync_context(dp));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	375
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	376 err = dmu_bonus_hold(mos, dsobj, tag, &dbuf);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	377 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	378 return (err);
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	379
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	380 /* Make sure dsobj has the correct object type. */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	381 dmu_object_info_from_db(dbuf, &doi);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	382 if (doi.doi_type != DMU_OT_DSL_DATASET)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	383 return (EINVAL);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	384
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	385 ds = dmu_buf_get_user(dbuf);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	386 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	387 dsl_dataset_t *winner;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	388
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	389 ds = kmem_zalloc(sizeof (dsl_dataset_t), KM_SLEEP);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	390 ds->ds_dbuf = dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	391 ds->ds_object = dsobj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	392 ds->ds_phys = dbuf->db_data;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	393
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	394 mutex_init(&ds->ds_lock, NULL, MUTEX_DEFAULT, NULL);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	395 mutex_init(&ds->ds_recvlock, NULL, MUTEX_DEFAULT, NULL);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	396 mutex_init(&ds->ds_opening_lock, NULL, MUTEX_DEFAULT, NULL);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	397 rw_init(&ds->ds_rwlock, 0, 0, 0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	398 cv_init(&ds->ds_exclusive_cv, NULL, CV_DEFAULT, NULL);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	399
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	400 bplist_create(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	401 dsl_deadlist_open(&ds->ds_deadlist,
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	402 mos, ds->ds_phys->ds_deadlist_obj);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	403
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	404 if (err == 0) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	405 err = dsl_dir_open_obj(dp,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	406 ds->ds_phys->ds_dir_obj, NULL, ds, &ds->ds_dir);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	407 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	408 if (err) {
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	409 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	410 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	411 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	412 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	413 cv_destroy(&ds->ds_exclusive_cv);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	414 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	415 dsl_deadlist_close(&ds->ds_deadlist);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	416 kmem_free(ds, sizeof (dsl_dataset_t));
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	417 dmu_buf_rele(dbuf, tag);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	418 return (err);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	419 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	420
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	421 if (!dsl_dataset_is_snapshot(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	422 ds->ds_snapname[0] = '\0';
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	423 if (ds->ds_phys->ds_prev_snap_obj) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	424 err = dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	425 ds->ds_phys->ds_prev_snap_obj,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	426 ds, &ds->ds_prev);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	427 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	428 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	429 if (zfs_flags & ZFS_DEBUG_SNAPNAMES)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	430 err = dsl_dataset_get_snapname(ds);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	431 if (err == 0 && ds->ds_phys->ds_userrefs_obj != 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	432 err = zap_count(
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	433 ds->ds_dir->dd_pool->dp_meta_objset,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	434 ds->ds_phys->ds_userrefs_obj,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	435 &ds->ds_userrefs);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	436 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	437 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	438
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	439 if (err == 0 && !dsl_dataset_is_snapshot(ds)) {
5569 d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	440 /*
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	441 * In sync context, we're called with either no lock
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	442 * or with the write lock. If we're not syncing,
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	443 * we're always called with the read lock held.
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	444 */
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	445 boolean_t need_lock =
5569 d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	446 !RW_WRITE_HELD(&dp->dp_config_rwlock) &&
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	447 dsl_pool_sync_context(dp);
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	448
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	449 if (need_lock)
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	450 rw_enter(&dp->dp_config_rwlock, RW_READER);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	451
7265 cc18862247da PSARC/2008/483 ZFS clone -o ahrens parents: 7237 diff changeset	452 err = dsl_prop_get_ds(ds,
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	453 "refreservation", sizeof (uint64_t), 1,
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	454 &ds->ds_reserved, NULL);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	455 if (err == 0) {
7265 cc18862247da PSARC/2008/483 ZFS clone -o ahrens parents: 7237 diff changeset	456 err = dsl_prop_get_ds(ds,
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	457 "refquota", sizeof (uint64_t), 1,
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	458 &ds->ds_quota, NULL);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	459 }
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	460
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	461 if (need_lock)
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	462 rw_exit(&dp->dp_config_rwlock);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	463 } else {
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	464 ds->ds_reserved = ds->ds_quota = 0;
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	465 }
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	466
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	467 if (err == 0) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	468 winner = dmu_buf_set_user_ie(dbuf, ds, &ds->ds_phys,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	469 dsl_dataset_evict);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	470 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	471 if (err \|\| winner) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	472 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	473 dsl_deadlist_close(&ds->ds_deadlist);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	474 if (ds->ds_prev)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	475 dsl_dataset_drop_ref(ds->ds_prev, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	476 dsl_dir_close(ds->ds_dir, ds);
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	477 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	478 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	479 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	480 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	481 cv_destroy(&ds->ds_exclusive_cv);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	482 kmem_free(ds, sizeof (dsl_dataset_t));
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	483 if (err) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	484 dmu_buf_rele(dbuf, tag);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	485 return (err);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	486 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	487 ds = winner;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	488 } else {
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	489 ds->ds_fsid_guid =
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	490 unique_insert(ds->ds_phys->ds_fsid_guid);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	491 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	492 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	493 ASSERT3P(ds->ds_dbuf, ==, dbuf);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	494 ASSERT3P(ds->ds_phys, ==, dbuf->db_data);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	495 ASSERT(ds->ds_phys->ds_prev_snap_obj != 0 \|\|
7061 524fec1acf1c 6723703 zpool upgrade -> assertion failed: ds->ds_phys->ds_prev_snap_obj != 0 \|\| ... ahrens parents: 7046 diff changeset	496 spa_version(dp->dp_spa) < SPA_VERSION_ORIGIN \|\|
7077 a63bdc0b8352 6724675 assertion failed in dsl_dataset_get_ref(): ds->ds_phys->ds_prev_snap_obj != 0 ... ahrens parents: 7061 diff changeset	497 dp->dp_origin_snap == NULL \|\| ds == dp->dp_origin_snap);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	498 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	499 if (!dsl_pool_sync_context(dp) && DSL_DATASET_IS_DESTROYED(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	500 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	501 dmu_buf_rele(ds->ds_dbuf, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	502 return (ENOENT);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	503 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	504 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	505 *dsp = ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	506 return (0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	507 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	508
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	509 static int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	510 dsl_dataset_hold_ref(dsl_dataset_t ds, void tag)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	511 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	512 dsl_pool_t *dp = ds->ds_dir->dd_pool;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	513
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	514 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	515 * In syncing context we don't want the rwlock lock: there
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	516 * may be an existing writer waiting for sync phase to
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	517 * finish. We don't need to worry about such writers, since
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	518 * sync phase is single-threaded, so the writer can't be
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	519 * doing anything while we are active.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	520 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	521 if (dsl_pool_sync_context(dp)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	522 ASSERT(!DSL_DATASET_IS_DESTROYED(ds));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	523 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	524 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	525
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	526 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	527 * Normal users will hold the ds_rwlock as a READER until they
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	528 * are finished (i.e., call dsl_dataset_rele()). "Owners" will
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	529 * drop their READER lock after they set the ds_owner field.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	530 *
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	531 * If the dataset is being destroyed, the destroy thread will
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	532 * obtain a WRITER lock for exclusive access after it's done its
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	533 * open-context work and then change the ds_owner to
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	534 * dsl_reaper once destruction is assured. So threads
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	535 * may block here temporarily, until the "destructability" of
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	536 * the dataset is determined.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	537 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	538 ASSERT(!RW_WRITE_HELD(&dp->dp_config_rwlock));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	539 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	540 while (!rw_tryenter(&ds->ds_rwlock, RW_READER)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	541 rw_exit(&dp->dp_config_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	542 cv_wait(&ds->ds_exclusive_cv, &ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	543 if (DSL_DATASET_IS_DESTROYED(ds)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	544 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	545 dsl_dataset_drop_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	546 rw_enter(&dp->dp_config_rwlock, RW_READER);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	547 return (ENOENT);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	548 }
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	549 /*
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	550 * The dp_config_rwlock lives above the ds_lock. And
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	551 * we need to check DSL_DATASET_IS_DESTROYED() while
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	552 * holding the ds_lock, so we have to drop and reacquire
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	553 * the ds_lock here.
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	554 */
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	555 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	556 rw_enter(&dp->dp_config_rwlock, RW_READER);
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	557 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	558 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	559 mutex_exit(&ds->ds_lock);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	560 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	561 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	562
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	563 int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	564 dsl_dataset_hold_obj(dsl_pool_t dp, uint64_t dsobj, void tag,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	565 dsl_dataset_t **dsp)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	566 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	567 int err = dsl_dataset_get_ref(dp, dsobj, tag, dsp);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	568
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	569 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	570 return (err);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	571 return (dsl_dataset_hold_ref(*dsp, tag));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	572 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	573
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	574 int
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	575 dsl_dataset_own_obj(dsl_pool_t *dp, uint64_t dsobj, boolean_t inconsistentok,
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	576 void tag, dsl_dataset_t *dsp)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	577 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	578 int err = dsl_dataset_hold_obj(dp, dsobj, tag, dsp);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	579 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	580 return (err);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	581 if (!dsl_dataset_tryown(*dsp, inconsistentok, tag)) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	582 dsl_dataset_rele(*dsp, tag);
8779 f164e0e90508 6784924 panic while ludelete (zfs destroy) Mark J Musante <Mark.Musante@Sun.COM> parents: 8746 diff changeset	583 *dsp = NULL;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	584 return (EBUSY);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	585 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	586 return (0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	587 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	588
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	589 int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	590 dsl_dataset_hold(const char name, void tag, dsl_dataset_t **dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	591 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	592 dsl_dir_t *dd;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	593 dsl_pool_t *dp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	594 const char *snapname;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	595 uint64_t obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	596 int err = 0;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	597
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	598 err = dsl_dir_open_spa(NULL, name, FTAG, &dd, &snapname);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	599 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	600 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	601
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	602 dp = dd->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	603 obj = dd->dd_phys->dd_head_dataset_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	604 rw_enter(&dp->dp_config_rwlock, RW_READER);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	605 if (obj)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	606 err = dsl_dataset_get_ref(dp, obj, tag, dsp);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	607 else
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	608 err = ENOENT;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	609 if (err)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	610 goto out;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	611
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	612 err = dsl_dataset_hold_ref(*dsp, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	613
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	614 /* we may be looking for a snapshot */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	615 if (err == 0 && snapname != NULL) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	616 dsl_dataset_t *ds = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	617
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	618 if (*snapname++ != '@') {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	619 dsl_dataset_rele(*dsp, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	620 err = ENOENT;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	621 goto out;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	622 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	623
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	624 dprintf("looking for snapshot '%s'\n", snapname);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	625 err = dsl_dataset_snap_lookup(*dsp, snapname, &obj);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	626 if (err == 0)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	627 err = dsl_dataset_get_ref(dp, obj, tag, &ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	628 dsl_dataset_rele(*dsp, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	629
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	630 ASSERT3U((err == 0), ==, (ds != NULL));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	631
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	632 if (ds) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	633 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	634 if (ds->ds_snapname[0] == 0)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	635 (void) strlcpy(ds->ds_snapname, snapname,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	636 sizeof (ds->ds_snapname));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	637 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	638 err = dsl_dataset_hold_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	639 *dsp = err ? NULL : ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	640 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	641 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	642 out:
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	643 rw_exit(&dp->dp_config_rwlock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	644 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	645 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	646 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	647
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	648 int
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	649 dsl_dataset_own(const char *name, boolean_t inconsistentok,
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	650 void tag, dsl_dataset_t *dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	651 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	652 int err = dsl_dataset_hold(name, tag, dsp);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	653 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	654 return (err);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	655 if (!dsl_dataset_tryown(*dsp, inconsistentok, tag)) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	656 dsl_dataset_rele(*dsp, tag);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	657 return (EBUSY);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	658 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	659 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	660 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	661
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	662 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	663 dsl_dataset_name(dsl_dataset_t ds, char name)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	664 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	665 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	666 (void) strcpy(name, "mos");
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	667 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	668 dsl_dir_name(ds->ds_dir, name);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	669 VERIFY(0 == dsl_dataset_get_snapname(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	670 if (ds->ds_snapname[0]) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	671 (void) strcat(name, "@");
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	672 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	673 * We use a "recursive" mutex so that we
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	674 * can call dprintf_ds() with ds_lock held.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	675 */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	676 if (!MUTEX_HELD(&ds->ds_lock)) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	677 mutex_enter(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	678 (void) strcat(name, ds->ds_snapname);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	679 mutex_exit(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	680 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	681 (void) strcat(name, ds->ds_snapname);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	682 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	683 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	684 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	685 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	686
3978 2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	687 static int
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	688 dsl_dataset_namelen(dsl_dataset_t *ds)
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	689 {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	690 int result;
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	691
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	692 if (ds == NULL) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	693 result = 3; /* "mos" */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	694 } else {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	695 result = dsl_dir_namelen(ds->ds_dir);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	696 VERIFY(0 == dsl_dataset_get_snapname(ds));
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	697 if (ds->ds_snapname[0]) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	698 ++result; /* adding one for the @-sign */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	699 if (!MUTEX_HELD(&ds->ds_lock)) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	700 mutex_enter(&ds->ds_lock);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	701 result += strlen(ds->ds_snapname);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	702 mutex_exit(&ds->ds_lock);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	703 } else {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	704 result += strlen(ds->ds_snapname);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	705 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	706 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	707 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	708
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	709 return (result);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	710 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	711
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	712 void
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	713 dsl_dataset_drop_ref(dsl_dataset_t ds, void tag)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	714 {
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	715 dmu_buf_rele(ds->ds_dbuf, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	716 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	717
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	718 void
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	719 dsl_dataset_rele(dsl_dataset_t ds, void tag)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	720 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	721 if (!dsl_pool_sync_context(ds->ds_dir->dd_pool)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	722 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	723 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	724 dsl_dataset_drop_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	725 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	726
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	727 void
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	728 dsl_dataset_disown(dsl_dataset_t ds, void tag)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	729 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	730 ASSERT((ds->ds_owner == tag && ds->ds_dbuf) \|\|
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	731 (DSL_DATASET_IS_DESTROYED(ds) && ds->ds_dbuf == NULL));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	732
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	733 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	734 ds->ds_owner = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	735 if (RW_WRITE_HELD(&ds->ds_rwlock)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	736 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	737 cv_broadcast(&ds->ds_exclusive_cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	738 }
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	739 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	740 if (ds->ds_dbuf)
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	741 dsl_dataset_drop_ref(ds, tag);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	742 else
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	743 dsl_dataset_evict(NULL, ds);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	744 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	745
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	746 boolean_t
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	747 dsl_dataset_tryown(dsl_dataset_t ds, boolean_t inconsistentok, void tag)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	748 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	749 boolean_t gotit = FALSE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	750
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	751 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	752 if (ds->ds_owner == NULL &&
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	753 (!DS_IS_INCONSISTENT(ds) \|\| inconsistentok)) {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	754 ds->ds_owner = tag;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	755 if (!dsl_pool_sync_context(ds->ds_dir->dd_pool))
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	756 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	757 gotit = TRUE;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	758 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	759 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	760 return (gotit);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	761 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	762
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	763 void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	764 dsl_dataset_make_exclusive(dsl_dataset_t ds, void owner)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	765 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	766 ASSERT3P(owner, ==, ds->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	767 if (!RW_WRITE_HELD(&ds->ds_rwlock))
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	768 rw_enter(&ds->ds_rwlock, RW_WRITER);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	769 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	770
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	771 uint64_t
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	772 dsl_dataset_create_sync_dd(dsl_dir_t dd, dsl_dataset_t origin,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	773 uint64_t flags, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	774 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	775 dsl_pool_t *dp = dd->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	776 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	777 dsl_dataset_phys_t *dsphys;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	778 uint64_t dsobj;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	779 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	780
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	781 if (origin == NULL)
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	782 origin = dp->dp_origin_snap;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	783
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	784 ASSERT(origin == NULL \|\| origin->ds_dir->dd_pool == dp);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	785 ASSERT(origin == NULL \|\| origin->ds_phys->ds_num_children > 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	786 ASSERT(dmu_tx_is_syncing(tx));
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	787 ASSERT(dd->dd_phys->dd_head_dataset_obj == 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	788
928 36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	789 dsobj = dmu_object_alloc(mos, DMU_OT_DSL_DATASET, 0,
36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	790 DMU_OT_DSL_DATASET, sizeof (dsl_dataset_phys_t), tx);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	791 VERIFY(0 == dmu_bonus_hold(mos, dsobj, FTAG, &dbuf));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	792 dmu_buf_will_dirty(dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	793 dsphys = dbuf->db_data;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	794 bzero(dsphys, sizeof (dsl_dataset_phys_t));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	795 dsphys->ds_dir_obj = dd->dd_object;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	796 dsphys->ds_flags = flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	797 dsphys->ds_fsid_guid = unique_create();
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	798 (void) random_get_pseudo_bytes((void*)&dsphys->ds_guid,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	799 sizeof (dsphys->ds_guid));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	800 dsphys->ds_snapnames_zapobj =
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	801 zap_create_norm(mos, U8_TEXTPREP_TOUPPER, DMU_OT_DSL_DS_SNAP_MAP,
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	802 DMU_OT_NONE, 0, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	803 dsphys->ds_creation_time = gethrestime_sec();
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	804 dsphys->ds_creation_txg = tx->tx_txg == TXG_INITIAL ? 1 : tx->tx_txg;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	805
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	806 if (origin == NULL) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	807 dsphys->ds_deadlist_obj = dsl_deadlist_alloc(mos, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	808 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	809 dsl_dataset_t *ohds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	810
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	811 dsphys->ds_prev_snap_obj = origin->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	812 dsphys->ds_prev_snap_txg =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	813 origin->ds_phys->ds_creation_txg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	814 dsphys->ds_used_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	815 origin->ds_phys->ds_used_bytes;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	816 dsphys->ds_compressed_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	817 origin->ds_phys->ds_compressed_bytes;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	818 dsphys->ds_uncompressed_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	819 origin->ds_phys->ds_uncompressed_bytes;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	820 dsphys->ds_bp = origin->ds_phys->ds_bp;
6502 66aef5f20377 6694731 drc->drc_real_ds->ds_phys->ds_flags & (1ULL<<0), file: ../../common/fs/zfs/dmu_send.c, line: 1069 timh parents: 6492 diff changeset	821 dsphys->ds_flags \|= origin->ds_phys->ds_flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	822
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	823 dmu_buf_will_dirty(origin->ds_dbuf, tx);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	824 origin->ds_phys->ds_num_children++;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	825
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	826 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	827 origin->ds_dir->dd_phys->dd_head_dataset_obj, FTAG, &ohds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	828 dsphys->ds_deadlist_obj = dsl_deadlist_clone(&ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	829 dsphys->ds_prev_snap_txg, dsphys->ds_prev_snap_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	830 dsl_dataset_rele(ohds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	831
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	832 if (spa_version(dp->dp_spa) >= SPA_VERSION_NEXT_CLONES) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	833 if (origin->ds_phys->ds_next_clones_obj == 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	834 origin->ds_phys->ds_next_clones_obj =
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	835 zap_create(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	836 DMU_OT_NEXT_CLONES, DMU_OT_NONE, 0, tx);
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	837 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	838 VERIFY(0 == zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	839 origin->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	840 dsobj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	841 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	842
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	843 dmu_buf_will_dirty(dd->dd_dbuf, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	844 dd->dd_phys->dd_origin_obj = origin->ds_object;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	845 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	846 if (origin->ds_dir->dd_phys->dd_clones == 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	847 dmu_buf_will_dirty(origin->ds_dir->dd_dbuf, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	848 origin->ds_dir->dd_phys->dd_clones =
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	849 zap_create(mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	850 DMU_OT_DSL_CLONES, DMU_OT_NONE, 0, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	851 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	852 VERIFY3U(0, ==, zap_add_int(mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	853 origin->ds_dir->dd_phys->dd_clones, dsobj, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	854 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	855 }
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	856
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	857 if (spa_version(dp->dp_spa) >= SPA_VERSION_UNIQUE_ACCURATE)
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	858 dsphys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	859
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	860 dmu_buf_rele(dbuf, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	861
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	862 dmu_buf_will_dirty(dd->dd_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	863 dd->dd_phys->dd_head_dataset_obj = dsobj;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	864
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	865 return (dsobj);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	866 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	867
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	868 uint64_t
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	869 dsl_dataset_create_sync(dsl_dir_t pdd, const char lastname,
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	870 dsl_dataset_t origin, uint64_t flags, cred_t cr, dmu_tx_t *tx)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	871 {
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	872 dsl_pool_t *dp = pdd->dd_pool;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	873 uint64_t dsobj, ddobj;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	874 dsl_dir_t *dd;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	875
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	876 ASSERT(lastname[0] != '@');
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	877
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	878 ddobj = dsl_dir_create_sync(dp, pdd, lastname, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	879 VERIFY(0 == dsl_dir_open_obj(dp, ddobj, lastname, FTAG, &dd));
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	880
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	881 dsobj = dsl_dataset_create_sync_dd(dd, origin, flags, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	882
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	883 dsl_deleg_set_create_perms(dd, tx, cr);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	884
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	885 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	886
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	887 /*
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	888 * If we are creating a clone, make sure we zero out any stale
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	889 * data from the origin snapshots zil header.
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	890 */
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	891 if (origin != NULL) {
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	892 dsl_dataset_t *ds;
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	893 objset_t *os;
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	894
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	895 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds));
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	896 VERIFY3U(0, ==, dmu_objset_from_ds(ds, &os));
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	897 bzero(&os->os_zil_header, sizeof (os->os_zil_header));
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	898 dsl_dataset_dirty(ds, tx);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	899 dsl_dataset_rele(ds, FTAG);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	900 }
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	901
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	902 return (dsobj);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	903 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	904
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	905 struct destroyarg {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	906 dsl_sync_task_group_t *dstg;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	907 char *snapname;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	908 char *failed;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	909 boolean_t defer;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	910 };
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	911
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	912 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	913 dsl_snapshot_destroy_one(const char name, void arg)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	914 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	915 struct destroyarg *da = arg;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	916 dsl_dataset_t *ds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	917 int err;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	918 char *dsname;
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	919
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	920 dsname = kmem_asprintf("%s@%s", name, da->snapname);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	921 err = dsl_dataset_own(dsname, B_TRUE, da->dstg, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	922 strfree(dsname);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	923 if (err == 0) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	924 struct dsl_ds_destroyarg *dsda;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	925
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	926 dsl_dataset_make_exclusive(ds, da->dstg);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	927 dsda = kmem_zalloc(sizeof (struct dsl_ds_destroyarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	928 dsda->ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	929 dsda->defer = da->defer;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	930 dsl_sync_task_create(da->dstg, dsl_dataset_destroy_check,
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	931 dsl_dataset_destroy_sync, dsda, da->dstg, 0);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	932 } else if (err == ENOENT) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	933 err = 0;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	934 } else {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	935 (void) strcpy(da->failed, name);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	936 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	937 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	938 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	939
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	940 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	941 * Destroy 'snapname' in all descendants of 'fsname'.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	942 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	943 #pragma weak dmu_snapshots_destroy = dsl_snapshots_destroy
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	944 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	945 dsl_snapshots_destroy(char fsname, char snapname, boolean_t defer)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	946 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	947 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	948 struct destroyarg da;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	949 dsl_sync_task_t *dst;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	950 spa_t *spa;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	951
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	952 err = spa_open(fsname, &spa, FTAG);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	953 if (err)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	954 return (err);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	955 da.dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	956 da.snapname = snapname;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	957 da.failed = fsname;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	958 da.defer = defer;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	959
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	960 err = dmu_objset_find(fsname,
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	961 dsl_snapshot_destroy_one, &da, DS_FIND_CHILDREN);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	962
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	963 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	964 err = dsl_sync_task_group_wait(da.dstg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	965
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	966 for (dst = list_head(&da.dstg->dstg_tasks); dst;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	967 dst = list_next(&da.dstg->dstg_tasks, dst)) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	968 struct dsl_ds_destroyarg *dsda = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	969 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	970
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	971 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	972 * Return the file system name that triggered the error
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	973 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	974 if (dst->dst_err) {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	975 dsl_dataset_name(ds, fsname);
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	976 *strchr(fsname, '@') = '\0';
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	977 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	978 ASSERT3P(dsda->rm_origin, ==, NULL);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	979 dsl_dataset_disown(ds, da.dstg);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	980 kmem_free(dsda, sizeof (struct dsl_ds_destroyarg));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	981 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	982
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	983 dsl_sync_task_group_destroy(da.dstg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	984 spa_close(spa, FTAG);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	985 return (err);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	986 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	987
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	988 static boolean_t
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	989 dsl_dataset_might_destroy_origin(dsl_dataset_t *ds)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	990 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	991 boolean_t might_destroy = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	992
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	993 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	994 if (ds->ds_phys->ds_num_children == 2 && ds->ds_userrefs == 0 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	995 DS_IS_DEFER_DESTROY(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	996 might_destroy = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	997 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	998
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	999 return (might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1000 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1001
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1002 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1003 * If we're removing a clone, and these three conditions are true:
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1004 * 1) the clone's origin has no other children
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1005 * 2) the clone's origin has no user references
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1006 * 3) the clone's origin has been marked for deferred destruction
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1007 * Then, prepare to remove the origin as part of this sync task group.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1008 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1009 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1010 dsl_dataset_origin_rm_prep(struct dsl_ds_destroyarg dsda, void tag)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1011 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1012 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1013 dsl_dataset_t *origin = ds->ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1014
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1015 if (dsl_dataset_might_destroy_origin(origin)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1016 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1017 int namelen;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1018 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1019
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1020 namelen = dsl_dataset_namelen(origin) + 1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1021 name = kmem_alloc(namelen, KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1022 dsl_dataset_name(origin, name);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1023 #ifdef _KERNEL
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1024 error = zfs_unmount_snap(name, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1025 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1026 kmem_free(name, namelen);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1027 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1028 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1029 #endif
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1030 error = dsl_dataset_own(name, B_TRUE, tag, &origin);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1031 kmem_free(name, namelen);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1032 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1033 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1034 dsda->rm_origin = origin;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1035 dsl_dataset_make_exclusive(origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1036 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1037
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1038 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1039 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1040
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1041 /*
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1042 * ds must be opened as OWNER. On return (whether successful or not),
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1043 * ds will be closed and caller can no longer dereference it.
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1044 */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1045 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1046 dsl_dataset_destroy(dsl_dataset_t ds, void tag, boolean_t defer)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1047 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1048 int err;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1049 dsl_sync_task_group_t *dstg;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1050 objset_t *os;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1051 dsl_dir_t *dd;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1052 uint64_t obj;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1053 struct dsl_ds_destroyarg dsda = { 0 };
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1054 dsl_dataset_t dummy_ds = { 0 };
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1055
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1056 dsda.ds = ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1057
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1058 if (dsl_dataset_is_snapshot(ds)) {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1059 /* Destroying a snapshot is simpler */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1060 dsl_dataset_make_exclusive(ds, tag);
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	1061
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1062 dsda.defer = defer;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1063 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1064 dsl_dataset_destroy_check, dsl_dataset_destroy_sync,
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1065 &dsda, tag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1066 ASSERT3P(dsda.rm_origin, ==, NULL);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1067 goto out;
10385 21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1068 } else if (defer) {
21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1069 err = EINVAL;
21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1070 goto out;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1071 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1072
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1073 dd = ds->ds_dir;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1074 dummy_ds.ds_dir = dd;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1075 dummy_ds.ds_object = ds->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1076
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1077 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1078 * Check for errors and mark this ds as inconsistent, in
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1079 * case we crash while freeing the objects.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1080 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1081 err = dsl_sync_task_do(dd->dd_pool, dsl_dataset_destroy_begin_check,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1082 dsl_dataset_destroy_begin_sync, ds, NULL, 0);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1083 if (err)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1084 goto out;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1085
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1086 err = dmu_objset_from_ds(ds, &os);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1087 if (err)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1088 goto out;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1089
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1090 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1091 * remove the objects in open context, so that we won't
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1092 * have too much to do in syncing context.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1093 */
3025 4e5ee8301d84 6424466 "panic: data after EOF" when unmounting abused pool ahrens parents: 2885 diff changeset	1094 for (obj = 0; err == 0; err = dmu_object_next(os, &obj, FALSE,
4e5ee8301d84 6424466 "panic: data after EOF" when unmounting abused pool ahrens parents: 2885 diff changeset	1095 ds->ds_phys->ds_prev_snap_txg)) {
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1096 /*
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1097 * Ignore errors, if there is not enough disk space
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1098 * we will deal with it in dsl_dataset_destroy_sync().
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1099 */
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	1100 (void) dmu_free_object(os, obj);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1101 }
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1102 if (err != ESRCH)
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1103 goto out;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1104
9396 f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1105 /*
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1106 * Only the ZIL knows how to free log blocks.
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1107 */
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1108 zil_destroy(dmu_objset_zil(os), B_FALSE);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1109
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1110 /*
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	1111 * Sync out all in-flight IO.
9396 f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1112 */
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1113 txg_wait_synced(dd->dd_pool, 0);
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1114
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1115 /*
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1116 * If we managed to free all the objects in open
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1117 * context, the user space accounting should be zero.
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1118 */
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1119 if (ds->ds_phys->ds_bp.blk_fill == 0 &&
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1120 dmu_objset_userused_enabled(os)) {
9396 f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1121 uint64_t count;
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1122
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1123 ASSERT(zap_count(os, DMU_USERUSED_OBJECT, &count) != 0 \|\|
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1124 count == 0);
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1125 ASSERT(zap_count(os, DMU_GROUPUSED_OBJECT, &count) != 0 \|\|
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1126 count == 0);
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1127 }
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1128
6975 c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1129 rw_enter(&dd->dd_pool->dp_config_rwlock, RW_READER);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1130 err = dsl_dir_open_obj(dd->dd_pool, dd->dd_object, NULL, FTAG, &dd);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1131 rw_exit(&dd->dd_pool->dp_config_rwlock);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1132
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1133 if (err)
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1134 goto out;
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1135
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1136 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1137 * Blow away the dsl_dir + head dataset.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1138 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1139 dsl_dataset_make_exclusive(ds, tag);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1140 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1141 * If we're removing a clone, we might also need to remove its
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1142 * origin.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1143 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1144 do {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1145 dsda.need_prep = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1146 if (dsl_dir_is_clone(dd)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1147 err = dsl_dataset_origin_rm_prep(&dsda, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1148 if (err) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1149 dsl_dir_close(dd, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1150 goto out;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1151 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1152 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1153
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1154 dstg = dsl_sync_task_group_create(ds->ds_dir->dd_pool);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1155 dsl_sync_task_create(dstg, dsl_dataset_destroy_check,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1156 dsl_dataset_destroy_sync, &dsda, tag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1157 dsl_sync_task_create(dstg, dsl_dir_destroy_check,
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1158 dsl_dir_destroy_sync, &dummy_ds, FTAG, 0);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1159 err = dsl_sync_task_group_wait(dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1160 dsl_sync_task_group_destroy(dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1161
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1162 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1163 * We could be racing against 'zfs release' or 'zfs destroy -d'
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1164 * on the origin snap, in which case we can get EBUSY if we
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1165 * needed to destroy the origin snap but were not ready to
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1166 * do so.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1167 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1168 if (dsda.need_prep) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1169 ASSERT(err == EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1170 ASSERT(dsl_dir_is_clone(dd));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1171 ASSERT(dsda.rm_origin == NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1172 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1173 } while (dsda.need_prep);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1174
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1175 if (dsda.rm_origin != NULL)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1176 dsl_dataset_disown(dsda.rm_origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1177
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1178 /* if it is successful, dsl_dir_destroy_sync will close the dd */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1179 if (err)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1180 dsl_dir_close(dd, FTAG);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1181 out:
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1182 dsl_dataset_disown(ds, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1183 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1184 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1185
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1186 blkptr_t *
e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1187 dsl_dataset_get_blkptr(dsl_dataset_t *ds)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1188 {
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1189 return (&ds->ds_phys->ds_bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1190 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1191
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1192 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1193 dsl_dataset_set_blkptr(dsl_dataset_t ds, blkptr_t bp, dmu_tx_t *tx)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1194 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1195 ASSERT(dmu_tx_is_syncing(tx));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1196 /* If it's the meta-objset, set dp_meta_rootbp */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1197 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1198 tx->tx_pool->dp_meta_rootbp = *bp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1199 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1200 dmu_buf_will_dirty(ds->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1201 ds->ds_phys->ds_bp = *bp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1202 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1203 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1204
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1205 spa_t *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1206 dsl_dataset_get_spa(dsl_dataset_t *ds)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1207 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1208 return (ds->ds_dir->dd_pool->dp_spa);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1209 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1210
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1211 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1212 dsl_dataset_dirty(dsl_dataset_t ds, dmu_tx_t tx)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1213 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1214 dsl_pool_t *dp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1215
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1216 if (ds == NULL) /* this is the meta-objset */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1217 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1218
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1219 ASSERT(ds->ds_objset != NULL);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1220
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1221 if (ds->ds_phys->ds_next_snap_obj != 0)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1222 panic("dirtying snapshot!");
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1223
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1224 dp = ds->ds_dir->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1225
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1226 if (txg_list_add(&dp->dp_dirty_datasets, ds, tx->tx_txg) == 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1227 /* up the hold count until we can be written out */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1228 dmu_buf_add_ref(ds->ds_dbuf, ds);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1229 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1230 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1231
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1232 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1233 * The unique space in the head dataset can be calculated by subtracting
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1234 * the space used in the most recent snapshot, that is still being used
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1235 * in this file system, from the space currently in use. To figure out
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1236 * the space in the most recent snapshot still in use, we need to take
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1237 * the total space used in the snapshot and subtract out the space that
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1238 * has been freed up since the snapshot was taken.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1239 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1240 static void
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1241 dsl_dataset_recalc_head_uniq(dsl_dataset_t *ds)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1242 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1243 uint64_t mrs_used;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1244 uint64_t dlused, dlcomp, dluncomp;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1245
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1246 ASSERT(!dsl_dataset_is_snapshot(ds));
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1247
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1248 if (ds->ds_phys->ds_prev_snap_obj != 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1249 mrs_used = ds->ds_prev->ds_phys->ds_used_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1250 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1251 mrs_used = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1252
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1253 dsl_deadlist_space(&ds->ds_deadlist, &dlused, &dlcomp, &dluncomp);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1254
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1255 ASSERT3U(dlused, <=, mrs_used);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1256 ds->ds_phys->ds_unique_bytes =
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1257 ds->ds_phys->ds_used_bytes - (mrs_used - dlused);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1258
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1259 if (spa_version(ds->ds_dir->dd_pool->dp_spa) >=
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1260 SPA_VERSION_UNIQUE_ACCURATE)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1261 ds->ds_phys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1262 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1263
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1264 struct killarg {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1265 dsl_dataset_t *ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1266 dmu_tx_t *tx;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1267 };
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1268
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1269 /* ARGSUSED */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1270 static int
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1271 kill_blkptr(spa_t spa, zilog_t zilog, const blkptr_t bp, arc_buf_t pbuf,
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1272 const zbookmark_t zb, const dnode_phys_t dnp, void *arg)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1273 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1274 struct killarg *ka = arg;
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1275 dmu_tx_t *tx = ka->tx;
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1276
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1277 if (bp == NULL)
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1278 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1279
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1280 if (zb->zb_level == ZB_ZIL_LEVEL) {
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1281 ASSERT(zilog != NULL);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1282 /*
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1283 * It's a block in the intent log. It has no
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1284 * accounting, so just free it.
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1285 */
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1286 dsl_free(ka->tx->tx_pool, ka->tx->tx_txg, bp);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1287 } else {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1288 ASSERT(zilog == NULL);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1289 ASSERT3U(bp->blk_birth, >, ka->ds->ds_phys->ds_prev_snap_txg);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1290 (void) dsl_dataset_block_kill(ka->ds, bp, tx, B_FALSE);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1291 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1292
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1293 return (0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1294 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1295
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1296 /* ARGSUSED */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1297 static int
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1298 dsl_dataset_destroy_begin_check(void arg1, void arg2, dmu_tx_t *tx)
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1299 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1300 dsl_dataset_t *ds = arg1;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1301 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1302 uint64_t count;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1303 int err;
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1304
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1305 /*
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1306 * Can't delete a head dataset if there are snapshots of it.
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1307 * (Except if the only snapshots are from the branch we cloned
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1308 * from.)
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1309 */
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1310 if (ds->ds_prev != NULL &&
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1311 ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object)
10816 731471f04028 6482588 zfs destroy -r aborts and dumps core when destroying a file system (while snapshotting is going on) vitezslav batrla - Sun Microsystems - Prague Czech Republic <Vitezslav.Batrla@Sun.COM> parents: 10801 diff changeset	1312 return (EBUSY);
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1313
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1314 /*
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1315 * This is really a dsl_dir thing, but check it here so that
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1316 * we'll be less likely to leave this dataset inconsistent &
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1317 * nearly destroyed.
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1318 */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1319 err = zap_count(mos, ds->ds_dir->dd_phys->dd_child_dir_zapobj, &count);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1320 if (err)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1321 return (err);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1322 if (count != 0)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1323 return (EEXIST);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1324
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1325 return (0);
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1326 }
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1327
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1328 /* ARGSUSED */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1329 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1330 dsl_dataset_destroy_begin_sync(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1331 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1332 dsl_dataset_t *ds = arg1;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1333 dsl_pool_t *dp = ds->ds_dir->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1334
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1335 /* Mark it as inconsistent on-disk, in case we crash */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1336 dmu_buf_will_dirty(ds->ds_dbuf, tx);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1337 ds->ds_phys->ds_flags \|= DS_FLAG_INCONSISTENT;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1338
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1339 spa_history_log_internal(LOG_DS_DESTROY_BEGIN, dp->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1340 "dataset = %llu", ds->ds_object);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1341 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1342
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1343 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1344 dsl_dataset_origin_check(struct dsl_ds_destroyarg dsda, void tag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1345 dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1346 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1347 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1348 dsl_dataset_t *ds_prev = ds->ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1349
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1350 if (dsl_dataset_might_destroy_origin(ds_prev)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1351 struct dsl_ds_destroyarg ndsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1352
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1353 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1354 * If we're not prepared to remove the origin, don't remove
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1355 * the clone either.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1356 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1357 if (dsda->rm_origin == NULL) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1358 dsda->need_prep = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1359 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1360 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1361
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1362 ndsda.ds = ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1363 ndsda.is_origin_rm = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1364 return (dsl_dataset_destroy_check(&ndsda, tag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1365 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1366
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1367 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1368 * If we're not going to remove the origin after all,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1369 * undo the open context setup.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1370 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1371 if (dsda->rm_origin != NULL) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1372 dsl_dataset_disown(dsda->rm_origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1373 dsda->rm_origin = NULL;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1374 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1375
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1376 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1377 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1378
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1379 /*
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1380 * If you add new checks here, you may need to add
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1381 * additional checks to the "temporary" case in
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1382 * snapshot_check() in dmu_objset.c.
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1383 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1384 /* ARGSUSED */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1385 int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1386 dsl_dataset_destroy_check(void arg1, void arg2, dmu_tx_t *tx)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1387 {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1388 struct dsl_ds_destroyarg *dsda = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1389 dsl_dataset_t *ds = dsda->ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1390
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1391 /* we have an owner hold, so noone else can destroy us */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1392 ASSERT(!DSL_DATASET_IS_DESTROYED(ds));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1393
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1394 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1395 * Only allow deferred destroy on pools that support it.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1396 * NOTE: deferred destroy is only supported on snapshots.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1397 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1398 if (dsda->defer) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1399 if (spa_version(ds->ds_dir->dd_pool->dp_spa) <
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1400 SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1401 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1402 ASSERT(dsl_dataset_is_snapshot(ds));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1403 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1404 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1405
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1406 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1407 * Can't delete a head dataset if there are snapshots of it.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1408 * (Except if the only snapshots are from the branch we cloned
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1409 * from.)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1410 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1411 if (ds->ds_prev != NULL &&
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1412 ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object)
10816 731471f04028 6482588 zfs destroy -r aborts and dumps core when destroying a file system (while snapshotting is going on) vitezslav batrla - Sun Microsystems - Prague Czech Republic <Vitezslav.Batrla@Sun.COM> parents: 10801 diff changeset	1413 return (EBUSY);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1414
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1415 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1416 * If we made changes this txg, traverse_dsl_dataset won't find
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1417 * them. Try again.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1418 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1419 if (ds->ds_phys->ds_bp.blk_birth >= tx->tx_txg)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1420 return (EAGAIN);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1421
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1422 if (dsl_dataset_is_snapshot(ds)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1423 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1424 * If this snapshot has an elevated user reference count,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1425 * we can't destroy it yet.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1426 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1427 if (ds->ds_userrefs > 0 && !dsda->releasing)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1428 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1429
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1430 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1431 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1432 * Can't delete a branch point. However, if we're destroying
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1433 * a clone and removing its origin due to it having a user
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1434 * hold count of 0 and having been marked for deferred destroy,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1435 * it's OK for the origin to have a single clone.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1436 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1437 if (ds->ds_phys->ds_num_children >
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1438 (dsda->is_origin_rm ? 2 : 1)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1439 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1440 return (EEXIST);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1441 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1442 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1443 } else if (dsl_dir_is_clone(ds->ds_dir)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1444 return (dsl_dataset_origin_check(dsda, arg2, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1445 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1446
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1447 /* XXX we should do some i/o error checking... */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1448 return (0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1449 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1450
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1451 struct refsarg {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1452 kmutex_t lock;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1453 boolean_t gone;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1454 kcondvar_t cv;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1455 };
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1456
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1457 /* ARGSUSED */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1458 static void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1459 dsl_dataset_refs_gone(dmu_buf_t db, void argv)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1460 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1461 struct refsarg *arg = argv;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1462
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1463 mutex_enter(&arg->lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1464 arg->gone = TRUE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1465 cv_signal(&arg->cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1466 mutex_exit(&arg->lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1467 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1468
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1469 static void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1470 dsl_dataset_drain_refs(dsl_dataset_t ds, void tag)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1471 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1472 struct refsarg arg;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1473
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1474 mutex_init(&arg.lock, NULL, MUTEX_DEFAULT, NULL);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1475 cv_init(&arg.cv, NULL, CV_DEFAULT, NULL);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1476 arg.gone = FALSE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1477 (void) dmu_buf_update_user(ds->ds_dbuf, ds, &arg, &ds->ds_phys,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1478 dsl_dataset_refs_gone);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1479 dmu_buf_rele(ds->ds_dbuf, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1480 mutex_enter(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1481 while (!arg.gone)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1482 cv_wait(&arg.cv, &arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1483 ASSERT(arg.gone);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1484 mutex_exit(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1485 ds->ds_dbuf = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1486 ds->ds_phys = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1487 mutex_destroy(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1488 cv_destroy(&arg.cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1489 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1490
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1491 static void
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1492 remove_from_next_clones(dsl_dataset_t ds, uint64_t obj, dmu_tx_t tx)
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1493 {
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1494 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1495 uint64_t count;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1496 int err;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1497
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1498 ASSERT(ds->ds_phys->ds_num_children >= 2);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1499 err = zap_remove_int(mos, ds->ds_phys->ds_next_clones_obj, obj, tx);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1500 /*
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1501 * The err should not be ENOENT, but a bug in a previous version
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1502 * of the code could cause upgrade_clones_cb() to not set
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1503 * ds_next_snap_obj when it should, leading to a missing entry.
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1504 * If we knew that the pool was created after
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1505 * SPA_VERSION_NEXT_CLONES, we could assert that it isn't
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1506 * ENOENT. However, at least we can check that we don't have
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1507 * too many entries in the next_clones_obj even after failing to
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1508 * remove this one.
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1509 */
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1510 if (err != ENOENT) {
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1511 VERIFY3U(err, ==, 0);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1512 }
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1513 ASSERT3U(0, ==, zap_count(mos, ds->ds_phys->ds_next_clones_obj,
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1514 &count));
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1515 ASSERT3U(count, <=, ds->ds_phys->ds_num_children - 2);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1516 }
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1517
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1518 static void
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1519 dsl_dataset_remove_clones_key(dsl_dataset_t ds, uint64_t mintxg, dmu_tx_t tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1520 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1521 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1522 zap_cursor_t zc;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1523 zap_attribute_t za;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1524
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1525 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1526 * If it is the old version, dd_clones doesn't exist so we can't
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1527 * find the clones, but deadlist_remove_key() is a no-op so it
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1528 * doesn't matter.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1529 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1530 if (ds->ds_dir->dd_phys->dd_clones == 0)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1531 return;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1532
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1533 for (zap_cursor_init(&zc, mos, ds->ds_dir->dd_phys->dd_clones);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1534 zap_cursor_retrieve(&zc, &za) == 0;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1535 zap_cursor_advance(&zc)) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1536 dsl_dataset_t *clone;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1537
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1538 VERIFY3U(0, ==, dsl_dataset_hold_obj(ds->ds_dir->dd_pool,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1539 za.za_first_integer, FTAG, &clone));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1540 if (clone->ds_dir->dd_origin_txg > mintxg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1541 dsl_deadlist_remove_key(&clone->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1542 mintxg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1543 dsl_dataset_remove_clones_key(clone, mintxg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1544 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1545 dsl_dataset_rele(clone, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1546 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1547 zap_cursor_fini(&zc);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1548 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1549
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1550 struct process_old_arg {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1551 dsl_dataset_t *ds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1552 dsl_dataset_t *ds_prev;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1553 boolean_t after_branch_point;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1554 zio_t *pio;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1555 uint64_t used, comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1556 };
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1557
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1558 static int
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1559 process_old_cb(void arg, const blkptr_t bp, dmu_tx_t *tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1560 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1561 struct process_old_arg *poa = arg;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1562 dsl_pool_t *dp = poa->ds->ds_dir->dd_pool;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1563
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1564 if (bp->blk_birth <= poa->ds->ds_phys->ds_prev_snap_txg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1565 dsl_deadlist_insert(&poa->ds->ds_deadlist, bp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1566 if (poa->ds_prev && !poa->after_branch_point &&
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1567 bp->blk_birth >
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1568 poa->ds_prev->ds_phys->ds_prev_snap_txg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1569 poa->ds_prev->ds_phys->ds_unique_bytes +=
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1570 bp_get_dsize_sync(dp->dp_spa, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1571 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1572 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1573 poa->used += bp_get_dsize_sync(dp->dp_spa, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1574 poa->comp += BP_GET_PSIZE(bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1575 poa->uncomp += BP_GET_UCSIZE(bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1576 dsl_free_sync(poa->pio, dp, tx->tx_txg, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1577 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1578 return (0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1579 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1580
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1581 static void
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1582 process_old_deadlist(dsl_dataset_t ds, dsl_dataset_t ds_prev,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1583 dsl_dataset_t ds_next, boolean_t after_branch_point, dmu_tx_t tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1584 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1585 struct process_old_arg poa = { 0 };
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1586 dsl_pool_t *dp = ds->ds_dir->dd_pool;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1587 objset_t *mos = dp->dp_meta_objset;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1588
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1589 ASSERT(ds->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1590 ASSERT(ds_next->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1591
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1592 poa.ds = ds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1593 poa.ds_prev = ds_prev;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1594 poa.after_branch_point = after_branch_point;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1595 poa.pio = zio_root(dp->dp_spa, NULL, NULL, ZIO_FLAG_MUSTSUCCEED);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1596 VERIFY3U(0, ==, bpobj_iterate(&ds_next->ds_deadlist.dl_bpobj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1597 process_old_cb, &poa, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1598 VERIFY3U(zio_wait(poa.pio), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1599 ASSERT3U(poa.used, ==, ds->ds_phys->ds_unique_bytes);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1600
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1601 /* change snapused */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1602 dsl_dir_diduse_space(ds->ds_dir, DD_USED_SNAP,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1603 -poa.used, -poa.comp, -poa.uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1604
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1605 /* swap next's deadlist to our deadlist */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1606 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1607 dsl_deadlist_close(&ds_next->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1608 SWITCH64(ds_next->ds_phys->ds_deadlist_obj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1609 ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1610 dsl_deadlist_open(&ds->ds_deadlist, mos, ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1611 dsl_deadlist_open(&ds_next->ds_deadlist, mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1612 ds_next->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1613 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1614
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1615 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1616 dsl_dataset_destroy_sync(void arg1, void tag, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1617 {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1618 struct dsl_ds_destroyarg *dsda = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1619 dsl_dataset_t *ds = dsda->ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1620 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1621 int after_branch_point = FALSE;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1622 dsl_pool_t *dp = ds->ds_dir->dd_pool;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1623 objset_t *mos = dp->dp_meta_objset;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1624 dsl_dataset_t *ds_prev = NULL;
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1625 boolean_t wont_destroy;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1626 uint64_t obj;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1627
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1628 wont_destroy = (dsda->defer &&
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1629 (ds->ds_userrefs > 0 \|\| ds->ds_phys->ds_num_children > 1));
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1630
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1631 ASSERT(ds->ds_owner \|\| wont_destroy);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1632 ASSERT(dsda->defer \|\| ds->ds_phys->ds_num_children <= 1);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1633 ASSERT(ds->ds_prev == NULL \|\|
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1634 ds->ds_prev->ds_phys->ds_next_snap_obj != ds->ds_object);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1635 ASSERT3U(ds->ds_phys->ds_bp.blk_birth, <=, tx->tx_txg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1636
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1637 if (wont_destroy) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1638 ASSERT(spa_version(dp->dp_spa) >= SPA_VERSION_USERREFS);
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1639 dmu_buf_will_dirty(ds->ds_dbuf, tx);
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1640 ds->ds_phys->ds_flags \|= DS_FLAG_DEFER_DESTROY;
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1641 return;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1642 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1643
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1644 /* signal any waiters that this dataset is going away */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1645 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1646 ds->ds_owner = dsl_reaper;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1647 cv_broadcast(&ds->ds_exclusive_cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1648 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1649
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1650 /* Remove our reservation */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1651 if (ds->ds_reserved != 0) {
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1652 dsl_prop_setarg_t psa;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1653 uint64_t value = 0;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1654
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1655 dsl_prop_setarg_init_uint64(&psa, "refreservation",
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1656 (ZPROP_SRC_NONE \| ZPROP_SRC_LOCAL \| ZPROP_SRC_RECEIVED),
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1657 &value);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1658 psa.psa_effective_value = 0; /* predict default value */
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1659
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1660 dsl_dataset_set_reservation_sync(ds, &psa, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1661 ASSERT3U(ds->ds_reserved, ==, 0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1662 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1663
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1664 ASSERT(RW_WRITE_HELD(&dp->dp_config_rwlock));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1665
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1666 dsl_scan_ds_destroyed(ds, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1667
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1668 obj = ds->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1669
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1670 if (ds->ds_phys->ds_prev_snap_obj != 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1671 if (ds->ds_prev) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1672 ds_prev = ds->ds_prev;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1673 } else {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1674 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1675 ds->ds_phys->ds_prev_snap_obj, FTAG, &ds_prev));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1676 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1677 after_branch_point =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1678 (ds_prev->ds_phys->ds_next_snap_obj != obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1679
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1680 dmu_buf_will_dirty(ds_prev->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1681 if (after_branch_point &&
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1682 ds_prev->ds_phys->ds_next_clones_obj != 0) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1683 remove_from_next_clones(ds_prev, obj, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1684 if (ds->ds_phys->ds_next_snap_obj != 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1685 VERIFY(0 == zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1686 ds_prev->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1687 ds->ds_phys->ds_next_snap_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1688 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1689 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1690 if (after_branch_point &&
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1691 ds->ds_phys->ds_next_snap_obj == 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1692 /* This clone is toast. */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1693 ASSERT(ds_prev->ds_phys->ds_num_children > 1);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1694 ds_prev->ds_phys->ds_num_children--;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1695
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1696 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1697 * If the clone's origin has no other clones, no
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1698 * user holds, and has been marked for deferred
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1699 * deletion, then we should have done the necessary
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1700 * destroy setup for it.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1701 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1702 if (ds_prev->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1703 ds_prev->ds_userrefs == 0 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1704 DS_IS_DEFER_DESTROY(ds_prev)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1705 ASSERT3P(dsda->rm_origin, !=, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1706 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1707 ASSERT3P(dsda->rm_origin, ==, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1708 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1709 } else if (!after_branch_point) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1710 ds_prev->ds_phys->ds_next_snap_obj =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1711 ds->ds_phys->ds_next_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1712 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1713 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1714
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1715 if (dsl_dataset_is_snapshot(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1716 dsl_dataset_t *ds_next;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1717 uint64_t old_unique;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1718 uint64_t used = 0, comp = 0, uncomp = 0;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1719
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1720 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1721 ds->ds_phys->ds_next_snap_obj, FTAG, &ds_next));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1722 ASSERT3U(ds_next->ds_phys->ds_prev_snap_obj, ==, obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1723
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1724 old_unique = ds_next->ds_phys->ds_unique_bytes;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1725
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1726 dmu_buf_will_dirty(ds_next->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1727 ds_next->ds_phys->ds_prev_snap_obj =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1728 ds->ds_phys->ds_prev_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1729 ds_next->ds_phys->ds_prev_snap_txg =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1730 ds->ds_phys->ds_prev_snap_txg;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1731 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, ==,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1732 ds_prev ? ds_prev->ds_phys->ds_creation_txg : 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1733
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1734
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1735 if (ds_next->ds_deadlist.dl_oldfmt) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1736 process_old_deadlist(ds, ds_prev, ds_next,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1737 after_branch_point, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1738 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1739 /* Adjust prev's unique space. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1740 if (ds_prev && !after_branch_point) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1741 dsl_deadlist_space_range(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1742 ds_prev->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1743 ds->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1744 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1745 ds_prev->ds_phys->ds_unique_bytes += used;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1746 }
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1747
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1748 /* Adjust snapused. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1749 dsl_deadlist_space_range(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1750 ds->ds_phys->ds_prev_snap_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1751 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1752 dsl_dir_diduse_space(ds->ds_dir, DD_USED_SNAP,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1753 -used, -comp, -uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1754
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1755 /* Move blocks to be freed to pool's free list. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1756 dsl_deadlist_move_bpobj(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1757 &dp->dp_free_bpobj, ds->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1758 tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1759 dsl_dir_diduse_space(tx->tx_pool->dp_free_dir,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1760 DD_USED_HEAD, used, comp, uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1761 dsl_dir_dirty(tx->tx_pool->dp_free_dir, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1762
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1763 /* Merge our deadlist into next's and free it. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1764 dsl_deadlist_merge(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1765 ds->ds_phys->ds_deadlist_obj, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1766 }
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1767 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1768 dsl_deadlist_free(mos, ds->ds_phys->ds_deadlist_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1769
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1770 /* Collapse range in clone heads */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1771 dsl_dataset_remove_clones_key(ds,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1772 ds->ds_phys->ds_creation_txg, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1773
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1774 if (dsl_dataset_is_snapshot(ds_next)) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1775 dsl_dataset_t *ds_nextnext;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1776
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1777 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1778 * Update next's unique to include blocks which
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1779 * were previously shared by only this snapshot
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1780 * and it. Those blocks will be born after the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1781 * prev snap and before this snap, and will have
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1782 * died after the next snap and before the one
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1783 * after that (ie. be on the snap after next's
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1784 * deadlist).
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1785 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1786 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1787 ds_next->ds_phys->ds_next_snap_obj,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1788 FTAG, &ds_nextnext));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1789 dsl_deadlist_space_range(&ds_nextnext->ds_deadlist,
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1790 ds->ds_phys->ds_prev_snap_txg,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1791 ds->ds_phys->ds_creation_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1792 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1793 ds_next->ds_phys->ds_unique_bytes += used;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1794 dsl_dataset_rele(ds_nextnext, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1795 ASSERT3P(ds_next->ds_prev, ==, NULL);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1796
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1797 /* Collapse range in this head. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1798 dsl_dataset_t *hds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1799 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1800 ds->ds_dir->dd_phys->dd_head_dataset_obj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1801 FTAG, &hds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1802 dsl_deadlist_remove_key(&hds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1803 ds->ds_phys->ds_creation_txg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1804 dsl_dataset_rele(hds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1805
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1806 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1807 ASSERT3P(ds_next->ds_prev, ==, ds);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1808 dsl_dataset_drop_ref(ds_next->ds_prev, ds_next);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1809 ds_next->ds_prev = NULL;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1810 if (ds_prev) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1811 VERIFY(0 == dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1812 ds->ds_phys->ds_prev_snap_obj,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1813 ds_next, &ds_next->ds_prev));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1814 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1815
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1816 dsl_dataset_recalc_head_uniq(ds_next);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1817
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1818 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1819 * Reduce the amount of our unconsmed refreservation
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1820 * being charged to our parent by the amount of
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1821 * new unique data we have gained.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1822 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1823 if (old_unique < ds_next->ds_reserved) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1824 int64_t mrsdelta;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1825 uint64_t new_unique =
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1826 ds_next->ds_phys->ds_unique_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1827
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1828 ASSERT(old_unique <= new_unique);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1829 mrsdelta = MIN(new_unique - old_unique,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1830 ds_next->ds_reserved - old_unique);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1831 dsl_dir_diduse_space(ds->ds_dir,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1832 DD_USED_REFRSRV, -mrsdelta, 0, 0, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1833 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1834 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1835 dsl_dataset_rele(ds_next, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1836 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1837 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1838 * There's no next snapshot, so this is a head dataset.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1839 * Destroy the deadlist. Unless it's a clone, the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1840 * deadlist should be empty. (If it's a clone, it's
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1841 * safe to ignore the deadlist contents.)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1842 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1843 struct killarg ka;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1844
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1845 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1846 dsl_deadlist_free(mos, ds->ds_phys->ds_deadlist_obj, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1847 ds->ds_phys->ds_deadlist_obj = 0;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1848
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1849 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1850 * Free everything that we point to (that's born after
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1851 * the previous snapshot, if we are a clone)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1852 *
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1853 * NB: this should be very quick, because we already
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1854 * freed all the objects in open context.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1855 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1856 ka.ds = ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1857 ka.tx = tx;
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1858 err = traverse_dataset(ds, ds->ds_phys->ds_prev_snap_txg,
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1859 TRAVERSE_POST, kill_blkptr, &ka);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1860 ASSERT3U(err, ==, 0);
9390 887948510f80 6826861 assertion failed in dsl_dataset_destroy_sync when "zfs destroy" old fs Chris Kirby <chris.kirby@sun.com> parents: 8779 diff changeset	1861 ASSERT(!DS_UNIQUE_IS_ACCURATE(ds) \|\|
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1862 ds->ds_phys->ds_unique_bytes == 0);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1863
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1864 if (ds->ds_prev != NULL) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1865 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1866 VERIFY3U(0, ==, zap_remove_int(mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1867 ds->ds_prev->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1868 ds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1869 }
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1870 dsl_dataset_rele(ds->ds_prev, ds);
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1871 ds->ds_prev = ds_prev = NULL;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1872 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1873 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1874
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1875 /*
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1876 * This must be done after the dsl_traverse(), because it will
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1877 * re-open the objset.
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1878 */
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1879 if (ds->ds_objset) {
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1880 dmu_objset_evict(ds->ds_objset);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1881 ds->ds_objset = NULL;
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1882 }
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1883
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1884 if (ds->ds_dir->dd_phys->dd_head_dataset_obj == ds->ds_object) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1885 /* Erase the link in the dir */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1886 dmu_buf_will_dirty(ds->ds_dir->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1887 ds->ds_dir->dd_phys->dd_head_dataset_obj = 0;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1888 ASSERT(ds->ds_phys->ds_snapnames_zapobj != 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1889 err = zap_destroy(mos, ds->ds_phys->ds_snapnames_zapobj, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1890 ASSERT(err == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1891 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1892 /* remove from snapshot namespace */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1893 dsl_dataset_t *ds_head;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1894 ASSERT(ds->ds_phys->ds_snapnames_zapobj == 0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1895 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1896 ds->ds_dir->dd_phys->dd_head_dataset_obj, FTAG, &ds_head));
2207 47efcb3433a7 6439370 assertion failures possible in dsl_dataset_destroy_sync() ahrens parents: 2199 diff changeset	1897 VERIFY(0 == dsl_dataset_get_snapname(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1898 #ifdef ZFS_DEBUG
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1899 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1900 uint64_t val;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	1901
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1902 err = dsl_dataset_snap_lookup(ds_head,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	1903 ds->ds_snapname, &val);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1904 ASSERT3U(err, ==, 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1905 ASSERT3U(val, ==, obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1906 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1907 #endif
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1908 err = dsl_dataset_snap_remove(ds_head, ds->ds_snapname, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1909 ASSERT(err == 0);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1910 dsl_dataset_rele(ds_head, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1911 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1912
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1913 if (ds_prev && ds->ds_prev != ds_prev)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1914 dsl_dataset_rele(ds_prev, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1915
5094 71a3e95fb9e2 PSARC 2007/342 Enhanced ZFS Pool Properties lling parents: 4967 diff changeset	1916 spa_prop_clear_bootfs(dp->dp_spa, ds->ds_object, tx);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1917 spa_history_log_internal(LOG_DS_DESTROY, dp->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1918 "dataset = %llu", ds->ds_object);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1919
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1920 if (ds->ds_phys->ds_next_clones_obj != 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1921 uint64_t count;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1922 ASSERT(0 == zap_count(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1923 ds->ds_phys->ds_next_clones_obj, &count) && count == 0);
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1924 VERIFY(0 == dmu_object_free(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1925 ds->ds_phys->ds_next_clones_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1926 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1927 if (ds->ds_phys->ds_props_obj != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1928 VERIFY(0 == zap_destroy(mos, ds->ds_phys->ds_props_obj, tx));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1929 if (ds->ds_phys->ds_userrefs_obj != 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1930 VERIFY(0 == zap_destroy(mos, ds->ds_phys->ds_userrefs_obj, tx));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1931 dsl_dir_close(ds->ds_dir, ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1932 ds->ds_dir = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1933 dsl_dataset_drain_refs(ds, tag);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1934 VERIFY(0 == dmu_object_free(mos, obj, tx));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1935
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1936 if (dsda->rm_origin) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1937 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1938 * Remove the origin of the clone we just destroyed.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1939 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1940 struct dsl_ds_destroyarg ndsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1941
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1942 ndsda.ds = dsda->rm_origin;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1943 dsl_dataset_destroy_sync(&ndsda, tag, tx);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1944 }
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1945 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1946
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1947 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1948 dsl_dataset_snapshot_reserve_space(dsl_dataset_t ds, dmu_tx_t tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1949 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1950 uint64_t asize;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1951
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1952 if (!dmu_tx_is_syncing(tx))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1953 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1954
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1955 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1956 * If there's an fs-only reservation, any blocks that might become
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1957 * owned by the snapshot dataset must be accommodated by space
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1958 * outside of the reservation.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1959 */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1960 ASSERT(ds->ds_reserved == 0 \|\| DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1961 asize = MIN(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1962 if (asize > dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE))
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1963 return (ENOSPC);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1964
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1965 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1966 * Propogate any reserved space for this snapshot to other
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1967 * snapshot checks in this sync group.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1968 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1969 if (asize > 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1970 dsl_dir_willuse_space(ds->ds_dir, asize, tx);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1971
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1972 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1973 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1974
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1975 int
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1976 dsl_dataset_snapshot_check(void arg1, void arg2, dmu_tx_t *tx)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1977 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1978 dsl_dataset_t *ds = arg1;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1979 const char *snapname = arg2;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1980 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1981 uint64_t value;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1982
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1983 /*
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1984 * We don't allow multiple snapshots of the same txg. If there
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1985 * is already one, try again.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1986 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1987 if (ds->ds_phys->ds_prev_snap_txg >= tx->tx_txg)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1988 return (EAGAIN);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1989
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1990 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1991 * Check for conflicting name snapshot name.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1992 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1993 err = dsl_dataset_snap_lookup(ds, snapname, &value);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1994 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1995 return (EEXIST);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1996 if (err != ENOENT)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1997 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1998
3978 2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	1999 /*
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2000 * Check that the dataset's name is not too long. Name consists
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2001 * of the dataset's length + 1 for the @-sign + snapshot name's length
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2002 */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2003 if (dsl_dataset_namelen(ds) + 1 + strlen(snapname) >= MAXNAMELEN)
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2004 return (ENAMETOOLONG);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2005
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2006 err = dsl_dataset_snapshot_reserve_space(ds, tx);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2007 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2008 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2009
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2010 ds->ds_trysnap_txg = tx->tx_txg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2011 return (0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2012 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2013
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2014 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2015 dsl_dataset_snapshot_sync(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2016 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2017 dsl_dataset_t *ds = arg1;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2018 const char *snapname = arg2;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2019 dsl_pool_t *dp = ds->ds_dir->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2020 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2021 dsl_dataset_phys_t *dsphys;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2022 uint64_t dsobj, crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2023 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2024 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2025
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2026 ASSERT(RW_WRITE_HELD(&dp->dp_config_rwlock));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2027
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2028 /*
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2029 * The origin's ds_creation_txg has to be < TXG_INITIAL
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2030 */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2031 if (strcmp(snapname, ORIGIN_DIR_NAME) == 0)
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2032 crtxg = 1;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2033 else
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2034 crtxg = tx->tx_txg;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2035
928 36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	2036 dsobj = dmu_object_alloc(mos, DMU_OT_DSL_DATASET, 0,
36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	2037 DMU_OT_DSL_DATASET, sizeof (dsl_dataset_phys_t), tx);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2038 VERIFY(0 == dmu_bonus_hold(mos, dsobj, FTAG, &dbuf));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2039 dmu_buf_will_dirty(dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2040 dsphys = dbuf->db_data;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2041 bzero(dsphys, sizeof (dsl_dataset_phys_t));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2042 dsphys->ds_dir_obj = ds->ds_dir->dd_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2043 dsphys->ds_fsid_guid = unique_create();
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2044 (void) random_get_pseudo_bytes((void*)&dsphys->ds_guid,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2045 sizeof (dsphys->ds_guid));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2046 dsphys->ds_prev_snap_obj = ds->ds_phys->ds_prev_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2047 dsphys->ds_prev_snap_txg = ds->ds_phys->ds_prev_snap_txg;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2048 dsphys->ds_next_snap_obj = ds->ds_object;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2049 dsphys->ds_num_children = 1;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2050 dsphys->ds_creation_time = gethrestime_sec();
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2051 dsphys->ds_creation_txg = crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2052 dsphys->ds_deadlist_obj = ds->ds_phys->ds_deadlist_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2053 dsphys->ds_used_bytes = ds->ds_phys->ds_used_bytes;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2054 dsphys->ds_compressed_bytes = ds->ds_phys->ds_compressed_bytes;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2055 dsphys->ds_uncompressed_bytes = ds->ds_phys->ds_uncompressed_bytes;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2056 dsphys->ds_flags = ds->ds_phys->ds_flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2057 dsphys->ds_bp = ds->ds_phys->ds_bp;
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2058 dmu_buf_rele(dbuf, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2059
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2060 ASSERT3U(ds->ds_prev != 0, ==, ds->ds_phys->ds_prev_snap_obj != 0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2061 if (ds->ds_prev) {
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2062 uint64_t next_clones_obj =
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2063 ds->ds_prev->ds_phys->ds_next_clones_obj;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2064 ASSERT(ds->ds_prev->ds_phys->ds_next_snap_obj ==
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2065 ds->ds_object \|\|
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2066 ds->ds_prev->ds_phys->ds_num_children > 1);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2067 if (ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object) {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2068 dmu_buf_will_dirty(ds->ds_prev->ds_dbuf, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2069 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, ==,
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2070 ds->ds_prev->ds_phys->ds_creation_txg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2071 ds->ds_prev->ds_phys->ds_next_snap_obj = dsobj;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2072 } else if (next_clones_obj != 0) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2073 remove_from_next_clones(ds->ds_prev,
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2074 dsphys->ds_next_snap_obj, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2075 VERIFY3U(0, ==, zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2076 next_clones_obj, dsobj, tx));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2077 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2078 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2079
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2080 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2081 * If we have a reference-reservation on this dataset, we will
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2082 * need to increase the amount of refreservation being charged
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2083 * since our unique space is going to zero.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2084 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2085 if (ds->ds_reserved) {
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2086 int64_t delta;
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2087 ASSERT(DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2088 delta = MIN(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2089 dsl_dir_diduse_space(ds->ds_dir, DD_USED_REFRSRV,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2090 delta, 0, 0, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2091 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2092
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2093 dmu_buf_will_dirty(ds->ds_dbuf, tx);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2094 zfs_dbgmsg("taking snapshot %s@%s/%llu; newkey=%llu",
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2095 ds->ds_dir->dd_myname, snapname, dsobj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2096 ds->ds_phys->ds_prev_snap_txg);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2097 ds->ds_phys->ds_deadlist_obj = dsl_deadlist_clone(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2098 UINT64_MAX, ds->ds_phys->ds_prev_snap_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2099 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2100 dsl_deadlist_open(&ds->ds_deadlist, mos, ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2101 dsl_deadlist_add_key(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2102 ds->ds_phys->ds_prev_snap_txg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2103
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	2104 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, <, tx->tx_txg);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2105 ds->ds_phys->ds_prev_snap_obj = dsobj;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2106 ds->ds_phys->ds_prev_snap_txg = crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2107 ds->ds_phys->ds_unique_bytes = 0;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2108 if (spa_version(dp->dp_spa) >= SPA_VERSION_UNIQUE_ACCURATE)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2109 ds->ds_phys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2110
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2111 err = zap_add(mos, ds->ds_phys->ds_snapnames_zapobj,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2112 snapname, 8, 1, &dsobj, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2113 ASSERT(err == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2114
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2115 if (ds->ds_prev)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2116 dsl_dataset_drop_ref(ds->ds_prev, ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2117 VERIFY(0 == dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2118 ds->ds_phys->ds_prev_snap_obj, ds, &ds->ds_prev));
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2119
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2120 dsl_scan_ds_snapshotted(ds, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2121
10373 bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	2122 dsl_dir_snap_cmtime_update(ds->ds_dir);
bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	2123
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2124 spa_history_log_internal(LOG_DS_SNAPSHOT, dp->dp_spa, tx,
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	2125 "dataset = %llu", dsobj);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2126 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2127
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2128 void
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	2129 dsl_dataset_sync(dsl_dataset_t ds, zio_t zio, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2130 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2131 ASSERT(dmu_tx_is_syncing(tx));
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2132 ASSERT(ds->ds_objset != NULL);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2133 ASSERT(ds->ds_phys->ds_next_snap_obj == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2134
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2135 /*
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2136 * in case we had to change ds_fsid_guid when we opened it,
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2137 * sync it out now.
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2138 */
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2139 dmu_buf_will_dirty(ds->ds_dbuf, tx);
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2140 ds->ds_phys->ds_fsid_guid = ds->ds_fsid_guid;
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2141
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2142 dsl_dir_dirty(ds->ds_dir, tx);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2143 dmu_objset_sync(ds->ds_objset, zio, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2144 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2145
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2146 void
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2147 dsl_dataset_stats(dsl_dataset_t ds, nvlist_t nv)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2148 {
13387 7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2149 uint64_t refd, avail, uobjs, aobjs, ratio;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2150
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2151 dsl_dir_stats(ds->ds_dir, nv);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2152
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2153 dsl_dataset_space(ds, &refd, &avail, &uobjs, &aobjs);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2154 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_AVAILABLE, avail);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2155 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFERENCED, refd);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2156
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2157 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_CREATION,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2158 ds->ds_phys->ds_creation_time);
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2159 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_CREATETXG,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2160 ds->ds_phys->ds_creation_txg);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2161 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFQUOTA,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2162 ds->ds_quota);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2163 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFRESERVATION,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2164 ds->ds_reserved);
6643 3a34b0dbb107 6625086 changing cachefile doesn't remove old cache on last user eschrock parents: 6502 diff changeset	2165 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_GUID,
3a34b0dbb107 6625086 changing cachefile doesn't remove old cache on last user eschrock parents: 6502 diff changeset	2166 ds->ds_phys->ds_guid);
10575 2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2167 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_UNIQUE,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2168 ds->ds_phys->ds_unique_bytes);
10575 2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2169 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_OBJSETID,
2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2170 ds->ds_object);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	2171 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_USERREFS,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	2172 ds->ds_userrefs);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	2173 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_DEFER_DESTROY,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	2174 DS_IS_DEFER_DESTROY(ds) ? 1 : 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2175
13387 7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2176 ratio = ds->ds_phys->ds_compressed_bytes == 0 ? 100 :
7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2177 (ds->ds_phys->ds_uncompressed_bytes * 100 /
7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2178 ds->ds_phys->ds_compressed_bytes);
7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2179 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFRATIO, ratio);
7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2180
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2181 if (ds->ds_phys->ds_next_snap_obj) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2182 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2183 * This is a snapshot; override the dd's space used with
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2184 * our unique space and compression ratio.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2185 */
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2186 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_USED,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2187 ds->ds_phys->ds_unique_bytes);
13387 7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2188 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_COMPRESSRATIO, ratio);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2189 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2190 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2191
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2192 void
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2193 dsl_dataset_fast_stat(dsl_dataset_t ds, dmu_objset_stats_t stat)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2194 {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2195 stat->dds_creation_txg = ds->ds_phys->ds_creation_txg;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2196 stat->dds_inconsistent = ds->ds_phys->ds_flags & DS_FLAG_INCONSISTENT;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2197 stat->dds_guid = ds->ds_phys->ds_guid;
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2198 if (ds->ds_phys->ds_next_snap_obj) {
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2199 stat->dds_is_snapshot = B_TRUE;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2200 stat->dds_num_clones = ds->ds_phys->ds_num_children - 1;
8228 51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2201 } else {
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2202 stat->dds_is_snapshot = B_FALSE;
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2203 stat->dds_num_clones = 0;
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2204 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2205
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2206 /* clone origin is really a dsl_dir thing... */
5446 51fbc14b301d 6421210 zfs rollback without unmounting ahrens parents: 5383 diff changeset	2207 rw_enter(&ds->ds_dir->dd_pool->dp_config_rwlock, RW_READER);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2208 if (dsl_dir_is_clone(ds->ds_dir)) {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2209 dsl_dataset_t *ods;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2210
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2211 VERIFY(0 == dsl_dataset_get_ref(ds->ds_dir->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2212 ds->ds_dir->dd_phys->dd_origin_obj, FTAG, &ods));
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2213 dsl_dataset_name(ods, stat->dds_origin);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2214 dsl_dataset_drop_ref(ods, FTAG);
8228 51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2215 } else {
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2216 stat->dds_origin[0] = '\0';
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2217 }
5446 51fbc14b301d 6421210 zfs rollback without unmounting ahrens parents: 5383 diff changeset	2218 rw_exit(&ds->ds_dir->dd_pool->dp_config_rwlock);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2219 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2220
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2221 uint64_t
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2222 dsl_dataset_fsid_guid(dsl_dataset_t *ds)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2223 {
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2224 return (ds->ds_fsid_guid);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2225 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2226
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2227 void
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2228 dsl_dataset_space(dsl_dataset_t *ds,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2229 uint64_t refdbytesp, uint64_t availbytesp,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2230 uint64_t usedobjsp, uint64_t availobjsp)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2231 {
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2232 *refdbytesp = ds->ds_phys->ds_used_bytes;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2233 *availbytesp = dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2234 if (ds->ds_reserved > ds->ds_phys->ds_unique_bytes)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2235 *availbytesp += ds->ds_reserved - ds->ds_phys->ds_unique_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2236 if (ds->ds_quota != 0) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2237 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2238 * Adjust available bytes according to refquota
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2239 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2240 if (*refdbytesp < ds->ds_quota)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2241 availbytesp = MIN(availbytesp,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2242 ds->ds_quota - *refdbytesp);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2243 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2244 *availbytesp = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2245 }
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2246 *usedobjsp = ds->ds_phys->ds_bp.blk_fill;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2247 availobjsp = DN_MAX_OBJECT - usedobjsp;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2248 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2249
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2250 boolean_t
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2251 dsl_dataset_modified_since_lastsnap(dsl_dataset_t *ds)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2252 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2253 dsl_pool_t *dp = ds->ds_dir->dd_pool;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2254
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2255 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock) \|\|
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2256 dsl_pool_sync_context(dp));
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2257 if (ds->ds_prev == NULL)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2258 return (B_FALSE);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2259 if (ds->ds_phys->ds_bp.blk_birth >
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2260 ds->ds_prev->ds_phys->ds_creation_txg) {
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2261 objset_t os, os_prev;
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2262 /*
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2263 * It may be that only the ZIL differs, because it was
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2264 * reset in the head. Don't count that as being
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2265 * modified.
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2266 */
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2267 if (dmu_objset_from_ds(ds, &os) != 0)
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2268 return (B_TRUE);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2269 if (dmu_objset_from_ds(ds->ds_prev, &os_prev) != 0)
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2270 return (B_TRUE);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2271 return (bcmp(&os->os_phys->os_meta_dnode,
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2272 &os_prev->os_phys->os_meta_dnode,
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2273 sizeof (os->os_phys->os_meta_dnode)) != 0);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2274 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2275 return (B_FALSE);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2276 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2277
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2278 /* ARGSUSED */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2279 static int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2280 dsl_dataset_snapshot_rename_check(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2281 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2282 dsl_dataset_t *ds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2283 char *newsnapname = arg2;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2284 dsl_dir_t *dd = ds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2285 dsl_dataset_t *hds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2286 uint64_t val;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2287 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2288
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2289 err = dsl_dataset_hold_obj(dd->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2290 dd->dd_phys->dd_head_dataset_obj, FTAG, &hds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2291 if (err)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2292 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2293
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2294 /* new name better not be in use */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2295 err = dsl_dataset_snap_lookup(hds, newsnapname, &val);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2296 dsl_dataset_rele(hds, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2297
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2298 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2299 err = EEXIST;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2300 else if (err == ENOENT)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2301 err = 0;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2302
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2303 /* dataset name + 1 for the "@" + the new snapshot name must fit */
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2304 if (dsl_dir_namelen(ds->ds_dir) + 1 + strlen(newsnapname) >= MAXNAMELEN)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2305 err = ENAMETOOLONG;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2306
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2307 return (err);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2308 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2309
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2310 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2311 dsl_dataset_snapshot_rename_sync(void arg1, void arg2, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2312 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2313 dsl_dataset_t *ds = arg1;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2314 const char *newsnapname = arg2;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2315 dsl_dir_t *dd = ds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2316 objset_t *mos = dd->dd_pool->dp_meta_objset;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2317 dsl_dataset_t *hds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2318 int err;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2319
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2320 ASSERT(ds->ds_phys->ds_next_snap_obj != 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2321
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2322 VERIFY(0 == dsl_dataset_hold_obj(dd->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2323 dd->dd_phys->dd_head_dataset_obj, FTAG, &hds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2324
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2325 VERIFY(0 == dsl_dataset_get_snapname(ds));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2326 err = dsl_dataset_snap_remove(hds, ds->ds_snapname, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2327 ASSERT3U(err, ==, 0);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2328 mutex_enter(&ds->ds_lock);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2329 (void) strcpy(ds->ds_snapname, newsnapname);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2330 mutex_exit(&ds->ds_lock);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2331 err = zap_add(mos, hds->ds_phys->ds_snapnames_zapobj,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2332 ds->ds_snapname, 8, 1, &ds->ds_object, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2333 ASSERT3U(err, ==, 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2334
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2335 spa_history_log_internal(LOG_DS_RENAME, dd->dd_pool->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2336 "dataset = %llu", ds->ds_object);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2337 dsl_dataset_rele(hds, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2338 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2339
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2340 struct renamesnaparg {
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2341 dsl_sync_task_group_t *dstg;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2342 char failed[MAXPATHLEN];
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2343 char *oldsnap;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2344 char *newsnap;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2345 };
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2346
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2347 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2348 dsl_snapshot_rename_one(const char name, void arg)
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2349 {
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2350 struct renamesnaparg *ra = arg;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2351 dsl_dataset_t *ds = NULL;
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2352 char *snapname;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2353 int err;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2354
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2355 snapname = kmem_asprintf("%s@%s", name, ra->oldsnap);
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2356 (void) strlcpy(ra->failed, snapname, sizeof (ra->failed));
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2357
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2358 /*
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2359 * For recursive snapshot renames the parent won't be changing
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2360 * so we just pass name for both the to/from argument.
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2361 */
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2362 err = zfs_secpolicy_rename_perms(snapname, snapname, CRED());
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2363 if (err != 0) {
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2364 strfree(snapname);
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2365 return (err == ENOENT ? 0 : err);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2366 }
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2367
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2368 #ifdef _KERNEL
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2369 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2370 * For all filesystems undergoing rename, we'll need to unmount it.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2371 */
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2372 (void) zfs_unmount_snap(snapname, NULL);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2373 #endif
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2374 err = dsl_dataset_hold(snapname, ra->dstg, &ds);
11609 3b5da7ebb54d 6920880 assertion failure in dbuf_write_ready() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11546 diff changeset	2375 strfree(snapname);
3b5da7ebb54d 6920880 assertion failure in dbuf_write_ready() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11546 diff changeset	2376 if (err != 0)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2377 return (err == ENOENT ? 0 : err);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2378
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2379 dsl_sync_task_create(ra->dstg, dsl_dataset_snapshot_rename_check,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2380 dsl_dataset_snapshot_rename_sync, ds, ra->newsnap, 0);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2381
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2382 return (0);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2383 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2384
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2385 static int
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2386 dsl_recursive_rename(char oldname, const char newname)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2387 {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2388 int err;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2389 struct renamesnaparg *ra;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2390 dsl_sync_task_t *dst;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2391 spa_t *spa;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2392 char cp, fsname = spa_strdup(oldname);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2393 int len = strlen(oldname) + 1;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2394
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2395 /* truncate the snapshot name to get the fsname */
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2396 cp = strchr(fsname, '@');
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2397 *cp = '\0';
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2398
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	2399 err = spa_open(fsname, &spa, FTAG);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2400 if (err) {
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2401 kmem_free(fsname, len);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2402 return (err);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2403 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2404 ra = kmem_alloc(sizeof (struct renamesnaparg), KM_SLEEP);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2405 ra->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2406
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2407 ra->oldsnap = strchr(oldname, '@') + 1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2408 ra->newsnap = strchr(newname, '@') + 1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2409 *ra->failed = '\0';
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2410
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2411 err = dmu_objset_find(fsname, dsl_snapshot_rename_one, ra,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2412 DS_FIND_CHILDREN);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2413 kmem_free(fsname, len);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2414
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2415 if (err == 0) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2416 err = dsl_sync_task_group_wait(ra->dstg);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2417 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2418
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2419 for (dst = list_head(&ra->dstg->dstg_tasks); dst;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2420 dst = list_next(&ra->dstg->dstg_tasks, dst)) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2421 dsl_dataset_t *ds = dst->dst_arg1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2422 if (dst->dst_err) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2423 dsl_dir_name(ds->ds_dir, ra->failed);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2424 (void) strlcat(ra->failed, "@", sizeof (ra->failed));
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2425 (void) strlcat(ra->failed, ra->newsnap,
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2426 sizeof (ra->failed));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2427 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2428 dsl_dataset_rele(ds, ra->dstg);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2429 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2430
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2431 if (err)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2432 (void) strlcpy(oldname, ra->failed, sizeof (ra->failed));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2433
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2434 dsl_sync_task_group_destroy(ra->dstg);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2435 kmem_free(ra, sizeof (struct renamesnaparg));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2436 spa_close(spa, FTAG);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2437 return (err);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2438 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2439
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2440 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2441 dsl_valid_rename(const char oldname, void arg)
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2442 {
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2443 int delta = (int )arg;
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2444
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2445 if (strlen(oldname) + delta >= MAXNAMELEN)
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2446 return (ENAMETOOLONG);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2447
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2448 return (0);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2449 }
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2450
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2451 #pragma weak dmu_objset_rename = dsl_dataset_rename
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2452 int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2453 dsl_dataset_rename(char oldname, const char newname, boolean_t recursive)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2454 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2455 dsl_dir_t *dd;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2456 dsl_dataset_t *ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2457 const char *tail;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2458 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2459
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2460 err = dsl_dir_open(oldname, FTAG, &dd, &tail);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2461 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2462 return (err);
11701 6f890435df16 6915532 snapshot related activity causes akd to hang Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 11609 diff changeset	2463
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2464 if (tail == NULL) {
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2465 int delta = strlen(newname) - strlen(oldname);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2466
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2467 /* if we're growing, validate child name lengths */
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2468 if (delta > 0)
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2469 err = dmu_objset_find(oldname, dsl_valid_rename,
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2470 &delta, DS_FIND_CHILDREN \| DS_FIND_SNAPSHOTS);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2471
11823 c756cd80d532 6930022 zfs rename of non-shapshot is slower than necessary Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11701 diff changeset	2472 if (err == 0)
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2473 err = dsl_dir_rename(dd, newname);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2474 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2475 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2476 }
11701 6f890435df16 6915532 snapshot related activity causes akd to hang Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 11609 diff changeset	2477
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2478 if (tail[0] != '@') {
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2479 /* the name ended in a nonexistent component */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2480 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2481 return (ENOENT);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2482 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2483
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2484 dsl_dir_close(dd, FTAG);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2485
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2486 /* new name must be snapshot in same filesystem */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2487 tail = strchr(newname, '@');
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2488 if (tail == NULL)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2489 return (EINVAL);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2490 tail++;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2491 if (strncmp(oldname, newname, tail - newname) != 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2492 return (EXDEV);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2493
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2494 if (recursive) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2495 err = dsl_recursive_rename(oldname, newname);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2496 } else {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2497 err = dsl_dataset_hold(oldname, FTAG, &ds);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2498 if (err)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2499 return (err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2500
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2501 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2502 dsl_dataset_snapshot_rename_check,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2503 dsl_dataset_snapshot_rename_sync, ds, (char *)tail, 1);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2504
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2505 dsl_dataset_rele(ds, FTAG);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2506 }
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2507
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2508 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2509 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2510
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2511 struct promotenode {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2512 list_node_t link;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2513 dsl_dataset_t *ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2514 };
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2515
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2516 struct promotearg {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2517 list_t shared_snaps, origin_snaps, clone_snaps;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2518 dsl_dataset_t *origin_origin;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2519 uint64_t used, comp, uncomp, unique, cloneusedsnap, originusedsnap;
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2520 char *err_ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2521 };
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2522
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2523 static int snaplist_space(list_t l, uint64_t mintxg, uint64_t spacep);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2524 static boolean_t snaplist_unstable(list_t *l);
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2525
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2526 static int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2527 dsl_dataset_promote_check(void arg1, void arg2, dmu_tx_t *tx)
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2528 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2529 dsl_dataset_t *hds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2530 struct promotearg *pa = arg2;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2531 struct promotenode *snap = list_head(&pa->shared_snaps);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2532 dsl_dataset_t *origin_ds = snap->ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2533 int err;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2534 uint64_t unused;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2535
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2536 /* Check that it is a real clone */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2537 if (!dsl_dir_is_clone(hds->ds_dir))
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2538 return (EINVAL);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2539
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2540 /* Since this is so expensive, don't do the preliminary check */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2541 if (!dmu_tx_is_syncing(tx))
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2542 return (0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2543
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2544 if (hds->ds_phys->ds_flags & DS_FLAG_NOPROMOTE)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2545 return (EXDEV);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2546
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2547 /* compute origin's new unique space */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2548 snap = list_tail(&pa->clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2549 ASSERT3U(snap->ds->ds_phys->ds_prev_snap_obj, ==, origin_ds->ds_object);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2550 dsl_deadlist_space_range(&snap->ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2551 origin_ds->ds_phys->ds_prev_snap_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2552 &pa->unique, &unused, &unused);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2553
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2554 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2555 * Walk the snapshots that we are moving
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2556 *
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2557 * Compute space to transfer. Consider the incremental changes
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2558 * to used for each snapshot:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2559 * (my used) = (prev's used) + (blocks born) - (blocks killed)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2560 * So each snapshot gave birth to:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2561 * (blocks born) = (my used) - (prev's used) + (blocks killed)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2562 * So a sequence would look like:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2563 * (uN - u(N-1) + kN) + ... + (u1 - u0 + k1) + (u0 - 0 + k0)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2564 * Which simplifies to:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2565 * uN + kN + kN-1 + ... + k1 + k0
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2566 * Note however, if we stop before we reach the ORIGIN we get:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2567 * uN + kN + kN-1 + ... + kM - uM-1
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2568 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2569 pa->used = origin_ds->ds_phys->ds_used_bytes;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2570 pa->comp = origin_ds->ds_phys->ds_compressed_bytes;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2571 pa->uncomp = origin_ds->ds_phys->ds_uncompressed_bytes;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2572 for (snap = list_head(&pa->shared_snaps); snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2573 snap = list_next(&pa->shared_snaps, snap)) {
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2574 uint64_t val, dlused, dlcomp, dluncomp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2575 dsl_dataset_t *ds = snap->ds;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2576
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2577 /* Check that the snapshot name does not conflict */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2578 VERIFY(0 == dsl_dataset_get_snapname(ds));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2579 err = dsl_dataset_snap_lookup(hds, ds->ds_snapname, &val);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2580 if (err == 0) {
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2581 err = EEXIST;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2582 goto out;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2583 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2584 if (err != ENOENT)
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2585 goto out;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2586
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2587 /* The very first snapshot does not have a deadlist */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2588 if (ds->ds_phys->ds_prev_snap_obj == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2589 continue;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2590
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2591 dsl_deadlist_space(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2592 &dlused, &dlcomp, &dluncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2593 pa->used += dlused;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2594 pa->comp += dlcomp;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2595 pa->uncomp += dluncomp;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2596 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2597
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2598 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2599 * If we are a clone of a clone then we never reached ORIGIN,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2600 * so we need to subtract out the clone origin's used space.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2601 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2602 if (pa->origin_origin) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2603 pa->used -= pa->origin_origin->ds_phys->ds_used_bytes;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2604 pa->comp -= pa->origin_origin->ds_phys->ds_compressed_bytes;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2605 pa->uncomp -= pa->origin_origin->ds_phys->ds_uncompressed_bytes;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2606 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2607
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2608 /* Check that there is enough space here */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2609 err = dsl_dir_transfer_possible(origin_ds->ds_dir, hds->ds_dir,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2610 pa->used);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2611 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2612 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2613
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2614 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2615 * Compute the amounts of space that will be used by snapshots
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2616 * after the promotion (for both origin and clone). For each,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2617 * it is the amount of space that will be on all of their
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2618 * deadlists (that was not born before their new origin).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2619 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2620 if (hds->ds_dir->dd_phys->dd_flags & DD_FLAG_USED_BREAKDOWN) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2621 uint64_t space;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2622
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2623 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2624 * Note, typically this will not be a clone of a clone,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2625 * so dd_origin_txg will be < TXG_INITIAL, so
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2626 * these snaplist_space() -> dsl_deadlist_space_range()
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2627 * calls will be fast because they do not have to
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2628 * iterate over all bps.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2629 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2630 snap = list_head(&pa->origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2631 err = snaplist_space(&pa->shared_snaps,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2632 snap->ds->ds_dir->dd_origin_txg, &pa->cloneusedsnap);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2633 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2634 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2635
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2636 err = snaplist_space(&pa->clone_snaps,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2637 snap->ds->ds_dir->dd_origin_txg, &space);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2638 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2639 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2640 pa->cloneusedsnap += space;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2641 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2642 if (origin_ds->ds_dir->dd_phys->dd_flags & DD_FLAG_USED_BREAKDOWN) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2643 err = snaplist_space(&pa->origin_snaps,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2644 origin_ds->ds_phys->ds_creation_txg, &pa->originusedsnap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2645 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2646 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2647 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2648
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2649 return (0);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2650 out:
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2651 pa->err_ds = snap->ds->ds_snapname;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2652 return (err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2653 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2654
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2655 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2656 dsl_dataset_promote_sync(void arg1, void arg2, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2657 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2658 dsl_dataset_t *hds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2659 struct promotearg *pa = arg2;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2660 struct promotenode *snap = list_head(&pa->shared_snaps);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2661 dsl_dataset_t *origin_ds = snap->ds;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2662 dsl_dataset_t *origin_head;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2663 dsl_dir_t *dd = hds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2664 dsl_pool_t *dp = hds->ds_dir->dd_pool;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2665 dsl_dir_t *odd = NULL;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2666 uint64_t oldnext_obj;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2667 int64_t delta;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2668
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2669 ASSERT(0 == (hds->ds_phys->ds_flags & DS_FLAG_NOPROMOTE));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2670
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2671 snap = list_head(&pa->origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2672 origin_head = snap->ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2673
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2674 /*
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2675 * We need to explicitly open odd, since origin_ds's dd will be
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2676 * changing.
694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2677 */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2678 VERIFY(0 == dsl_dir_open_obj(dp, origin_ds->ds_dir->dd_object,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2679 NULL, FTAG, &odd));
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2680
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2681 /* change origin's next snap */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2682 dmu_buf_will_dirty(origin_ds->ds_dbuf, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2683 oldnext_obj = origin_ds->ds_phys->ds_next_snap_obj;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2684 snap = list_tail(&pa->clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2685 ASSERT3U(snap->ds->ds_phys->ds_prev_snap_obj, ==, origin_ds->ds_object);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2686 origin_ds->ds_phys->ds_next_snap_obj = snap->ds->ds_object;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2687
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2688 /* change the origin's next clone */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2689 if (origin_ds->ds_phys->ds_next_clones_obj) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2690 remove_from_next_clones(origin_ds, snap->ds->ds_object, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2691 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2692 origin_ds->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2693 oldnext_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2694 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2695
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2696 /* change origin */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2697 dmu_buf_will_dirty(dd->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2698 ASSERT3U(dd->dd_phys->dd_origin_obj, ==, origin_ds->ds_object);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2699 dd->dd_phys->dd_origin_obj = odd->dd_phys->dd_origin_obj;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2700 dd->dd_origin_txg = origin_head->ds_dir->dd_origin_txg;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2701 dmu_buf_will_dirty(odd->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2702 odd->dd_phys->dd_origin_obj = origin_ds->ds_object;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2703 origin_head->ds_dir->dd_origin_txg =
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2704 origin_ds->ds_phys->ds_creation_txg;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2705
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2706 /* change dd_clone entries */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2707 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2708 VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2709 odd->dd_phys->dd_clones, hds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2710 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2711 pa->origin_origin->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2712 hds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2713
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2714 VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2715 pa->origin_origin->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2716 origin_head->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2717 if (dd->dd_phys->dd_clones == 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2718 dd->dd_phys->dd_clones = zap_create(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2719 DMU_OT_DSL_CLONES, DMU_OT_NONE, 0, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2720 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2721 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2722 dd->dd_phys->dd_clones, origin_head->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2723
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2724 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2725
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2726 /* move snapshots to this dir */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2727 for (snap = list_head(&pa->shared_snaps); snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2728 snap = list_next(&pa->shared_snaps, snap)) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2729 dsl_dataset_t *ds = snap->ds;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2730
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	2731 /* unregister props as dsl_dir is changing */
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2732 if (ds->ds_objset) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2733 dmu_objset_evict(ds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2734 ds->ds_objset = NULL;
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	2735 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2736 /* move snap name entry */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2737 VERIFY(0 == dsl_dataset_get_snapname(ds));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2738 VERIFY(0 == dsl_dataset_snap_remove(origin_head,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2739 ds->ds_snapname, tx));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2740 VERIFY(0 == zap_add(dp->dp_meta_objset,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2741 hds->ds_phys->ds_snapnames_zapobj, ds->ds_snapname,
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2742 8, 1, &ds->ds_object, tx));
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2743
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2744 /* change containing dsl_dir */
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2745 dmu_buf_will_dirty(ds->ds_dbuf, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2746 ASSERT3U(ds->ds_phys->ds_dir_obj, ==, odd->dd_object);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2747 ds->ds_phys->ds_dir_obj = dd->dd_object;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2748 ASSERT3P(ds->ds_dir, ==, odd);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2749 dsl_dir_close(ds->ds_dir, ds);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2750 VERIFY(0 == dsl_dir_open_obj(dp, dd->dd_object,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2751 NULL, ds, &ds->ds_dir));
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2752
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2753 /* move any clone references */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2754 if (ds->ds_phys->ds_next_clones_obj &&
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2755 spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2756 zap_cursor_t zc;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2757 zap_attribute_t za;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2758
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2759 for (zap_cursor_init(&zc, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2760 ds->ds_phys->ds_next_clones_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2761 zap_cursor_retrieve(&zc, &za) == 0;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2762 zap_cursor_advance(&zc)) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2763 dsl_dataset_t *cnds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2764 uint64_t o;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2765
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2766 if (za.za_first_integer == oldnext_obj) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2767 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2768 * We've already moved the
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2769 * origin's reference.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2770 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2771 continue;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2772 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2773
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2774 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2775 za.za_first_integer, FTAG, &cnds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2776 o = cnds->ds_dir->dd_phys->dd_head_dataset_obj;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2777
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2778 VERIFY3U(zap_remove_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2779 odd->dd_phys->dd_clones, o, tx), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2780 VERIFY3U(zap_add_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2781 dd->dd_phys->dd_clones, o, tx), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2782 dsl_dataset_rele(cnds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2783 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2784 zap_cursor_fini(&zc);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2785 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2786
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2787 ASSERT3U(dsl_prop_numcb(ds), ==, 0);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2788 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2789
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2790 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2791 * Change space accounting.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2792 * Note, pa->*usedsnap and dd_used_breakdown[SNAP] will either
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2793 * both be valid, or both be 0 (resulting in delta == 0). This
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2794 * is true for each of {clone,origin} independently.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2795 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2796
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2797 delta = pa->cloneusedsnap -
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2798 dd->dd_phys->dd_used_breakdown[DD_USED_SNAP];
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2799 ASSERT3S(delta, >=, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2800 ASSERT3U(pa->used, >=, delta);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2801 dsl_dir_diduse_space(dd, DD_USED_SNAP, delta, 0, 0, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2802 dsl_dir_diduse_space(dd, DD_USED_HEAD,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2803 pa->used - delta, pa->comp, pa->uncomp, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2804
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2805 delta = pa->originusedsnap -
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2806 odd->dd_phys->dd_used_breakdown[DD_USED_SNAP];
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2807 ASSERT3S(delta, <=, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2808 ASSERT3U(pa->used, >=, -delta);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2809 dsl_dir_diduse_space(odd, DD_USED_SNAP, delta, 0, 0, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2810 dsl_dir_diduse_space(odd, DD_USED_HEAD,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2811 -pa->used - delta, -pa->comp, -pa->uncomp, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2812
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2813 origin_ds->ds_phys->ds_unique_bytes = pa->unique;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2814
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2815 /* log history record */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2816 spa_history_log_internal(LOG_DS_PROMOTE, dd->dd_pool->dp_spa, tx,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2817 "dataset = %llu", hds->ds_object);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2818
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2819 dsl_dir_close(odd, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2820 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2821
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2822 static char *snaplist_tag = "snaplist";
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2823 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2824 * Make a list of dsl_dataset_t's for the snapshots between first_obj
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2825 * (exclusive) and last_obj (inclusive). The list will be in reverse
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2826 * order (last_obj will be the list_head()). If first_obj == 0, do all
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2827 * snapshots back to this dataset's origin.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2828 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2829 static int
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2830 snaplist_make(dsl_pool_t *dp, boolean_t own,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2831 uint64_t first_obj, uint64_t last_obj, list_t *l)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2832 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2833 uint64_t obj = last_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2834
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2835 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2836
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2837 list_create(l, sizeof (struct promotenode),
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2838 offsetof(struct promotenode, link));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2839
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2840 while (obj != first_obj) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2841 dsl_dataset_t *ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2842 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2843 int err;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2844
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2845 if (own) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2846 err = dsl_dataset_own_obj(dp, obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2847 0, snaplist_tag, &ds);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2848 if (err == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2849 dsl_dataset_make_exclusive(ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2850 } else {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2851 err = dsl_dataset_hold_obj(dp, obj, snaplist_tag, &ds);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2852 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2853 if (err == ENOENT) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2854 /* lost race with snapshot destroy */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2855 struct promotenode *last = list_tail(l);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2856 ASSERT(obj != last->ds->ds_phys->ds_prev_snap_obj);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2857 obj = last->ds->ds_phys->ds_prev_snap_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2858 continue;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2859 } else if (err) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2860 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2861 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2862
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2863 if (first_obj == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2864 first_obj = ds->ds_dir->dd_phys->dd_origin_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2865
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2866 snap = kmem_alloc(sizeof (struct promotenode), KM_SLEEP);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2867 snap->ds = ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2868 list_insert_tail(l, snap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2869 obj = ds->ds_phys->ds_prev_snap_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2870 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2871
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2872 return (0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2873 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2874
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2875 static int
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2876 snaplist_space(list_t l, uint64_t mintxg, uint64_t spacep)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2877 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2878 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2879
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2880 *spacep = 0;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2881 for (snap = list_head(l); snap; snap = list_next(l, snap)) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2882 uint64_t used, comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2883 dsl_deadlist_space_range(&snap->ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2884 mintxg, UINT64_MAX, &used, &comp, &uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2885 *spacep += used;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2886 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2887 return (0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2888 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2889
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2890 static void
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2891 snaplist_destroy(list_t *l, boolean_t own)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2892 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2893 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2894
8779 f164e0e90508 6784924 panic while ludelete (zfs destroy) Mark J Musante <Mark.Musante@Sun.COM> parents: 8746 diff changeset	2895 if (!l \|\| !list_link_active(&l->list_head))
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2896 return;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2897
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2898 while ((snap = list_tail(l)) != NULL) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2899 list_remove(l, snap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2900 if (own)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2901 dsl_dataset_disown(snap->ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2902 else
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2903 dsl_dataset_rele(snap->ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2904 kmem_free(snap, sizeof (struct promotenode));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2905 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2906 list_destroy(l);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2907 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2908
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2909 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2910 * Promote a clone. Nomenclature note:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2911 * "clone" or "cds": the original clone which is being promoted
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2912 * "origin" or "ods": the snapshot which is originally clone's origin
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2913 * "origin head" or "ohds": the dataset which is the head
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2914 * (filesystem/volume) for the origin
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2915 * "origin origin": the origin of the origin's filesystem (typically
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2916 * NULL, indicating that the clone is not a clone of a clone).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2917 */
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2918 int
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2919 dsl_dataset_promote(const char name, char conflsnap)
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2920 {
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2921 dsl_dataset_t *ds;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2922 dsl_dir_t *dd;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2923 dsl_pool_t *dp;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2924 dmu_object_info_t doi;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2925 struct promotearg pa = { 0 };
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2926 struct promotenode *snap;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2927 int err;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2928
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2929 err = dsl_dataset_hold(name, FTAG, &ds);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2930 if (err)
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2931 return (err);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2932 dd = ds->ds_dir;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2933 dp = dd->dd_pool;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2934
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2935 err = dmu_object_info(dp->dp_meta_objset,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2936 ds->ds_phys->ds_snapnames_zapobj, &doi);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2937 if (err) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2938 dsl_dataset_rele(ds, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2939 return (err);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2940 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2941
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2942 if (dsl_dataset_is_snapshot(ds) \|\| dd->dd_phys->dd_origin_obj == 0) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2943 dsl_dataset_rele(ds, FTAG);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2944 return (EINVAL);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2945 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2946
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2947 /*
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2948 * We are going to inherit all the snapshots taken before our
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2949 * origin (i.e., our new origin will be our parent's origin).
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2950 * Take ownership of them so that we can rename them into our
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2951 * namespace.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2952 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2953 rw_enter(&dp->dp_config_rwlock, RW_READER);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2954
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2955 err = snaplist_make(dp, B_TRUE, 0, dd->dd_phys->dd_origin_obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2956 &pa.shared_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2957 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2958 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2959
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2960 err = snaplist_make(dp, B_FALSE, 0, ds->ds_object, &pa.clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2961 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2962 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2963
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2964 snap = list_head(&pa.shared_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2965 ASSERT3U(snap->ds->ds_object, ==, dd->dd_phys->dd_origin_obj);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2966 err = snaplist_make(dp, B_FALSE, dd->dd_phys->dd_origin_obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2967 snap->ds->ds_dir->dd_phys->dd_head_dataset_obj, &pa.origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2968 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2969 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2970
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2971 if (snap->ds->ds_dir->dd_phys->dd_origin_obj != 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2972 err = dsl_dataset_hold_obj(dp,
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2973 snap->ds->ds_dir->dd_phys->dd_origin_obj,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2974 FTAG, &pa.origin_origin);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2975 if (err != 0)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2976 goto out;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2977 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2978
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2979 out:
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2980 rw_exit(&dp->dp_config_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2981
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2982 /*
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2983 * Add in 128x the snapnames zapobj size, since we will be moving
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2984 * a bunch of snapnames to the promoted ds, and dirtying their
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2985 * bonus buffers.
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2986 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2987 if (err == 0) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2988 err = dsl_sync_task_do(dp, dsl_dataset_promote_check,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2989 dsl_dataset_promote_sync, ds, &pa,
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	2990 2 + 2 * doi.doi_physical_blocks_512);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2991 if (err && pa.err_ds && conflsnap)
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2992 (void) strncpy(conflsnap, pa.err_ds, MAXNAMELEN);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2993 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2994
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2995 snaplist_destroy(&pa.shared_snaps, B_TRUE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2996 snaplist_destroy(&pa.clone_snaps, B_FALSE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2997 snaplist_destroy(&pa.origin_snaps, B_FALSE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2998 if (pa.origin_origin)
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2999 dsl_dataset_rele(pa.origin_origin, FTAG);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3000 dsl_dataset_rele(ds, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3001 return (err);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3002 }
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3003
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3004 struct cloneswaparg {
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3005 dsl_dataset_t cds; / clone dataset */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3006 dsl_dataset_t ohds; / origin's head dataset */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3007 boolean_t force;
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3008 int64_t unused_refres_delta; /* change in unconsumed refreservation */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3009 };
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3010
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3011 /* ARGSUSED */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3012 static int
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3013 dsl_dataset_clone_swap_check(void arg1, void arg2, dmu_tx_t *tx)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3014 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3015 struct cloneswaparg *csa = arg1;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3016
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3017 /* they should both be heads */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3018 if (dsl_dataset_is_snapshot(csa->cds) \|\|
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3019 dsl_dataset_is_snapshot(csa->ohds))
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3020 return (EINVAL);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3021
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3022 /* the branch point should be just before them */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3023 if (csa->cds->ds_prev != csa->ohds->ds_prev)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3024 return (EINVAL);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3025
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3026 /* cds should be the clone (unless they are unrelated) */
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3027 if (csa->cds->ds_prev != NULL &&
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3028 csa->cds->ds_prev != csa->cds->ds_dir->dd_pool->dp_origin_snap &&
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3029 csa->ohds->ds_object !=
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3030 csa->cds->ds_prev->ds_phys->ds_next_snap_obj)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3031 return (EINVAL);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3032
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3033 /* the clone should be a child of the origin */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3034 if (csa->cds->ds_dir->dd_parent != csa->ohds->ds_dir)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3035 return (EINVAL);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3036
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3037 /* ohds shouldn't be modified unless 'force' */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3038 if (!csa->force && dsl_dataset_modified_since_lastsnap(csa->ohds))
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3039 return (ETXTBSY);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3040
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3041 /* adjust amount of any unconsumed refreservation */
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3042 csa->unused_refres_delta =
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3043 (int64_t)MIN(csa->ohds->ds_reserved,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3044 csa->ohds->ds_phys->ds_unique_bytes) -
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3045 (int64_t)MIN(csa->ohds->ds_reserved,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3046 csa->cds->ds_phys->ds_unique_bytes);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3047
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3048 if (csa->unused_refres_delta > 0 &&
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3049 csa->unused_refres_delta >
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3050 dsl_dir_space_available(csa->ohds->ds_dir, NULL, 0, TRUE))
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3051 return (ENOSPC);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3052
10799 395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3053 if (csa->ohds->ds_quota != 0 &&
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3054 csa->cds->ds_phys->ds_unique_bytes > csa->ohds->ds_quota)
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3055 return (EDQUOT);
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3056
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3057 return (0);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3058 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3059
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3060 /* ARGSUSED */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3061 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3062 dsl_dataset_clone_swap_sync(void arg1, void arg2, dmu_tx_t *tx)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3063 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3064 struct cloneswaparg *csa = arg1;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3065 dsl_pool_t *dp = csa->cds->ds_dir->dd_pool;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3066
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3067 ASSERT(csa->cds->ds_reserved == 0);
10799 395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3068 ASSERT(csa->ohds->ds_quota == 0 \|\|
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3069 csa->cds->ds_phys->ds_unique_bytes <= csa->ohds->ds_quota);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3070
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3071 dmu_buf_will_dirty(csa->cds->ds_dbuf, tx);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3072 dmu_buf_will_dirty(csa->ohds->ds_dbuf, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3073
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3074 if (csa->cds->ds_objset != NULL) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3075 dmu_objset_evict(csa->cds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3076 csa->cds->ds_objset = NULL;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3077 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3078
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3079 if (csa->ohds->ds_objset != NULL) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3080 dmu_objset_evict(csa->ohds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3081 csa->ohds->ds_objset = NULL;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3082 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3083
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3084 /*
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3085 * Reset origin's unique bytes, if it exists.
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3086 */
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3087 if (csa->cds->ds_prev) {
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3088 dsl_dataset_t *origin = csa->cds->ds_prev;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3089 uint64_t comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3090
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3091 dmu_buf_will_dirty(origin->ds_dbuf, tx);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3092 dsl_deadlist_space_range(&csa->cds->ds_deadlist,
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3093 origin->ds_phys->ds_prev_snap_txg, UINT64_MAX,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3094 &origin->ds_phys->ds_unique_bytes, &comp, &uncomp);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3095 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3096
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3097 /* swap blkptrs */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3098 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3099 blkptr_t tmp;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3100 tmp = csa->ohds->ds_phys->ds_bp;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3101 csa->ohds->ds_phys->ds_bp = csa->cds->ds_phys->ds_bp;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3102 csa->cds->ds_phys->ds_bp = tmp;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3103 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3104
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3105 /* set dd__bytes /
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3106 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3107 int64_t dused, dcomp, duncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3108 uint64_t cdl_used, cdl_comp, cdl_uncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3109 uint64_t odl_used, odl_comp, odl_uncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3110
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3111 ASSERT3U(csa->cds->ds_dir->dd_phys->
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3112 dd_used_breakdown[DD_USED_SNAP], ==, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3113
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3114 dsl_deadlist_space(&csa->cds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3115 &cdl_used, &cdl_comp, &cdl_uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3116 dsl_deadlist_space(&csa->ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3117 &odl_used, &odl_comp, &odl_uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3118
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3119 dused = csa->cds->ds_phys->ds_used_bytes + cdl_used -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3120 (csa->ohds->ds_phys->ds_used_bytes + odl_used);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3121 dcomp = csa->cds->ds_phys->ds_compressed_bytes + cdl_comp -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3122 (csa->ohds->ds_phys->ds_compressed_bytes + odl_comp);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3123 duncomp = csa->cds->ds_phys->ds_uncompressed_bytes +
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3124 cdl_uncomp -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3125 (csa->ohds->ds_phys->ds_uncompressed_bytes + odl_uncomp);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3126
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3127 dsl_dir_diduse_space(csa->ohds->ds_dir, DD_USED_HEAD,
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3128 dused, dcomp, duncomp, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3129 dsl_dir_diduse_space(csa->cds->ds_dir, DD_USED_HEAD,
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3130 -dused, -dcomp, -duncomp, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3131
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3132 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3133 * The difference in the space used by snapshots is the
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3134 * difference in snapshot space due to the head's
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3135 * deadlist (since that's the only thing that's
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3136 * changing that affects the snapused).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3137 */
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3138 dsl_deadlist_space_range(&csa->cds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3139 csa->ohds->ds_dir->dd_origin_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3140 &cdl_used, &cdl_comp, &cdl_uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3141 dsl_deadlist_space_range(&csa->ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3142 csa->ohds->ds_dir->dd_origin_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3143 &odl_used, &odl_comp, &odl_uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3144 dsl_dir_transfer_space(csa->ohds->ds_dir, cdl_used - odl_used,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3145 DD_USED_HEAD, DD_USED_SNAP, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3146 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3147
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3148 /* swap ds__bytes /
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3149 SWITCH64(csa->ohds->ds_phys->ds_used_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3150 csa->cds->ds_phys->ds_used_bytes);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3151 SWITCH64(csa->ohds->ds_phys->ds_compressed_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3152 csa->cds->ds_phys->ds_compressed_bytes);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3153 SWITCH64(csa->ohds->ds_phys->ds_uncompressed_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3154 csa->cds->ds_phys->ds_uncompressed_bytes);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3155 SWITCH64(csa->ohds->ds_phys->ds_unique_bytes,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3156 csa->cds->ds_phys->ds_unique_bytes);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3157
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3158 /* apply any parent delta for change in unconsumed refreservation */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3159 dsl_dir_diduse_space(csa->ohds->ds_dir, DD_USED_REFRSRV,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3160 csa->unused_refres_delta, 0, 0, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3161
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3162 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3163 * Swap deadlists.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3164 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3165 dsl_deadlist_close(&csa->cds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3166 dsl_deadlist_close(&csa->ohds->ds_deadlist);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3167 SWITCH64(csa->ohds->ds_phys->ds_deadlist_obj,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3168 csa->cds->ds_phys->ds_deadlist_obj);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3169 dsl_deadlist_open(&csa->cds->ds_deadlist, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3170 csa->cds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3171 dsl_deadlist_open(&csa->ohds->ds_deadlist, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3172 csa->ohds->ds_phys->ds_deadlist_obj);
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	3173
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3174 dsl_scan_ds_clone_swapped(csa->ohds, csa->cds, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3175 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3176
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3177 /*
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3178 * Swap 'clone' with its origin head datasets. Used at the end of "zfs
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3179 * recv" into an existing fs to swizzle the file system to the new
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3180 * version, and by "zfs rollback". Can also be used to swap two
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3181 * independent head datasets if neither has any snapshots.
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3182 */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3183 int
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3184 dsl_dataset_clone_swap(dsl_dataset_t clone, dsl_dataset_t origin_head,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3185 boolean_t force)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3186 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3187 struct cloneswaparg csa;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3188 int error;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3189
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3190 ASSERT(clone->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3191 ASSERT(origin_head->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3192 retry:
12711 7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3193 /*
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3194 * Need exclusive access for the swap. If we're swapping these
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3195 * datasets back after an error, we already hold the locks.
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3196 */
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3197 if (!RW_WRITE_HELD(&clone->ds_rwlock))
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3198 rw_enter(&clone->ds_rwlock, RW_WRITER);
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3199 if (!RW_WRITE_HELD(&origin_head->ds_rwlock) &&
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3200 !rw_tryenter(&origin_head->ds_rwlock, RW_WRITER)) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3201 rw_exit(&clone->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3202 rw_enter(&origin_head->ds_rwlock, RW_WRITER);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3203 if (!rw_tryenter(&clone->ds_rwlock, RW_WRITER)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3204 rw_exit(&origin_head->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3205 goto retry;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3206 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3207 }
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3208 csa.cds = clone;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3209 csa.ohds = origin_head;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3210 csa.force = force;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3211 error = dsl_sync_task_do(clone->ds_dir->dd_pool,
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3212 dsl_dataset_clone_swap_check,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3213 dsl_dataset_clone_swap_sync, &csa, NULL, 9);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3214 return (error);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3215 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3216
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3217 /*
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3218 * Given a pool name and a dataset object number in that pool,
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3219 * return the name of that dataset.
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3220 */
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3221 int
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3222 dsl_dsobj_to_dsname(char pname, uint64_t obj, char buf)
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3223 {
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3224 spa_t *spa;
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3225 dsl_pool_t *dp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3226 dsl_dataset_t *ds;
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3227 int error;
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3228
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3229 if ((error = spa_open(pname, &spa, FTAG)) != 0)
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3230 return (error);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3231 dp = spa_get_dsl(spa);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3232 rw_enter(&dp->dp_config_rwlock, RW_READER);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3233 if ((error = dsl_dataset_hold_obj(dp, obj, FTAG, &ds)) == 0) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3234 dsl_dataset_name(ds, buf);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3235 dsl_dataset_rele(ds, FTAG);
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3236 }
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3237 rw_exit(&dp->dp_config_rwlock);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3238 spa_close(spa, FTAG);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3239
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3240 return (error);
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3241 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3242
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3243 int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3244 dsl_dataset_check_quota(dsl_dataset_t *ds, boolean_t check_quota,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3245 uint64_t asize, uint64_t inflight, uint64_t used, uint64_t ref_rsrv)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3246 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3247 int error = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3248
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3249 ASSERT3S(asize, >, 0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3250
5831 48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3251 /*
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3252 * *ref_rsrv is the portion of asize that will come from any
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3253 * unconsumed refreservation space.
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3254 */
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3255 *ref_rsrv = 0;
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3256
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3257 mutex_enter(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3258 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3259 * Make a space adjustment for reserved bytes.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3260 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3261 if (ds->ds_reserved > ds->ds_phys->ds_unique_bytes) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3262 ASSERT3U(*used, >=,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3263 ds->ds_reserved - ds->ds_phys->ds_unique_bytes);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3264 *used -= (ds->ds_reserved - ds->ds_phys->ds_unique_bytes);
5831 48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3265 *ref_rsrv =
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3266 asize - MIN(asize, parent_delta(ds, asize + inflight));
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3267 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3268
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3269 if (!check_quota \|\| ds->ds_quota == 0) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3270 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3271 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3272 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3273 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3274 * If they are requesting more space, and our current estimate
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3275 * is over quota, they get to try again unless the actual
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3276 * on-disk is over quota and there are no pending changes (which
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3277 * may free up space for us).
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3278 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3279 if (ds->ds_phys->ds_used_bytes + inflight >= ds->ds_quota) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3280 if (inflight > 0 \|\| ds->ds_phys->ds_used_bytes < ds->ds_quota)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3281 error = ERESTART;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3282 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3283 error = EDQUOT;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3284 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3285 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3286
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3287 return (error);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3288 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3289
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3290 /* ARGSUSED */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3291 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3292 dsl_dataset_set_quota_check(void arg1, void arg2, dmu_tx_t *tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3293 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3294 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3295 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3296 int err;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3297
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3298 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_REFQUOTA)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3299 return (ENOTSUP);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3300
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3301 if ((err = dsl_prop_predict_sync(ds->ds_dir, psa)) != 0)
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3302 return (err);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3303
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3304 if (psa->psa_effective_value == 0)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3305 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3306
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3307 if (psa->psa_effective_value < ds->ds_phys->ds_used_bytes \|\|
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3308 psa->psa_effective_value < ds->ds_reserved)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3309 return (ENOSPC);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3310
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3311 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3312 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3313
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3314 extern void dsl_prop_set_sync(void , void , dmu_tx_t *);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3315
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3316 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3317 dsl_dataset_set_quota_sync(void arg1, void arg2, dmu_tx_t *tx)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3318 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3319 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3320 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3321 uint64_t effective_value = psa->psa_effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3322
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3323 dsl_prop_set_sync(ds, psa, tx);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3324 DSL_PROP_CHECK_PREDICTION(ds->ds_dir, psa);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3325
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3326 if (ds->ds_quota != effective_value) {
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3327 dmu_buf_will_dirty(ds->ds_dbuf, tx);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3328 ds->ds_quota = effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3329
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3330 spa_history_log_internal(LOG_DS_REFQUOTA,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3331 ds->ds_dir->dd_pool->dp_spa, tx, "%lld dataset = %llu ",
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3332 (longlong_t)ds->ds_quota, ds->ds_object);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3333 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3334 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3335
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3336 int
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3337 dsl_dataset_set_quota(const char *dsname, zprop_source_t source, uint64_t quota)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3338 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3339 dsl_dataset_t *ds;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3340 dsl_prop_setarg_t psa;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3341 int err;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3342
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3343 dsl_prop_setarg_init_uint64(&psa, "refquota", source, &quota);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3344
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3345 err = dsl_dataset_hold(dsname, FTAG, &ds);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3346 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3347 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3348
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3349 /*
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3350 * If someone removes a file, then tries to set the quota, we
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3351 * want to make sure the file freeing takes effect.
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3352 */
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3353 txg_wait_open(ds->ds_dir->dd_pool, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3354
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3355 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3356 dsl_dataset_set_quota_check, dsl_dataset_set_quota_sync,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3357 ds, &psa, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3358
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3359 dsl_dataset_rele(ds, FTAG);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3360 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3361 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3362
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3363 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3364 dsl_dataset_set_reservation_check(void arg1, void arg2, dmu_tx_t *tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3365 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3366 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3367 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3368 uint64_t effective_value;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3369 uint64_t unique;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3370 int err;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3371
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3372 if (spa_version(ds->ds_dir->dd_pool->dp_spa) <
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3373 SPA_VERSION_REFRESERVATION)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3374 return (ENOTSUP);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3375
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3376 if (dsl_dataset_is_snapshot(ds))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3377 return (EINVAL);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3378
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3379 if ((err = dsl_prop_predict_sync(ds->ds_dir, psa)) != 0)
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3380 return (err);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3381
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3382 effective_value = psa->psa_effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3383
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3384 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3385 * If we are doing the preliminary check in open context, the
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3386 * space estimates may be inaccurate.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3387 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3388 if (!dmu_tx_is_syncing(tx))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3389 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3390
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3391 mutex_enter(&ds->ds_lock);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3392 if (!DS_UNIQUE_IS_ACCURATE(ds))
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3393 dsl_dataset_recalc_head_uniq(ds);
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3394 unique = ds->ds_phys->ds_unique_bytes;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3395 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3396
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3397 if (MAX(unique, effective_value) > MAX(unique, ds->ds_reserved)) {
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3398 uint64_t delta = MAX(unique, effective_value) -
8525 e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3399 MAX(unique, ds->ds_reserved);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3400
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3401 if (delta > dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE))
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3402 return (ENOSPC);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3403 if (ds->ds_quota > 0 &&
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3404 effective_value > ds->ds_quota)
8525 e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3405 return (ENOSPC);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3406 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3407
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3408 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3409 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3410
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3411 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3412 dsl_dataset_set_reservation_sync(void arg1, void arg2, dmu_tx_t *tx)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3413 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3414 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3415 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3416 uint64_t effective_value = psa->psa_effective_value;
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3417 uint64_t unique;
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3418 int64_t delta;
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3419
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3420 dsl_prop_set_sync(ds, psa, tx);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3421 DSL_PROP_CHECK_PREDICTION(ds->ds_dir, psa);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3422
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3423 dmu_buf_will_dirty(ds->ds_dbuf, tx);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3424
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3425 mutex_enter(&ds->ds_dir->dd_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3426 mutex_enter(&ds->ds_lock);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3427 ASSERT(DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3428 unique = ds->ds_phys->ds_unique_bytes;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3429 delta = MAX(0, (int64_t)(effective_value - unique)) -
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3430 MAX(0, (int64_t)(ds->ds_reserved - unique));
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3431 ds->ds_reserved = effective_value;
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3432 mutex_exit(&ds->ds_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3433
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3434 dsl_dir_diduse_space(ds->ds_dir, DD_USED_REFRSRV, delta, 0, 0, tx);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3435 mutex_exit(&ds->ds_dir->dd_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3436
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3437 spa_history_log_internal(LOG_DS_REFRESERV,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3438 ds->ds_dir->dd_pool->dp_spa, tx, "%lld dataset = %llu",
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3439 (longlong_t)effective_value, ds->ds_object);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3440 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3441
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3442 int
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3443 dsl_dataset_set_reservation(const char *dsname, zprop_source_t source,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3444 uint64_t reservation)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3445 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3446 dsl_dataset_t *ds;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3447 dsl_prop_setarg_t psa;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3448 int err;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3449
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3450 dsl_prop_setarg_init_uint64(&psa, "refreservation", source,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3451 &reservation);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3452
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3453 err = dsl_dataset_hold(dsname, FTAG, &ds);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3454 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3455 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3456
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3457 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3458 dsl_dataset_set_reservation_check,
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3459 dsl_dataset_set_reservation_sync, ds, &psa, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3460
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3461 dsl_dataset_rele(ds, FTAG);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3462 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3463 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3464
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3465 typedef struct zfs_hold_cleanup_arg {
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3466 dsl_pool_t *dp;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3467 uint64_t dsobj;
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3468 char htag[MAXNAMELEN];
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3469 } zfs_hold_cleanup_arg_t;
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3470
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3471 static void
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3472 dsl_dataset_user_release_onexit(void *arg)
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3473 {
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3474 zfs_hold_cleanup_arg_t *ca = arg;
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3475
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3476 (void) dsl_dataset_user_release_tmp(ca->dp, ca->dsobj, ca->htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3477 B_TRUE);
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3478 kmem_free(ca, sizeof (zfs_hold_cleanup_arg_t));
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3479 }
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3480
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3481 void
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3482 dsl_register_onexit_hold_cleanup(dsl_dataset_t ds, const char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3483 minor_t minor)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3484 {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3485 zfs_hold_cleanup_arg_t *ca;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3486
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3487 ca = kmem_alloc(sizeof (zfs_hold_cleanup_arg_t), KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3488 ca->dp = ds->ds_dir->dd_pool;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3489 ca->dsobj = ds->ds_object;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3490 (void) strlcpy(ca->htag, htag, sizeof (ca->htag));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3491 VERIFY3U(0, ==, zfs_onexit_add_cb(minor,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3492 dsl_dataset_user_release_onexit, ca, NULL));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3493 }
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3494
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3495 /*
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3496 * If you add new checks here, you may need to add
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3497 * additional checks to the "temporary" case in
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3498 * snapshot_check() in dmu_objset.c.
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3499 */
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3500 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3501 dsl_dataset_user_hold_check(void arg1, void arg2, dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3502 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3503 dsl_dataset_t *ds = arg1;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3504 struct dsl_ds_holdarg *ha = arg2;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3505 char *htag = ha->htag;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3506 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3507 int error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3508
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3509 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3510 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3511
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3512 if (!dsl_dataset_is_snapshot(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3513 return (EINVAL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3514
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3515 /* tags must be unique */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3516 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3517 if (ds->ds_phys->ds_userrefs_obj) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3518 error = zap_lookup(mos, ds->ds_phys->ds_userrefs_obj, htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3519 8, 1, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3520 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3521 error = EEXIST;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3522 else if (error == ENOENT)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3523 error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3524 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3525 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3526
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3527 if (error == 0 && ha->temphold &&
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3528 strlen(htag) + MAX_TAG_PREFIX_LEN >= MAXNAMELEN)
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3529 error = E2BIG;
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3530
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3531 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3532 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3533
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3534 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3535 dsl_dataset_user_hold_sync(void arg1, void arg2, dmu_tx_t *tx)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3536 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3537 dsl_dataset_t *ds = arg1;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3538 struct dsl_ds_holdarg *ha = arg2;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3539 char *htag = ha->htag;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3540 dsl_pool_t *dp = ds->ds_dir->dd_pool;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3541 objset_t *mos = dp->dp_meta_objset;
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3542 uint64_t now = gethrestime_sec();
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3543 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3544
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3545 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3546 if (ds->ds_phys->ds_userrefs_obj == 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3547 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3548 * This is the first user hold for this dataset. Create
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3549 * the userrefs zap object.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3550 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3551 dmu_buf_will_dirty(ds->ds_dbuf, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3552 zapobj = ds->ds_phys->ds_userrefs_obj =
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3553 zap_create(mos, DMU_OT_USERREFS, DMU_OT_NONE, 0, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3554 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3555 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3556 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3557 ds->ds_userrefs++;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3558 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3559
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3560 VERIFY(0 == zap_add(mos, zapobj, htag, 8, 1, &now, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3561
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3562 if (ha->temphold) {
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3563 VERIFY(0 == dsl_pool_user_hold(dp, ds->ds_object,
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3564 htag, &now, tx));
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3565 }
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3566
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3567 spa_history_log_internal(LOG_DS_USER_HOLD,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3568 dp->dp_spa, tx, "<%s> temp = %d dataset = %llu", htag,
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3569 (int)ha->temphold, ds->ds_object);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3570 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3571
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3572 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3573 dsl_dataset_user_hold_one(const char dsname, void arg)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3574 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3575 struct dsl_ds_holdarg *ha = arg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3576 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3577 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3578 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3579
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3580 /* alloc a buffer to hold dsname@snapname plus terminating NULL */
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3581 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3582 error = dsl_dataset_hold(name, ha->dstg, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3583 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3584 if (error == 0) {
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3585 ha->gotone = B_TRUE;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3586 dsl_sync_task_create(ha->dstg, dsl_dataset_user_hold_check,
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3587 dsl_dataset_user_hold_sync, ds, ha, 0);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3588 } else if (error == ENOENT && ha->recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3589 error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3590 } else {
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3591 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3592 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3593 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3594 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3595
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3596 int
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3597 dsl_dataset_user_hold_for_send(dsl_dataset_t ds, char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3598 boolean_t temphold)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3599 {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3600 struct dsl_ds_holdarg *ha;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3601 int error;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3602
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3603 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3604 ha->htag = htag;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3605 ha->temphold = temphold;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3606 error = dsl_sync_task_do(ds->ds_dir->dd_pool,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3607 dsl_dataset_user_hold_check, dsl_dataset_user_hold_sync,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3608 ds, ha, 0);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3609 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3610
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3611 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3612 }
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3613
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3614 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3615 dsl_dataset_user_hold(char dsname, char snapname, char *htag,
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3616 boolean_t recursive, boolean_t temphold, int cleanup_fd)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3617 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3618 struct dsl_ds_holdarg *ha;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3619 dsl_sync_task_t *dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3620 spa_t *spa;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3621 int error;
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3622 minor_t minor = 0;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3623
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3624 if (cleanup_fd != -1) {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3625 /* Currently we only support cleanup-on-exit of tempholds. */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3626 if (!temphold)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3627 return (EINVAL);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3628 error = zfs_onexit_fd_hold(cleanup_fd, &minor);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3629 if (error)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3630 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3631 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3632
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3633 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3634
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3635 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3636
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3637 error = spa_open(dsname, &spa, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3638 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3639 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3640 if (cleanup_fd != -1)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3641 zfs_onexit_fd_rele(cleanup_fd);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3642 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3643 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3644
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3645 ha->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3646 ha->htag = htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3647 ha->snapname = snapname;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3648 ha->recursive = recursive;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3649 ha->temphold = temphold;
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3650
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3651 if (recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3652 error = dmu_objset_find(dsname, dsl_dataset_user_hold_one,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3653 ha, DS_FIND_CHILDREN);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3654 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3655 error = dsl_dataset_user_hold_one(dsname, ha);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3656 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3657 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3658 error = dsl_sync_task_group_wait(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3659
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3660 for (dst = list_head(&ha->dstg->dstg_tasks); dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3661 dst = list_next(&ha->dstg->dstg_tasks, dst)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3662 dsl_dataset_t *ds = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3663
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3664 if (dst->dst_err) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3665 dsl_dataset_name(ds, ha->failed);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3666 *strchr(ha->failed, '@') = '\0';
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3667 } else if (error == 0 && minor != 0 && temphold) {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3668 /*
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3669 * If this hold is to be released upon process exit,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3670 * register that action now.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3671 */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3672 dsl_register_onexit_hold_cleanup(ds, htag, minor);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3673 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3674 dsl_dataset_rele(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3675 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3676
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3677 if (error == 0 && recursive && !ha->gotone)
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3678 error = ENOENT;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3679
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3680 if (error)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3681 (void) strlcpy(dsname, ha->failed, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3682
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3683 dsl_sync_task_group_destroy(ha->dstg);
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3684
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3685 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3686 spa_close(spa, FTAG);
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3687 if (cleanup_fd != -1)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3688 zfs_onexit_fd_rele(cleanup_fd);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3689 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3690 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3691
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3692 struct dsl_ds_releasearg {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3693 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3694 const char *htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3695 boolean_t own; /* do we own or just hold ds? */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3696 };
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3697
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3698 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3699 dsl_dataset_release_might_destroy(dsl_dataset_t ds, const char htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3700 boolean_t *might_destroy)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3701 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3702 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3703 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3704 uint64_t tmp;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3705 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3706
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3707 *might_destroy = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3708
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3709 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3710 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3711 if (zapobj == 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3712 /* The tag can't possibly exist */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3713 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3714 return (ESRCH);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3715 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3716
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3717 /* Make sure the tag exists */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3718 error = zap_lookup(mos, zapobj, htag, 8, 1, &tmp);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3719 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3720 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3721 if (error == ENOENT)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3722 error = ESRCH;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3723 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3724 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3725
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3726 if (ds->ds_userrefs == 1 && ds->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3727 DS_IS_DEFER_DESTROY(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3728 *might_destroy = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3729
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3730 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3731 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3732 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3733
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3734 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3735 dsl_dataset_user_release_check(void arg1, void tag, dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3736 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3737 struct dsl_ds_releasearg *ra = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3738 dsl_dataset_t *ds = ra->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3739 boolean_t might_destroy;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3740 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3741
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3742 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3743 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3744
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3745 error = dsl_dataset_release_might_destroy(ds, ra->htag, &might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3746 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3747 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3748
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3749 if (might_destroy) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3750 struct dsl_ds_destroyarg dsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3751
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3752 if (dmu_tx_is_syncing(tx)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3753 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3754 * If we're not prepared to remove the snapshot,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3755 * we can't allow the release to happen right now.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3756 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3757 if (!ra->own)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3758 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3759 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3760 dsda.ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3761 dsda.releasing = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3762 return (dsl_dataset_destroy_check(&dsda, tag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3763 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3764
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3765 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3766 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3767
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3768 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3769 dsl_dataset_user_release_sync(void arg1, void tag, dmu_tx_t *tx)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3770 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3771 struct dsl_ds_releasearg *ra = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3772 dsl_dataset_t *ds = ra->ds;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3773 dsl_pool_t *dp = ds->ds_dir->dd_pool;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3774 objset_t *mos = dp->dp_meta_objset;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3775 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3776 uint64_t dsobj = ds->ds_object;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3777 uint64_t refs;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3778 int error;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3779
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3780 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3781 ds->ds_userrefs--;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3782 refs = ds->ds_userrefs;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3783 mutex_exit(&ds->ds_lock);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3784 error = dsl_pool_user_release(dp, ds->ds_object, ra->htag, tx);
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3785 VERIFY(error == 0 \|\| error == ENOENT);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3786 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3787 VERIFY(0 == zap_remove(mos, zapobj, ra->htag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3788 if (ds->ds_userrefs == 0 && ds->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3789 DS_IS_DEFER_DESTROY(ds)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3790 struct dsl_ds_destroyarg dsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3791
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3792 ASSERT(ra->own);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3793 dsda.ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3794 dsda.releasing = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3795 /* We already did the destroy_check */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3796 dsl_dataset_destroy_sync(&dsda, tag, tx);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3797 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3798
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3799 spa_history_log_internal(LOG_DS_USER_RELEASE,
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3800 dp->dp_spa, tx, "<%s> %lld dataset = %llu",
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3801 ra->htag, (longlong_t)refs, dsobj);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3802 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3803
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3804 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3805 dsl_dataset_user_release_one(const char dsname, void arg)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3806 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3807 struct dsl_ds_holdarg *ha = arg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3808 struct dsl_ds_releasearg *ra;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3809 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3810 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3811 void *dtag = ha->dstg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3812 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3813 boolean_t own = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3814 boolean_t might_destroy;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3815
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3816 /* alloc a buffer to hold dsname@snapname, plus the terminating NULL */
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3817 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3818 error = dsl_dataset_hold(name, dtag, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3819 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3820 if (error == ENOENT && ha->recursive)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3821 return (0);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3822 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3823 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3824 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3825
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3826 ha->gotone = B_TRUE;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3827
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3828 ASSERT(dsl_dataset_is_snapshot(ds));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3829
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3830 error = dsl_dataset_release_might_destroy(ds, ha->htag, &might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3831 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3832 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3833 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3834 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3835
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3836 if (might_destroy) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3837 #ifdef _KERNEL
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	3838 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3839 error = zfs_unmount_snap(name, NULL);
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	3840 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3841 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3842 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3843 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3844 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3845 #endif
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3846 if (!dsl_dataset_tryown(ds, B_TRUE, dtag)) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3847 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3848 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3849 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3850 own = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3851 dsl_dataset_make_exclusive(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3852 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3853 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3854
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3855 ra = kmem_alloc(sizeof (struct dsl_ds_releasearg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3856 ra->ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3857 ra->htag = ha->htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3858 ra->own = own;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3859 dsl_sync_task_create(ha->dstg, dsl_dataset_user_release_check,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3860 dsl_dataset_user_release_sync, ra, dtag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3861
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3862 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3863 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3864
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3865 int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3866 dsl_dataset_user_release(char dsname, char snapname, char *htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3867 boolean_t recursive)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3868 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3869 struct dsl_ds_holdarg *ha;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3870 dsl_sync_task_t *dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3871 spa_t *spa;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3872 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3873
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3874 top:
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3875 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3876
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3877 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3878
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3879 error = spa_open(dsname, &spa, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3880 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3881 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3882 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3883 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3884
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3885 ha->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3886 ha->htag = htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3887 ha->snapname = snapname;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3888 ha->recursive = recursive;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3889 if (recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3890 error = dmu_objset_find(dsname, dsl_dataset_user_release_one,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3891 ha, DS_FIND_CHILDREN);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3892 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3893 error = dsl_dataset_user_release_one(dsname, ha);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3894 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3895 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3896 error = dsl_sync_task_group_wait(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3897
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3898 for (dst = list_head(&ha->dstg->dstg_tasks); dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3899 dst = list_next(&ha->dstg->dstg_tasks, dst)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3900 struct dsl_ds_releasearg *ra = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3901 dsl_dataset_t *ds = ra->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3902
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3903 if (dst->dst_err)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3904 dsl_dataset_name(ds, ha->failed);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3905
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3906 if (ra->own)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3907 dsl_dataset_disown(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3908 else
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3909 dsl_dataset_rele(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3910
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3911 kmem_free(ra, sizeof (struct dsl_ds_releasearg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3912 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3913
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3914 if (error == 0 && recursive && !ha->gotone)
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3915 error = ENOENT;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3916
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3917 if (error && error != EBUSY)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3918 (void) strlcpy(dsname, ha->failed, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3919
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3920 dsl_sync_task_group_destroy(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3921 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3922 spa_close(spa, FTAG);
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3923
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3924 /*
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3925 * We can get EBUSY if we were racing with deferred destroy and
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3926 * dsl_dataset_user_release_check() hadn't done the necessary
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3927 * open context setup. We can also get EBUSY if we're racing
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3928 * with destroy and that thread is the ds_owner. Either way
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3929 * the busy condition should be transient, and we should retry
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3930 * the release operation.
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3931 */
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3932 if (error == EBUSY)
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3933 goto top;
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3934
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3935 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3936 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3937
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3938 /*
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3939 * Called at spa_load time (with retry == B_FALSE) to release a stale
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3940 * temporary user hold. Also called by the onexit code (with retry == B_TRUE).
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3941 */
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3942 int
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3943 dsl_dataset_user_release_tmp(dsl_pool_t dp, uint64_t dsobj, char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3944 boolean_t retry)
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3945 {
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3946 dsl_dataset_t *ds;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3947 char *snap;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3948 char *name;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3949 int namelen;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3950 int error;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3951
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3952 do {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3953 rw_enter(&dp->dp_config_rwlock, RW_READER);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3954 error = dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3955 rw_exit(&dp->dp_config_rwlock);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3956 if (error)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3957 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3958 namelen = dsl_dataset_namelen(ds)+1;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3959 name = kmem_alloc(namelen, KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3960 dsl_dataset_name(ds, name);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3961 dsl_dataset_rele(ds, FTAG);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3962
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3963 snap = strchr(name, '@');
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3964 *snap = '\0';
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3965 ++snap;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3966 error = dsl_dataset_user_release(name, snap, htag, B_FALSE);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3967 kmem_free(name, namelen);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3968
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3969 /*
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3970 * The object can't have been destroyed because we have a hold,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3971 * but it might have been renamed, resulting in ENOENT. Retry
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3972 * if we've been requested to do so.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3973 *
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3974 * It would be nice if we could use the dsobj all the way
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3975 * through and avoid ENOENT entirely. But we might need to
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3976 * unmount the snapshot, and there's currently no way to lookup
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3977 * a vfsp using a ZFS object id.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3978 */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3979 } while ((error == ENOENT) && retry);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3980
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3981 return (error);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3982 }
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3983
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3984 int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3985 dsl_dataset_get_holds(const char dsname, nvlist_t *nvp)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3986 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3987 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3988 int err;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3989
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3990 err = dsl_dataset_hold(dsname, FTAG, &ds);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3991 if (err)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3992 return (err);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3993
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3994 VERIFY(0 == nvlist_alloc(nvp, NV_UNIQUE_NAME, KM_SLEEP));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3995 if (ds->ds_phys->ds_userrefs_obj != 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3996 zap_attribute_t *za;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3997 zap_cursor_t zc;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3998
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3999 za = kmem_alloc(sizeof (zap_attribute_t), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4000 for (zap_cursor_init(&zc, ds->ds_dir->dd_pool->dp_meta_objset,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4001 ds->ds_phys->ds_userrefs_obj);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4002 zap_cursor_retrieve(&zc, za) == 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4003 zap_cursor_advance(&zc)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4004 VERIFY(0 == nvlist_add_uint64(*nvp, za->za_name,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4005 za->za_first_integer));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4006 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4007 zap_cursor_fini(&zc);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4008 kmem_free(za, sizeof (zap_attribute_t));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4009 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4010 dsl_dataset_rele(ds, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4011 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4012 }
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4013
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4014 /*
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4015 * Note, this fuction is used as the callback for dmu_objset_find(). We
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4016 * always return 0 so that we will continue to find and process
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4017 * inconsistent datasets, even if we encounter an error trying to
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4018 * process one of them.
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4019 */
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4020 /* ARGSUSED */
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4021 int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	4022 dsl_destroy_inconsistent(const char dsname, void arg)
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4023 {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4024 dsl_dataset_t *ds;
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4025
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4026 if (dsl_dataset_own(dsname, B_TRUE, FTAG, &ds) == 0) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4027 if (DS_IS_INCONSISTENT(ds))
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4028 (void) dsl_dataset_destroy(ds, FTAG, B_FALSE);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4029 else
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4030 dsl_dataset_disown(ds, FTAG);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4031 }
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4032 return (0);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4033 }

Mercurial > illumos > illumos-gate

annotate usr/src/uts/common/fs/zfs/dsl_dataset.c @ 13387:7dd5626b8b49