Mercurial > nomad
changeset 871:7f43822eef34
objstore: add a FIXME about decrementing the unlink target's nlinks
Not doing this is currently fine because:
1. nothing will have a link count >1 as we don't support hardlinks yet
2. everything we unlink will cease to exist, so not writing a 0 nlinks is ok
Signed-off-by: Josef 'Jeff' Sipek <jeffpc@josefsipek.net>
| author | Josef 'Jeff' Sipek <jeffpc@josefsipek.net> |
|---|---|
| date | Sat, 17 Dec 2022 20:19:31 -0500 |
| parents | 75e654e85cab |
| children | 42b193c0524f |
| files | src/objstore/obj_dir_unlink.c |
| diffstat | 1 files changed, 3 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/src/objstore/obj_dir_unlink.c Sat Dec 17 20:15:05 2022 -0500 +++ b/src/objstore/obj_dir_unlink.c Sat Dec 17 20:19:31 2022 -0500 @@ -72,6 +72,9 @@ if (!rmdir && (block->entries[i].tgts[j].type == NDIRENT_TYPE_DIR)) return -EISDIR; + if (!rmdir) + FIXME("need to decrement the target's link count"); + /* update the target */ block->entries[i].tgts[j].deleted = true;