illumos/illumos-gate: usr/src/uts/common/fs/zfs/dsl

annotate usr/src/uts/common/fs/zfs/dsl_dataset.c @ 13952:7a22d0770fc8

3522 zfs module should not allow uninitialized variables Reviewed by: Sebastien Roy <seb@delphix.com> Reviewed by: Adam Leventhal <ahl@delphix.com> Reviewed by: Matthew Ahrens <mahrens@delphix.com> Approved by: Garrett D'Amore <garrett@damore.org>

author	George Wilson <george.wilson@delphix.com>
date	Sun, 10 Feb 2013 22:21:05 -0800
parents	d48547176ab4
children	b2c7608044b7

rev	line source
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2 * CDDL HEADER START
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	3 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	4 * The contents of this file are subject to the terms of the
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	5 * Common Development and Distribution License (the "License").
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	6 * You may not use this file except in compliance with the License.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	7 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	8 * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	9 * or http://www.opensolaris.org/os/licensing.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	10 * See the License for the specific language governing permissions
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	11 * and limitations under the License.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	12 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	13 * When distributing Covered Code, include this CDDL HEADER in each
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	14 * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	15 * If applicable, add the following below this CDDL HEADER, with the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	16 * fields enclosed by brackets "[]" replaced with your own identifying
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	17 * information: Portions Copyright [yyyy] [name of copyright owner]
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	18 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	19 * CDDL HEADER END
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	20 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	21 /*
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	22 * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	23 * Copyright (c) 2012 by Delphix. All rights reserved.
13686 4bc0783f6064 2703 add mechanism to report ZFS send progress Bill Pijewski <wdp@joyent.com> parents: 13524 diff changeset	24 * Copyright (c) 2012, Joyent, Inc. All rights reserved.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	25 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	26
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	27 #include <sys/dmu_objset.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	28 #include <sys/dsl_dataset.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	29 #include <sys/dsl_dir.h>
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	30 #include <sys/dsl_prop.h>
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	31 #include <sys/dsl_synctask.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	32 #include <sys/dmu_traverse.h>
13686 4bc0783f6064 2703 add mechanism to report ZFS send progress Bill Pijewski <wdp@joyent.com> parents: 13524 diff changeset	33 #include <sys/dmu_impl.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	34 #include <sys/dmu_tx.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	35 #include <sys/arc.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	36 #include <sys/zio.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	37 #include <sys/zap.h>
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	38 #include <sys/zfeature.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	39 #include <sys/unique.h>
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	40 #include <sys/zfs_context.h>
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	41 #include <sys/zfs_ioctl.h>
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	42 #include <sys/spa.h>
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	43 #include <sys/zfs_znode.h>
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	44 #include <sys/zfs_onexit.h>
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	45 #include <sys/zvol.h>
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	46 #include <sys/dsl_scan.h>
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	47 #include <sys/dsl_deadlist.h>
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	48
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	49 static char *dsl_reaper = "the grim reaper";
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	50
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	51 static dsl_checkfunc_t dsl_dataset_destroy_begin_check;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	52 static dsl_syncfunc_t dsl_dataset_destroy_begin_sync;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	53 static dsl_syncfunc_t dsl_dataset_set_reservation_sync;
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	54
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	55 #define SWITCH64(x, y) \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	56 { \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	57 uint64_t __tmp = (x); \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	58 (x) = (y); \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	59 (y) = __tmp; \
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	60 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	61
3444 dc160a70a50d 6410433 'zpool status -v' would be more useful with filenames ek110237 parents: 3025 diff changeset	62 #define DS_REF_MAX (1ULL << 62)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	63
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	64 #define DSL_DEADLIST_BLOCKSIZE SPA_MAXBLOCKSIZE
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	65
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	66 #define DSL_DATASET_IS_DESTROYED(ds) ((ds)->ds_owner == dsl_reaper)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	67
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	68
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	69 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	70 * Figure out how much of this delta should be propogated to the dsl_dir
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	71 * layer. If there's a refreservation, that space has already been
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	72 * partially accounted for in our ancestors.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	73 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	74 static int64_t
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	75 parent_delta(dsl_dataset_t *ds, int64_t delta)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	76 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	77 uint64_t old_bytes, new_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	78
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	79 if (ds->ds_reserved == 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	80 return (delta);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	81
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	82 old_bytes = MAX(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	83 new_bytes = MAX(ds->ds_phys->ds_unique_bytes + delta, ds->ds_reserved);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	84
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	85 ASSERT3U(ABS((int64_t)(new_bytes - old_bytes)), <=, ABS(delta));
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	86 return (new_bytes - old_bytes);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	87 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	88
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	89 void
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	90 dsl_dataset_block_born(dsl_dataset_t ds, const blkptr_t bp, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	91 {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	92 int used = bp_get_dsize_sync(tx->tx_pool->dp_spa, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	93 int compressed = BP_GET_PSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	94 int uncompressed = BP_GET_UCSIZE(bp);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	95 int64_t delta;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	96
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	97 dprintf_bp(bp, "ds=%p", ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	98
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	99 ASSERT(dmu_tx_is_syncing(tx));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	100 /* It could have been compressed away to nothing */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	101 if (BP_IS_HOLE(bp))
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	102 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	103 ASSERT(BP_GET_TYPE(bp) != DMU_OT_NONE);
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	104 ASSERT(DMU_OT_IS_VALID(BP_GET_TYPE(bp)));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	105 if (ds == NULL) {
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	106 dsl_pool_mos_diduse_space(tx->tx_pool,
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	107 used, compressed, uncompressed);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	108 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	109 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	110 dmu_buf_will_dirty(ds->ds_dbuf, tx);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	111
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	112 mutex_enter(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	113 mutex_enter(&ds->ds_lock);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	114 delta = parent_delta(ds, used);
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	115 ds->ds_phys->ds_referenced_bytes += used;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	116 ds->ds_phys->ds_compressed_bytes += compressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	117 ds->ds_phys->ds_uncompressed_bytes += uncompressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	118 ds->ds_phys->ds_unique_bytes += used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	119 mutex_exit(&ds->ds_lock);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	120 dsl_dir_diduse_space(ds->ds_dir, DD_USED_HEAD, delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	121 compressed, uncompressed, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	122 dsl_dir_transfer_space(ds->ds_dir, used - delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	123 DD_USED_REFRSRV, DD_USED_HEAD, tx);
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	124 mutex_exit(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	125 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	126
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	127 int
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	128 dsl_dataset_block_kill(dsl_dataset_t ds, const blkptr_t bp, dmu_tx_t *tx,
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	129 boolean_t async)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	130 {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	131 if (BP_IS_HOLE(bp))
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	132 return (0);
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	133
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	134 ASSERT(dmu_tx_is_syncing(tx));
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	135 ASSERT(bp->blk_birth <= tx->tx_txg);
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	136
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	137 int used = bp_get_dsize_sync(tx->tx_pool->dp_spa, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	138 int compressed = BP_GET_PSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	139 int uncompressed = BP_GET_UCSIZE(bp);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	140
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	141 ASSERT(used > 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	142 if (ds == NULL) {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	143 dsl_free(tx->tx_pool, tx->tx_txg, bp);
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	144 dsl_pool_mos_diduse_space(tx->tx_pool,
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	145 -used, -compressed, -uncompressed);
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	146 return (used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	147 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	148 ASSERT3P(tx->tx_pool, ==, ds->ds_dir->dd_pool);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	149
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	150 ASSERT(!dsl_dataset_is_snapshot(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	151 dmu_buf_will_dirty(ds->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	152
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	153 if (bp->blk_birth > ds->ds_phys->ds_prev_snap_txg) {
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	154 int64_t delta;
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	155
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	156 dprintf_bp(bp, "freeing ds=%llu", ds->ds_object);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	157 dsl_free(tx->tx_pool, tx->tx_txg, bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	158
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	159 mutex_enter(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	160 mutex_enter(&ds->ds_lock);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	161 ASSERT(ds->ds_phys->ds_unique_bytes >= used \|\|
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	162 !DS_UNIQUE_IS_ACCURATE(ds));
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	163 delta = parent_delta(ds, -used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	164 ds->ds_phys->ds_unique_bytes -= used;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	165 mutex_exit(&ds->ds_lock);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	166 dsl_dir_diduse_space(ds->ds_dir, DD_USED_HEAD,
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	167 delta, -compressed, -uncompressed, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	168 dsl_dir_transfer_space(ds->ds_dir, -used - delta,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	169 DD_USED_REFRSRV, DD_USED_HEAD, tx);
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	170 mutex_exit(&ds->ds_dir->dd_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	171 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	172 dprintf_bp(bp, "putting on dead list: %s", "");
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	173 if (async) {
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	174 /*
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	175 * We are here as part of zio's write done callback,
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	176 * which means we're a zio interrupt thread. We can't
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	177 * call dsl_deadlist_insert() now because it may block
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	178 * waiting for I/O. Instead, put bp on the deferred
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	179 * queue and let dsl_pool_sync() finish the job.
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	180 */
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	181 bplist_append(&ds->ds_pending_deadlist, bp);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	182 } else {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	183 dsl_deadlist_insert(&ds->ds_deadlist, bp, tx);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	184 }
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	185 ASSERT3U(ds->ds_prev->ds_object, ==,
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	186 ds->ds_phys->ds_prev_snap_obj);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	187 ASSERT(ds->ds_prev->ds_phys->ds_num_children > 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	188 /* if (bp->blk_birth > prev prev snap txg) prev unique += bs */
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	189 if (ds->ds_prev->ds_phys->ds_next_snap_obj ==
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	190 ds->ds_object && bp->blk_birth >
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	191 ds->ds_prev->ds_phys->ds_prev_snap_txg) {
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	192 dmu_buf_will_dirty(ds->ds_prev->ds_dbuf, tx);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	193 mutex_enter(&ds->ds_prev->ds_lock);
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	194 ds->ds_prev->ds_phys->ds_unique_bytes += used;
81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	195 mutex_exit(&ds->ds_prev->ds_lock);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	196 }
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	197 if (bp->blk_birth > ds->ds_dir->dd_origin_txg) {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	198 dsl_dir_transfer_space(ds->ds_dir, used,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	199 DD_USED_HEAD, DD_USED_SNAP, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	200 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	201 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	202 mutex_enter(&ds->ds_lock);
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	203 ASSERT3U(ds->ds_phys->ds_referenced_bytes, >=, used);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	204 ds->ds_phys->ds_referenced_bytes -= used;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	205 ASSERT3U(ds->ds_phys->ds_compressed_bytes, >=, compressed);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	206 ds->ds_phys->ds_compressed_bytes -= compressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	207 ASSERT3U(ds->ds_phys->ds_uncompressed_bytes, >=, uncompressed);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	208 ds->ds_phys->ds_uncompressed_bytes -= uncompressed;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	209 mutex_exit(&ds->ds_lock);
6992 20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	210
20c04e18c58c 6573681 deleting a very large file can be slow maybee parents: 6975 diff changeset	211 return (used);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	212 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	213
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	214 uint64_t
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	215 dsl_dataset_prev_snap_txg(dsl_dataset_t *ds)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	216 {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	217 uint64_t trysnap = 0;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	218
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	219 if (ds == NULL)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	220 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	221 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	222 * The snapshot creation could fail, but that would cause an
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	223 * incorrect FALSE return, which would only result in an
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	224 * overestimation of the amount of space that an operation would
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	225 * consume, which is OK.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	226 *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	227 * There's also a small window where we could miss a pending
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	228 * snapshot, because we could set the sync task in the quiescing
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	229 * phase. So this should only be used as a guess.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	230 */
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	231 if (ds->ds_trysnap_txg >
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	232 spa_last_synced_txg(ds->ds_dir->dd_pool->dp_spa))
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	233 trysnap = ds->ds_trysnap_txg;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	234 return (MAX(ds->ds_phys->ds_prev_snap_txg, trysnap));
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	235 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	236
9653 a70048a304d1 6664765 Unable to remove files when using fat-zap and quota exceeded on ZFS filesystem Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 9396 diff changeset	237 boolean_t
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	238 dsl_dataset_block_freeable(dsl_dataset_t ds, const blkptr_t bp,
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	239 uint64_t blk_birth)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	240 {
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	241 if (blk_birth <= dsl_dataset_prev_snap_txg(ds))
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	242 return (B_FALSE);
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	243
12587 16aef3d16470 6957090 ddt_zap_prefetch() induces deadlock, panic George Wilson <George.Wilson@Sun.COM> parents: 12527 diff changeset	244 ddt_prefetch(dsl_dataset_get_spa(ds), bp);
12450 c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	245
c77e20e4e046 6938089 dedup-induced latency causes FC initiator logouts/FC port resets George Wilson <George.Wilson@Sun.COM> parents: 12296 diff changeset	246 return (B_TRUE);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	247 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	248
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	249 /* ARGSUSED */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	250 static void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	251 dsl_dataset_evict(dmu_buf_t db, void dsv)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	252 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	253 dsl_dataset_t *ds = dsv;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	254
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	255 ASSERT(ds->ds_owner == NULL \|\| DSL_DATASET_IS_DESTROYED(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	256
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	257 unique_remove(ds->ds_fsid_guid);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	258
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	259 if (ds->ds_objset != NULL)
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	260 dmu_objset_evict(ds->ds_objset);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	261
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	262 if (ds->ds_prev) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	263 dsl_dataset_drop_ref(ds->ds_prev, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	264 ds->ds_prev = NULL;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	265 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	266
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	267 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	268 if (db != NULL) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	269 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	270 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	271 ASSERT(ds->ds_deadlist.dl_dbuf == NULL);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	272 ASSERT(!ds->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	273 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	274 if (ds->ds_dir)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	275 dsl_dir_close(ds->ds_dir, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	276
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	277 ASSERT(!list_link_active(&ds->ds_synced_link));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	278
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	279 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	280 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	281 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	282 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	283 cv_destroy(&ds->ds_exclusive_cv);
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	284
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	285 kmem_free(ds, sizeof (dsl_dataset_t));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	286 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	287
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	288 static int
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	289 dsl_dataset_get_snapname(dsl_dataset_t *ds)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	290 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	291 dsl_dataset_phys_t *headphys;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	292 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	293 dmu_buf_t *headdbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	294 dsl_pool_t *dp = ds->ds_dir->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	295 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	296
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	297 if (ds->ds_snapname[0])
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	298 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	299 if (ds->ds_phys->ds_next_snap_obj == 0)
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	300 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	301
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	302 err = dmu_bonus_hold(mos, ds->ds_dir->dd_phys->dd_head_dataset_obj,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	303 FTAG, &headdbuf);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	304 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	305 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	306 headphys = headdbuf->db_data;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	307 err = zap_value_search(dp->dp_meta_objset,
4577 ed36b0e652bc PSARC/2007/328 zfs upgrade ahrens parents: 4569 diff changeset	308 headphys->ds_snapnames_zapobj, ds->ds_object, 0, ds->ds_snapname);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	309 dmu_buf_rele(headdbuf, FTAG);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	310 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	311 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	312
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	313 static int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	314 dsl_dataset_snap_lookup(dsl_dataset_t ds, const char name, uint64_t *value)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	315 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	316 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	317 uint64_t snapobj = ds->ds_phys->ds_snapnames_zapobj;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	318 matchtype_t mt;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	319 int err;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	320
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	321 if (ds->ds_phys->ds_flags & DS_FLAG_CI_DATASET)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	322 mt = MT_FIRST;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	323 else
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	324 mt = MT_EXACT;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	325
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	326 err = zap_lookup_norm(mos, snapobj, name, 8, 1,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	327 value, mt, NULL, 0, NULL);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	328 if (err == ENOTSUP && mt == MT_FIRST)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	329 err = zap_lookup(mos, snapobj, name, 8, 1, value);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	330 return (err);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	331 }
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	332
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	333 static int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	334 dsl_dataset_snap_remove(dsl_dataset_t ds, char name, dmu_tx_t *tx)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	335 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	336 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	337 uint64_t snapobj = ds->ds_phys->ds_snapnames_zapobj;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	338 matchtype_t mt;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	339 int err;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	340
10373 bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	341 dsl_dir_snap_cmtime_update(ds->ds_dir);
bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	342
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	343 if (ds->ds_phys->ds_flags & DS_FLAG_CI_DATASET)
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	344 mt = MT_FIRST;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	345 else
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	346 mt = MT_EXACT;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	347
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	348 err = zap_remove_norm(mos, snapobj, name, mt, tx);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	349 if (err == ENOTSUP && mt == MT_FIRST)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	350 err = zap_remove(mos, snapobj, name, tx);
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	351 return (err);
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	352 }
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	353
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	354 static int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	355 dsl_dataset_get_ref(dsl_pool_t dp, uint64_t dsobj, void tag,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	356 dsl_dataset_t **dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	357 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	358 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	359 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	360 dsl_dataset_t *ds;
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	361 int err;
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	362 dmu_object_info_t doi;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	363
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	364 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock) \|\|
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	365 dsl_pool_sync_context(dp));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	366
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	367 err = dmu_bonus_hold(mos, dsobj, tag, &dbuf);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	368 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	369 return (err);
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	370
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	371 /* Make sure dsobj has the correct object type. */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	372 dmu_object_info_from_db(dbuf, &doi);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	373 if (doi.doi_type != DMU_OT_DSL_DATASET)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	374 return (EINVAL);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	375
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	376 ds = dmu_buf_get_user(dbuf);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	377 if (ds == NULL) {
13952 7a22d0770fc8 3522 zfs module should not allow uninitialized variables George Wilson <george.wilson@delphix.com> parents: 13941 diff changeset	378 dsl_dataset_t *winner = NULL;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	379
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	380 ds = kmem_zalloc(sizeof (dsl_dataset_t), KM_SLEEP);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	381 ds->ds_dbuf = dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	382 ds->ds_object = dsobj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	383 ds->ds_phys = dbuf->db_data;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	384
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	385 mutex_init(&ds->ds_lock, NULL, MUTEX_DEFAULT, NULL);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	386 mutex_init(&ds->ds_recvlock, NULL, MUTEX_DEFAULT, NULL);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	387 mutex_init(&ds->ds_opening_lock, NULL, MUTEX_DEFAULT, NULL);
13686 4bc0783f6064 2703 add mechanism to report ZFS send progress Bill Pijewski <wdp@joyent.com> parents: 13524 diff changeset	388 mutex_init(&ds->ds_sendstream_lock, NULL, MUTEX_DEFAULT, NULL);
4bc0783f6064 2703 add mechanism to report ZFS send progress Bill Pijewski <wdp@joyent.com> parents: 13524 diff changeset	389
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	390 rw_init(&ds->ds_rwlock, 0, 0, 0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	391 cv_init(&ds->ds_exclusive_cv, NULL, CV_DEFAULT, NULL);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	392
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	393 bplist_create(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	394 dsl_deadlist_open(&ds->ds_deadlist,
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	395 mos, ds->ds_phys->ds_deadlist_obj);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	396
13686 4bc0783f6064 2703 add mechanism to report ZFS send progress Bill Pijewski <wdp@joyent.com> parents: 13524 diff changeset	397 list_create(&ds->ds_sendstreams, sizeof (dmu_sendarg_t),
4bc0783f6064 2703 add mechanism to report ZFS send progress Bill Pijewski <wdp@joyent.com> parents: 13524 diff changeset	398 offsetof(dmu_sendarg_t, dsa_link));
4bc0783f6064 2703 add mechanism to report ZFS send progress Bill Pijewski <wdp@joyent.com> parents: 13524 diff changeset	399
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	400 if (err == 0) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	401 err = dsl_dir_open_obj(dp,
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	402 ds->ds_phys->ds_dir_obj, NULL, ds, &ds->ds_dir);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	403 }
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	404 if (err) {
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	405 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	406 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	407 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	408 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	409 cv_destroy(&ds->ds_exclusive_cv);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	410 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	411 dsl_deadlist_close(&ds->ds_deadlist);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	412 kmem_free(ds, sizeof (dsl_dataset_t));
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	413 dmu_buf_rele(dbuf, tag);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	414 return (err);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	415 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	416
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	417 if (!dsl_dataset_is_snapshot(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	418 ds->ds_snapname[0] = '\0';
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	419 if (ds->ds_phys->ds_prev_snap_obj) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	420 err = dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	421 ds->ds_phys->ds_prev_snap_obj,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	422 ds, &ds->ds_prev);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	423 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	424 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	425 if (zfs_flags & ZFS_DEBUG_SNAPNAMES)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	426 err = dsl_dataset_get_snapname(ds);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	427 if (err == 0 && ds->ds_phys->ds_userrefs_obj != 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	428 err = zap_count(
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	429 ds->ds_dir->dd_pool->dp_meta_objset,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	430 ds->ds_phys->ds_userrefs_obj,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	431 &ds->ds_userrefs);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	432 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	433 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	434
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	435 if (err == 0 && !dsl_dataset_is_snapshot(ds)) {
5569 d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	436 /*
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	437 * In sync context, we're called with either no lock
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	438 * or with the write lock. If we're not syncing,
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	439 * we're always called with the read lock held.
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	440 */
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	441 boolean_t need_lock =
5569 d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	442 !RW_WRITE_HELD(&dp->dp_config_rwlock) &&
d3caac36d311 6634062 dsl_dataset_open_obj misuses RW_LOCK_HELD ck153898 parents: 5518 diff changeset	443 dsl_pool_sync_context(dp);
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	444
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	445 if (need_lock)
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	446 rw_enter(&dp->dp_config_rwlock, RW_READER);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	447
7265 cc18862247da PSARC/2008/483 ZFS clone -o ahrens parents: 7237 diff changeset	448 err = dsl_prop_get_ds(ds,
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	449 "refreservation", sizeof (uint64_t), 1,
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	450 &ds->ds_reserved, NULL);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	451 if (err == 0) {
7265 cc18862247da PSARC/2008/483 ZFS clone -o ahrens parents: 7237 diff changeset	452 err = dsl_prop_get_ds(ds,
5475 e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	453 "refquota", sizeof (uint64_t), 1,
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	454 &ds->ds_quota, NULL);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	455 }
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	456
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	457 if (need_lock)
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	458 rw_exit(&dp->dp_config_rwlock);
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	459 } else {
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	460 ds->ds_reserved = ds->ds_quota = 0;
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	461 }
e140313199cc 6626338 assertion failed: 0 == dsl_prop_get_ds_locked(ds->ds_dir, "refreservation", sizeof (uint64_t), 1, &d ck153898 parents: 5446 diff changeset	462
13952 7a22d0770fc8 3522 zfs module should not allow uninitialized variables George Wilson <george.wilson@delphix.com> parents: 13941 diff changeset	463 if (err != 0 \|\| (winner = dmu_buf_set_user_ie(dbuf, ds,
7a22d0770fc8 3522 zfs module should not allow uninitialized variables George Wilson <george.wilson@delphix.com> parents: 13941 diff changeset	464 &ds->ds_phys, dsl_dataset_evict)) != NULL) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	465 bplist_destroy(&ds->ds_pending_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	466 dsl_deadlist_close(&ds->ds_deadlist);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	467 if (ds->ds_prev)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	468 dsl_dataset_drop_ref(ds->ds_prev, ds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	469 dsl_dir_close(ds->ds_dir, ds);
2856 6f4d5ee1906a 6463348 ZFS code could be more portable nd150628 parents: 2532 diff changeset	470 mutex_destroy(&ds->ds_lock);
10204 83c3a84aecef 6760420 zfs unmount -f causes recv to fail Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10002 diff changeset	471 mutex_destroy(&ds->ds_recvlock);
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	472 mutex_destroy(&ds->ds_opening_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	473 rw_destroy(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	474 cv_destroy(&ds->ds_exclusive_cv);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	475 kmem_free(ds, sizeof (dsl_dataset_t));
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	476 if (err) {
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	477 dmu_buf_rele(dbuf, tag);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	478 return (err);
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	479 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	480 ds = winner;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	481 } else {
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	482 ds->ds_fsid_guid =
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	483 unique_insert(ds->ds_phys->ds_fsid_guid);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	484 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	485 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	486 ASSERT3P(ds->ds_dbuf, ==, dbuf);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	487 ASSERT3P(ds->ds_phys, ==, dbuf->db_data);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	488 ASSERT(ds->ds_phys->ds_prev_snap_obj != 0 \|\|
7061 524fec1acf1c 6723703 zpool upgrade -> assertion failed: ds->ds_phys->ds_prev_snap_obj != 0 \|\| ... ahrens parents: 7046 diff changeset	489 spa_version(dp->dp_spa) < SPA_VERSION_ORIGIN \|\|
7077 a63bdc0b8352 6724675 assertion failed in dsl_dataset_get_ref(): ds->ds_phys->ds_prev_snap_obj != 0 ... ahrens parents: 7061 diff changeset	490 dp->dp_origin_snap == NULL \|\| ds == dp->dp_origin_snap);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	491 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	492 if (!dsl_pool_sync_context(dp) && DSL_DATASET_IS_DESTROYED(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	493 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	494 dmu_buf_rele(ds->ds_dbuf, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	495 return (ENOENT);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	496 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	497 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	498 *dsp = ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	499 return (0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	500 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	501
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	502 static int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	503 dsl_dataset_hold_ref(dsl_dataset_t ds, void tag)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	504 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	505 dsl_pool_t *dp = ds->ds_dir->dd_pool;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	506
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	507 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	508 * In syncing context we don't want the rwlock lock: there
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	509 * may be an existing writer waiting for sync phase to
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	510 * finish. We don't need to worry about such writers, since
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	511 * sync phase is single-threaded, so the writer can't be
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	512 * doing anything while we are active.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	513 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	514 if (dsl_pool_sync_context(dp)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	515 ASSERT(!DSL_DATASET_IS_DESTROYED(ds));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	516 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	517 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	518
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	519 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	520 * Normal users will hold the ds_rwlock as a READER until they
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	521 * are finished (i.e., call dsl_dataset_rele()). "Owners" will
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	522 * drop their READER lock after they set the ds_owner field.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	523 *
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	524 * If the dataset is being destroyed, the destroy thread will
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	525 * obtain a WRITER lock for exclusive access after it's done its
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	526 * open-context work and then change the ds_owner to
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	527 * dsl_reaper once destruction is assured. So threads
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	528 * may block here temporarily, until the "destructability" of
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	529 * the dataset is determined.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	530 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	531 ASSERT(!RW_WRITE_HELD(&dp->dp_config_rwlock));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	532 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	533 while (!rw_tryenter(&ds->ds_rwlock, RW_READER)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	534 rw_exit(&dp->dp_config_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	535 cv_wait(&ds->ds_exclusive_cv, &ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	536 if (DSL_DATASET_IS_DESTROYED(ds)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	537 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	538 dsl_dataset_drop_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	539 rw_enter(&dp->dp_config_rwlock, RW_READER);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	540 return (ENOENT);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	541 }
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	542 /*
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	543 * The dp_config_rwlock lives above the ds_lock. And
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	544 * we need to check DSL_DATASET_IS_DESTROYED() while
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	545 * holding the ds_lock, so we have to drop and reacquire
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	546 * the ds_lock here.
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	547 */
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	548 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	549 rw_enter(&dp->dp_config_rwlock, RW_READER);
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	550 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	551 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	552 mutex_exit(&ds->ds_lock);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	553 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	554 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	555
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	556 int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	557 dsl_dataset_hold_obj(dsl_pool_t dp, uint64_t dsobj, void tag,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	558 dsl_dataset_t **dsp)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	559 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	560 int err = dsl_dataset_get_ref(dp, dsobj, tag, dsp);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	561
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	562 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	563 return (err);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	564 return (dsl_dataset_hold_ref(*dsp, tag));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	565 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	566
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	567 int
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	568 dsl_dataset_own_obj(dsl_pool_t *dp, uint64_t dsobj, boolean_t inconsistentok,
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	569 void tag, dsl_dataset_t *dsp)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	570 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	571 int err = dsl_dataset_hold_obj(dp, dsobj, tag, dsp);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	572 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	573 return (err);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	574 if (!dsl_dataset_tryown(*dsp, inconsistentok, tag)) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	575 dsl_dataset_rele(*dsp, tag);
8779 f164e0e90508 6784924 panic while ludelete (zfs destroy) Mark J Musante <Mark.Musante@Sun.COM> parents: 8746 diff changeset	576 *dsp = NULL;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	577 return (EBUSY);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	578 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	579 return (0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	580 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	581
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	582 int
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	583 dsl_dataset_hold(const char name, void tag, dsl_dataset_t **dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	584 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	585 dsl_dir_t *dd;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	586 dsl_pool_t *dp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	587 const char *snapname;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	588 uint64_t obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	589 int err = 0;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	590
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	591 err = dsl_dir_open_spa(NULL, name, FTAG, &dd, &snapname);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	592 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	593 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	594
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	595 dp = dd->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	596 obj = dd->dd_phys->dd_head_dataset_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	597 rw_enter(&dp->dp_config_rwlock, RW_READER);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	598 if (obj)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	599 err = dsl_dataset_get_ref(dp, obj, tag, dsp);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	600 else
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	601 err = ENOENT;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	602 if (err)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	603 goto out;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	604
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	605 err = dsl_dataset_hold_ref(*dsp, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	606
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	607 /* we may be looking for a snapshot */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	608 if (err == 0 && snapname != NULL) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	609 dsl_dataset_t *ds = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	610
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	611 if (*snapname++ != '@') {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	612 dsl_dataset_rele(*dsp, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	613 err = ENOENT;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	614 goto out;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	615 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	616
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	617 dprintf("looking for snapshot '%s'\n", snapname);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	618 err = dsl_dataset_snap_lookup(*dsp, snapname, &obj);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	619 if (err == 0)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	620 err = dsl_dataset_get_ref(dp, obj, tag, &ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	621 dsl_dataset_rele(*dsp, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	622
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	623 ASSERT3U((err == 0), ==, (ds != NULL));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	624
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	625 if (ds) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	626 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	627 if (ds->ds_snapname[0] == 0)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	628 (void) strlcpy(ds->ds_snapname, snapname,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	629 sizeof (ds->ds_snapname));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	630 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	631 err = dsl_dataset_hold_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	632 *dsp = err ? NULL : ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	633 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	634 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	635 out:
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	636 rw_exit(&dp->dp_config_rwlock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	637 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	638 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	639 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	640
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	641 int
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	642 dsl_dataset_own(const char *name, boolean_t inconsistentok,
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	643 void tag, dsl_dataset_t *dsp)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	644 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	645 int err = dsl_dataset_hold(name, tag, dsp);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	646 if (err)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	647 return (err);
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	648 if (!dsl_dataset_tryown(*dsp, inconsistentok, tag)) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	649 dsl_dataset_rele(*dsp, tag);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	650 return (EBUSY);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	651 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	652 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	653 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	654
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	655 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	656 dsl_dataset_name(dsl_dataset_t ds, char name)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	657 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	658 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	659 (void) strcpy(name, "mos");
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	660 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	661 dsl_dir_name(ds->ds_dir, name);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	662 VERIFY(0 == dsl_dataset_get_snapname(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	663 if (ds->ds_snapname[0]) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	664 (void) strcat(name, "@");
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	665 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	666 * We use a "recursive" mutex so that we
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	667 * can call dprintf_ds() with ds_lock held.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	668 */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	669 if (!MUTEX_HELD(&ds->ds_lock)) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	670 mutex_enter(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	671 (void) strcat(name, ds->ds_snapname);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	672 mutex_exit(&ds->ds_lock);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	673 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	674 (void) strcat(name, ds->ds_snapname);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	675 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	676 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	677 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	678 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	679
3978 2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	680 static int
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	681 dsl_dataset_namelen(dsl_dataset_t *ds)
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	682 {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	683 int result;
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	684
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	685 if (ds == NULL) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	686 result = 3; /* "mos" */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	687 } else {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	688 result = dsl_dir_namelen(ds->ds_dir);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	689 VERIFY(0 == dsl_dataset_get_snapname(ds));
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	690 if (ds->ds_snapname[0]) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	691 ++result; /* adding one for the @-sign */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	692 if (!MUTEX_HELD(&ds->ds_lock)) {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	693 mutex_enter(&ds->ds_lock);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	694 result += strlen(ds->ds_snapname);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	695 mutex_exit(&ds->ds_lock);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	696 } else {
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	697 result += strlen(ds->ds_snapname);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	698 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	699 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	700 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	701
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	702 return (result);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	703 }
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	704
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	705 void
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	706 dsl_dataset_drop_ref(dsl_dataset_t ds, void tag)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	707 {
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	708 dmu_buf_rele(ds->ds_dbuf, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	709 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	710
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	711 void
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	712 dsl_dataset_rele(dsl_dataset_t ds, void tag)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	713 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	714 if (!dsl_pool_sync_context(ds->ds_dir->dd_pool)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	715 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	716 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	717 dsl_dataset_drop_ref(ds, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	718 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	719
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	720 void
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	721 dsl_dataset_disown(dsl_dataset_t ds, void tag)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	722 {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	723 ASSERT((ds->ds_owner == tag && ds->ds_dbuf) \|\|
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	724 (DSL_DATASET_IS_DESTROYED(ds) && ds->ds_dbuf == NULL));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	725
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	726 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	727 ds->ds_owner = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	728 if (RW_WRITE_HELD(&ds->ds_rwlock)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	729 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	730 cv_broadcast(&ds->ds_exclusive_cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	731 }
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	732 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	733 if (ds->ds_dbuf)
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	734 dsl_dataset_drop_ref(ds, tag);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	735 else
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	736 dsl_dataset_evict(NULL, ds);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	737 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	738
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	739 boolean_t
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	740 dsl_dataset_tryown(dsl_dataset_t ds, boolean_t inconsistentok, void tag)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	741 {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	742 boolean_t gotit = FALSE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	743
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	744 mutex_enter(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	745 if (ds->ds_owner == NULL &&
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	746 (!DS_IS_INCONSISTENT(ds) \|\| inconsistentok)) {
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	747 ds->ds_owner = tag;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	748 if (!dsl_pool_sync_context(ds->ds_dir->dd_pool))
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	749 rw_exit(&ds->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	750 gotit = TRUE;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	751 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	752 mutex_exit(&ds->ds_lock);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	753 return (gotit);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	754 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	755
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	756 void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	757 dsl_dataset_make_exclusive(dsl_dataset_t ds, void owner)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	758 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	759 ASSERT3P(owner, ==, ds->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	760 if (!RW_WRITE_HELD(&ds->ds_rwlock))
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	761 rw_enter(&ds->ds_rwlock, RW_WRITER);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	762 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	763
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	764 uint64_t
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	765 dsl_dataset_create_sync_dd(dsl_dir_t dd, dsl_dataset_t origin,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	766 uint64_t flags, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	767 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	768 dsl_pool_t *dp = dd->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	769 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	770 dsl_dataset_phys_t *dsphys;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	771 uint64_t dsobj;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	772 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	773
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	774 if (origin == NULL)
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	775 origin = dp->dp_origin_snap;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	776
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	777 ASSERT(origin == NULL \|\| origin->ds_dir->dd_pool == dp);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	778 ASSERT(origin == NULL \|\| origin->ds_phys->ds_num_children > 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	779 ASSERT(dmu_tx_is_syncing(tx));
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	780 ASSERT(dd->dd_phys->dd_head_dataset_obj == 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	781
928 36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	782 dsobj = dmu_object_alloc(mos, DMU_OT_DSL_DATASET, 0,
36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	783 DMU_OT_DSL_DATASET, sizeof (dsl_dataset_phys_t), tx);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	784 VERIFY(0 == dmu_bonus_hold(mos, dsobj, FTAG, &dbuf));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	785 dmu_buf_will_dirty(dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	786 dsphys = dbuf->db_data;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	787 bzero(dsphys, sizeof (dsl_dataset_phys_t));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	788 dsphys->ds_dir_obj = dd->dd_object;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	789 dsphys->ds_flags = flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	790 dsphys->ds_fsid_guid = unique_create();
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	791 (void) random_get_pseudo_bytes((void*)&dsphys->ds_guid,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	792 sizeof (dsphys->ds_guid));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	793 dsphys->ds_snapnames_zapobj =
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	794 zap_create_norm(mos, U8_TEXTPREP_TOUPPER, DMU_OT_DSL_DS_SNAP_MAP,
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	795 DMU_OT_NONE, 0, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	796 dsphys->ds_creation_time = gethrestime_sec();
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	797 dsphys->ds_creation_txg = tx->tx_txg == TXG_INITIAL ? 1 : tx->tx_txg;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	798
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	799 if (origin == NULL) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	800 dsphys->ds_deadlist_obj = dsl_deadlist_alloc(mos, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	801 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	802 dsl_dataset_t *ohds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	803
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	804 dsphys->ds_prev_snap_obj = origin->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	805 dsphys->ds_prev_snap_txg =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	806 origin->ds_phys->ds_creation_txg;
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	807 dsphys->ds_referenced_bytes =
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	808 origin->ds_phys->ds_referenced_bytes;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	809 dsphys->ds_compressed_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	810 origin->ds_phys->ds_compressed_bytes;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	811 dsphys->ds_uncompressed_bytes =
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	812 origin->ds_phys->ds_uncompressed_bytes;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	813 dsphys->ds_bp = origin->ds_phys->ds_bp;
6502 66aef5f20377 6694731 drc->drc_real_ds->ds_phys->ds_flags & (1ULL<<0), file: ../../common/fs/zfs/dmu_send.c, line: 1069 timh parents: 6492 diff changeset	814 dsphys->ds_flags \|= origin->ds_phys->ds_flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	815
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	816 dmu_buf_will_dirty(origin->ds_dbuf, tx);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	817 origin->ds_phys->ds_num_children++;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	818
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	819 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	820 origin->ds_dir->dd_phys->dd_head_dataset_obj, FTAG, &ohds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	821 dsphys->ds_deadlist_obj = dsl_deadlist_clone(&ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	822 dsphys->ds_prev_snap_txg, dsphys->ds_prev_snap_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	823 dsl_dataset_rele(ohds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	824
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	825 if (spa_version(dp->dp_spa) >= SPA_VERSION_NEXT_CLONES) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	826 if (origin->ds_phys->ds_next_clones_obj == 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	827 origin->ds_phys->ds_next_clones_obj =
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	828 zap_create(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	829 DMU_OT_NEXT_CLONES, DMU_OT_NONE, 0, tx);
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	830 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	831 VERIFY(0 == zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	832 origin->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	833 dsobj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	834 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	835
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	836 dmu_buf_will_dirty(dd->dd_dbuf, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	837 dd->dd_phys->dd_origin_obj = origin->ds_object;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	838 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	839 if (origin->ds_dir->dd_phys->dd_clones == 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	840 dmu_buf_will_dirty(origin->ds_dir->dd_dbuf, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	841 origin->ds_dir->dd_phys->dd_clones =
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	842 zap_create(mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	843 DMU_OT_DSL_CLONES, DMU_OT_NONE, 0, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	844 }
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	845 VERIFY3U(0, ==, zap_add_int(mos,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	846 origin->ds_dir->dd_phys->dd_clones, dsobj, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	847 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	848 }
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	849
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	850 if (spa_version(dp->dp_spa) >= SPA_VERSION_UNIQUE_ACCURATE)
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	851 dsphys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	852
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	853 dmu_buf_rele(dbuf, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	854
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	855 dmu_buf_will_dirty(dd->dd_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	856 dd->dd_phys->dd_head_dataset_obj = dsobj;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	857
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	858 return (dsobj);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	859 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	860
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	861 uint64_t
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	862 dsl_dataset_create_sync(dsl_dir_t pdd, const char lastname,
903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	863 dsl_dataset_t origin, uint64_t flags, cred_t cr, dmu_tx_t *tx)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	864 {
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	865 dsl_pool_t *dp = pdd->dd_pool;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	866 uint64_t dsobj, ddobj;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	867 dsl_dir_t *dd;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	868
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	869 ASSERT(lastname[0] != '@');
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	870
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	871 ddobj = dsl_dir_create_sync(dp, pdd, lastname, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	872 VERIFY(0 == dsl_dir_open_obj(dp, ddobj, lastname, FTAG, &dd));
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	873
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	874 dsobj = dsl_dataset_create_sync_dd(dd, origin, flags, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	875
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	876 dsl_deleg_set_create_perms(dd, tx, cr);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	877
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	878 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	879
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	880 /*
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	881 * If we are creating a clone, make sure we zero out any stale
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	882 * data from the origin snapshots zil header.
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	883 */
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	884 if (origin != NULL) {
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	885 dsl_dataset_t *ds;
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	886 objset_t *os;
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	887
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	888 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds));
9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	889 VERIFY3U(0, ==, dmu_objset_from_ds(ds, &os));
12982 5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	890 bzero(&os->os_zil_header, sizeof (os->os_zil_header));
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	891 dsl_dataset_dirty(ds, tx);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	892 dsl_dataset_rele(ds, FTAG);
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	893 }
5d7f2db1e620 6972862 rollback can leak log blocks Mark Maybee <Mark.Maybee@Sun.COM> parents: 12840 diff changeset	894
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	895 return (dsobj);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	896 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	897
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	898 /*
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	899 * The snapshots must all be in the same pool.
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	900 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	901 int
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	902 dmu_snapshots_destroy_nvl(nvlist_t *snaps, boolean_t defer,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	903 nvlist_t *errlist)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	904 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	905 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	906 dsl_sync_task_t *dst;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	907 spa_t *spa;
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	908 nvpair_t *pair;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	909 dsl_sync_task_group_t *dstg;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	910
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	911 pair = nvlist_next_nvpair(snaps, NULL);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	912 if (pair == NULL)
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	913 return (0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	914
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	915 err = spa_open(nvpair_name(pair), &spa, FTAG);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	916 if (err)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	917 return (err);
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	918 dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	919
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	920 for (pair = nvlist_next_nvpair(snaps, NULL); pair != NULL;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	921 pair = nvlist_next_nvpair(snaps, pair)) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	922 dsl_dataset_t *ds;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	923
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	924 err = dsl_dataset_own(nvpair_name(pair), B_TRUE, dstg, &ds);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	925 if (err == 0) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	926 struct dsl_ds_destroyarg *dsda;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	927
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	928 dsl_dataset_make_exclusive(ds, dstg);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	929 dsda = kmem_zalloc(sizeof (struct dsl_ds_destroyarg),
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	930 KM_SLEEP);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	931 dsda->ds = ds;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	932 dsda->defer = defer;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	933 dsl_sync_task_create(dstg, dsl_dataset_destroy_check,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	934 dsl_dataset_destroy_sync, dsda, dstg, 0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	935 } else if (err == ENOENT) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	936 err = 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	937 } else {
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	938 fnvlist_add_int32(errlist, nvpair_name(pair), err);
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	939 break;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	940 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	941 }
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	942
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	943 if (err == 0)
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	944 err = dsl_sync_task_group_wait(dstg);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	945
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	946 for (dst = list_head(&dstg->dstg_tasks); dst;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	947 dst = list_next(&dstg->dstg_tasks, dst)) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	948 struct dsl_ds_destroyarg *dsda = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	949 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	950
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	951 /*
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	952 * Return the snapshots that triggered the error.
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	953 */
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	954 if (dst->dst_err != 0) {
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	955 char name[ZFS_MAXNAMELEN];
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	956 dsl_dataset_name(ds, name);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	957 fnvlist_add_int32(errlist, name, dst->dst_err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	958 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	959 ASSERT3P(dsda->rm_origin, ==, NULL);
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	960 dsl_dataset_disown(ds, dstg);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	961 kmem_free(dsda, sizeof (struct dsl_ds_destroyarg));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	962 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	963
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	964 dsl_sync_task_group_destroy(dstg);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	965 spa_close(spa, FTAG);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	966 return (err);
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	967
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	968 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	969
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	970 static boolean_t
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	971 dsl_dataset_might_destroy_origin(dsl_dataset_t *ds)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	972 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	973 boolean_t might_destroy = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	974
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	975 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	976 if (ds->ds_phys->ds_num_children == 2 && ds->ds_userrefs == 0 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	977 DS_IS_DEFER_DESTROY(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	978 might_destroy = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	979 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	980
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	981 return (might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	982 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	983
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	984 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	985 * If we're removing a clone, and these three conditions are true:
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	986 * 1) the clone's origin has no other children
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	987 * 2) the clone's origin has no user references
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	988 * 3) the clone's origin has been marked for deferred destruction
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	989 * Then, prepare to remove the origin as part of this sync task group.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	990 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	991 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	992 dsl_dataset_origin_rm_prep(struct dsl_ds_destroyarg dsda, void tag)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	993 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	994 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	995 dsl_dataset_t *origin = ds->ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	996
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	997 if (dsl_dataset_might_destroy_origin(origin)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	998 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	999 int namelen;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1000 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1001
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1002 namelen = dsl_dataset_namelen(origin) + 1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1003 name = kmem_alloc(namelen, KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1004 dsl_dataset_name(origin, name);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1005 #ifdef _KERNEL
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1006 error = zfs_unmount_snap(name, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1007 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1008 kmem_free(name, namelen);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1009 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1010 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1011 #endif
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1012 error = dsl_dataset_own(name, B_TRUE, tag, &origin);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1013 kmem_free(name, namelen);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1014 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1015 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1016 dsda->rm_origin = origin;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1017 dsl_dataset_make_exclusive(origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1018 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1019
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1020 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1021 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1022
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1023 /*
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1024 * ds must be opened as OWNER. On return (whether successful or not),
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1025 * ds will be closed and caller can no longer dereference it.
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1026 */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1027 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1028 dsl_dataset_destroy(dsl_dataset_t ds, void tag, boolean_t defer)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1029 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1030 int err;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1031 dsl_sync_task_group_t *dstg;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1032 objset_t *os;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1033 dsl_dir_t *dd;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1034 uint64_t obj;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1035 struct dsl_ds_destroyarg dsda = { 0 };
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1036
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1037 dsda.ds = ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1038
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1039 if (dsl_dataset_is_snapshot(ds)) {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1040 /* Destroying a snapshot is simpler */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1041 dsl_dataset_make_exclusive(ds, tag);
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	1042
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1043 dsda.defer = defer;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1044 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1045 dsl_dataset_destroy_check, dsl_dataset_destroy_sync,
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1046 &dsda, tag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1047 ASSERT3P(dsda.rm_origin, ==, NULL);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1048 goto out;
10385 21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1049 } else if (defer) {
21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1050 err = EINVAL;
21cb6e67d108 6873727 zfs destroy -d <fs> should fail more gracefully when children are present Chris Kirby <chris.kirby@sun.com> parents: 10373 diff changeset	1051 goto out;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1052 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1053
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1054 dd = ds->ds_dir;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1055
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1056 if (!spa_feature_is_enabled(dsl_dataset_get_spa(ds),
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1057 &spa_feature_table[SPA_FEATURE_ASYNC_DESTROY])) {
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1058 /*
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1059 * Check for errors and mark this ds as inconsistent, in
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1060 * case we crash while freeing the objects.
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1061 */
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1062 err = dsl_sync_task_do(dd->dd_pool,
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1063 dsl_dataset_destroy_begin_check,
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1064 dsl_dataset_destroy_begin_sync, ds, NULL, 0);
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1065 if (err)
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1066 goto out;
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1067
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1068 err = dmu_objset_from_ds(ds, &os);
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1069 if (err)
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1070 goto out;
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1071
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1072 /*
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1073 * Remove all objects while in the open context so that
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1074 * there is less work to do in the syncing context.
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1075 */
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1076 for (obj = 0; err == 0; err = dmu_object_next(os, &obj, FALSE,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1077 ds->ds_phys->ds_prev_snap_txg)) {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1078 /*
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1079 * Ignore errors, if there is not enough disk space
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1080 * we will deal with it in dsl_dataset_destroy_sync().
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1081 */
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1082 (void) dmu_free_object(os, obj);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1083 }
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1084 if (err != ESRCH)
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1085 goto out;
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1086
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1087 /*
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1088 * Sync out all in-flight IO.
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1089 */
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1090 txg_wait_synced(dd->dd_pool, 0);
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1091
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1092 /*
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1093 * If we managed to free all the objects in open
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1094 * context, the user space accounting should be zero.
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1095 */
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1096 if (ds->ds_phys->ds_bp.blk_fill == 0 &&
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1097 dmu_objset_userused_enabled(os)) {
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1098 uint64_t count;
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1099
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1100 ASSERT(zap_count(os, DMU_USERUSED_OBJECT,
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1101 &count) != 0 \|\| count == 0);
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1102 ASSERT(zap_count(os, DMU_GROUPUSED_OBJECT,
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1103 &count) != 0 \|\| count == 0);
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1104 }
9396 f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1105 }
f41cf682d0d3 PSARC/2009/204 ZFS user/group quotas & space accounting Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 9390 diff changeset	1106
6975 c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1107 rw_enter(&dd->dd_pool->dp_config_rwlock, RW_READER);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1108 err = dsl_dir_open_obj(dd->dd_pool, dd->dd_object, NULL, FTAG, &dd);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1109 rw_exit(&dd->dd_pool->dp_config_rwlock);
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1110
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1111 if (err)
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1112 goto out;
c511f317869e 6717522 panic in dmu_objset_stats() due to freed objset_impl_t maybee parents: 6689 diff changeset	1113
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1114 /*
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1115 * Blow away the dsl_dir + head dataset.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1116 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1117 dsl_dataset_make_exclusive(ds, tag);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1118 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1119 * If we're removing a clone, we might also need to remove its
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1120 * origin.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1121 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1122 do {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1123 dsda.need_prep = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1124 if (dsl_dir_is_clone(dd)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1125 err = dsl_dataset_origin_rm_prep(&dsda, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1126 if (err) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1127 dsl_dir_close(dd, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1128 goto out;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1129 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1130 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1131
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1132 dstg = dsl_sync_task_group_create(ds->ds_dir->dd_pool);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1133 dsl_sync_task_create(dstg, dsl_dataset_destroy_check,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1134 dsl_dataset_destroy_sync, &dsda, tag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1135 dsl_sync_task_create(dstg, dsl_dir_destroy_check,
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	1136 dsl_dir_destroy_sync, dd, FTAG, 0);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1137 err = dsl_sync_task_group_wait(dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1138 dsl_sync_task_group_destroy(dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1139
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1140 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1141 * We could be racing against 'zfs release' or 'zfs destroy -d'
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1142 * on the origin snap, in which case we can get EBUSY if we
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1143 * needed to destroy the origin snap but were not ready to
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1144 * do so.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1145 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1146 if (dsda.need_prep) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1147 ASSERT(err == EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1148 ASSERT(dsl_dir_is_clone(dd));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1149 ASSERT(dsda.rm_origin == NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1150 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1151 } while (dsda.need_prep);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1152
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1153 if (dsda.rm_origin != NULL)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1154 dsl_dataset_disown(dsda.rm_origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1155
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1156 /* if it is successful, dsl_dir_destroy_sync will close the dd */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1157 if (err)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1158 dsl_dir_close(dd, FTAG);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1159 out:
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1160 dsl_dataset_disown(ds, tag);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1161 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1162 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1163
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1164 blkptr_t *
e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1165 dsl_dataset_get_blkptr(dsl_dataset_t *ds)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1166 {
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	1167 return (&ds->ds_phys->ds_bp);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1168 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1169
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1170 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1171 dsl_dataset_set_blkptr(dsl_dataset_t ds, blkptr_t bp, dmu_tx_t *tx)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1172 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1173 ASSERT(dmu_tx_is_syncing(tx));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1174 /* If it's the meta-objset, set dp_meta_rootbp */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1175 if (ds == NULL) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1176 tx->tx_pool->dp_meta_rootbp = *bp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1177 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1178 dmu_buf_will_dirty(ds->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1179 ds->ds_phys->ds_bp = *bp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1180 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1181 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1182
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1183 spa_t *
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1184 dsl_dataset_get_spa(dsl_dataset_t *ds)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1185 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1186 return (ds->ds_dir->dd_pool->dp_spa);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1187 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1188
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1189 void
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1190 dsl_dataset_dirty(dsl_dataset_t ds, dmu_tx_t tx)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1191 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1192 dsl_pool_t *dp;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1193
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1194 if (ds == NULL) /* this is the meta-objset */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1195 return;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1196
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	1197 ASSERT(ds->ds_objset != NULL);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1198
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1199 if (ds->ds_phys->ds_next_snap_obj != 0)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	1200 panic("dirtying snapshot!");
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1201
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1202 dp = ds->ds_dir->dd_pool;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1203
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1204 if (txg_list_add(&dp->dp_dirty_datasets, ds, tx->tx_txg) == 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1205 /* up the hold count until we can be written out */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1206 dmu_buf_add_ref(ds->ds_dbuf, ds);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1207 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1208 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1209
13780 6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1210 boolean_t
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1211 dsl_dataset_is_dirty(dsl_dataset_t *ds)
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1212 {
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1213 for (int t = 0; t < TXG_SIZE; t++) {
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1214 if (txg_list_member(&ds->ds_dir->dd_pool->dp_dirty_datasets,
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1215 ds, t))
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1216 return (B_TRUE);
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1217 }
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1218 return (B_FALSE);
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1219 }
6da32a929222 3100 zvol rename fails with EBUSY when dirty Matthew Ahrens <mahrens@delphix.com> parents: 13776 diff changeset	1220
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1221 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1222 * The unique space in the head dataset can be calculated by subtracting
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1223 * the space used in the most recent snapshot, that is still being used
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1224 * in this file system, from the space currently in use. To figure out
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1225 * the space in the most recent snapshot still in use, we need to take
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1226 * the total space used in the snapshot and subtract out the space that
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1227 * has been freed up since the snapshot was taken.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1228 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1229 static void
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1230 dsl_dataset_recalc_head_uniq(dsl_dataset_t *ds)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1231 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1232 uint64_t mrs_used;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1233 uint64_t dlused, dlcomp, dluncomp;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1234
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1235 ASSERT(!dsl_dataset_is_snapshot(ds));
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1236
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1237 if (ds->ds_phys->ds_prev_snap_obj != 0)
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1238 mrs_used = ds->ds_prev->ds_phys->ds_referenced_bytes;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1239 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1240 mrs_used = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1241
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1242 dsl_deadlist_space(&ds->ds_deadlist, &dlused, &dlcomp, &dluncomp);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1243
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1244 ASSERT3U(dlused, <=, mrs_used);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1245 ds->ds_phys->ds_unique_bytes =
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1246 ds->ds_phys->ds_referenced_bytes - (mrs_used - dlused);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1247
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1248 if (spa_version(ds->ds_dir->dd_pool->dp_spa) >=
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1249 SPA_VERSION_UNIQUE_ACCURATE)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1250 ds->ds_phys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1251 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1252
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1253 struct killarg {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1254 dsl_dataset_t *ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1255 dmu_tx_t *tx;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1256 };
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1257
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1258 /* ARGSUSED */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1259 static int
13941 d48547176ab4 3498 panic in arc_read(): !refcount_is_zero(&pbuf->b_hdr->b_refcnt) George Wilson <george.wilson@delphix.com> parents: 13805 diff changeset	1260 kill_blkptr(spa_t spa, zilog_t zilog, const blkptr_t *bp,
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1261 const zbookmark_t zb, const dnode_phys_t dnp, void *arg)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1262 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1263 struct killarg *ka = arg;
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1264 dmu_tx_t *tx = ka->tx;
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1265
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1266 if (bp == NULL)
001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	1267 return (0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1268
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1269 if (zb->zb_level == ZB_ZIL_LEVEL) {
e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1270 ASSERT(zilog != NULL);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1271 /*
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1272 * It's a block in the intent log. It has no
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1273 * accounting, so just free it.
e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1274 */
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1275 dsl_free(ka->tx->tx_pool, ka->tx->tx_txg, bp);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1276 } else {
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1277 ASSERT(zilog == NULL);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1278 ASSERT3U(bp->blk_birth, >, ka->ds->ds_phys->ds_prev_snap_txg);
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	1279 (void) dsl_dataset_block_kill(ka->ds, bp, tx, B_FALSE);
8746 e1d96ca6808c 6796377 panic on rollback in space_map_add() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 8525 diff changeset	1280 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1281
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1282 return (0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1283 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1284
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1285 /* ARGSUSED */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1286 static int
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1287 dsl_dataset_destroy_begin_check(void arg1, void arg2, dmu_tx_t *tx)
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1288 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1289 dsl_dataset_t *ds = arg1;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1290 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1291 uint64_t count;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1292 int err;
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1293
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1294 /*
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1295 * Can't delete a head dataset if there are snapshots of it.
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1296 * (Except if the only snapshots are from the branch we cloned
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1297 * from.)
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1298 */
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1299 if (ds->ds_prev != NULL &&
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1300 ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object)
10816 731471f04028 6482588 zfs destroy -r aborts and dumps core when destroying a file system (while snapshotting is going on) vitezslav batrla - Sun Microsystems - Prague Czech Republic <Vitezslav.Batrla@Sun.COM> parents: 10801 diff changeset	1301 return (EBUSY);
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1302
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1303 /*
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1304 * This is really a dsl_dir thing, but check it here so that
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1305 * we'll be less likely to leave this dataset inconsistent &
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1306 * nearly destroyed.
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1307 */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1308 err = zap_count(mos, ds->ds_dir->dd_phys->dd_child_dir_zapobj, &count);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1309 if (err)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1310 return (err);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1311 if (count != 0)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1312 return (EEXIST);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1313
1731 1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1314 return (0);
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1315 }
1efa8b3d1296 6402598 'zfs destroy <fs>' can take a long time, stopping up the txg train bonwick parents: 1544 diff changeset	1316
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1317 /* ARGSUSED */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1318 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1319 dsl_dataset_destroy_begin_sync(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1320 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1321 dsl_dataset_t *ds = arg1;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1322
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1323 /* Mark it as inconsistent on-disk, in case we crash */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1324 dmu_buf_will_dirty(ds->ds_dbuf, tx);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1325 ds->ds_phys->ds_flags \|= DS_FLAG_INCONSISTENT;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1326
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	1327 spa_history_log_internal_ds(ds, "destroy begin", tx, "");
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1328 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1329
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1330 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1331 dsl_dataset_origin_check(struct dsl_ds_destroyarg dsda, void tag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1332 dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1333 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1334 dsl_dataset_t *ds = dsda->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1335 dsl_dataset_t *ds_prev = ds->ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1336
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1337 if (dsl_dataset_might_destroy_origin(ds_prev)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1338 struct dsl_ds_destroyarg ndsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1339
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1340 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1341 * If we're not prepared to remove the origin, don't remove
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1342 * the clone either.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1343 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1344 if (dsda->rm_origin == NULL) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1345 dsda->need_prep = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1346 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1347 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1348
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1349 ndsda.ds = ds_prev;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1350 ndsda.is_origin_rm = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1351 return (dsl_dataset_destroy_check(&ndsda, tag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1352 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1353
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1354 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1355 * If we're not going to remove the origin after all,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1356 * undo the open context setup.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1357 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1358 if (dsda->rm_origin != NULL) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1359 dsl_dataset_disown(dsda->rm_origin, tag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1360 dsda->rm_origin = NULL;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1361 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1362
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1363 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1364 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1365
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1366 /*
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1367 * If you add new checks here, you may need to add
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1368 * additional checks to the "temporary" case in
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1369 * snapshot_check() in dmu_objset.c.
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1370 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1371 /* ARGSUSED */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1372 int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1373 dsl_dataset_destroy_check(void arg1, void arg2, dmu_tx_t *tx)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1374 {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1375 struct dsl_ds_destroyarg *dsda = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1376 dsl_dataset_t *ds = dsda->ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1377
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1378 /* we have an owner hold, so noone else can destroy us */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1379 ASSERT(!DSL_DATASET_IS_DESTROYED(ds));
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1380
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1381 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1382 * Only allow deferred destroy on pools that support it.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1383 * NOTE: deferred destroy is only supported on snapshots.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1384 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1385 if (dsda->defer) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1386 if (spa_version(ds->ds_dir->dd_pool->dp_spa) <
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1387 SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1388 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1389 ASSERT(dsl_dataset_is_snapshot(ds));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1390 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1391 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1392
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1393 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1394 * Can't delete a head dataset if there are snapshots of it.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1395 * (Except if the only snapshots are from the branch we cloned
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1396 * from.)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1397 */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1398 if (ds->ds_prev != NULL &&
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1399 ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object)
10816 731471f04028 6482588 zfs destroy -r aborts and dumps core when destroying a file system (while snapshotting is going on) vitezslav batrla - Sun Microsystems - Prague Czech Republic <Vitezslav.Batrla@Sun.COM> parents: 10801 diff changeset	1400 return (EBUSY);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1401
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1402 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1403 * If we made changes this txg, traverse_dsl_dataset won't find
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1404 * them. Try again.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1405 */
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1406 if (ds->ds_phys->ds_bp.blk_birth >= tx->tx_txg)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1407 return (EAGAIN);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1408
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1409 if (dsl_dataset_is_snapshot(ds)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1410 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1411 * If this snapshot has an elevated user reference count,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1412 * we can't destroy it yet.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1413 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1414 if (ds->ds_userrefs > 0 && !dsda->releasing)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1415 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1416
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1417 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1418 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1419 * Can't delete a branch point. However, if we're destroying
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1420 * a clone and removing its origin due to it having a user
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1421 * hold count of 0 and having been marked for deferred destroy,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1422 * it's OK for the origin to have a single clone.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1423 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1424 if (ds->ds_phys->ds_num_children >
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1425 (dsda->is_origin_rm ? 2 : 1)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1426 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1427 return (EEXIST);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1428 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1429 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1430 } else if (dsl_dir_is_clone(ds->ds_dir)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1431 return (dsl_dataset_origin_check(dsda, arg2, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1432 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1433
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1434 /* XXX we should do some i/o error checking... */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1435 return (0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1436 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1437
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1438 struct refsarg {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1439 kmutex_t lock;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1440 boolean_t gone;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1441 kcondvar_t cv;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1442 };
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1443
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1444 /* ARGSUSED */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1445 static void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1446 dsl_dataset_refs_gone(dmu_buf_t db, void argv)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1447 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1448 struct refsarg *arg = argv;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1449
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1450 mutex_enter(&arg->lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1451 arg->gone = TRUE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1452 cv_signal(&arg->cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1453 mutex_exit(&arg->lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1454 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1455
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1456 static void
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1457 dsl_dataset_drain_refs(dsl_dataset_t ds, void tag)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1458 {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1459 struct refsarg arg;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1460
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1461 mutex_init(&arg.lock, NULL, MUTEX_DEFAULT, NULL);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1462 cv_init(&arg.cv, NULL, CV_DEFAULT, NULL);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1463 arg.gone = FALSE;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1464 (void) dmu_buf_update_user(ds->ds_dbuf, ds, &arg, &ds->ds_phys,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1465 dsl_dataset_refs_gone);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1466 dmu_buf_rele(ds->ds_dbuf, tag);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1467 mutex_enter(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1468 while (!arg.gone)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1469 cv_wait(&arg.cv, &arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1470 ASSERT(arg.gone);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1471 mutex_exit(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1472 ds->ds_dbuf = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1473 ds->ds_phys = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1474 mutex_destroy(&arg.lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1475 cv_destroy(&arg.cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1476 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1477
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1478 static void
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1479 remove_from_next_clones(dsl_dataset_t ds, uint64_t obj, dmu_tx_t tx)
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1480 {
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1481 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1482 uint64_t count;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1483 int err;
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1484
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1485 ASSERT(ds->ds_phys->ds_num_children >= 2);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1486 err = zap_remove_int(mos, ds->ds_phys->ds_next_clones_obj, obj, tx);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1487 /*
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1488 * The err should not be ENOENT, but a bug in a previous version
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1489 * of the code could cause upgrade_clones_cb() to not set
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1490 * ds_next_snap_obj when it should, leading to a missing entry.
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1491 * If we knew that the pool was created after
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1492 * SPA_VERSION_NEXT_CLONES, we could assert that it isn't
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1493 * ENOENT. However, at least we can check that we don't have
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1494 * too many entries in the next_clones_obj even after failing to
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1495 * remove this one.
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1496 */
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1497 if (err != ENOENT) {
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	1498 VERIFY0(err);
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1499 }
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	1500 ASSERT3U(0, ==, zap_count(mos, ds->ds_phys->ds_next_clones_obj,
9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	1501 &count));
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1502 ASSERT3U(count, <=, ds->ds_phys->ds_num_children - 2);
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1503 }
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1504
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1505 static void
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1506 dsl_dataset_remove_clones_key(dsl_dataset_t ds, uint64_t mintxg, dmu_tx_t tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1507 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1508 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1509 zap_cursor_t zc;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1510 zap_attribute_t za;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1511
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1512 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1513 * If it is the old version, dd_clones doesn't exist so we can't
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1514 * find the clones, but deadlist_remove_key() is a no-op so it
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1515 * doesn't matter.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1516 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1517 if (ds->ds_dir->dd_phys->dd_clones == 0)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1518 return;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1519
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1520 for (zap_cursor_init(&zc, mos, ds->ds_dir->dd_phys->dd_clones);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1521 zap_cursor_retrieve(&zc, &za) == 0;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1522 zap_cursor_advance(&zc)) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1523 dsl_dataset_t *clone;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1524
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	1525 VERIFY3U(0, ==, dsl_dataset_hold_obj(ds->ds_dir->dd_pool,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1526 za.za_first_integer, FTAG, &clone));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1527 if (clone->ds_dir->dd_origin_txg > mintxg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1528 dsl_deadlist_remove_key(&clone->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1529 mintxg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1530 dsl_dataset_remove_clones_key(clone, mintxg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1531 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1532 dsl_dataset_rele(clone, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1533 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1534 zap_cursor_fini(&zc);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1535 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1536
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1537 struct process_old_arg {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1538 dsl_dataset_t *ds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1539 dsl_dataset_t *ds_prev;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1540 boolean_t after_branch_point;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1541 zio_t *pio;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1542 uint64_t used, comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1543 };
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1544
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1545 static int
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1546 process_old_cb(void arg, const blkptr_t bp, dmu_tx_t *tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1547 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1548 struct process_old_arg *poa = arg;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1549 dsl_pool_t *dp = poa->ds->ds_dir->dd_pool;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1550
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1551 if (bp->blk_birth <= poa->ds->ds_phys->ds_prev_snap_txg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1552 dsl_deadlist_insert(&poa->ds->ds_deadlist, bp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1553 if (poa->ds_prev && !poa->after_branch_point &&
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1554 bp->blk_birth >
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1555 poa->ds_prev->ds_phys->ds_prev_snap_txg) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1556 poa->ds_prev->ds_phys->ds_unique_bytes +=
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1557 bp_get_dsize_sync(dp->dp_spa, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1558 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1559 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1560 poa->used += bp_get_dsize_sync(dp->dp_spa, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1561 poa->comp += BP_GET_PSIZE(bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1562 poa->uncomp += BP_GET_UCSIZE(bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1563 dsl_free_sync(poa->pio, dp, tx->tx_txg, bp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1564 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1565 return (0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1566 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1567
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1568 static void
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1569 process_old_deadlist(dsl_dataset_t ds, dsl_dataset_t ds_prev,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1570 dsl_dataset_t ds_next, boolean_t after_branch_point, dmu_tx_t tx)
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1571 {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1572 struct process_old_arg poa = { 0 };
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1573 dsl_pool_t *dp = ds->ds_dir->dd_pool;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1574 objset_t *mos = dp->dp_meta_objset;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1575
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1576 ASSERT(ds->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1577 ASSERT(ds_next->ds_deadlist.dl_oldfmt);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1578
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1579 poa.ds = ds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1580 poa.ds_prev = ds_prev;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1581 poa.after_branch_point = after_branch_point;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1582 poa.pio = zio_root(dp->dp_spa, NULL, NULL, ZIO_FLAG_MUSTSUCCEED);
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	1583 VERIFY3U(0, ==, bpobj_iterate(&ds_next->ds_deadlist.dl_bpobj,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1584 process_old_cb, &poa, tx));
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	1585 VERIFY0(zio_wait(poa.pio));
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1586 ASSERT3U(poa.used, ==, ds->ds_phys->ds_unique_bytes);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1587
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1588 /* change snapused */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1589 dsl_dir_diduse_space(ds->ds_dir, DD_USED_SNAP,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1590 -poa.used, -poa.comp, -poa.uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1591
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1592 /* swap next's deadlist to our deadlist */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1593 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1594 dsl_deadlist_close(&ds_next->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1595 SWITCH64(ds_next->ds_phys->ds_deadlist_obj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1596 ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1597 dsl_deadlist_open(&ds->ds_deadlist, mos, ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1598 dsl_deadlist_open(&ds_next->ds_deadlist, mos,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1599 ds_next->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1600 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1601
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1602 static int
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1603 old_synchronous_dataset_destroy(dsl_dataset_t ds, dmu_tx_t tx)
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1604 {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1605 int err;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1606 struct killarg ka;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1607
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1608 /*
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1609 * Free everything that we point to (that's born after
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1610 * the previous snapshot, if we are a clone)
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1611 *
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1612 * NB: this should be very quick, because we already
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1613 * freed all the objects in open context.
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1614 */
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1615 ka.ds = ds;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1616 ka.tx = tx;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1617 err = traverse_dataset(ds,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1618 ds->ds_phys->ds_prev_snap_txg, TRAVERSE_POST,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1619 kill_blkptr, &ka);
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	1620 ASSERT0(err);
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1621 ASSERT(!DS_UNIQUE_IS_ACCURATE(ds) \|\| ds->ds_phys->ds_unique_bytes == 0);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1622
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1623 return (err);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1624 }
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1625
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	1626 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1627 dsl_dataset_destroy_sync(void arg1, void tag, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1628 {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1629 struct dsl_ds_destroyarg *dsda = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1630 dsl_dataset_t *ds = dsda->ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1631 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1632 int after_branch_point = FALSE;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1633 dsl_pool_t *dp = ds->ds_dir->dd_pool;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1634 objset_t *mos = dp->dp_meta_objset;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1635 dsl_dataset_t *ds_prev = NULL;
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1636 boolean_t wont_destroy;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1637 uint64_t obj;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1638
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1639 wont_destroy = (dsda->defer &&
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1640 (ds->ds_userrefs > 0 \|\| ds->ds_phys->ds_num_children > 1));
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1641
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1642 ASSERT(ds->ds_owner \|\| wont_destroy);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1643 ASSERT(dsda->defer \|\| ds->ds_phys->ds_num_children <= 1);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1644 ASSERT(ds->ds_prev == NULL \|\|
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1645 ds->ds_prev->ds_phys->ds_next_snap_obj != ds->ds_object);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1646 ASSERT3U(ds->ds_phys->ds_bp.blk_birth, <=, tx->tx_txg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1647
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1648 if (wont_destroy) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1649 ASSERT(spa_version(dp->dp_spa) >= SPA_VERSION_USERREFS);
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1650 dmu_buf_will_dirty(ds->ds_dbuf, tx);
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1651 ds->ds_phys->ds_flags \|= DS_FLAG_DEFER_DESTROY;
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	1652 spa_history_log_internal_ds(ds, "defer_destroy", tx, "");
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	1653 return;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1654 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1655
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	1656 /* We need to log before removing it from the namespace. */
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	1657 spa_history_log_internal_ds(ds, "destroy", tx, "");
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	1658
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1659 /* signal any waiters that this dataset is going away */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1660 mutex_enter(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1661 ds->ds_owner = dsl_reaper;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1662 cv_broadcast(&ds->ds_exclusive_cv);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1663 mutex_exit(&ds->ds_lock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1664
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1665 /* Remove our reservation */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1666 if (ds->ds_reserved != 0) {
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1667 dsl_prop_setarg_t psa;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1668 uint64_t value = 0;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1669
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1670 dsl_prop_setarg_init_uint64(&psa, "refreservation",
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1671 (ZPROP_SRC_NONE \| ZPROP_SRC_LOCAL \| ZPROP_SRC_RECEIVED),
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1672 &value);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1673 psa.psa_effective_value = 0; /* predict default value */
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	1674
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1675 dsl_dataset_set_reservation_sync(ds, &psa, tx);
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	1676 ASSERT0(ds->ds_reserved);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1677 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1678
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1679 ASSERT(RW_WRITE_HELD(&dp->dp_config_rwlock));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1680
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1681 dsl_scan_ds_destroyed(ds, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1682
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1683 obj = ds->ds_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1684
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1685 if (ds->ds_phys->ds_prev_snap_obj != 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1686 if (ds->ds_prev) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1687 ds_prev = ds->ds_prev;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1688 } else {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1689 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1690 ds->ds_phys->ds_prev_snap_obj, FTAG, &ds_prev));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1691 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1692 after_branch_point =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1693 (ds_prev->ds_phys->ds_next_snap_obj != obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1694
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1695 dmu_buf_will_dirty(ds_prev->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1696 if (after_branch_point &&
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1697 ds_prev->ds_phys->ds_next_clones_obj != 0) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	1698 remove_from_next_clones(ds_prev, obj, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1699 if (ds->ds_phys->ds_next_snap_obj != 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1700 VERIFY(0 == zap_add_int(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1701 ds_prev->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1702 ds->ds_phys->ds_next_snap_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1703 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1704 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1705 if (after_branch_point &&
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1706 ds->ds_phys->ds_next_snap_obj == 0) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1707 /* This clone is toast. */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1708 ASSERT(ds_prev->ds_phys->ds_num_children > 1);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1709 ds_prev->ds_phys->ds_num_children--;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1710
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1711 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1712 * If the clone's origin has no other clones, no
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1713 * user holds, and has been marked for deferred
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1714 * deletion, then we should have done the necessary
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1715 * destroy setup for it.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1716 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1717 if (ds_prev->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1718 ds_prev->ds_userrefs == 0 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1719 DS_IS_DEFER_DESTROY(ds_prev)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1720 ASSERT3P(dsda->rm_origin, !=, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1721 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1722 ASSERT3P(dsda->rm_origin, ==, NULL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1723 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1724 } else if (!after_branch_point) {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1725 ds_prev->ds_phys->ds_next_snap_obj =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1726 ds->ds_phys->ds_next_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1727 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1728 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1729
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1730 if (dsl_dataset_is_snapshot(ds)) {
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1731 dsl_dataset_t *ds_next;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1732 uint64_t old_unique;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1733 uint64_t used = 0, comp = 0, uncomp = 0;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1734
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1735 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1736 ds->ds_phys->ds_next_snap_obj, FTAG, &ds_next));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1737 ASSERT3U(ds_next->ds_phys->ds_prev_snap_obj, ==, obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1738
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1739 old_unique = ds_next->ds_phys->ds_unique_bytes;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1740
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1741 dmu_buf_will_dirty(ds_next->ds_dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1742 ds_next->ds_phys->ds_prev_snap_obj =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1743 ds->ds_phys->ds_prev_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1744 ds_next->ds_phys->ds_prev_snap_txg =
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1745 ds->ds_phys->ds_prev_snap_txg;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1746 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, ==,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1747 ds_prev ? ds_prev->ds_phys->ds_creation_txg : 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1748
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1749
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1750 if (ds_next->ds_deadlist.dl_oldfmt) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1751 process_old_deadlist(ds, ds_prev, ds_next,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1752 after_branch_point, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1753 } else {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1754 /* Adjust prev's unique space. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1755 if (ds_prev && !after_branch_point) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1756 dsl_deadlist_space_range(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1757 ds_prev->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1758 ds->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1759 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1760 ds_prev->ds_phys->ds_unique_bytes += used;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1761 }
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1762
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1763 /* Adjust snapused. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1764 dsl_deadlist_space_range(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1765 ds->ds_phys->ds_prev_snap_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1766 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1767 dsl_dir_diduse_space(ds->ds_dir, DD_USED_SNAP,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1768 -used, -comp, -uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1769
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1770 /* Move blocks to be freed to pool's free list. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1771 dsl_deadlist_move_bpobj(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1772 &dp->dp_free_bpobj, ds->ds_phys->ds_prev_snap_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1773 tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1774 dsl_dir_diduse_space(tx->tx_pool->dp_free_dir,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1775 DD_USED_HEAD, used, comp, uncomp, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1776
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1777 /* Merge our deadlist into next's and free it. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1778 dsl_deadlist_merge(&ds_next->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1779 ds->ds_phys->ds_deadlist_obj, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1780 }
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1781 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1782 dsl_deadlist_free(mos, ds->ds_phys->ds_deadlist_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1783
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1784 /* Collapse range in clone heads */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1785 dsl_dataset_remove_clones_key(ds,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1786 ds->ds_phys->ds_creation_txg, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1787
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1788 if (dsl_dataset_is_snapshot(ds_next)) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1789 dsl_dataset_t *ds_nextnext;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1790
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1791 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1792 * Update next's unique to include blocks which
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1793 * were previously shared by only this snapshot
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1794 * and it. Those blocks will be born after the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1795 * prev snap and before this snap, and will have
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1796 * died after the next snap and before the one
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1797 * after that (ie. be on the snap after next's
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1798 * deadlist).
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1799 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1800 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1801 ds_next->ds_phys->ds_next_snap_obj,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1802 FTAG, &ds_nextnext));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1803 dsl_deadlist_space_range(&ds_nextnext->ds_deadlist,
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1804 ds->ds_phys->ds_prev_snap_txg,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1805 ds->ds_phys->ds_creation_txg,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1806 &used, &comp, &uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1807 ds_next->ds_phys->ds_unique_bytes += used;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1808 dsl_dataset_rele(ds_nextnext, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1809 ASSERT3P(ds_next->ds_prev, ==, NULL);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1810
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1811 /* Collapse range in this head. */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1812 dsl_dataset_t *hds;
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	1813 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1814 ds->ds_dir->dd_phys->dd_head_dataset_obj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1815 FTAG, &hds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1816 dsl_deadlist_remove_key(&hds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1817 ds->ds_phys->ds_creation_txg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1818 dsl_dataset_rele(hds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1819
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1820 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1821 ASSERT3P(ds_next->ds_prev, ==, ds);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1822 dsl_dataset_drop_ref(ds_next->ds_prev, ds_next);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1823 ds_next->ds_prev = NULL;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1824 if (ds_prev) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1825 VERIFY(0 == dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1826 ds->ds_phys->ds_prev_snap_obj,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1827 ds_next, &ds_next->ds_prev));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1828 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1829
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1830 dsl_dataset_recalc_head_uniq(ds_next);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1831
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1832 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1833 * Reduce the amount of our unconsmed refreservation
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1834 * being charged to our parent by the amount of
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1835 * new unique data we have gained.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1836 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1837 if (old_unique < ds_next->ds_reserved) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1838 int64_t mrsdelta;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1839 uint64_t new_unique =
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1840 ds_next->ds_phys->ds_unique_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1841
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1842 ASSERT(old_unique <= new_unique);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1843 mrsdelta = MIN(new_unique - old_unique,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1844 ds_next->ds_reserved - old_unique);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1845 dsl_dir_diduse_space(ds->ds_dir,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1846 DD_USED_REFRSRV, -mrsdelta, 0, 0, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1847 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1848 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1849 dsl_dataset_rele(ds_next, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1850 } else {
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1851 zfeature_info_t *async_destroy =
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1852 &spa_feature_table[SPA_FEATURE_ASYNC_DESTROY];
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1853 objset_t *os;
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1854
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1855 /*
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1856 * There's no next snapshot, so this is a head dataset.
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1857 * Destroy the deadlist. Unless it's a clone, the
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1858 * deadlist should be empty. (If it's a clone, it's
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1859 * safe to ignore the deadlist contents.)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1860 */
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1861 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1862 dsl_deadlist_free(mos, ds->ds_phys->ds_deadlist_obj, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1863 ds->ds_phys->ds_deadlist_obj = 0;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1864
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1865 VERIFY3U(0, ==, dmu_objset_from_ds(ds, &os));
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1866
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1867 if (!spa_feature_is_enabled(dp->dp_spa, async_destroy)) {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1868 err = old_synchronous_dataset_destroy(ds, tx);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1869 } else {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1870 /*
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1871 * Move the bptree into the pool's list of trees to
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1872 * clean up and update space accounting information.
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1873 */
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1874 uint64_t used, comp, uncomp;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1875
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1876 zil_destroy_sync(dmu_objset_zil(os), tx);
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1877
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1878 if (!spa_feature_is_active(dp->dp_spa, async_destroy)) {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1879 spa_feature_incr(dp->dp_spa, async_destroy, tx);
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1880 dp->dp_bptree_obj = bptree_alloc(mos, tx);
cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1881 VERIFY(zap_add(mos,
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1882 DMU_POOL_DIRECTORY_OBJECT,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1883 DMU_POOL_BPTREE_OBJ, sizeof (uint64_t), 1,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1884 &dp->dp_bptree_obj, tx) == 0);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1885 }
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1886
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1887 used = ds->ds_dir->dd_phys->dd_used_bytes;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1888 comp = ds->ds_dir->dd_phys->dd_compressed_bytes;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1889 uncomp = ds->ds_dir->dd_phys->dd_uncompressed_bytes;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1890
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1891 ASSERT(!DS_UNIQUE_IS_ACCURATE(ds) \|\|
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1892 ds->ds_phys->ds_unique_bytes == used);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1893
13776 cd512c80fd75 3086 unnecessarily setting DS_FLAG_INCONSISTENT on async destroyed datasets Matthew Ahrens <mahrens@delphix.com> parents: 13772 diff changeset	1894 bptree_add(mos, dp->dp_bptree_obj,
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1895 &ds->ds_phys->ds_bp, ds->ds_phys->ds_prev_snap_txg,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1896 used, comp, uncomp, tx);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1897 dsl_dir_diduse_space(ds->ds_dir, DD_USED_HEAD,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1898 -used, -comp, -uncomp, tx);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1899 dsl_dir_diduse_space(dp->dp_free_dir, DD_USED_HEAD,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1900 used, comp, uncomp, tx);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	1901 }
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1902
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1903 if (ds->ds_prev != NULL) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1904 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	1905 VERIFY3U(0, ==, zap_remove_int(mos,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1906 ds->ds_prev->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1907 ds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	1908 }
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1909 dsl_dataset_rele(ds->ds_prev, ds);
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1910 ds->ds_prev = ds_prev = NULL;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1911 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1912 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1913
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1914 /*
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1915 * This must be done after the dsl_traverse(), because it will
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1916 * re-open the objset.
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1917 */
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1918 if (ds->ds_objset) {
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1919 dmu_objset_evict(ds->ds_objset);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1920 ds->ds_objset = NULL;
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1921 }
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1922
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1923 if (ds->ds_dir->dd_phys->dd_head_dataset_obj == ds->ds_object) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1924 /* Erase the link in the dir */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1925 dmu_buf_will_dirty(ds->ds_dir->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1926 ds->ds_dir->dd_phys->dd_head_dataset_obj = 0;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1927 ASSERT(ds->ds_phys->ds_snapnames_zapobj != 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1928 err = zap_destroy(mos, ds->ds_phys->ds_snapnames_zapobj, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1929 ASSERT(err == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1930 } else {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1931 /* remove from snapshot namespace */
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1932 dsl_dataset_t *ds_head;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1933 ASSERT(ds->ds_phys->ds_snapnames_zapobj == 0);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1934 VERIFY(0 == dsl_dataset_hold_obj(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1935 ds->ds_dir->dd_phys->dd_head_dataset_obj, FTAG, &ds_head));
2207 47efcb3433a7 6439370 assertion failures possible in dsl_dataset_destroy_sync() ahrens parents: 2199 diff changeset	1936 VERIFY(0 == dsl_dataset_get_snapname(ds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1937 #ifdef ZFS_DEBUG
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1938 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1939 uint64_t val;
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	1940
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1941 err = dsl_dataset_snap_lookup(ds_head,
6492 903545192033 6654808 FIGNORECASE lookups in a zfs xattr dir don't provide 'realname' data timh parents: 6047 diff changeset	1942 ds->ds_snapname, &val);
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	1943 ASSERT0(err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1944 ASSERT3U(val, ==, obj);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1945 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1946 #endif
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1947 err = dsl_dataset_snap_remove(ds_head, ds->ds_snapname, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1948 ASSERT(err == 0);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1949 dsl_dataset_rele(ds_head, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1950 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1951
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1952 if (ds_prev && ds->ds_prev != ds_prev)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1953 dsl_dataset_rele(ds_prev, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	1954
5094 71a3e95fb9e2 PSARC 2007/342 Enhanced ZFS Pool Properties lling parents: 4967 diff changeset	1955 spa_prop_clear_bootfs(dp->dp_spa, ds->ds_object, tx);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	1956
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1957 if (ds->ds_phys->ds_next_clones_obj != 0) {
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1958 uint64_t count;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1959 ASSERT(0 == zap_count(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1960 ds->ds_phys->ds_next_clones_obj, &count) && count == 0);
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1961 VERIFY(0 == dmu_object_free(mos,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1962 ds->ds_phys->ds_next_clones_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	1963 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1964 if (ds->ds_phys->ds_props_obj != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	1965 VERIFY(0 == zap_destroy(mos, ds->ds_phys->ds_props_obj, tx));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1966 if (ds->ds_phys->ds_userrefs_obj != 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1967 VERIFY(0 == zap_destroy(mos, ds->ds_phys->ds_userrefs_obj, tx));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1968 dsl_dir_close(ds->ds_dir, ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1969 ds->ds_dir = NULL;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	1970 dsl_dataset_drain_refs(ds, tag);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1971 VERIFY(0 == dmu_object_free(mos, obj, tx));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1972
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1973 if (dsda->rm_origin) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1974 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1975 * Remove the origin of the clone we just destroyed.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1976 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1977 struct dsl_ds_destroyarg ndsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1978
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	1979 ndsda.ds = dsda->rm_origin;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1980 dsl_dataset_destroy_sync(&ndsda, tag, tx);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	1981 }
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1982 }
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	1983
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1984 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1985 dsl_dataset_snapshot_reserve_space(dsl_dataset_t ds, dmu_tx_t tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1986 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1987 uint64_t asize;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1988
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1989 if (!dmu_tx_is_syncing(tx))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1990 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1991
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1992 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1993 * If there's an fs-only reservation, any blocks that might become
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1994 * owned by the snapshot dataset must be accommodated by space
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1995 * outside of the reservation.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	1996 */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1997 ASSERT(ds->ds_reserved == 0 \|\| DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	1998 asize = MIN(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	1999 if (asize > dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE))
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2000 return (ENOSPC);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2001
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2002 /*
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2003 * Propagate any reserved space for this snapshot to other
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2004 * snapshot checks in this sync group.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2005 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2006 if (asize > 0)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2007 dsl_dir_willuse_space(ds->ds_dir, asize, tx);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2008
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2009 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2010 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2011
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2012 int
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2013 dsl_dataset_snapshot_check(dsl_dataset_t ds, const char snapname,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2014 dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2015 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2016 int err;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2017 uint64_t value;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2018
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2019 /*
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2020 * We don't allow multiple snapshots of the same txg. If there
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2021 * is already one, try again.
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2022 */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2023 if (ds->ds_phys->ds_prev_snap_txg >= tx->tx_txg)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2024 return (EAGAIN);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2025
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2026 /*
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2027 * Check for conflicting snapshot name.
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2028 */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2029 err = dsl_dataset_snap_lookup(ds, snapname, &value);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2030 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2031 return (EEXIST);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2032 if (err != ENOENT)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2033 return (err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2034
3978 2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2035 /*
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2036 * Check that the dataset's name is not too long. Name consists
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2037 * of the dataset's length + 1 for the @-sign + snapshot name's length
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2038 */
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2039 if (dsl_dataset_namelen(ds) + 1 + strlen(snapname) >= MAXNAMELEN)
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2040 return (ENAMETOOLONG);
2dd668007b7a 6533813 recursive snapshotting resulted in a bad stack overflow mmusante parents: 3912 diff changeset	2041
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2042 err = dsl_dataset_snapshot_reserve_space(ds, tx);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2043 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2044 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2045
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2046 ds->ds_trysnap_txg = tx->tx_txg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2047 return (0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2048 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2049
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2050 void
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2051 dsl_dataset_snapshot_sync(dsl_dataset_t ds, const char snapname,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2052 dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2053 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2054 dsl_pool_t *dp = ds->ds_dir->dd_pool;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2055 dmu_buf_t *dbuf;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2056 dsl_dataset_phys_t *dsphys;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2057 uint64_t dsobj, crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2058 objset_t *mos = dp->dp_meta_objset;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2059 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2060
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2061 ASSERT(RW_WRITE_HELD(&dp->dp_config_rwlock));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2062
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2063 /*
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2064 * The origin's ds_creation_txg has to be < TXG_INITIAL
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2065 */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2066 if (strcmp(snapname, ORIGIN_DIR_NAME) == 0)
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2067 crtxg = 1;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2068 else
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2069 crtxg = tx->tx_txg;
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2070
928 36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	2071 dsobj = dmu_object_alloc(mos, DMU_OT_DSL_DATASET, 0,
36d72fe4da29 6349314 dmu_object_type names incorrect for DSL Directories and DSL Datasets tabriz parents: 885 diff changeset	2072 DMU_OT_DSL_DATASET, sizeof (dsl_dataset_phys_t), tx);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2073 VERIFY(0 == dmu_bonus_hold(mos, dsobj, FTAG, &dbuf));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2074 dmu_buf_will_dirty(dbuf, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2075 dsphys = dbuf->db_data;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2076 bzero(dsphys, sizeof (dsl_dataset_phys_t));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2077 dsphys->ds_dir_obj = ds->ds_dir->dd_object;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2078 dsphys->ds_fsid_guid = unique_create();
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2079 (void) random_get_pseudo_bytes((void*)&dsphys->ds_guid,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2080 sizeof (dsphys->ds_guid));
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2081 dsphys->ds_prev_snap_obj = ds->ds_phys->ds_prev_snap_obj;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2082 dsphys->ds_prev_snap_txg = ds->ds_phys->ds_prev_snap_txg;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2083 dsphys->ds_next_snap_obj = ds->ds_object;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2084 dsphys->ds_num_children = 1;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2085 dsphys->ds_creation_time = gethrestime_sec();
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2086 dsphys->ds_creation_txg = crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2087 dsphys->ds_deadlist_obj = ds->ds_phys->ds_deadlist_obj;
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2088 dsphys->ds_referenced_bytes = ds->ds_phys->ds_referenced_bytes;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2089 dsphys->ds_compressed_bytes = ds->ds_phys->ds_compressed_bytes;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2090 dsphys->ds_uncompressed_bytes = ds->ds_phys->ds_uncompressed_bytes;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2091 dsphys->ds_flags = ds->ds_phys->ds_flags;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2092 dsphys->ds_bp = ds->ds_phys->ds_bp;
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2093 dmu_buf_rele(dbuf, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2094
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2095 ASSERT3U(ds->ds_prev != 0, ==, ds->ds_phys->ds_prev_snap_obj != 0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2096 if (ds->ds_prev) {
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2097 uint64_t next_clones_obj =
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2098 ds->ds_prev->ds_phys->ds_next_clones_obj;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2099 ASSERT(ds->ds_prev->ds_phys->ds_next_snap_obj ==
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2100 ds->ds_object \|\|
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2101 ds->ds_prev->ds_phys->ds_num_children > 1);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2102 if (ds->ds_prev->ds_phys->ds_next_snap_obj == ds->ds_object) {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2103 dmu_buf_will_dirty(ds->ds_prev->ds_dbuf, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2104 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, ==,
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2105 ds->ds_prev->ds_phys->ds_creation_txg);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2106 ds->ds_prev->ds_phys->ds_next_snap_obj = dsobj;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2107 } else if (next_clones_obj != 0) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2108 remove_from_next_clones(ds->ds_prev,
e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2109 dsphys->ds_next_snap_obj, tx);
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2110 VERIFY3U(0, ==, zap_add_int(mos,
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2111 next_clones_obj, dsobj, tx));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2112 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2113 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2114
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2115 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2116 * If we have a reference-reservation on this dataset, we will
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2117 * need to increase the amount of refreservation being charged
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2118 * since our unique space is going to zero.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2119 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2120 if (ds->ds_reserved) {
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2121 int64_t delta;
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2122 ASSERT(DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2123 delta = MIN(ds->ds_phys->ds_unique_bytes, ds->ds_reserved);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2124 dsl_dir_diduse_space(ds->ds_dir, DD_USED_REFRSRV,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2125 delta, 0, 0, tx);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2126 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2127
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2128 dmu_buf_will_dirty(ds->ds_dbuf, tx);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2129 zfs_dbgmsg("taking snapshot %s@%s/%llu; newkey=%llu",
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2130 ds->ds_dir->dd_myname, snapname, dsobj,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2131 ds->ds_phys->ds_prev_snap_txg);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2132 ds->ds_phys->ds_deadlist_obj = dsl_deadlist_clone(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2133 UINT64_MAX, ds->ds_phys->ds_prev_snap_obj, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2134 dsl_deadlist_close(&ds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2135 dsl_deadlist_open(&ds->ds_deadlist, mos, ds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2136 dsl_deadlist_add_key(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2137 ds->ds_phys->ds_prev_snap_txg, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2138
5712 81f1af42bafc 6628232 zfs snapshot -r is very slow, causes systemic slowdown ahrens parents: 5569 diff changeset	2139 ASSERT3U(ds->ds_phys->ds_prev_snap_txg, <, tx->tx_txg);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2140 ds->ds_phys->ds_prev_snap_obj = dsobj;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2141 ds->ds_phys->ds_prev_snap_txg = crtxg;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2142 ds->ds_phys->ds_unique_bytes = 0;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2143 if (spa_version(dp->dp_spa) >= SPA_VERSION_UNIQUE_ACCURATE)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2144 ds->ds_phys->ds_flags \|= DS_FLAG_UNIQUE_ACCURATE;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2145
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2146 err = zap_add(mos, ds->ds_phys->ds_snapnames_zapobj,
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2147 snapname, 8, 1, &dsobj, tx);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2148 ASSERT(err == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2149
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2150 if (ds->ds_prev)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2151 dsl_dataset_drop_ref(ds->ds_prev, ds);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2152 VERIFY(0 == dsl_dataset_get_ref(dp,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2153 ds->ds_phys->ds_prev_snap_obj, ds, &ds->ds_prev));
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2154
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2155 dsl_scan_ds_snapshotted(ds, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2156
10373 bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	2157 dsl_dir_snap_cmtime_update(ds->ds_dir);
bcf97ee54990 6395956 snapshot dir needs real c/mtime Chris Kirby <chris.kirby@sun.com> parents: 10342 diff changeset	2158
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2159 spa_history_log_internal_ds(ds->ds_prev, "snapshot", tx, "");
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2160 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2161
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2162 void
3547 e396e0a440b1 6512391 DMU should leverage ZIO dependencies to achieve greater parallelism maybee parents: 3444 diff changeset	2163 dsl_dataset_sync(dsl_dataset_t ds, zio_t zio, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2164 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2165 ASSERT(dmu_tx_is_syncing(tx));
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2166 ASSERT(ds->ds_objset != NULL);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2167 ASSERT(ds->ds_phys->ds_next_snap_obj == 0);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2168
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2169 /*
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2170 * in case we had to change ds_fsid_guid when we opened it,
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2171 * sync it out now.
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2172 */
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2173 dmu_buf_will_dirty(ds->ds_dbuf, tx);
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2174 ds->ds_phys->ds_fsid_guid = ds->ds_fsid_guid;
602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2175
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2176 dmu_objset_sync(ds->ds_objset, zio, tx);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2177 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2178
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2179 static void
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2180 get_clones_stat(dsl_dataset_t ds, nvlist_t nv)
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2181 {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2182 uint64_t count = 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2183 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2184 zap_cursor_t zc;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2185 zap_attribute_t za;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2186 nvlist_t *propval;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2187 nvlist_t *val;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2188
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2189 rw_enter(&ds->ds_dir->dd_pool->dp_config_rwlock, RW_READER);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2190 VERIFY(nvlist_alloc(&propval, NV_UNIQUE_NAME, KM_SLEEP) == 0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2191 VERIFY(nvlist_alloc(&val, NV_UNIQUE_NAME, KM_SLEEP) == 0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2192
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2193 /*
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2194 * There may me missing entries in ds_next_clones_obj
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2195 * due to a bug in a previous version of the code.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2196 * Only trust it if it has the right number of entries.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2197 */
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2198 if (ds->ds_phys->ds_next_clones_obj != 0) {
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2199 ASSERT3U(0, ==, zap_count(mos, ds->ds_phys->ds_next_clones_obj,
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2200 &count));
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2201 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2202 if (count != ds->ds_phys->ds_num_children - 1) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2203 goto fail;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2204 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2205 for (zap_cursor_init(&zc, mos, ds->ds_phys->ds_next_clones_obj);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2206 zap_cursor_retrieve(&zc, &za) == 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2207 zap_cursor_advance(&zc)) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2208 dsl_dataset_t *clone;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2209 char buf[ZFS_MAXNAMELEN];
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2210 /*
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2211 * Even though we hold the dp_config_rwlock, the dataset
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2212 * may fail to open, returning ENOENT. If there is a
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2213 * thread concurrently attempting to destroy this
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2214 * dataset, it will have the ds_rwlock held for
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2215 * RW_WRITER. Our call to dsl_dataset_hold_obj() ->
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2216 * dsl_dataset_hold_ref() will fail its
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2217 * rw_tryenter(&ds->ds_rwlock, RW_READER), drop the
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2218 * dp_config_rwlock, and wait for the destroy progress
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2219 * and signal ds_exclusive_cv. If the destroy was
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2220 * successful, we will see that
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2221 * DSL_DATASET_IS_DESTROYED(), and return ENOENT.
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2222 */
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2223 if (dsl_dataset_hold_obj(ds->ds_dir->dd_pool,
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2224 za.za_first_integer, FTAG, &clone) != 0)
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2225 continue;
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2226 dsl_dir_name(clone->ds_dir, buf);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2227 VERIFY(nvlist_add_boolean(val, buf) == 0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2228 dsl_dataset_rele(clone, FTAG);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2229 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2230 zap_cursor_fini(&zc);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2231 VERIFY(nvlist_add_nvlist(propval, ZPROP_VALUE, val) == 0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2232 VERIFY(nvlist_add_nvlist(nv, zfs_prop_to_name(ZFS_PROP_CLONES),
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2233 propval) == 0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2234 fail:
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2235 nvlist_free(val);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2236 nvlist_free(propval);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2237 rw_exit(&ds->ds_dir->dd_pool->dp_config_rwlock);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2238 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2239
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2240 void
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2241 dsl_dataset_stats(dsl_dataset_t ds, nvlist_t nv)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2242 {
13387 7dd5626b8b49 1092 zfs refratio property Matt Ahrens <Matt.Ahrens@delphix.com> parents: 13055 diff changeset	2243 uint64_t refd, avail, uobjs, aobjs, ratio;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2244
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2245 ratio = ds->ds_phys->ds_compressed_bytes == 0 ? 100 :
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2246 (ds->ds_phys->ds_uncompressed_bytes * 100 /
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2247 ds->ds_phys->ds_compressed_bytes);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2248
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2249 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFRATIO, ratio);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2250
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2251 if (dsl_dataset_is_snapshot(ds)) {
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2252 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_COMPRESSRATIO, ratio);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2253 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_USED,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2254 ds->ds_phys->ds_unique_bytes);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2255 get_clones_stat(ds, nv);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2256 } else {
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2257 dsl_dir_stats(ds->ds_dir, nv);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2258 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2259
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2260 dsl_dataset_space(ds, &refd, &avail, &uobjs, &aobjs);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2261 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_AVAILABLE, avail);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2262 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFERENCED, refd);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2263
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2264 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_CREATION,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2265 ds->ds_phys->ds_creation_time);
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2266 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_CREATETXG,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2267 ds->ds_phys->ds_creation_txg);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2268 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFQUOTA,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2269 ds->ds_quota);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2270 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_REFRESERVATION,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2271 ds->ds_reserved);
6643 3a34b0dbb107 6625086 changing cachefile doesn't remove old cache on last user eschrock parents: 6502 diff changeset	2272 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_GUID,
3a34b0dbb107 6625086 changing cachefile doesn't remove old cache on last user eschrock parents: 6502 diff changeset	2273 ds->ds_phys->ds_guid);
10575 2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2274 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_UNIQUE,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2275 ds->ds_phys->ds_unique_bytes);
10575 2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2276 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_OBJSETID,
2a8816c5173b 6882196 resource.* events shouldn't be posted during spa_tryimport() Eric Schrock <Eric.Schrock@Sun.COM> parents: 10385 diff changeset	2277 ds->ds_object);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	2278 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_USERREFS,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	2279 ds->ds_userrefs);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	2280 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_DEFER_DESTROY,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	2281 DS_IS_DEFER_DESTROY(ds) ? 1 : 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2282
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2283 if (ds->ds_phys->ds_prev_snap_obj != 0) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2284 uint64_t written, comp, uncomp;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2285 dsl_pool_t *dp = ds->ds_dir->dd_pool;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2286 dsl_dataset_t *prev;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2287
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2288 rw_enter(&dp->dp_config_rwlock, RW_READER);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2289 int err = dsl_dataset_hold_obj(dp,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2290 ds->ds_phys->ds_prev_snap_obj, FTAG, &prev);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2291 rw_exit(&dp->dp_config_rwlock);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2292 if (err == 0) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2293 err = dsl_dataset_space_written(prev, ds, &written,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2294 &comp, &uncomp);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2295 dsl_dataset_rele(prev, FTAG);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2296 if (err == 0) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2297 dsl_prop_nvlist_add_uint64(nv, ZFS_PROP_WRITTEN,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2298 written);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2299 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2300 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	2301 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2302 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2303
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2304 void
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2305 dsl_dataset_fast_stat(dsl_dataset_t ds, dmu_objset_stats_t stat)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2306 {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2307 stat->dds_creation_txg = ds->ds_phys->ds_creation_txg;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2308 stat->dds_inconsistent = ds->ds_phys->ds_flags & DS_FLAG_INCONSISTENT;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2309 stat->dds_guid = ds->ds_phys->ds_guid;
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2310 stat->dds_origin[0] = '\0';
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2311 if (dsl_dataset_is_snapshot(ds)) {
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2312 stat->dds_is_snapshot = B_TRUE;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2313 stat->dds_num_clones = ds->ds_phys->ds_num_children - 1;
8228 51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2314 } else {
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2315 stat->dds_is_snapshot = B_FALSE;
51e9ca9ee3a5 6572357 libzfs should do more to avoid mnttab lookups Eric Taylor <Eric.Taylor@Sun.COM> parents: 7837 diff changeset	2316 stat->dds_num_clones = 0;
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2317
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2318 rw_enter(&ds->ds_dir->dd_pool->dp_config_rwlock, RW_READER);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2319 if (dsl_dir_is_clone(ds->ds_dir)) {
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2320 dsl_dataset_t *ods;
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2321
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2322 VERIFY(0 == dsl_dataset_get_ref(ds->ds_dir->dd_pool,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2323 ds->ds_dir->dd_phys->dd_origin_obj, FTAG, &ods));
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2324 dsl_dataset_name(ods, stat->dds_origin);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2325 dsl_dataset_drop_ref(ods, FTAG);
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2326 }
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2327 rw_exit(&ds->ds_dir->dd_pool->dp_config_rwlock);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2328 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2329 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2330
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2331 uint64_t
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2332 dsl_dataset_fsid_guid(dsl_dataset_t *ds)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2333 {
4787 602d3f97842c 6393351 unique_* could be improved ahrens parents: 4603 diff changeset	2334 return (ds->ds_fsid_guid);
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2335 }
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2336
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2337 void
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2338 dsl_dataset_space(dsl_dataset_t *ds,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2339 uint64_t refdbytesp, uint64_t availbytesp,
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2340 uint64_t usedobjsp, uint64_t availobjsp)
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2341 {
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2342 *refdbytesp = ds->ds_phys->ds_referenced_bytes;
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2343 *availbytesp = dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2344 if (ds->ds_reserved > ds->ds_phys->ds_unique_bytes)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2345 *availbytesp += ds->ds_reserved - ds->ds_phys->ds_unique_bytes;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2346 if (ds->ds_quota != 0) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2347 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2348 * Adjust available bytes according to refquota
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2349 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2350 if (*refdbytesp < ds->ds_quota)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2351 availbytesp = MIN(availbytesp,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2352 ds->ds_quota - *refdbytesp);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2353 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2354 *availbytesp = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	2355 }
2885 c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2356 *usedobjsp = ds->ds_phys->ds_bp.blk_fill;
c0259887ebbc 6460059 zfs destroy <snapshot> leaves behind kruft ahrens parents: 2856 diff changeset	2357 availobjsp = DN_MAX_OBJECT - usedobjsp;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2358 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2359
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2360 boolean_t
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2361 dsl_dataset_modified_since_lastsnap(dsl_dataset_t *ds)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2362 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2363 dsl_pool_t *dp = ds->ds_dir->dd_pool;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2364
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2365 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock) \|\|
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2366 dsl_pool_sync_context(dp));
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2367 if (ds->ds_prev == NULL)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2368 return (B_FALSE);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2369 if (ds->ds_phys->ds_bp.blk_birth >
12839 1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2370 ds->ds_prev->ds_phys->ds_creation_txg) {
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2371 objset_t os, os_prev;
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2372 /*
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2373 * It may be that only the ZIL differs, because it was
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2374 * reset in the head. Don't count that as being
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2375 * modified.
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2376 */
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2377 if (dmu_objset_from_ds(ds, &os) != 0)
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2378 return (B_TRUE);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2379 if (dmu_objset_from_ds(ds->ds_prev, &os_prev) != 0)
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2380 return (B_TRUE);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2381 return (bcmp(&os->os_phys->os_meta_dnode,
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2382 &os_prev->os_phys->os_meta_dnode,
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2383 sizeof (os->os_phys->os_meta_dnode)) != 0);
1eab9192da8b 6844896 recursive snapshots take a long time Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12798 diff changeset	2384 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2385 return (B_FALSE);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2386 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2387
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2388 /* ARGSUSED */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2389 static int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2390 dsl_dataset_snapshot_rename_check(void arg1, void arg2, dmu_tx_t *tx)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2391 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2392 dsl_dataset_t *ds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2393 char *newsnapname = arg2;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2394 dsl_dir_t *dd = ds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2395 dsl_dataset_t *hds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2396 uint64_t val;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2397 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2398
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2399 err = dsl_dataset_hold_obj(dd->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2400 dd->dd_phys->dd_head_dataset_obj, FTAG, &hds);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2401 if (err)
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2402 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2403
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2404 /* new name better not be in use */
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2405 err = dsl_dataset_snap_lookup(hds, newsnapname, &val);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2406 dsl_dataset_rele(hds, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2407
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2408 if (err == 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2409 err = EEXIST;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2410 else if (err == ENOENT)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2411 err = 0;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2412
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2413 /* dataset name + 1 for the "@" + the new snapshot name must fit */
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2414 if (dsl_dir_namelen(ds->ds_dir) + 1 + strlen(newsnapname) >= MAXNAMELEN)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2415 err = ENAMETOOLONG;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2416
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2417 return (err);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2418 }
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2419
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2420 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2421 dsl_dataset_snapshot_rename_sync(void arg1, void arg2, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2422 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2423 dsl_dataset_t *ds = arg1;
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2424 const char *newsnapname = arg2;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2425 dsl_dir_t *dd = ds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2426 objset_t *mos = dd->dd_pool->dp_meta_objset;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2427 dsl_dataset_t *hds;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2428 int err;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2429
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2430 ASSERT(ds->ds_phys->ds_next_snap_obj != 0);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2431
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2432 VERIFY(0 == dsl_dataset_hold_obj(dd->dd_pool,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2433 dd->dd_phys->dd_head_dataset_obj, FTAG, &hds));
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2434
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2435 VERIFY(0 == dsl_dataset_get_snapname(ds));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2436 err = dsl_dataset_snap_remove(hds, ds->ds_snapname, tx);
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	2437 ASSERT0(err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2438 mutex_enter(&ds->ds_lock);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2439 (void) strcpy(ds->ds_snapname, newsnapname);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2440 mutex_exit(&ds->ds_lock);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2441 err = zap_add(mos, hds->ds_phys->ds_snapnames_zapobj,
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2442 ds->ds_snapname, 8, 1, &ds->ds_object, tx);
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	2443 ASSERT0(err);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2444
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2445 spa_history_log_internal_ds(ds, "rename", tx,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2446 "-> @%s", newsnapname);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2447 dsl_dataset_rele(hds, FTAG);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2448 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2449
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2450 struct renamesnaparg {
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2451 dsl_sync_task_group_t *dstg;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2452 char failed[MAXPATHLEN];
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2453 char *oldsnap;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2454 char *newsnap;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2455 };
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2456
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2457 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2458 dsl_snapshot_rename_one(const char name, void arg)
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2459 {
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2460 struct renamesnaparg *ra = arg;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2461 dsl_dataset_t *ds = NULL;
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2462 char *snapname;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2463 int err;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2464
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2465 snapname = kmem_asprintf("%s@%s", name, ra->oldsnap);
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2466 (void) strlcpy(ra->failed, snapname, sizeof (ra->failed));
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2467
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2468 /*
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2469 * For recursive snapshot renames the parent won't be changing
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2470 * so we just pass name for both the to/from argument.
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2471 */
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2472 err = zfs_secpolicy_rename_perms(snapname, snapname, CRED());
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2473 if (err != 0) {
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2474 strfree(snapname);
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2475 return (err == ENOENT ? 0 : err);
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2476 }
12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2477
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2478 #ifdef _KERNEL
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2479 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2480 * For all filesystems undergoing rename, we'll need to unmount it.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2481 */
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2482 (void) zfs_unmount_snap(snapname, NULL);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2483 #endif
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2484 err = dsl_dataset_hold(snapname, ra->dstg, &ds);
11609 3b5da7ebb54d 6920880 assertion failure in dbuf_write_ready() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11546 diff changeset	2485 strfree(snapname);
3b5da7ebb54d 6920880 assertion failure in dbuf_write_ready() Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11546 diff changeset	2486 if (err != 0)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2487 return (err == ENOENT ? 0 : err);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2488
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2489 dsl_sync_task_create(ra->dstg, dsl_dataset_snapshot_rename_check,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2490 dsl_dataset_snapshot_rename_sync, ds, ra->newsnap, 0);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2491
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2492 return (0);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2493 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2494
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2495 static int
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2496 dsl_recursive_rename(char oldname, const char newname)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2497 {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2498 int err;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2499 struct renamesnaparg *ra;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2500 dsl_sync_task_t *dst;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2501 spa_t *spa;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2502 char cp, fsname = spa_strdup(oldname);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2503 int len = strlen(oldname) + 1;
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2504
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2505 /* truncate the snapshot name to get the fsname */
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2506 cp = strchr(fsname, '@');
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2507 *cp = '\0';
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2508
4603 c7840c367d00 6494569 zfs recv -d pool/<doesn't exist> core dumps for top-level filesystem backups ahrens parents: 4577 diff changeset	2509 err = spa_open(fsname, &spa, FTAG);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2510 if (err) {
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2511 kmem_free(fsname, len);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2512 return (err);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2513 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2514 ra = kmem_alloc(sizeof (struct renamesnaparg), KM_SLEEP);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2515 ra->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2516
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2517 ra->oldsnap = strchr(oldname, '@') + 1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2518 ra->newsnap = strchr(newname, '@') + 1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2519 *ra->failed = '\0';
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2520
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2521 err = dmu_objset_find(fsname, dsl_snapshot_rename_one, ra,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2522 DS_FIND_CHILDREN);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2523 kmem_free(fsname, len);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2524
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2525 if (err == 0) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2526 err = dsl_sync_task_group_wait(ra->dstg);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2527 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2528
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2529 for (dst = list_head(&ra->dstg->dstg_tasks); dst;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2530 dst = list_next(&ra->dstg->dstg_tasks, dst)) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2531 dsl_dataset_t *ds = dst->dst_arg1;
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2532 if (dst->dst_err) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2533 dsl_dir_name(ds->ds_dir, ra->failed);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2534 (void) strlcat(ra->failed, "@", sizeof (ra->failed));
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2535 (void) strlcat(ra->failed, ra->newsnap,
462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2536 sizeof (ra->failed));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2537 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2538 dsl_dataset_rele(ds, ra->dstg);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2539 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2540
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2541 if (err)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2542 (void) strlcpy(oldname, ra->failed, sizeof (ra->failed));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2543
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2544 dsl_sync_task_group_destroy(ra->dstg);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	2545 kmem_free(ra, sizeof (struct renamesnaparg));
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2546 spa_close(spa, FTAG);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2547 return (err);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2548 }
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2549
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2550 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	2551 dsl_valid_rename(const char oldname, void arg)
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2552 {
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2553 int delta = (int )arg;
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2554
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2555 if (strlen(oldname) + delta >= MAXNAMELEN)
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2556 return (ENAMETOOLONG);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2557
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2558 return (0);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2559 }
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2560
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2561 #pragma weak dmu_objset_rename = dsl_dataset_rename
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2562 int
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2563 dsl_dataset_rename(char oldname, const char newname, boolean_t recursive)
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2564 {
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2565 dsl_dir_t *dd;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2566 dsl_dataset_t *ds;
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2567 const char *tail;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2568 int err;
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2569
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2570 err = dsl_dir_open(oldname, FTAG, &dd, &tail);
1544 938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2571 if (err)
938876158511 PSARC 2006/077 zpool clear eschrock parents: 928 diff changeset	2572 return (err);
11701 6f890435df16 6915532 snapshot related activity causes akd to hang Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 11609 diff changeset	2573
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2574 if (tail == NULL) {
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2575 int delta = strlen(newname) - strlen(oldname);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2576
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2577 /* if we're growing, validate child name lengths */
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2578 if (delta > 0)
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2579 err = dmu_objset_find(oldname, dsl_valid_rename,
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2580 &delta, DS_FIND_CHILDREN \| DS_FIND_SNAPSHOTS);
e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2581
11823 c756cd80d532 6930022 zfs rename of non-shapshot is slower than necessary Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11701 diff changeset	2582 if (err == 0)
4569 e80d40447f27 6355623 zfs rename to a valid dataset name, but its snapshot name becomes too long, panics the system mmusante parents: 4543 diff changeset	2583 err = dsl_dir_rename(dd, newname);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2584 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2585 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2586 }
11701 6f890435df16 6915532 snapshot related activity causes akd to hang Sanjeev Bagewadi <Sanjeev.Bagewadi@Sun.COM> parents: 11609 diff changeset	2587
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2588 if (tail[0] != '@') {
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2589 /* the name ended in a nonexistent component */
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2590 dsl_dir_close(dd, FTAG);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2591 return (ENOENT);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2592 }
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2593
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2594 dsl_dir_close(dd, FTAG);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2595
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2596 /* new name must be snapshot in same filesystem */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2597 tail = strchr(newname, '@');
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2598 if (tail == NULL)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2599 return (EINVAL);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2600 tail++;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2601 if (strncmp(oldname, newname, tail - newname) != 0)
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2602 return (EXDEV);
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2603
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2604 if (recursive) {
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2605 err = dsl_recursive_rename(oldname, newname);
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2606 } else {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2607 err = dsl_dataset_hold(oldname, FTAG, &ds);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2608 if (err)
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2609 return (err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2610
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2611 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2612 dsl_dataset_snapshot_rename_check,
c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2613 dsl_dataset_snapshot_rename_sync, ds, (char *)tail, 1);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2614
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2615 dsl_dataset_rele(ds, FTAG);
4007 c6f5c6753018 PSARC 2007/142 zfs rename -r mmusante parents: 3978 diff changeset	2616 }
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2617
789 b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2618 return (err);
b348f31ed315 PSARC 2002/240 ZFS ahrens parents: diff changeset	2619 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2620
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2621 struct promotenode {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2622 list_node_t link;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2623 dsl_dataset_t *ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2624 };
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2625
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2626 struct promotearg {
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2627 list_t shared_snaps, origin_snaps, clone_snaps;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2628 dsl_dataset_t *origin_origin;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2629 uint64_t used, comp, uncomp, unique, cloneusedsnap, originusedsnap;
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2630 char *err_ds;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2631 };
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2632
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2633 static int snaplist_space(list_t l, uint64_t mintxg, uint64_t spacep);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2634 static boolean_t snaplist_unstable(list_t *l);
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2635
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2636 static int
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2637 dsl_dataset_promote_check(void arg1, void arg2, dmu_tx_t *tx)
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2638 {
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2639 dsl_dataset_t *hds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2640 struct promotearg *pa = arg2;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2641 struct promotenode *snap = list_head(&pa->shared_snaps);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2642 dsl_dataset_t *origin_ds = snap->ds;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2643 int err;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2644 uint64_t unused;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2645
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2646 /* Check that it is a real clone */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2647 if (!dsl_dir_is_clone(hds->ds_dir))
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2648 return (EINVAL);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2649
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2650 /* Since this is so expensive, don't do the preliminary check */
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2651 if (!dmu_tx_is_syncing(tx))
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2652 return (0);
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2653
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2654 if (hds->ds_phys->ds_flags & DS_FLAG_NOPROMOTE)
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2655 return (EXDEV);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2656
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2657 /* compute origin's new unique space */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2658 snap = list_tail(&pa->clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2659 ASSERT3U(snap->ds->ds_phys->ds_prev_snap_obj, ==, origin_ds->ds_object);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2660 dsl_deadlist_space_range(&snap->ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2661 origin_ds->ds_phys->ds_prev_snap_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2662 &pa->unique, &unused, &unused);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2663
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2664 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2665 * Walk the snapshots that we are moving
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2666 *
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2667 * Compute space to transfer. Consider the incremental changes
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2668 * to used for each snapshot:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2669 * (my used) = (prev's used) + (blocks born) - (blocks killed)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2670 * So each snapshot gave birth to:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2671 * (blocks born) = (my used) - (prev's used) + (blocks killed)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2672 * So a sequence would look like:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2673 * (uN - u(N-1) + kN) + ... + (u1 - u0 + k1) + (u0 - 0 + k0)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2674 * Which simplifies to:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2675 * uN + kN + kN-1 + ... + k1 + k0
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2676 * Note however, if we stop before we reach the ORIGIN we get:
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2677 * uN + kN + kN-1 + ... + kM - uM-1
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2678 */
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2679 pa->used = origin_ds->ds_phys->ds_referenced_bytes;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2680 pa->comp = origin_ds->ds_phys->ds_compressed_bytes;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2681 pa->uncomp = origin_ds->ds_phys->ds_uncompressed_bytes;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2682 for (snap = list_head(&pa->shared_snaps); snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2683 snap = list_next(&pa->shared_snaps, snap)) {
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2684 uint64_t val, dlused, dlcomp, dluncomp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2685 dsl_dataset_t *ds = snap->ds;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2686
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2687 /* Check that the snapshot name does not conflict */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2688 VERIFY(0 == dsl_dataset_get_snapname(ds));
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2689 err = dsl_dataset_snap_lookup(hds, ds->ds_snapname, &val);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2690 if (err == 0) {
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2691 err = EEXIST;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2692 goto out;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2693 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2694 if (err != ENOENT)
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2695 goto out;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2696
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2697 /* The very first snapshot does not have a deadlist */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2698 if (ds->ds_phys->ds_prev_snap_obj == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2699 continue;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2700
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2701 dsl_deadlist_space(&ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2702 &dlused, &dlcomp, &dluncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2703 pa->used += dlused;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2704 pa->comp += dlcomp;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2705 pa->uncomp += dluncomp;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2706 }
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2707
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2708 /*
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2709 * If we are a clone of a clone then we never reached ORIGIN,
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2710 * so we need to subtract out the clone origin's used space.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2711 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2712 if (pa->origin_origin) {
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	2713 pa->used -= pa->origin_origin->ds_phys->ds_referenced_bytes;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2714 pa->comp -= pa->origin_origin->ds_phys->ds_compressed_bytes;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2715 pa->uncomp -= pa->origin_origin->ds_phys->ds_uncompressed_bytes;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2716 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2717
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2718 /* Check that there is enough space here */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2719 err = dsl_dir_transfer_possible(origin_ds->ds_dir, hds->ds_dir,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2720 pa->used);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2721 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2722 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2723
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2724 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2725 * Compute the amounts of space that will be used by snapshots
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2726 * after the promotion (for both origin and clone). For each,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2727 * it is the amount of space that will be on all of their
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2728 * deadlists (that was not born before their new origin).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2729 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2730 if (hds->ds_dir->dd_phys->dd_flags & DD_FLAG_USED_BREAKDOWN) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2731 uint64_t space;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2732
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2733 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2734 * Note, typically this will not be a clone of a clone,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2735 * so dd_origin_txg will be < TXG_INITIAL, so
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2736 * these snaplist_space() -> dsl_deadlist_space_range()
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2737 * calls will be fast because they do not have to
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2738 * iterate over all bps.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2739 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2740 snap = list_head(&pa->origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2741 err = snaplist_space(&pa->shared_snaps,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2742 snap->ds->ds_dir->dd_origin_txg, &pa->cloneusedsnap);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2743 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2744 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2745
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2746 err = snaplist_space(&pa->clone_snaps,
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2747 snap->ds->ds_dir->dd_origin_txg, &space);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2748 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2749 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2750 pa->cloneusedsnap += space;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2751 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2752 if (origin_ds->ds_dir->dd_phys->dd_flags & DD_FLAG_USED_BREAKDOWN) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2753 err = snaplist_space(&pa->origin_snaps,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2754 origin_ds->ds_phys->ds_creation_txg, &pa->originusedsnap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2755 if (err)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2756 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2757 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2758
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2759 return (0);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2760 out:
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2761 pa->err_ds = snap->ds->ds_snapname;
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	2762 return (err);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2763 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2764
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2765 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2766 dsl_dataset_promote_sync(void arg1, void arg2, dmu_tx_t *tx)
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2767 {
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2768 dsl_dataset_t *hds = arg1;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2769 struct promotearg *pa = arg2;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2770 struct promotenode *snap = list_head(&pa->shared_snaps);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2771 dsl_dataset_t *origin_ds = snap->ds;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2772 dsl_dataset_t *origin_head;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2773 dsl_dir_t *dd = hds->ds_dir;
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2774 dsl_pool_t *dp = hds->ds_dir->dd_pool;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2775 dsl_dir_t *odd = NULL;
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2776 uint64_t oldnext_obj;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2777 int64_t delta;
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2778
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2779 ASSERT(0 == (hds->ds_phys->ds_flags & DS_FLAG_NOPROMOTE));
712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2780
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2781 snap = list_head(&pa->origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2782 origin_head = snap->ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2783
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2784 /*
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2785 * We need to explicitly open odd, since origin_ds's dd will be
2417 694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2786 * changing.
694d5de97348 6444346 zfs promote fails in zone ahrens parents: 2207 diff changeset	2787 */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2788 VERIFY(0 == dsl_dir_open_obj(dp, origin_ds->ds_dir->dd_object,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2789 NULL, FTAG, &odd));
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2790
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2791 /* change origin's next snap */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2792 dmu_buf_will_dirty(origin_ds->ds_dbuf, tx);
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2793 oldnext_obj = origin_ds->ds_phys->ds_next_snap_obj;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2794 snap = list_tail(&pa->clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2795 ASSERT3U(snap->ds->ds_phys->ds_prev_snap_obj, ==, origin_ds->ds_object);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2796 origin_ds->ds_phys->ds_next_snap_obj = snap->ds->ds_object;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2797
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2798 /* change the origin's next clone */
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2799 if (origin_ds->ds_phys->ds_next_clones_obj) {
10801 e0bf032e8673 6822816 assertion failed: zap_remove_int(ds_next_clones_obj) returns ENOENT Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10799 diff changeset	2800 remove_from_next_clones(origin_ds, snap->ds->ds_object, tx);
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2801 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2802 origin_ds->ds_phys->ds_next_clones_obj,
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2803 oldnext_obj, tx));
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2804 }
361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	2805
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2806 /* change origin */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2807 dmu_buf_will_dirty(dd->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2808 ASSERT3U(dd->dd_phys->dd_origin_obj, ==, origin_ds->ds_object);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2809 dd->dd_phys->dd_origin_obj = odd->dd_phys->dd_origin_obj;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2810 dd->dd_origin_txg = origin_head->ds_dir->dd_origin_txg;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2811 dmu_buf_will_dirty(odd->dd_dbuf, tx);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2812 odd->dd_phys->dd_origin_obj = origin_ds->ds_object;
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2813 origin_head->ds_dir->dd_origin_txg =
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	2814 origin_ds->ds_phys->ds_creation_txg;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2815
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2816 /* change dd_clone entries */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2817 if (spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2818 VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2819 odd->dd_phys->dd_clones, hds->ds_object, tx));
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2820 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2821 pa->origin_origin->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2822 hds->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2823
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2824 VERIFY3U(0, ==, zap_remove_int(dp->dp_meta_objset,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2825 pa->origin_origin->ds_dir->dd_phys->dd_clones,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2826 origin_head->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2827 if (dd->dd_phys->dd_clones == 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2828 dd->dd_phys->dd_clones = zap_create(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2829 DMU_OT_DSL_CLONES, DMU_OT_NONE, 0, tx);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2830 }
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2831 VERIFY3U(0, ==, zap_add_int(dp->dp_meta_objset,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2832 dd->dd_phys->dd_clones, origin_head->ds_object, tx));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2833
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2834 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2835
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2836 /* move snapshots to this dir */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2837 for (snap = list_head(&pa->shared_snaps); snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2838 snap = list_next(&pa->shared_snaps, snap)) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2839 dsl_dataset_t *ds = snap->ds;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2840
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	2841 /* unregister props as dsl_dir is changing */
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2842 if (ds->ds_objset) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2843 dmu_objset_evict(ds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	2844 ds->ds_objset = NULL;
7237 f47d41541b14 PSARC 2008/393 zfs primarycache and secondarycache properties ek110237 parents: 7077 diff changeset	2845 }
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2846 /* move snap name entry */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2847 VERIFY(0 == dsl_dataset_get_snapname(ds));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2848 VERIFY(0 == dsl_dataset_snap_remove(origin_head,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	2849 ds->ds_snapname, tx));
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2850 VERIFY(0 == zap_add(dp->dp_meta_objset,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2851 hds->ds_phys->ds_snapnames_zapobj, ds->ds_snapname,
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2852 8, 1, &ds->ds_object, tx));
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2853
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2854 /* change containing dsl_dir */
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2855 dmu_buf_will_dirty(ds->ds_dbuf, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2856 ASSERT3U(ds->ds_phys->ds_dir_obj, ==, odd->dd_object);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2857 ds->ds_phys->ds_dir_obj = dd->dd_object;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2858 ASSERT3P(ds->ds_dir, ==, odd);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2859 dsl_dir_close(ds->ds_dir, ds);
2199 712a788c2dfd PSARC 2006/388 snapshot -r ahrens parents: 2082 diff changeset	2860 VERIFY(0 == dsl_dir_open_obj(dp, dd->dd_object,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2861 NULL, ds, &ds->ds_dir));
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2862
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2863 /* move any clone references */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2864 if (ds->ds_phys->ds_next_clones_obj &&
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2865 spa_version(dp->dp_spa) >= SPA_VERSION_DIR_CLONES) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2866 zap_cursor_t zc;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2867 zap_attribute_t za;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2868
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2869 for (zap_cursor_init(&zc, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2870 ds->ds_phys->ds_next_clones_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2871 zap_cursor_retrieve(&zc, &za) == 0;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2872 zap_cursor_advance(&zc)) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2873 dsl_dataset_t *cnds;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2874 uint64_t o;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2875
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2876 if (za.za_first_integer == oldnext_obj) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2877 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2878 * We've already moved the
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2879 * origin's reference.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2880 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2881 continue;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2882 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2883
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	2884 VERIFY3U(0, ==, dsl_dataset_hold_obj(dp,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2885 za.za_first_integer, FTAG, &cnds));
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2886 o = cnds->ds_dir->dd_phys->dd_head_dataset_obj;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2887
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2888 VERIFY3U(zap_remove_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2889 odd->dd_phys->dd_clones, o, tx), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2890 VERIFY3U(zap_add_int(dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2891 dd->dd_phys->dd_clones, o, tx), ==, 0);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2892 dsl_dataset_rele(cnds, FTAG);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2893 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2894 zap_cursor_fini(&zc);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2895 }
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2896
13805 e3a9ae14a119 3006 VERIFY[S,U,P] and ASSERT[S,U,P] frequently check if first argument is zero Madhav Suresh <madhav.suresh@delphix.com> parents: 13790 diff changeset	2897 ASSERT0(dsl_prop_numcb(ds));
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2898 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2899
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2900 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2901 * Change space accounting.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2902 * Note, pa->*usedsnap and dd_used_breakdown[SNAP] will either
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2903 * both be valid, or both be 0 (resulting in delta == 0). This
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2904 * is true for each of {clone,origin} independently.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2905 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2906
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2907 delta = pa->cloneusedsnap -
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2908 dd->dd_phys->dd_used_breakdown[DD_USED_SNAP];
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2909 ASSERT3S(delta, >=, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2910 ASSERT3U(pa->used, >=, delta);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2911 dsl_dir_diduse_space(dd, DD_USED_SNAP, delta, 0, 0, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2912 dsl_dir_diduse_space(dd, DD_USED_HEAD,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2913 pa->used - delta, pa->comp, pa->uncomp, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2914
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2915 delta = pa->originusedsnap -
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2916 odd->dd_phys->dd_used_breakdown[DD_USED_SNAP];
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2917 ASSERT3S(delta, <=, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2918 ASSERT3U(pa->used, >=, -delta);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2919 dsl_dir_diduse_space(odd, DD_USED_SNAP, delta, 0, 0, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2920 dsl_dir_diduse_space(odd, DD_USED_HEAD,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2921 -pa->used - delta, -pa->comp, -pa->uncomp, tx);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2922
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2923 origin_ds->ds_phys->ds_unique_bytes = pa->unique;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2924
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2925 /* log history record */
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	2926 spa_history_log_internal_ds(hds, "promote", tx, "");
4543 12bb2876a62e PSARC/2006/465 ZFS Delegated Administration marks parents: 4009 diff changeset	2927
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	2928 dsl_dir_close(odd, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2929 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	2930
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2931 static char *snaplist_tag = "snaplist";
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2932 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2933 * Make a list of dsl_dataset_t's for the snapshots between first_obj
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2934 * (exclusive) and last_obj (inclusive). The list will be in reverse
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2935 * order (last_obj will be the list_head()). If first_obj == 0, do all
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2936 * snapshots back to this dataset's origin.
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2937 */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2938 static int
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2939 snaplist_make(dsl_pool_t *dp, boolean_t own,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2940 uint64_t first_obj, uint64_t last_obj, list_t *l)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2941 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2942 uint64_t obj = last_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2943
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2944 ASSERT(RW_LOCK_HELD(&dp->dp_config_rwlock));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2945
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2946 list_create(l, sizeof (struct promotenode),
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2947 offsetof(struct promotenode, link));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2948
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2949 while (obj != first_obj) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2950 dsl_dataset_t *ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2951 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2952 int err;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2953
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2954 if (own) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2955 err = dsl_dataset_own_obj(dp, obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2956 0, snaplist_tag, &ds);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2957 if (err == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2958 dsl_dataset_make_exclusive(ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2959 } else {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2960 err = dsl_dataset_hold_obj(dp, obj, snaplist_tag, &ds);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2961 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2962 if (err == ENOENT) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2963 /* lost race with snapshot destroy */
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2964 struct promotenode *last = list_tail(l);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2965 ASSERT(obj != last->ds->ds_phys->ds_prev_snap_obj);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2966 obj = last->ds->ds_phys->ds_prev_snap_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2967 continue;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2968 } else if (err) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2969 return (err);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2970 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2971
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2972 if (first_obj == 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2973 first_obj = ds->ds_dir->dd_phys->dd_origin_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2974
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2975 snap = kmem_alloc(sizeof (struct promotenode), KM_SLEEP);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2976 snap->ds = ds;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2977 list_insert_tail(l, snap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2978 obj = ds->ds_phys->ds_prev_snap_obj;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2979 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2980
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2981 return (0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2982 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2983
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2984 static int
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2985 snaplist_space(list_t l, uint64_t mintxg, uint64_t spacep)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2986 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2987 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2988
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2989 *spacep = 0;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2990 for (snap = list_head(l); snap; snap = list_next(l, snap)) {
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2991 uint64_t used, comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2992 dsl_deadlist_space_range(&snap->ds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	2993 mintxg, UINT64_MAX, &used, &comp, &uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2994 *spacep += used;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2995 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2996 return (0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2997 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2998
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	2999 static void
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3000 snaplist_destroy(list_t *l, boolean_t own)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3001 {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3002 struct promotenode *snap;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3003
8779 f164e0e90508 6784924 panic while ludelete (zfs destroy) Mark J Musante <Mark.Musante@Sun.COM> parents: 8746 diff changeset	3004 if (!l \|\| !list_link_active(&l->list_head))
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3005 return;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3006
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3007 while ((snap = list_tail(l)) != NULL) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3008 list_remove(l, snap);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3009 if (own)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3010 dsl_dataset_disown(snap->ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3011 else
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3012 dsl_dataset_rele(snap->ds, snaplist_tag);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3013 kmem_free(snap, sizeof (struct promotenode));
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3014 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3015 list_destroy(l);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3016 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3017
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3018 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3019 * Promote a clone. Nomenclature note:
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3020 * "clone" or "cds": the original clone which is being promoted
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3021 * "origin" or "ods": the snapshot which is originally clone's origin
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3022 * "origin head" or "ohds": the dataset which is the head
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3023 * (filesystem/volume) for the origin
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3024 * "origin origin": the origin of the origin's filesystem (typically
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3025 * NULL, indicating that the clone is not a clone of a clone).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3026 */
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3027 int
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	3028 dsl_dataset_promote(const char name, char conflsnap)
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3029 {
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3030 dsl_dataset_t *ds;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3031 dsl_dir_t *dd;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3032 dsl_pool_t *dp;
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3033 dmu_object_info_t doi;
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3034 struct promotearg pa = { 0 };
7046 361307ae060d 6343667 scrub/resilver has to start over when a snapshot is taken ahrens parents: 6992 diff changeset	3035 struct promotenode *snap;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3036 int err;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3037
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3038 err = dsl_dataset_hold(name, FTAG, &ds);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3039 if (err)
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3040 return (err);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3041 dd = ds->ds_dir;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3042 dp = dd->dd_pool;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3043
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3044 err = dmu_object_info(dp->dp_meta_objset,
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3045 ds->ds_phys->ds_snapnames_zapobj, &doi);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3046 if (err) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3047 dsl_dataset_rele(ds, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3048 return (err);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3049 }
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3050
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3051 if (dsl_dataset_is_snapshot(ds) \|\| dd->dd_phys->dd_origin_obj == 0) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3052 dsl_dataset_rele(ds, FTAG);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3053 return (EINVAL);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3054 }
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3055
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3056 /*
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3057 * We are going to inherit all the snapshots taken before our
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3058 * origin (i.e., our new origin will be our parent's origin).
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3059 * Take ownership of them so that we can rename them into our
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3060 * namespace.
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3061 */
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3062 rw_enter(&dp->dp_config_rwlock, RW_READER);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3063
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3064 err = snaplist_make(dp, B_TRUE, 0, dd->dd_phys->dd_origin_obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3065 &pa.shared_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3066 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3067 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3068
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3069 err = snaplist_make(dp, B_FALSE, 0, ds->ds_object, &pa.clone_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3070 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3071 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3072
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3073 snap = list_head(&pa.shared_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3074 ASSERT3U(snap->ds->ds_object, ==, dd->dd_phys->dd_origin_obj);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3075 err = snaplist_make(dp, B_FALSE, dd->dd_phys->dd_origin_obj,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3076 snap->ds->ds_dir->dd_phys->dd_head_dataset_obj, &pa.origin_snaps);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3077 if (err != 0)
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3078 goto out;
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3079
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3080 if (snap->ds->ds_dir->dd_phys->dd_origin_obj != 0) {
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3081 err = dsl_dataset_hold_obj(dp,
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3082 snap->ds->ds_dir->dd_phys->dd_origin_obj,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3083 FTAG, &pa.origin_origin);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3084 if (err != 0)
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3085 goto out;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3086 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3087
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3088 out:
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3089 rw_exit(&dp->dp_config_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3090
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3091 /*
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3092 * Add in 128x the snapnames zapobj size, since we will be moving
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3093 * a bunch of snapnames to the promoted ds, and dirtying their
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3094 * bonus buffers.
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3095 */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3096 if (err == 0) {
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3097 err = dsl_sync_task_do(dp, dsl_dataset_promote_check,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3098 dsl_dataset_promote_sync, ds, &pa,
10922 e2081f502306 PSARC 2009/571 ZFS Deduplication Properties Jeff Bonwick <Jeff.Bonwick@Sun.COM> parents: 10816 diff changeset	3099 2 + 2 * doi.doi_physical_blocks_512);
10588 dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	3100 if (err && pa.err_ds && conflsnap)
dc03f981ea18 6438937 if 'zfs destroy' fails, it can leave a zvol device link missing Eric Taylor <Eric.Taylor@Sun.COM> parents: 10575 diff changeset	3101 (void) strncpy(conflsnap, pa.err_ds, MAXNAMELEN);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3102 }
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3103
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3104 snaplist_destroy(&pa.shared_snaps, B_TRUE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3105 snaplist_destroy(&pa.clone_snaps, B_FALSE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3106 snaplist_destroy(&pa.origin_snaps, B_FALSE);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3107 if (pa.origin_origin)
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3108 dsl_dataset_rele(pa.origin_origin, FTAG);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3109 dsl_dataset_rele(ds, FTAG);
2082 76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3110 return (err);
76b439ec3ac1 PSARC 2006/223 ZFS Hot Spares eschrock parents: 1758 diff changeset	3111 }
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3112
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3113 struct cloneswaparg {
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3114 dsl_dataset_t cds; / clone dataset */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3115 dsl_dataset_t ohds; / origin's head dataset */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3116 boolean_t force;
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3117 int64_t unused_refres_delta; /* change in unconsumed refreservation */
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3118 };
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3119
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3120 /* ARGSUSED */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3121 static int
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3122 dsl_dataset_clone_swap_check(void arg1, void arg2, dmu_tx_t *tx)
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3123 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3124 struct cloneswaparg *csa = arg1;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3125
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3126 /* they should both be heads */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3127 if (dsl_dataset_is_snapshot(csa->cds) \|\|
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3128 dsl_dataset_is_snapshot(csa->ohds))
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3129 return (EINVAL);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3130
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3131 /* the branch point should be just before them */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3132 if (csa->cds->ds_prev != csa->ohds->ds_prev)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3133 return (EINVAL);
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3134
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3135 /* cds should be the clone (unless they are unrelated) */
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3136 if (csa->cds->ds_prev != NULL &&
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3137 csa->cds->ds_prev != csa->cds->ds_dir->dd_pool->dp_origin_snap &&
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3138 csa->ohds->ds_object !=
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3139 csa->cds->ds_prev->ds_phys->ds_next_snap_obj)
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3140 return (EINVAL);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3141
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3142 /* the clone should be a child of the origin */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3143 if (csa->cds->ds_dir->dd_parent != csa->ohds->ds_dir)
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3144 return (EINVAL);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3145
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3146 /* ohds shouldn't be modified unless 'force' */
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3147 if (!csa->force && dsl_dataset_modified_since_lastsnap(csa->ohds))
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3148 return (ETXTBSY);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3149
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3150 /* adjust amount of any unconsumed refreservation */
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3151 csa->unused_refres_delta =
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3152 (int64_t)MIN(csa->ohds->ds_reserved,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3153 csa->ohds->ds_phys->ds_unique_bytes) -
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3154 (int64_t)MIN(csa->ohds->ds_reserved,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3155 csa->cds->ds_phys->ds_unique_bytes);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3156
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3157 if (csa->unused_refres_delta > 0 &&
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3158 csa->unused_refres_delta >
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3159 dsl_dir_space_available(csa->ohds->ds_dir, NULL, 0, TRUE))
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3160 return (ENOSPC);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3161
10799 395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3162 if (csa->ohds->ds_quota != 0 &&
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3163 csa->cds->ds_phys->ds_unique_bytes > csa->ohds->ds_quota)
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3164 return (EDQUOT);
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3165
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3166 return (0);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3167 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3168
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3169 /* ARGSUSED */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3170 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3171 dsl_dataset_clone_swap_sync(void arg1, void arg2, dmu_tx_t *tx)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3172 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3173 struct cloneswaparg *csa = arg1;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3174 dsl_pool_t *dp = csa->cds->ds_dir->dd_pool;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3175
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3176 ASSERT(csa->cds->ds_reserved == 0);
10799 395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3177 ASSERT(csa->ohds->ds_quota == 0 \|\|
395576ddfea9 6881321 zfs test rsend_012_pos panics when running daily.0807 archives Chris Kirby <Chris.Kirby@sun.com> parents: 10588 diff changeset	3178 csa->cds->ds_phys->ds_unique_bytes <= csa->ohds->ds_quota);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3179
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3180 dmu_buf_will_dirty(csa->cds->ds_dbuf, tx);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3181 dmu_buf_will_dirty(csa->ohds->ds_dbuf, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3182
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3183 if (csa->cds->ds_objset != NULL) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3184 dmu_objset_evict(csa->cds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3185 csa->cds->ds_objset = NULL;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3186 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3187
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3188 if (csa->ohds->ds_objset != NULL) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3189 dmu_objset_evict(csa->ohds->ds_objset);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3190 csa->ohds->ds_objset = NULL;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3191 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3192
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3193 /*
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3194 * Reset origin's unique bytes, if it exists.
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3195 */
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3196 if (csa->cds->ds_prev) {
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3197 dsl_dataset_t *origin = csa->cds->ds_prev;
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3198 uint64_t comp, uncomp;
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3199
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3200 dmu_buf_will_dirty(origin->ds_dbuf, tx);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3201 dsl_deadlist_space_range(&csa->cds->ds_deadlist,
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3202 origin->ds_phys->ds_prev_snap_txg, UINT64_MAX,
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3203 &origin->ds_phys->ds_unique_bytes, &comp, &uncomp);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3204 }
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3205
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3206 /* swap blkptrs */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3207 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3208 blkptr_t tmp;
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3209 tmp = csa->ohds->ds_phys->ds_bp;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3210 csa->ohds->ds_phys->ds_bp = csa->cds->ds_phys->ds_bp;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3211 csa->cds->ds_phys->ds_bp = tmp;
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3212 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3213
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3214 /* set dd__bytes /
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3215 {
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3216 int64_t dused, dcomp, duncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3217 uint64_t cdl_used, cdl_comp, cdl_uncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3218 uint64_t odl_used, odl_comp, odl_uncomp;
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3219
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3220 ASSERT3U(csa->cds->ds_dir->dd_phys->
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3221 dd_used_breakdown[DD_USED_SNAP], ==, 0);
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3222
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3223 dsl_deadlist_space(&csa->cds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3224 &cdl_used, &cdl_comp, &cdl_uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3225 dsl_deadlist_space(&csa->ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3226 &odl_used, &odl_comp, &odl_uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3227
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3228 dused = csa->cds->ds_phys->ds_referenced_bytes + cdl_used -
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3229 (csa->ohds->ds_phys->ds_referenced_bytes + odl_used);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3230 dcomp = csa->cds->ds_phys->ds_compressed_bytes + cdl_comp -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3231 (csa->ohds->ds_phys->ds_compressed_bytes + odl_comp);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3232 duncomp = csa->cds->ds_phys->ds_uncompressed_bytes +
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3233 cdl_uncomp -
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3234 (csa->ohds->ds_phys->ds_uncompressed_bytes + odl_uncomp);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3235
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3236 dsl_dir_diduse_space(csa->ohds->ds_dir, DD_USED_HEAD,
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3237 dused, dcomp, duncomp, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3238 dsl_dir_diduse_space(csa->cds->ds_dir, DD_USED_HEAD,
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3239 -dused, -dcomp, -duncomp, tx);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3240
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3241 /*
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3242 * The difference in the space used by snapshots is the
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3243 * difference in snapshot space due to the head's
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3244 * deadlist (since that's the only thing that's
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3245 * changing that affects the snapused).
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3246 */
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3247 dsl_deadlist_space_range(&csa->cds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3248 csa->ohds->ds_dir->dd_origin_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3249 &cdl_used, &cdl_comp, &cdl_uncomp);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3250 dsl_deadlist_space_range(&csa->ohds->ds_deadlist,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3251 csa->ohds->ds_dir->dd_origin_txg, UINT64_MAX,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3252 &odl_used, &odl_comp, &odl_uncomp);
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3253 dsl_dir_transfer_space(csa->ohds->ds_dir, cdl_used - odl_used,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3254 DD_USED_HEAD, DD_USED_SNAP, tx);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3255 }
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3256
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3257 /* swap ds__bytes /
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3258 SWITCH64(csa->ohds->ds_phys->ds_referenced_bytes,
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3259 csa->cds->ds_phys->ds_referenced_bytes);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3260 SWITCH64(csa->ohds->ds_phys->ds_compressed_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3261 csa->cds->ds_phys->ds_compressed_bytes);
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3262 SWITCH64(csa->ohds->ds_phys->ds_uncompressed_bytes,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3263 csa->cds->ds_phys->ds_uncompressed_bytes);
5481 1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3264 SWITCH64(csa->ohds->ds_phys->ds_unique_bytes,
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3265 csa->cds->ds_phys->ds_unique_bytes);
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3266
1364fb7de75d 6619182 new non-sparse zvols should get refreservations ck153898 parents: 5475 diff changeset	3267 /* apply any parent delta for change in unconsumed refreservation */
7390 6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3268 dsl_dir_diduse_space(csa->ohds->ds_dir, DD_USED_REFRSRV,
6d408f0a5fbd PSARC/2008/518 ZFS space accounting enhancements Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7385 diff changeset	3269 csa->unused_refres_delta, 0, 0, tx);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3270
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3271 /*
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3272 * Swap deadlists.
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3273 */
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3274 dsl_deadlist_close(&csa->cds->ds_deadlist);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3275 dsl_deadlist_close(&csa->ohds->ds_deadlist);
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3276 SWITCH64(csa->ohds->ds_phys->ds_deadlist_obj,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3277 csa->cds->ds_phys->ds_deadlist_obj);
12470 54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3278 dsl_deadlist_open(&csa->cds->ds_deadlist, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3279 csa->cds->ds_phys->ds_deadlist_obj);
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3280 dsl_deadlist_open(&csa->ohds->ds_deadlist, dp->dp_meta_objset,
54258108784b 6948890 snapshot deletion can induce pathologically long spa_sync() times Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 12450 diff changeset	3281 csa->ohds->ds_phys->ds_deadlist_obj);
7837 001de5627df3 6333409 traversal code should be able to issue multiple reads in parallel Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7754 diff changeset	3282
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3283 dsl_scan_ds_clone_swapped(csa->ohds, csa->cds, tx);
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3284
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3285 spa_history_log_internal_ds(csa->cds, "clone swap", tx,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3286 "parent=%s", csa->ohds->ds_dir->dd_myname);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3287 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3288
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3289 /*
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3290 * Swap 'clone' with its origin head datasets. Used at the end of "zfs
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3291 * recv" into an existing fs to swizzle the file system to the new
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3292 * version, and by "zfs rollback". Can also be used to swap two
a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3293 * independent head datasets if neither has any snapshots.
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3294 */
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3295 int
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3296 dsl_dataset_clone_swap(dsl_dataset_t clone, dsl_dataset_t origin_head,
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3297 boolean_t force)
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3298 {
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3299 struct cloneswaparg csa;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3300 int error;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3301
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3302 ASSERT(clone->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3303 ASSERT(origin_head->ds_owner);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3304 retry:
12711 7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3305 /*
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3306 * Need exclusive access for the swap. If we're swapping these
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3307 * datasets back after an error, we already hold the locks.
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3308 */
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3309 if (!RW_WRITE_HELD(&clone->ds_rwlock))
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3310 rw_enter(&clone->ds_rwlock, RW_WRITER);
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3311 if (!RW_WRITE_HELD(&origin_head->ds_rwlock) &&
7ba0ca9a0395 6952867 recursive rw_enter in dsl_dataset_clone_swap Chris Kirby <Chris.Kirby@oracle.com> parents: 12687 diff changeset	3312 !rw_tryenter(&origin_head->ds_rwlock, RW_WRITER)) {
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3313 rw_exit(&clone->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3314 rw_enter(&origin_head->ds_rwlock, RW_WRITER);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3315 if (!rw_tryenter(&clone->ds_rwlock, RW_WRITER)) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3316 rw_exit(&origin_head->ds_rwlock);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3317 goto retry;
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3318 }
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3319 }
5367 c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3320 csa.cds = clone;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3321 csa.ohds = origin_head;
c40abbe796be PSARC/2007/574 zfs send -R ahrens parents: 5326 diff changeset	3322 csa.force = force;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3323 error = dsl_sync_task_do(clone->ds_dir->dd_pool,
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3324 dsl_dataset_clone_swap_check,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3325 dsl_dataset_clone_swap_sync, &csa, NULL, 9);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3326 return (error);
5326 6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3327 }
6752aa2bd5bc 6425096 want online 'zfs recv' (read only and read/write) ek110237 parents: 5094 diff changeset	3328
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3329 /*
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3330 * Given a pool name and a dataset object number in that pool,
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3331 * return the name of that dataset.
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3332 */
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3333 int
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3334 dsl_dsobj_to_dsname(char pname, uint64_t obj, char buf)
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3335 {
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3336 spa_t *spa;
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3337 dsl_pool_t *dp;
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3338 dsl_dataset_t *ds;
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3339 int error;
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3340
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3341 if ((error = spa_open(pname, &spa, FTAG)) != 0)
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3342 return (error);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3343 dp = spa_get_dsl(spa);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3344 rw_enter(&dp->dp_config_rwlock, RW_READER);
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3345 if ((error = dsl_dataset_hold_obj(dp, obj, FTAG, &ds)) == 0) {
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3346 dsl_dataset_name(ds, buf);
47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3347 dsl_dataset_rele(ds, FTAG);
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3348 }
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3349 rw_exit(&dp->dp_config_rwlock);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3350 spa_close(spa, FTAG);
f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3351
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3352 return (error);
3912 f6891a60bd72 PSARC 2007/083 ZFS bootable datasets lling parents: 3547 diff changeset	3353 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3354
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3355 int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3356 dsl_dataset_check_quota(dsl_dataset_t *ds, boolean_t check_quota,
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3357 uint64_t asize, uint64_t inflight, uint64_t used, uint64_t ref_rsrv)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3358 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3359 int error = 0;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3360
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3361 ASSERT3S(asize, >, 0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3362
5831 48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3363 /*
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3364 * *ref_rsrv is the portion of asize that will come from any
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3365 * unconsumed refreservation space.
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3366 */
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3367 *ref_rsrv = 0;
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3368
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3369 mutex_enter(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3370 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3371 * Make a space adjustment for reserved bytes.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3372 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3373 if (ds->ds_reserved > ds->ds_phys->ds_unique_bytes) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3374 ASSERT3U(*used, >=,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3375 ds->ds_reserved - ds->ds_phys->ds_unique_bytes);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3376 *used -= (ds->ds_reserved - ds->ds_phys->ds_unique_bytes);
5831 48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3377 *ref_rsrv =
48655d6b290b 6630761 In sub-filesystem, available space is less than refreservation space ck153898 parents: 5712 diff changeset	3378 asize - MIN(asize, parent_delta(ds, asize + inflight));
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3379 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3380
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3381 if (!check_quota \|\| ds->ds_quota == 0) {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3382 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3383 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3384 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3385 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3386 * If they are requesting more space, and our current estimate
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3387 * is over quota, they get to try again unless the actual
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3388 * on-disk is over quota and there are no pending changes (which
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3389 * may free up space for us).
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3390 */
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3391 if (ds->ds_phys->ds_referenced_bytes + inflight >= ds->ds_quota) {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3392 if (inflight > 0 \|\|
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3393 ds->ds_phys->ds_referenced_bytes < ds->ds_quota)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3394 error = ERESTART;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3395 else
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3396 error = EDQUOT;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3397 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3398 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3399
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3400 return (error);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3401 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3402
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3403 /* ARGSUSED */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3404 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3405 dsl_dataset_set_quota_check(void arg1, void arg2, dmu_tx_t *tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3406 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3407 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3408 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3409 int err;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3410
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3411 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_REFQUOTA)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3412 return (ENOTSUP);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3413
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3414 if ((err = dsl_prop_predict_sync(ds->ds_dir, psa)) != 0)
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3415 return (err);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3416
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3417 if (psa->psa_effective_value == 0)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3418 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3419
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	3420 if (psa->psa_effective_value < ds->ds_phys->ds_referenced_bytes \|\|
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3421 psa->psa_effective_value < ds->ds_reserved)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3422 return (ENOSPC);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3423
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3424 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3425 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3426
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3427 extern void dsl_prop_set_sync(void , void , dmu_tx_t *);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3428
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3429 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3430 dsl_dataset_set_quota_sync(void arg1, void arg2, dmu_tx_t *tx)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3431 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3432 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3433 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3434 uint64_t effective_value = psa->psa_effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3435
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3436 dsl_prop_set_sync(ds, psa, tx);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3437 DSL_PROP_CHECK_PREDICTION(ds->ds_dir, psa);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3438
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3439 if (ds->ds_quota != effective_value) {
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3440 dmu_buf_will_dirty(ds->ds_dbuf, tx);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3441 ds->ds_quota = effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3442 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3443 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3444
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3445 int
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3446 dsl_dataset_set_quota(const char *dsname, zprop_source_t source, uint64_t quota)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3447 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3448 dsl_dataset_t *ds;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3449 dsl_prop_setarg_t psa;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3450 int err;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3451
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3452 dsl_prop_setarg_init_uint64(&psa, "refquota", source, &quota);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3453
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3454 err = dsl_dataset_hold(dsname, FTAG, &ds);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3455 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3456 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3457
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3458 /*
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3459 * If someone removes a file, then tries to set the quota, we
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3460 * want to make sure the file freeing takes effect.
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3461 */
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3462 txg_wait_open(ds->ds_dir->dd_pool, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3463
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3464 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3465 dsl_dataset_set_quota_check, dsl_dataset_set_quota_sync,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3466 ds, &psa, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3467
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3468 dsl_dataset_rele(ds, FTAG);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3469 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3470 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3471
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3472 static int
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3473 dsl_dataset_set_reservation_check(void arg1, void arg2, dmu_tx_t *tx)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3474 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3475 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3476 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3477 uint64_t effective_value;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3478 uint64_t unique;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3479 int err;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3480
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3481 if (spa_version(ds->ds_dir->dd_pool->dp_spa) <
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3482 SPA_VERSION_REFRESERVATION)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3483 return (ENOTSUP);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3484
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3485 if (dsl_dataset_is_snapshot(ds))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3486 return (EINVAL);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3487
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3488 if ((err = dsl_prop_predict_sync(ds->ds_dir, psa)) != 0)
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3489 return (err);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3490
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3491 effective_value = psa->psa_effective_value;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3492
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3493 /*
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3494 * If we are doing the preliminary check in open context, the
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3495 * space estimates may be inaccurate.
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3496 */
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3497 if (!dmu_tx_is_syncing(tx))
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3498 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3499
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3500 mutex_enter(&ds->ds_lock);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3501 if (!DS_UNIQUE_IS_ACCURATE(ds))
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3502 dsl_dataset_recalc_head_uniq(ds);
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3503 unique = ds->ds_phys->ds_unique_bytes;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3504 mutex_exit(&ds->ds_lock);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3505
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3506 if (MAX(unique, effective_value) > MAX(unique, ds->ds_reserved)) {
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3507 uint64_t delta = MAX(unique, effective_value) -
8525 e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3508 MAX(unique, ds->ds_reserved);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3509
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3510 if (delta > dsl_dir_space_available(ds->ds_dir, NULL, 0, TRUE))
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3511 return (ENOSPC);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3512 if (ds->ds_quota > 0 &&
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3513 effective_value > ds->ds_quota)
8525 e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3514 return (ENOSPC);
e0e0e525d0f8 6788830 set large value to reservation cause core dump Eric Schrock <Eric.Schrock@Sun.COM> parents: 8517 diff changeset	3515 }
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3516
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3517 return (0);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3518 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3519
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3520 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3521 dsl_dataset_set_reservation_sync(void arg1, void arg2, dmu_tx_t *tx)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3522 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3523 dsl_dataset_t *ds = arg1;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3524 dsl_prop_setarg_t *psa = arg2;
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3525 uint64_t effective_value = psa->psa_effective_value;
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3526 uint64_t unique;
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3527 int64_t delta;
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3528
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3529 dsl_prop_set_sync(ds, psa, tx);
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3530 DSL_PROP_CHECK_PREDICTION(ds->ds_dir, psa);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3531
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3532 dmu_buf_will_dirty(ds->ds_dbuf, tx);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3533
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3534 mutex_enter(&ds->ds_dir->dd_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3535 mutex_enter(&ds->ds_lock);
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3536 ASSERT(DS_UNIQUE_IS_ACCURATE(ds));
7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3537 unique = ds->ds_phys->ds_unique_bytes;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3538 delta = MAX(0, (int64_t)(effective_value - unique)) -
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3539 MAX(0, (int64_t)(ds->ds_reserved - unique));
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3540 ds->ds_reserved = effective_value;
7595 2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3541 mutex_exit(&ds->ds_lock);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3542
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3543 dsl_dir_diduse_space(ds->ds_dir, DD_USED_REFRSRV, delta, 0, 0, tx);
2ff5700c7efc 6747355 finish closing race condition when setting refreservation Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 7525 diff changeset	3544 mutex_exit(&ds->ds_dir->dd_lock);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3545 }
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3546
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3547 int
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3548 dsl_dataset_set_reservation(const char *dsname, zprop_source_t source,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3549 uint64_t reservation)
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3550 {
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3551 dsl_dataset_t *ds;
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3552 dsl_prop_setarg_t psa;
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3553 int err;
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3554
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3555 dsl_prop_setarg_init_uint64(&psa, "refreservation", source,
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3556 &reservation);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3557
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3558 err = dsl_dataset_hold(dsname, FTAG, &ds);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3559 if (err)
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3560 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3561
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3562 err = dsl_sync_task_do(ds->ds_dir->dd_pool,
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3563 dsl_dataset_set_reservation_check,
11022 63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3564 dsl_dataset_set_reservation_sync, ds, &psa, 0);
63ab26072e41 PSARC 2009/510 ZFS received properties Tom Erickson <Tom.Erickson@Sun.COM> parents: 10951 diff changeset	3565
6689 47572a2f5e73 6610506 Eliminate or improve retry logic from callers of dmu_objset_open() maybee parents: 6643 diff changeset	3566 dsl_dataset_rele(ds, FTAG);
5378 111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3567 return (err);
111aa1baa84a PSARC 2007/555 zfs fs-only quotas and reservations ck153898 parents: 5367 diff changeset	3568 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3569
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3570 typedef struct zfs_hold_cleanup_arg {
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3571 dsl_pool_t *dp;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3572 uint64_t dsobj;
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3573 char htag[MAXNAMELEN];
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3574 } zfs_hold_cleanup_arg_t;
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3575
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3576 static void
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3577 dsl_dataset_user_release_onexit(void *arg)
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3578 {
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3579 zfs_hold_cleanup_arg_t *ca = arg;
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3580
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3581 (void) dsl_dataset_user_release_tmp(ca->dp, ca->dsobj, ca->htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3582 B_TRUE);
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3583 kmem_free(ca, sizeof (zfs_hold_cleanup_arg_t));
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3584 }
693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3585
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3586 void
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3587 dsl_register_onexit_hold_cleanup(dsl_dataset_t ds, const char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3588 minor_t minor)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3589 {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3590 zfs_hold_cleanup_arg_t *ca;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3591
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3592 ca = kmem_alloc(sizeof (zfs_hold_cleanup_arg_t), KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3593 ca->dp = ds->ds_dir->dd_pool;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3594 ca->dsobj = ds->ds_object;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3595 (void) strlcpy(ca->htag, htag, sizeof (ca->htag));
13765 9410cf539b11 backout 3006: causes 3046 (panics after mounting root) Richard Lowe <richlowe@richlowe.net> parents: 13764 diff changeset	3596 VERIFY3U(0, ==, zfs_onexit_add_cb(minor,
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3597 dsl_dataset_user_release_onexit, ca, NULL));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3598 }
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3599
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3600 /*
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3601 * If you add new checks here, you may need to add
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3602 * additional checks to the "temporary" case in
8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3603 * snapshot_check() in dmu_objset.c.
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3604 */
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3605 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3606 dsl_dataset_user_hold_check(void arg1, void arg2, dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3607 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3608 dsl_dataset_t *ds = arg1;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3609 struct dsl_ds_holdarg *ha = arg2;
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3610 const char *htag = ha->htag;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3611 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3612 int error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3613
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3614 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3615 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3616
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3617 if (!dsl_dataset_is_snapshot(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3618 return (EINVAL);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3619
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3620 /* tags must be unique */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3621 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3622 if (ds->ds_phys->ds_userrefs_obj) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3623 error = zap_lookup(mos, ds->ds_phys->ds_userrefs_obj, htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3624 8, 1, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3625 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3626 error = EEXIST;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3627 else if (error == ENOENT)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3628 error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3629 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3630 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3631
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3632 if (error == 0 && ha->temphold &&
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3633 strlen(htag) + MAX_TAG_PREFIX_LEN >= MAXNAMELEN)
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3634 error = E2BIG;
56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3635
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3636 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3637 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3638
13055 8c712bbb18ea PSARC 2010/105 zfs diff Tim Haley <Tim.Haley@Sun.COM> parents: 12982 diff changeset	3639 void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3640 dsl_dataset_user_hold_sync(void arg1, void arg2, dmu_tx_t *tx)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3641 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3642 dsl_dataset_t *ds = arg1;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3643 struct dsl_ds_holdarg *ha = arg2;
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3644 const char *htag = ha->htag;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3645 dsl_pool_t *dp = ds->ds_dir->dd_pool;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3646 objset_t *mos = dp->dp_meta_objset;
10951 56fd5475e8fe 6896756 assertion failed: 0 == dsl_pool_user_hold(dp, ds->ds_object, htag, &now, tx) Chris Kirby <Chris.Kirby@sun.com> parents: 10922 diff changeset	3647 uint64_t now = gethrestime_sec();
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3648 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3649
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3650 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3651 if (ds->ds_phys->ds_userrefs_obj == 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3652 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3653 * This is the first user hold for this dataset. Create
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3654 * the userrefs zap object.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3655 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3656 dmu_buf_will_dirty(ds->ds_dbuf, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3657 zapobj = ds->ds_phys->ds_userrefs_obj =
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3658 zap_create(mos, DMU_OT_USERREFS, DMU_OT_NONE, 0, tx);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3659 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3660 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3661 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3662 ds->ds_userrefs++;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3663 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3664
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3665 VERIFY(0 == zap_add(mos, zapobj, htag, 8, 1, &now, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3666
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3667 if (ha->temphold) {
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3668 VERIFY(0 == dsl_pool_user_hold(dp, ds->ds_object,
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3669 htag, &now, tx));
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3670 }
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3671
13743 95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3672 spa_history_log_internal_ds(ds, "hold", tx,
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3673 "tag = %s temp = %d holds now = %llu",
95aba6e49b9f 2882 implement libzfs_core Matthew Ahrens <mahrens@delphix.com> parents: 13700 diff changeset	3674 htag, (int)ha->temphold, ds->ds_userrefs);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3675 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3676
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3677 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3678 dsl_dataset_user_hold_one(const char dsname, void arg)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3679 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3680 struct dsl_ds_holdarg *ha = arg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3681 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3682 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3683 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3684
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3685 /* alloc a buffer to hold dsname@snapname plus terminating NULL */
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3686 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3687 error = dsl_dataset_hold(name, ha->dstg, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3688 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3689 if (error == 0) {
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3690 ha->gotone = B_TRUE;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3691 dsl_sync_task_create(ha->dstg, dsl_dataset_user_hold_check,
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3692 dsl_dataset_user_hold_sync, ds, ha, 0);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3693 } else if (error == ENOENT && ha->recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3694 error = 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3695 } else {
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3696 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3697 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3698 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3699 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3700
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3701 int
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3702 dsl_dataset_user_hold_for_send(dsl_dataset_t ds, char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3703 boolean_t temphold)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3704 {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3705 struct dsl_ds_holdarg *ha;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3706 int error;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3707
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3708 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3709 ha->htag = htag;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3710 ha->temphold = temphold;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3711 error = dsl_sync_task_do(ds->ds_dir->dd_pool,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3712 dsl_dataset_user_hold_check, dsl_dataset_user_hold_sync,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3713 ds, ha, 0);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3714 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3715
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3716 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3717 }
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3718
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3719 int
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3720 dsl_dataset_user_hold(char dsname, char snapname, char *htag,
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3721 boolean_t recursive, boolean_t temphold, int cleanup_fd)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3722 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3723 struct dsl_ds_holdarg *ha;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3724 dsl_sync_task_t *dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3725 spa_t *spa;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3726 int error;
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3727 minor_t minor = 0;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3728
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3729 if (cleanup_fd != -1) {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3730 /* Currently we only support cleanup-on-exit of tempholds. */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3731 if (!temphold)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3732 return (EINVAL);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3733 error = zfs_onexit_fd_hold(cleanup_fd, &minor);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3734 if (error)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3735 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3736 }
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3737
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3738 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3739
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3740 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3741
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3742 error = spa_open(dsname, &spa, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3743 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3744 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3745 if (cleanup_fd != -1)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3746 zfs_onexit_fd_rele(cleanup_fd);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3747 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3748 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3749
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3750 ha->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3751 ha->htag = htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3752 ha->snapname = snapname;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3753 ha->recursive = recursive;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3754 ha->temphold = temphold;
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3755
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3756 if (recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3757 error = dmu_objset_find(dsname, dsl_dataset_user_hold_one,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3758 ha, DS_FIND_CHILDREN);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3759 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3760 error = dsl_dataset_user_hold_one(dsname, ha);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3761 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3762 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3763 error = dsl_sync_task_group_wait(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3764
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3765 for (dst = list_head(&ha->dstg->dstg_tasks); dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3766 dst = list_next(&ha->dstg->dstg_tasks, dst)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3767 dsl_dataset_t *ds = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3768
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3769 if (dst->dst_err) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3770 dsl_dataset_name(ds, ha->failed);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3771 *strchr(ha->failed, '@') = '\0';
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3772 } else if (error == 0 && minor != 0 && temphold) {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3773 /*
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3774 * If this hold is to be released upon process exit,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3775 * register that action now.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3776 */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3777 dsl_register_onexit_hold_cleanup(ds, htag, minor);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3778 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3779 dsl_dataset_rele(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3780 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3781
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3782 if (error == 0 && recursive && !ha->gotone)
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3783 error = ENOENT;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3784
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3785 if (error)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3786 (void) strlcpy(dsname, ha->failed, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3787
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3788 dsl_sync_task_group_destroy(ha->dstg);
12527 693dd2cad55f 6884007 zfs_send() can leave temporary holds around Chris Kirby <Chris.Kirby@oracle.com> parents: 12470 diff changeset	3789
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3790 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3791 spa_close(spa, FTAG);
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3792 if (cleanup_fd != -1)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	3793 zfs_onexit_fd_rele(cleanup_fd);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3794 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3795 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3796
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3797 struct dsl_ds_releasearg {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3798 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3799 const char *htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3800 boolean_t own; /* do we own or just hold ds? */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3801 };
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3802
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3803 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3804 dsl_dataset_release_might_destroy(dsl_dataset_t ds, const char htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3805 boolean_t *might_destroy)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3806 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3807 objset_t *mos = ds->ds_dir->dd_pool->dp_meta_objset;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3808 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3809 uint64_t tmp;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3810 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3811
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3812 *might_destroy = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3813
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3814 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3815 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3816 if (zapobj == 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3817 /* The tag can't possibly exist */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3818 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3819 return (ESRCH);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3820 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3821
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3822 /* Make sure the tag exists */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3823 error = zap_lookup(mos, zapobj, htag, 8, 1, &tmp);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3824 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3825 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3826 if (error == ENOENT)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3827 error = ESRCH;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3828 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3829 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3830
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3831 if (ds->ds_userrefs == 1 && ds->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3832 DS_IS_DEFER_DESTROY(ds))
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3833 *might_destroy = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3834
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3835 mutex_exit(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3836 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3837 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3838
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3839 static int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3840 dsl_dataset_user_release_check(void arg1, void tag, dmu_tx_t *tx)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3841 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3842 struct dsl_ds_releasearg *ra = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3843 dsl_dataset_t *ds = ra->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3844 boolean_t might_destroy;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3845 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3846
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3847 if (spa_version(ds->ds_dir->dd_pool->dp_spa) < SPA_VERSION_USERREFS)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3848 return (ENOTSUP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3849
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3850 error = dsl_dataset_release_might_destroy(ds, ra->htag, &might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3851 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3852 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3853
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3854 if (might_destroy) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3855 struct dsl_ds_destroyarg dsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3856
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3857 if (dmu_tx_is_syncing(tx)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3858 /*
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3859 * If we're not prepared to remove the snapshot,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3860 * we can't allow the release to happen right now.
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3861 */
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3862 if (!ra->own)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3863 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3864 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3865 dsda.ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3866 dsda.releasing = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3867 return (dsl_dataset_destroy_check(&dsda, tag, tx));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3868 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3869
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3870 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3871 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3872
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3873 static void
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3874 dsl_dataset_user_release_sync(void arg1, void tag, dmu_tx_t *tx)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3875 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3876 struct dsl_ds_releasearg *ra = arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3877 dsl_dataset_t *ds = ra->ds;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3878 dsl_pool_t *dp = ds->ds_dir->dd_pool;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3879 objset_t *mos = dp->dp_meta_objset;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3880 uint64_t zapobj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3881 uint64_t refs;
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3882 int error;
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3883
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3884 mutex_enter(&ds->ds_lock);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3885 ds->ds_userrefs--;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3886 refs = ds->ds_userrefs;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3887 mutex_exit(&ds->ds_lock);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3888 error = dsl_pool_user_release(dp, ds->ds_object, ra->htag, tx);
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	3889 VERIFY(error == 0 \|\| error == ENOENT);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3890 zapobj = ds->ds_phys->ds_userrefs_obj;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3891 VERIFY(0 == zap_remove(mos, zapobj, ra->htag, tx));
13772 2579580ac955 3085 zfs diff panics, then panics in a loop on booting Christopher Siden <chris.siden@delphix.com> parents: 13765 diff changeset	3892
2579580ac955 3085 zfs diff panics, then panics in a loop on booting Christopher Siden <chris.siden@delphix.com> parents: 13765 diff changeset	3893 spa_history_log_internal_ds(ds, "release", tx,
2579580ac955 3085 zfs diff panics, then panics in a loop on booting Christopher Siden <chris.siden@delphix.com> parents: 13765 diff changeset	3894 "tag = %s refs now = %lld", ra->htag, (longlong_t)refs);
2579580ac955 3085 zfs diff panics, then panics in a loop on booting Christopher Siden <chris.siden@delphix.com> parents: 13765 diff changeset	3895
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3896 if (ds->ds_userrefs == 0 && ds->ds_phys->ds_num_children == 1 &&
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3897 DS_IS_DEFER_DESTROY(ds)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3898 struct dsl_ds_destroyarg dsda = {0};
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3899
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3900 ASSERT(ra->own);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3901 dsda.ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3902 dsda.releasing = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3903 /* We already did the destroy_check */
12296 7cf402a7f374 6675946 'zpool status' should show the progress of resilvering for individual disk. Lin Ling <Lin.Ling@Sun.COM> parents: 12295 diff changeset	3904 dsl_dataset_destroy_sync(&dsda, tag, tx);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3905 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3906 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3907
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3908 static int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3909 dsl_dataset_user_release_one(const char dsname, void arg)
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3910 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3911 struct dsl_ds_holdarg *ha = arg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3912 struct dsl_ds_releasearg *ra;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3913 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3914 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3915 void *dtag = ha->dstg;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3916 char *name;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3917 boolean_t own = B_FALSE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3918 boolean_t might_destroy;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3919
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3920 /* alloc a buffer to hold dsname@snapname, plus the terminating NULL */
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3921 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3922 error = dsl_dataset_hold(name, dtag, &ds);
10272 a0669934e974 6861581 ZFS frees in synching context during rollback Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10268 diff changeset	3923 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3924 if (error == ENOENT && ha->recursive)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3925 return (0);
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	3926 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3927 if (error)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3928 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3929
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3930 ha->gotone = B_TRUE;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	3931
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3932 ASSERT(dsl_dataset_is_snapshot(ds));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3933
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3934 error = dsl_dataset_release_might_destroy(ds, ha->htag, &might_destroy);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3935 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3936 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3937 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3938 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3939
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3940 if (might_destroy) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3941 #ifdef _KERNEL
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	3942 name = kmem_asprintf("%s@%s", dsname, ha->snapname);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3943 error = zfs_unmount_snap(name, NULL);
12115 3655f38d3bea 6942295 use-after-free panic in dsl_dataset_user_release_one Chris Kirby <Chris.Kirby@oracle.com> parents: 11823 diff changeset	3944 strfree(name);
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3945 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3946 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3947 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3948 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3949 #endif
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	3950 if (!dsl_dataset_tryown(ds, B_TRUE, dtag)) {
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3951 dsl_dataset_rele(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3952 return (EBUSY);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3953 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3954 own = B_TRUE;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3955 dsl_dataset_make_exclusive(ds, dtag);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3956 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3957 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3958
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3959 ra = kmem_alloc(sizeof (struct dsl_ds_releasearg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3960 ra->ds = ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3961 ra->htag = ha->htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3962 ra->own = own;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3963 dsl_sync_task_create(ha->dstg, dsl_dataset_user_release_check,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3964 dsl_dataset_user_release_sync, ra, dtag, 0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3965
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3966 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3967 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3968
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3969 int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3970 dsl_dataset_user_release(char dsname, char snapname, char *htag,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3971 boolean_t recursive)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3972 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3973 struct dsl_ds_holdarg *ha;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3974 dsl_sync_task_t *dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3975 spa_t *spa;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3976 int error;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3977
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	3978 top:
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3979 ha = kmem_zalloc(sizeof (struct dsl_ds_holdarg), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3980
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3981 (void) strlcpy(ha->failed, dsname, sizeof (ha->failed));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3982
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3983 error = spa_open(dsname, &spa, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3984 if (error) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3985 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3986 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3987 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3988
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3989 ha->dstg = dsl_sync_task_group_create(spa_get_dsl(spa));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3990 ha->htag = htag;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3991 ha->snapname = snapname;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3992 ha->recursive = recursive;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3993 if (recursive) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3994 error = dmu_objset_find(dsname, dsl_dataset_user_release_one,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3995 ha, DS_FIND_CHILDREN);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3996 } else {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3997 error = dsl_dataset_user_release_one(dsname, ha);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3998 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	3999 if (error == 0)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4000 error = dsl_sync_task_group_wait(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4001
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4002 for (dst = list_head(&ha->dstg->dstg_tasks); dst;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4003 dst = list_next(&ha->dstg->dstg_tasks, dst)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4004 struct dsl_ds_releasearg *ra = dst->dst_arg1;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4005 dsl_dataset_t *ds = ra->ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4006
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4007 if (dst->dst_err)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4008 dsl_dataset_name(ds, ha->failed);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4009
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4010 if (ra->own)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4011 dsl_dataset_disown(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4012 else
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4013 dsl_dataset_rele(ds, ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4014
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4015 kmem_free(ra, sizeof (struct dsl_ds_releasearg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4016 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4017
10268 cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	4018 if (error == 0 && recursive && !ha->gotone)
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	4019 error = ENOENT;
cb380b2e9410 6868130 ZFS hold/release "zfs hold -r tag snapshot" failed to check the existence of snapshot Chris Kirby <chris.kirby@sun.com> parents: 10242 diff changeset	4020
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4021 if (error && error != EBUSY)
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	4022 (void) strlcpy(dsname, ha->failed, sizeof (ha->failed));
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4023
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4024 dsl_sync_task_group_destroy(ha->dstg);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4025 kmem_free(ha, sizeof (struct dsl_ds_holdarg));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4026 spa_close(spa, FTAG);
11546 42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4027
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4028 /*
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4029 * We can get EBUSY if we were racing with deferred destroy and
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4030 * dsl_dataset_user_release_check() hadn't done the necessary
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4031 * open context setup. We can also get EBUSY if we're racing
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4032 * with destroy and that thread is the ds_owner. Either way
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4033 * the busy condition should be transient, and we should retry
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4034 * the release operation.
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4035 */
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4036 if (error == EBUSY)
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4037 goto top;
42ea6be8961b 6915111 zfs_iter_snapshots() can miss snapshots Chris Kirby <Chris.Kirby@sun.com> parents: 11209 diff changeset	4038
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4039 return (error);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4040 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4041
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4042 /*
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4043 * Called at spa_load time (with retry == B_FALSE) to release a stale
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4044 * temporary user hold. Also called by the onexit code (with retry == B_TRUE).
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4045 */
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4046 int
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4047 dsl_dataset_user_release_tmp(dsl_pool_t dp, uint64_t dsobj, char htag,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4048 boolean_t retry)
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4049 {
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4050 dsl_dataset_t *ds;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4051 char *snap;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4052 char *name;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4053 int namelen;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4054 int error;
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4055
12798 f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4056 do {
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4057 rw_enter(&dp->dp_config_rwlock, RW_READER);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4058 error = dsl_dataset_hold_obj(dp, dsobj, FTAG, &ds);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4059 rw_exit(&dp->dp_config_rwlock);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4060 if (error)
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4061 return (error);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4062 namelen = dsl_dataset_namelen(ds)+1;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4063 name = kmem_alloc(namelen, KM_SLEEP);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4064 dsl_dataset_name(ds, name);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4065 dsl_dataset_rele(ds, FTAG);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4066
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4067 snap = strchr(name, '@');
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4068 *snap = '\0';
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4069 ++snap;
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4070 error = dsl_dataset_user_release(name, snap, htag, B_FALSE);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4071 kmem_free(name, namelen);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4072
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4073 /*
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4074 * The object can't have been destroyed because we have a hold,
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4075 * but it might have been renamed, resulting in ENOENT. Retry
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4076 * if we've been requested to do so.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4077 *
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4078 * It would be nice if we could use the dsobj all the way
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4079 * through and avoid ENOENT entirely. But we might need to
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4080 * unmount the snapshot, and there's currently no way to lookup
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4081 * a vfsp using a ZFS object id.
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4082 */
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4083 } while ((error == ENOENT) && retry);
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4084
f6c8601080b4 6938335 zfs send -R can still miss renamed snapshots Chris Kirby <Chris.Kirby@oracle.com> parents: 12711 diff changeset	4085 return (error);
10342 108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4086 }
108f0058f837 6833815 scheduled snapshots deleted per snapshot policy can lead to replication failures Chris Kirby <chris.kirby@sun.com> parents: 10298 diff changeset	4087
10242 c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4088 int
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4089 dsl_dataset_get_holds(const char dsname, nvlist_t *nvp)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4090 {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4091 dsl_dataset_t *ds;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4092 int err;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4093
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4094 err = dsl_dataset_hold(dsname, FTAG, &ds);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4095 if (err)
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4096 return (err);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4097
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4098 VERIFY(0 == nvlist_alloc(nvp, NV_UNIQUE_NAME, KM_SLEEP));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4099 if (ds->ds_phys->ds_userrefs_obj != 0) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4100 zap_attribute_t *za;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4101 zap_cursor_t zc;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4102
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4103 za = kmem_alloc(sizeof (zap_attribute_t), KM_SLEEP);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4104 for (zap_cursor_init(&zc, ds->ds_dir->dd_pool->dp_meta_objset,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4105 ds->ds_phys->ds_userrefs_obj);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4106 zap_cursor_retrieve(&zc, za) == 0;
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4107 zap_cursor_advance(&zc)) {
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4108 VERIFY(0 == nvlist_add_uint64(*nvp, za->za_name,
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4109 za->za_first_integer));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4110 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4111 zap_cursor_fini(&zc);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4112 kmem_free(za, sizeof (zap_attribute_t));
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4113 }
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4114 dsl_dataset_rele(ds, FTAG);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4115 return (0);
c40d075fbca6 PSARC/2009/297 zfs snapshot holds Chris Kirby <chris.kirby@sun.com> parents: 10204 diff changeset	4116 }
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4117
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4118 /*
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4119 * Note, this function is used as the callback for dmu_objset_find(). We
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4120 * always return 0 so that we will continue to find and process
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4121 * inconsistent datasets, even if we encounter an error trying to
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4122 * process one of them.
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4123 */
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4124 /* ARGSUSED */
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4125 int
11209 462283cb4096 6905188 panic: kernel heap corruption when doing "zfs rename -r" Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 11022 diff changeset	4126 dsl_destroy_inconsistent(const char dsname, void arg)
10298 a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4127 {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4128 dsl_dataset_t *ds;
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4129
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4130 if (dsl_dataset_own(dsname, B_TRUE, FTAG, &ds) == 0) {
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4131 if (DS_IS_INCONSISTENT(ds))
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4132 (void) dsl_dataset_destroy(ds, FTAG, B_FALSE);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4133 else
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4134 dsl_dataset_disown(ds, FTAG);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4135 }
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4136 return (0);
a0d52501437c 6860996 %temporary clones are not automatically destroyed on error Matthew Ahrens <Matthew.Ahrens@Sun.COM> parents: 10272 diff changeset	4137 }
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4138
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4139 /*
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4140 * Return (in *usedp) the amount of space written in new that is not
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4141 * present in oldsnap. New may be a snapshot or the head. Old must be
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4142 * a snapshot before new, in new's filesystem (or its origin). If not then
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4143 * fail and return EINVAL.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4144 *
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4145 * The written space is calculated by considering two components: First, we
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4146 * ignore any freed space, and calculate the written as new's used space
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4147 * minus old's used space. Next, we add in the amount of space that was freed
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4148 * between the two snapshots, thus reducing new's used space relative to old's.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4149 * Specifically, this is the space that was born before old->ds_creation_txg,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4150 * and freed before new (ie. on new's deadlist or a previous deadlist).
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4151 *
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4152 * space freed [---------------------]
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4153 * snapshots ---O-------O--------O-------O------
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4154 * oldsnap new
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4155 */
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4156 int
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4157 dsl_dataset_space_written(dsl_dataset_t oldsnap, dsl_dataset_t new,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4158 uint64_t usedp, uint64_t compp, uint64_t *uncompp)
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4159 {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4160 int err = 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4161 uint64_t snapobj;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4162 dsl_pool_t *dp = new->ds_dir->dd_pool;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4163
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4164 *usedp = 0;
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4165 *usedp += new->ds_phys->ds_referenced_bytes;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4166 *usedp -= oldsnap->ds_phys->ds_referenced_bytes;
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4167
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4168 *compp = 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4169 *compp += new->ds_phys->ds_compressed_bytes;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4170 *compp -= oldsnap->ds_phys->ds_compressed_bytes;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4171
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4172 *uncompp = 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4173 *uncompp += new->ds_phys->ds_uncompressed_bytes;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4174 *uncompp -= oldsnap->ds_phys->ds_uncompressed_bytes;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4175
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4176 rw_enter(&dp->dp_config_rwlock, RW_READER);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4177 snapobj = new->ds_object;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4178 while (snapobj != oldsnap->ds_object) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4179 dsl_dataset_t *snap;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4180 uint64_t used, comp, uncomp;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4181
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4182 if (snapobj == new->ds_object) {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4183 snap = new;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4184 } else {
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4185 err = dsl_dataset_hold_obj(dp, snapobj, FTAG, &snap);
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4186 if (err != 0)
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4187 break;
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4188 }
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4189
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4190 if (snap->ds_phys->ds_prev_snap_txg ==
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4191 oldsnap->ds_phys->ds_creation_txg) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4192 /*
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4193 * The blocks in the deadlist can not be born after
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4194 * ds_prev_snap_txg, so get the whole deadlist space,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4195 * which is more efficient (especially for old-format
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4196 * deadlists). Unfortunately the deadlist code
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4197 * doesn't have enough information to make this
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4198 * optimization itself.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4199 */
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4200 dsl_deadlist_space(&snap->ds_deadlist,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4201 &used, &comp, &uncomp);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4202 } else {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4203 dsl_deadlist_space_range(&snap->ds_deadlist,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4204 0, oldsnap->ds_phys->ds_creation_txg,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4205 &used, &comp, &uncomp);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4206 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4207 *usedp += used;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4208 *compp += comp;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4209 *uncompp += uncomp;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4210
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4211 /*
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4212 * If we get to the beginning of the chain of snapshots
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4213 * (ds_prev_snap_obj == 0) before oldsnap, then oldsnap
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4214 * was not a snapshot of/before new.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4215 */
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4216 snapobj = snap->ds_phys->ds_prev_snap_obj;
13700 2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4217 if (snap != new)
2889e2596bd6 2619 asynchronous destruction of ZFS file systems Christopher Siden <chris.siden@delphix.com> parents: 13686 diff changeset	4218 dsl_dataset_rele(snap, FTAG);
13524 f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4219 if (snapobj == 0) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4220 err = EINVAL;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4221 break;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4222 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4223
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4224 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4225 rw_exit(&dp->dp_config_rwlock);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4226 return (err);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4227 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4228
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4229 /*
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4230 * Return (in *usedp) the amount of space that will be reclaimed if firstsnap,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4231 * lastsnap, and all snapshots in between are deleted.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4232 *
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4233 * blocks that would be freed [---------------------------]
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4234 * snapshots ---O-------O--------O-------O--------O
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4235 * firstsnap lastsnap
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4236 *
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4237 * This is the set of blocks that were born after the snap before firstsnap,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4238 * (birth > firstsnap->prev_snap_txg) and died before the snap after the
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4239 * last snap (ie, is on lastsnap->ds_next->ds_deadlist or an earlier deadlist).
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4240 * We calculate this by iterating over the relevant deadlists (from the snap
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4241 * after lastsnap, backward to the snap after firstsnap), summing up the
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4242 * space on the deadlist that was born after the snap before firstsnap.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4243 */
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4244 int
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4245 dsl_dataset_space_wouldfree(dsl_dataset_t *firstsnap,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4246 dsl_dataset_t *lastsnap,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4247 uint64_t usedp, uint64_t compp, uint64_t *uncompp)
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4248 {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4249 int err = 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4250 uint64_t snapobj;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4251 dsl_pool_t *dp = firstsnap->ds_dir->dd_pool;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4252
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4253 ASSERT(dsl_dataset_is_snapshot(firstsnap));
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4254 ASSERT(dsl_dataset_is_snapshot(lastsnap));
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4255
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4256 /*
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4257 * Check that the snapshots are in the same dsl_dir, and firstsnap
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4258 * is before lastsnap.
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4259 */
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4260 if (firstsnap->ds_dir != lastsnap->ds_dir \|\|
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4261 firstsnap->ds_phys->ds_creation_txg >
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4262 lastsnap->ds_phys->ds_creation_txg)
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4263 return (EINVAL);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4264
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4265 usedp = compp = *uncompp = 0;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4266
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4267 rw_enter(&dp->dp_config_rwlock, RW_READER);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4268 snapobj = lastsnap->ds_phys->ds_next_snap_obj;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4269 while (snapobj != firstsnap->ds_object) {
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4270 dsl_dataset_t *ds;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4271 uint64_t used, comp, uncomp;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4272
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4273 err = dsl_dataset_hold_obj(dp, snapobj, FTAG, &ds);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4274 if (err != 0)
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4275 break;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4276
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4277 dsl_deadlist_space_range(&ds->ds_deadlist,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4278 firstsnap->ds_phys->ds_prev_snap_txg, UINT64_MAX,
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4279 &used, &comp, &uncomp);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4280 *usedp += used;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4281 *compp += comp;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4282 *uncompp += uncomp;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4283
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4284 snapobj = ds->ds_phys->ds_prev_snap_obj;
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4285 ASSERT3U(snapobj, !=, 0);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4286 dsl_dataset_rele(ds, FTAG);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4287 }
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4288 rw_exit(&dp->dp_config_rwlock);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4289 return (err);
f0e12b33f77c 1644 add ZFS "clones" property Matthew Ahrens <matt@delphix.com> parents: 13512 diff changeset	4290 }

Mercurial > illumos > illumos-gate

annotate usr/src/uts/common/fs/zfs/dsl_dataset.c @ 13952:7a22d0770fc8